Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30180 )
Change subject: mainboard/google/poppy/variants/rammus: Fixed touchscreen function failed on EVT FATP
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30180/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30180/3//COMMIT_MSG@9
PS3, Line 9: According to issue tracker b:119238959 #13.
: Add control on GPP_E3 pin to delay touchscreen I2C communication witch PCH.
: To Avoid abnormal data transfer before touchscreen I2C function complete ready during power on initialization.
I would suggest you describe the problem more detail here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628
Gerrit-Change-Number: 30180
Gerrit-PatchSet: 3
Gerrit-Owner: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-CC: Jerry Chou <jerry_chou(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 12 Dec 2018 10:41:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )
Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
......................................................................
Patch Set 3:
> Patch Set 3:
>
> (1 comment)
--
To view, visit https://review.coreboot.org/c/coreboot/+/30178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Gerrit-Change-Number: 30178
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 10:22:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Ivy Jian has removed Patrick Georgi from this change. ( https://review.coreboot.org/c/coreboot/+/30183 )
Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
......................................................................
Removed reviewer Patrick Georgi.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf731bfefd550e9b94b6404bc870d4d76451deb1
Gerrit-Change-Number: 30183
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: deleteReviewer
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30183 )
Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf731bfefd550e9b94b6404bc870d4d76451deb1
Gerrit-Change-Number: 30183
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 10:11:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Iru Cai (vimacs) has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30192 )
Change subject: mrc_alloc
......................................................................
Abandoned
sorry, push to the wrong place...
--
To view, visit https://review.coreboot.org/c/coreboot/+/30192
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fd6d50f8a9c45b9204f39954bd3dfc3a2951a11
Gerrit-Change-Number: 30192
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Iru Cai (vimacs) <mytbk920423(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: abandon