coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza
by Subrata Banik (Code Review) 12 Dec '18

12 Dec '18

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30193 ) Change subject: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza ...................................................................... Patch Set 1: Lots of build failure since morning due to below reason https://qa.coreboot.org/job/coreboot-gerrit/84767/testReport/board/chromeos… hence i have added this CL. Can you please check Patrick. -- To view, visit https://review.coreboot.org/c/coreboot/+/30193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Gerrit-Change-Number: 30193 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 12:12:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza
by Subrata Banik (Code Review) 12 Dec '18

12 Dec '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30193 Change subject: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza ...................................................................... mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/mainboard/google/cheza/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/30193/1 diff --git a/src/mainboard/google/cheza/Kconfig b/src/mainboard/google/cheza/Kconfig index b940314..9ba3b72 100644 --- a/src/mainboard/google/cheza/Kconfig +++ b/src/mainboard/google/cheza/Kconfig @@ -22,6 +22,7 @@ config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES + select VBOOT_NO_BOARD_SUPPORT select VBOOT_VBNV_FLASH config MAINBOARD_DIR -- To view, visit https://review.coreboot.org/c/coreboot/+/30193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Gerrit-Change-Number: 30193 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mainboard/google/poppy/variants/rammus: Fixed touchscreen function fa...
by Ken Lu (Code Review) 12 Dec '18

12 Dec '18

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30180 ) Change subject: mainboard/google/poppy/variants/rammus: Fixed touchscreen function failed on EVT FATP ...................................................................... Patch Set 4: > Patch Set 3: > > (1 comment) Update commit message . -- To view, visit https://review.coreboot.org/c/coreboot/+/30180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628 Gerrit-Change-Number: 30180 Gerrit-PatchSet: 4 Gerrit-Owner: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-CC: Jerry Chou <jerry_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 12 Dec 2018 11:19:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/google/poppy/variants/rammus: Fixed touchscreen function fa...
by Ken Lu (Code Review) 12 Dec '18

12 Dec '18

Ken Lu has uploaded a new patch set (#4) to the change originally created by YanRu Chen. ( https://review.coreboot.org/c/coreboot/+/30180 ) Change subject: mainboard/google/poppy/variants/rammus: Fixed touchscreen function failed on EVT FATP ...................................................................... mainboard/google/poppy/variants/rammus: Fixed touchscreen function failed on EVT FATP According to issue tracker b:119238959 #4 & #6 . Hardware modify design to make GPP_E3 to be a switch of touchscreen I2C CLK and SDA. Control GPP_E3 to make touchscreen I2C CLK and SDA keep low during power on initialization to avoid data transfer during this time . After touchscreen IC initial complete ,control GPP_E3 to high to make touchscreen I2C CLK and SDA work normally . BUG=b:119238959 BRANCH=firmware-rammus-11275.B TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage Flash FW to DUT, run S5 stress test and verify the result Signed-off-by: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Change-Id: I86452c1445243c499aeaf931dba286db169c5628 --- M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/rammus/gpio.c 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/30180/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30180 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628 Gerrit-Change-Number: 30180 Gerrit-PatchSet: 4 Gerrit-Owner: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-CC: Jerry Chou <jerry_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 4 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 11:04:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30178 to look at the new patch set (#4). Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko According to bard/ekko cpu types, PL2 need to set the values 1. KBL_U PL2 is 25w. 2. KBL_R PL2 is 29w. BUG=b:120874861 TEST=power on and check the DUT can boot up well Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30178/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 4 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has restored this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 ) Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 10:45:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
by Ren Kuo (Code Review) 12 Dec '18

12 Dec '18

Ren Kuo has removed a vote on this change. Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko ...................................................................... Removed Code-Review+1 by Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/30178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0 Gerrit-Change-Number: 30178 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteVote

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018