coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad
by EricR Lai (Code Review) 12 Dec '18

12 Dec '18

EricR Lai has uploaded a new patch set (#4) to the change originally created by Chris Zhou. ( https://review.coreboot.org/c/coreboot/+/30194 ) Change subject: mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad ...................................................................... mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad Enable ELAN Touchpad and Disable ALPS Touchpad BUG=b:119628524 BRANCH=master TEST=ELAN Touchpad can work normally. Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Signed-off-by: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/30194/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/30194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Gerrit-Change-Number: 30194 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Enable ELAN Touchpad and Disable AL...
by EricR Lai (Code Review) 12 Dec '18

12 Dec '18

EricR Lai has uploaded a new patch set (#3) to the change originally created by Chris Zhou. ( https://review.coreboot.org/c/coreboot/+/30194 ) Change subject: mb/google/sarien/variants/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad ...................................................................... mb/google/sarien/variants/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad Enable ELAN Touchpad and Disable ALPS Touchpad BUG=b:119628524 BRANCH=master TEST=ELAN Touchpad can work normally. Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Signed-off-by: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/30194/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Gerrit-Change-Number: 30194 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: IntelFB: Add support for Intel font driver
by Nico Huber (Code Review) 12 Dec '18

12 Dec '18

1 0

Change in ...coreboot[master]: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza to fix build...
by Subrata Banik (Code Review) 12 Dec '18

12 Dec '18

Hello build bot (Jenkins), Martin Roth, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30193 to look at the new patch set (#3). Change subject: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza to fix build error ...................................................................... mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza to fix build error Fix build error as below: vboot_handoff.c:62: undefined reference to `get_write_protect_state' Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/mainboard/google/cheza/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/30193/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/30193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Gerrit-Change-Number: 30193 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: IntelFB: Add support for Intel font driver
by Patrick Rudolph (Code Review) 12 Dec '18

12 Dec '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 ) Change subject: IntelFB: Add support for Intel font driver ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/30182/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/30182/1//COMMIT_MSG@10 PS1, Line 10: Framebuffer during BIOS boot to display boot message/update messages. firmware boot I don't see how it would be that useful. Please give a few more examples. Graphics should be initialized at BS_DEV_INIT. After BS_DEV_INIT you only lock registers and write tables. Nothing that is expected to fail or generate that much verbose output. All the magic already has been done. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/font8x16.c File src/drivers/intel/fb/font8x16.c: https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/font8x16.c@18 PS1, Line 18: * documentation and/or other materials provided with the distribution. is this license compatible to GPLv2 ? Please explain why you think so. -- To view, visit https://review.coreboot.org/c/coreboot/+/30182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237 Gerrit-Change-Number: 30182 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 12 Dec 2018 13:20:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
by build bot (Jenkins) (Code Review) 12 Dec '18

12 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 ) Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs ...................................................................... Patch Set 41: (7 comments) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… File src/soc/intel/common/block/cpu/mp_service_ppi.c: https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 47: EFI_PEI_SERVICES **ignored1, EFI_PEI_MP_SERVICES_PPI *ignored2, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 60: static EFI_STATUS mp_get_processor_info(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 85: static EFI_STATUS mp_startup_all_aps(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 104: static EFI_STATUS mp_startup_this_ap(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 130: static EFI_STATUS mp_switch_bsp(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 138: static EFI_STATUS mp_enable_disable_ap(CONST EFI_PEI_SERVICES **ignored1, need consistent spacing around '*' (ctx:WxO) https://review.coreboot.org/#/c/25634/41/src/soc/intel/common/block/cpu/mp_… PS41, Line 145: static EFI_STATUS mp_identify_processor(CONST EFI_PEI_SERVICES **PeiServices, need consistent spacing around '*' (ctx:WxO) -- To view, visit https://review.coreboot.org/c/coreboot/+/25634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956 Gerrit-Change-Number: 25634 Gerrit-PatchSet: 41 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone(a)intel.com> Gerrit-Comment-Date: Wed, 12 Dec 2018 13:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Enable ELAN Touchpad and Disable AL...
by Chris Zhou (Code Review) 12 Dec '18

12 Dec '18

Hello Duncan Laurie, build bot (Jenkins), Lijian Zhao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30194 to look at the new patch set (#2). Change subject: mb/google/sarien/variants/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad ...................................................................... mb/google/sarien/variants/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad Enable ELAN Touchpad and Disable ALPS Touchpad BUG=b:119628524 TEST=ELAN Touchpad can work normally. Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Signed-off-by: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/30194/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Gerrit-Change-Number: 30194 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad
by Chris Zhou (Code Review) 12 Dec '18

12 Dec '18

Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30194 Change subject: mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad ...................................................................... mb/google/sarien: Enable ELAN Touchpad and Disable ALPS Touchpad Enable ELAN Touchpad and Disable ALPS Touchpad BUG=119628524 TEST=ELAN Touchpad can work normally. Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Signed-off-by: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/30194/1 diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 49200ad..771bec2 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -219,11 +219,11 @@ end end # I2C #0 device pci 15.1 on - chip drivers/i2c/hid - register "generic.hid" = ""ACPI0C50"" - register "generic.desc" = ""Touchpad"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" - register "hid_desc_reg_offset" = "0x20" + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_B3_IRQ)" + register "probed" = "1" device i2c 2c on end end end # I2C #1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7839459a70768fa95ba4871b1915d2ea86419bbb Gerrit-Change-Number: 30194 Gerrit-PatchSet: 1 Gerrit-Owner: Chris Zhou <chris_zhou(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: IntelFB: Add support for Intel font driver
by Nico Huber (Code Review) 12 Dec '18

12 Dec '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 ) Change subject: IntelFB: Add support for Intel font driver ...................................................................... Patch Set 1: (14 comments) Hi Maulik, I think this driver could easily be modified to work with any coreboot framebuffer (not just FSP ones). Though, it's hard to anticipate the requirements without seeing it hooked up. Is there already a patch in queue that makes use of this? https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/Kconfig File src/drivers/intel/fb/Kconfig: https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/Kconfig@3 PS1, Line 3: depends on ARCH_X86 The current implementation depends on PLATFORM_USES_FSP2_0 and RUN_FSP_GOP. Though, a generic implementation should only depend on LINEAR_FRAMEBUFFER. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c File src/drivers/intel/fb/fbdriver.c: https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@28 PS1, Line 28: #define FI fb_info This seems unnecessary, `fb_info` should already be short enough? https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@29 PS1, Line 29: unsigned long Use `uintptr_t` instead of `unsigned long`. There's no guarantee that the latter has the same width as a pointer. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@29 PS1, Line 29: no space, please https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@41 PS1, Line 41: 0xFF It seems more common in coreboot to write hex-digits in lower case, i.e. `0xff`. In any case, please make sure to use one style within this file. Hmmm, also why not make it an explicit `unsigned char`? https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@42 PS1, Line 42: / Please put spaces around the /'s https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@51 PS1, Line 51: pci_write_config16(dev1, 0x04, 0x07); There are definitions for these registers/bits in `device/pci_def.h`. I don't think, it's legal to activate IO and MMIO here, and also bus mastering should be taken care of by the device driver. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@53 PS1, Line 53: status = fsp_fill_lb_framebuffer (&fb_info); > space prohibited between function name and open parenthesis '(' If you'd use fill_lb_framebuffer() instead, this driver could work with all framebuffers in coreboot. Please always check the return value. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@54 PS1, Line 54: fb_info.physical_address = pci_read_config32(dev1, 0x18); Shouldn't be necessary if you use fill_lb_framebuffer() proper. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@60 PS1, Line 60: x_resolution bytes_per_line https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@61 PS1, Line 61: (void *) Cast to (void *) shouldn't be necessary. https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@73 PS1, Line 73: fb_inverse = 0; : previous_write = 0; Why? https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@79 PS1, Line 79: = 0 unnecessary initialization https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@101 PS1, Line 101: for(x = font_width - 1; x >= 0; x--) { > space required before the open parenthesis '(' why the reverse loop (from font_width down to 0)? -- To view, visit https://review.coreboot.org/c/coreboot/+/30182 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237 Gerrit-Change-Number: 30182 Gerrit-PatchSet: 1 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 12 Dec 2018 12:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza
by Subrata Banik (Code Review) 12 Dec '18

12 Dec '18

Hello build bot (Jenkins), Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30193 to look at the new patch set (#2). Change subject: mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza ...................................................................... mb/google/cheza: select VBOOT_NO_BOARD_SUPPORT for cheza Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/mainboard/google/cheza/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/30193/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1996525b788df341e76bc91231e610cb2ae3a282 Gerrit-Change-Number: 30193 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018