coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: mrc_util: license
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30191 Change subject: mrc_util: license ...................................................................... mrc_util: license Change-Id: I0825a9918b46052496477da65cbd7ae03dd822fe Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/northbridge/intel/haswell/mrc_utils.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/30191/1 diff --git a/src/northbridge/intel/haswell/mrc_utils.c b/src/northbridge/intel/haswell/mrc_utils.c index f4c125a..6c81bf0 100644 --- a/src/northbridge/intel/haswell/mrc_utils.c +++ b/src/northbridge/intel/haswell/mrc_utils.c @@ -1,3 +1,16 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <string.h> void __attribute((regparm(3))) mrc_setmem(void *s, size_t n, int c); -- To view, visit https://review.coreboot.org/c/coreboot/+/30191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0825a9918b46052496477da65cbd7ae03dd822fe Gerrit-Change-Number: 30191 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mrc main
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30190 Change subject: mrc main ...................................................................... mrc main Change-Id: Id2626410e23d153ac11b796115c5a63bc6f21711 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/northbridge/intel/haswell/Makefile.inc M src/northbridge/intel/haswell/mrc.asm A src/northbridge/intel/haswell/mrc_main.c 3 files changed, 67 insertions(+), 111 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/30190/1 diff --git a/src/northbridge/intel/haswell/Makefile.inc b/src/northbridge/intel/haswell/Makefile.inc index 7f53f78..30c3267 100644 --- a/src/northbridge/intel/haswell/Makefile.inc +++ b/src/northbridge/intel/haswell/Makefile.inc @@ -35,6 +35,7 @@ nasm -f elf32 -o $@ $< romstage-y += mrc_utils.c +romstage-y += mrc_main.c postcar-y += ram_calc.c diff --git a/src/northbridge/intel/haswell/mrc.asm b/src/northbridge/intel/haswell/mrc.asm index feca76f..9bb6b28 100644 --- a/src/northbridge/intel/haswell/mrc.asm +++ b/src/northbridge/intel/haswell/mrc.asm @@ -3,6 +3,8 @@ bits 32 global mrc_entry +global do_raminit +global heap_check extern mrc_printk extern mrc_setmem @@ -11,6 +13,7 @@ extern mrc_fillword extern mrc_zeromem extern mrc_highest_bit +extern mrc_main mrc_entry: mov ecx, esp @@ -20,7 +23,7 @@ mov al, 1 out 0x80, al cld -call fcn_fffc18c8 ; call 0xfffc18c8 +call mrc_main pop ecx pop ecx mov esp, ecx @@ -2482,7 +2485,7 @@ pop ebp ret -fcn_fffa2937: +heap_check: push ebp lea edx, [eax + 3] and edx, 0xfffffffc @@ -2550,7 +2553,7 @@ jne short loc_fffa29f2 ; jne 0xfffa29f2 add eax, 4 mov dword [ebp - 0x1c], edx -call fcn_fffa2937 ; call 0xfffa2937 +call heap_check ; call 0xfffa2937 test eax, eax mov edx, dword [ebp - 0x1c] jne short loc_fffa29f4 ; jne 0xfffa29f4 @@ -2840,7 +2843,7 @@ pop ebp ret -fcn_fffa2c51: +do_raminit: push ebp xor edx, edx mov ebp, esp @@ -3758,14 +3761,14 @@ mov eax, ebx call fcn_fffc7c9d ; call 0xfffc7c9d mov eax, 0xc -call fcn_fffa2937 ; call 0xfffa2937 +call heap_check ; call 0xfffa2937 test eax, eax mov esi, eax je short loc_fffa3d32 ; je 0xfffa3d32 mov edx, 0xc call mrc_zeromem mov eax, 0x28 -call fcn_fffa2937 ; call 0xfffa2937 +call heap_check ; call 0xfffa2937 test eax, eax mov edi, eax je short loc_fffa3d32 ; je 0xfffa3d32 @@ -3814,7 +3817,7 @@ call mrc_printk ; call 0xfffa1253 mov eax, 0x10f mov esi, dword [0xff7d7538] -call fcn_fffa2937 ; call 0xfffa2937 +call heap_check ; call 0xfffa2937 add esp, 0x10 test eax, eax mov ebx, eax @@ -42190,101 +42193,6 @@ db 0x00 db 0x00 -fcn_fffc18c8: -push ebp -mov ecx, 8 -mov ebp, esp -push edi -push esi -push ebx -mov ebx, 0xff800000 -sub ebx, 0xff7d7544 -lea esp, [esp - 0x1c] -sar ebx, 2 -mov eax, ebx -cdq -idiv ecx -mov dword [ebp - 0x1c], eax -xor eax, eax -jmp short loc_fffc190c ; jmp 0xfffc190c - -loc_fffc18f1: -xor edx, edx - -loc_fffc18f3: -lea ecx, [edx + eax] -inc edx -cmp edx, 4 -mov dword [ecx*4 - 0x828abc], 0xdeedbeef -jne short loc_fffc18f3 ; jne 0xfffc18f3 -add eax, 0x100 - -loc_fffc190c: -cmp eax, dword [ebp - 0x1c] -jl short loc_fffc18f1 ; jl 0xfffc18f1 -mov eax, dword [ebp + 8] -xor esi, esi -call fcn_fffa2c51 ; call 0xfffa2c51 -mov edi, eax -jmp short loc_fffc1939 ; jmp 0xfffc1939 - -loc_fffc191f: -xor eax, eax - -loc_fffc1921: -lea ecx, [eax + esi] -cmp dword [ecx*4 - 0x828abc], 0xdeedbeef -jne short loc_fffc195a ; jne 0xfffc195a -inc eax -cmp eax, 4 -jne short loc_fffc1921 ; jne 0xfffc1921 -jmp short loc_fffc1952 ; jmp 0xfffc1952 - -loc_fffc1939: -cmp esi, dword [ebp - 0x1c] -jl short loc_fffc191f ; jl 0xfffc191f -jmp short loc_fffc197a ; jmp 0xfffc197a - -loc_fffc1940: -sub esp, 0xc -push ref_fffcc6f2 ; push 0xfffcc6f2 -call mrc_printk ; call 0xfffa1253 -add esp, 0x10 - -loc_fffc1950: -jmp short loc_fffc1950 ; jmp 0xfffc1950 - -loc_fffc1952: -add esi, 0x100 -jmp short loc_fffc1939 ; jmp 0xfffc1939 - -loc_fffc195a: -push eax -lea eax, [ebx*4] -sub ebx, esi -push eax -shl ebx, 2 -push ebx -push ref_fffcc725 ; push 0xfffcc725 -call mrc_printk ; call 0xfffa1253 -add esp, 0x10 -test esi, esi -je short loc_fffc1940 ; je 0xfffc1940 - -loc_fffc197a: -sub esp, 0xc -push ref_fffcc70e ; push 0xfffcc70e -call mrc_printk ; call 0xfffa1253 -mov eax, 8 -call fcn_fffa2937 ; call 0xfffa2937 -lea esp, [ebp - 0xc] -mov eax, edi -pop ebx -pop esi -pop edi -pop ebp -ret - fcn_fffc1ae2: push ebp mov ebp, esp @@ -56223,15 +56131,6 @@ ref_fffcc6dd: db 'System Agent: Done.',0x0a,0x00 -ref_fffcc6f2: -db 'Stack completely exhaused!',0x0a,0x00 - -ref_fffcc70e: -db 'Sanity checking heap.',0x0a,0x00 - -ref_fffcc725: -db 'Reference code used approx 0x%x/0x%x of stack.',0x0a,0x00,0x00 - ref_fffcc756: db 0x50 db 0x00 diff --git a/src/northbridge/intel/haswell/mrc_main.c b/src/northbridge/intel/haswell/mrc_main.c new file mode 100644 index 0000000..a00abf2 --- /dev/null +++ b/src/northbridge/intel/haswell/mrc_main.c @@ -0,0 +1,56 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "pei_data.h" +#include <console/console.h> + +static int *STACK_TOP = (int *)0xff800000; +static int *STACK_BTM = (int *)0xff7d7544; + +int __attribute((regparm(1))) do_raminit(struct pei_data *pd); +int __attribute((regparm(1))) heap_check(int n); +int mrc_main(struct pei_data *pd); + +int mrc_main(struct pei_data *pd) +{ + int stkwords = (STACK_TOP - STACK_BTM); + int lowsize = stkwords / 8; + int rv; + + for (int i = 0; i < lowsize; i += 0x100) { + for (int j = 0; j < 4; j++) + STACK_BTM[i + j] = 0xdeadbeef; + } + + rv = do_raminit(pd); + + for (int i = 0; i < lowsize; i += 0x100) { + for (int j = 0; j < 4; j++) { + if (STACK_BTM[i + j] != 0xdeadbeef) { + mrc_printk("Reference code used " + "approx 0x%x/0x%x of stack.\n", + (stkwords - i) * 4, + stkwords * 4); + if (i == 0) { + mrc_printk("Stack completely exhaused!\n"); + while (1) + ; + } + } + } + } + + mrc_printk("Sanity checking heap.\n"); + heap_check(8); + return rv; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/30190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id2626410e23d153ac11b796115c5a63bc6f21711 Gerrit-Change-Number: 30190 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: move mrc_printk to console.h
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30189 Change subject: move mrc_printk to console.h ...................................................................... move mrc_printk to console.h Change-Id: Iaa1a3ab5178fdf86ecd69e5a9bbaf48be76d50e8 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/console/printk.c M src/include/console/console.h 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30189/1 diff --git a/src/console/printk.c b/src/console/printk.c index 4b39374..55a97c9 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -78,7 +78,6 @@ return i; } -int mrc_printk(const char *fmt, ...); int mrc_printk(const char *fmt, ...) { int i; diff --git a/src/include/console/console.h b/src/include/console/console.h index a5f7305..d26ce5d 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -83,6 +83,8 @@ static inline void do_putchar(unsigned char byte) {} #endif +int mrc_printk(const char *fmt, ...); + #if IS_ENABLED(CONFIG_VBOOT) /* FIXME: Collision of varargs with AMD headers without guard. */ #include <console/vtxprintf.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/30189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa1a3ab5178fdf86ecd69e5a9bbaf48be76d50e8 Gerrit-Change-Number: 30189 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: helper functions: memcpy, memset, ...
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30188 Change subject: helper functions: memcpy, memset, ... ...................................................................... helper functions: memcpy, memset, ... Change-Id: Ifebe96f655c13d7c17ac09f520581d7df7e3cf7d Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/northbridge/intel/haswell/Makefile.inc M src/northbridge/intel/haswell/mrc.asm A src/northbridge/intel/haswell/mrc_utils.c 3 files changed, 231 insertions(+), 303 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/30188/1 diff --git a/src/northbridge/intel/haswell/Makefile.inc b/src/northbridge/intel/haswell/Makefile.inc index a450eb5..7f53f78 100644 --- a/src/northbridge/intel/haswell/Makefile.inc +++ b/src/northbridge/intel/haswell/Makefile.inc @@ -34,6 +34,8 @@ $(obj)/mrc.o: $(src)/northbridge/intel/haswell/mrc.asm nasm -f elf32 -o $@ $< +romstage-y += mrc_utils.c + postcar-y += ram_calc.c endif diff --git a/src/northbridge/intel/haswell/mrc.asm b/src/northbridge/intel/haswell/mrc.asm index cc4361b..feca76f 100644 --- a/src/northbridge/intel/haswell/mrc.asm +++ b/src/northbridge/intel/haswell/mrc.asm @@ -5,6 +5,12 @@ global mrc_entry extern mrc_printk +extern mrc_setmem +extern mrc_memcpy +extern memcpy ; pass parameters by stack +extern mrc_fillword +extern mrc_zeromem +extern mrc_highest_bit mrc_entry: mov ecx, esp @@ -1558,75 +1564,6 @@ pop ebp ret -fcn_fffa115e: -push ebp -mov ebp, esp -push esi -mov esi, ecx -push ebx -xor ebx, ebx -jmp short loc_fffa1170 ; jmp 0xfffa1170 - -loc_fffa1169: -mov cl, byte [edx + ebx] -mov byte [eax + ebx], cl -inc ebx - -loc_fffa1170: -cmp ebx, esi -jne short loc_fffa1169 ; jne 0xfffa1169 -pop ebx -pop esi -pop ebp -ret - -fcn_fffa1178: ; not directly referenced -push ebp -mov ebp, esp -mov ecx, dword [ebp + 0x10] -mov edx, dword [ebp + 0xc] -mov eax, dword [ebp + 8] -pop ebp -jmp near fcn_fffa115e ; jmp 0xfffa115e - -fcn_fffa118a: -push ebp -test edx, edx -mov ebp, esp -jne short loc_fffa1197 ; jne 0xfffa1197 -jmp short loc_fffa119d ; jmp 0xfffa119d - -loc_fffa1193: -mov byte [eax + edx], 0 - -loc_fffa1197: -dec edx -cmp edx, 0xffffffffffffffff -jne short loc_fffa1193 ; jne 0xfffa1193 - -loc_fffa119d: -pop ebp -ret - -fcn_fffa119f: ; not directly referenced -push ebp -test edx, edx -mov ebp, esp -jne short loc_fffa11ab ; jne 0xfffa11ab -jmp short loc_fffa11b1 ; jmp 0xfffa11b1 - -loc_fffa11a8: ; not directly referenced -mov byte [eax + edx], cl - -loc_fffa11ab: ; not directly referenced -dec edx -cmp edx, 0xffffffffffffffff -jne short loc_fffa11a8 ; jne 0xfffa11a8 - -loc_fffa11b1: ; not directly referenced -pop ebp -ret - fcn_fffa11b3: push ebp mov ebp, esp @@ -2477,7 +2414,7 @@ mov ecx, 0x100 lea eax, [edx + 0x40] mov edx, dword [ebp - 0x2c] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov edx, dword [ebp - 0x20] add esp, 0x10 mov byte [edx + 0x14e], 0 @@ -3450,7 +3387,7 @@ mov dword [ebp - 0x1dc], eax mov dword [ebp - 0x230], fcn_fffa04e7 ; mov dword [ebp - 0x230], 0xfffa04e7 lea eax, [ebp - 0x565] -mov dword [ebp - 0x224], fcn_fffa1178 ; mov dword [ebp - 0x224], 0xfffa1178 +mov dword [ebp - 0x224], memcpy ; mov dword [ebp - 0x224], 0xfffa1178 mov dword [ebp - 0x1d0], eax mov dword [ebp - 0x21c], fcn_fffa04ee ; mov dword [ebp - 0x21c], 0xfffa04ee lea eax, [ebp - 0x585] @@ -3826,18 +3763,18 @@ mov esi, eax je short loc_fffa3d32 ; je 0xfffa3d32 mov edx, 0xc -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov eax, 0x28 call fcn_fffa2937 ; call 0xfffa2937 test eax, eax mov edi, eax je short loc_fffa3d32 ; je 0xfffa3d32 mov edx, 0x28 -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov ecx, 0x28 mov edx, ref_fffcc8dc ; mov edx, 0xfffcc8dc mov eax, edi -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov dword [esi + 8], edi mov dword [esi], 0x80000010 mov dword [esi + 4], ref_fffcd534 ; mov dword [esi + 4], 0xfffcd534 @@ -4005,15 +3942,15 @@ lea edi, [eax + 8] add eax, 0x18 rep movsd ; rep movsd dword es:[edi], dword ptr [esi] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov eax, dword [ebp - 0x620] mov edx, 8 add eax, 0x20 -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov eax, dword [ebp - 0x620] mov edx, 0x1e add eax, 0x29 -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov eax, dword [ebp - 0x620] add esp, 0x10 mov byte [eax + 0x28], 0 @@ -4927,10 +4864,10 @@ loc_fffa4e1b: mov edx, 7 lea eax, [ebp - 0x5f6] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov edx, 7 lea eax, [ebp - 0x5ef] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov eax, dword [0xff7d7538] sub esp, 0xc lea ecx, [ebp - 0x620] @@ -4960,14 +4897,14 @@ loc_fffa4e85: mov edx, 5 lea eax, [ebp - 0x5fb] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov edx, 8 lea eax, [ebp - 0x5b4] mov byte [ebp - 0x5f7], bl -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov edx, 8 lea eax, [ebp - 0x5b4] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov al, byte [ebp - 0x5f7] sub esp, 0xc mov byte [ebp - 0x5af], al @@ -5011,14 +4948,14 @@ loc_fffa4f70: mov edx, 7 lea eax, [ebp - 0x5f6] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov edx, 8 lea eax, [ebp - 0x5b4] mov byte [ebp - 0x5f0], bl -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov edx, 8 lea eax, [ebp - 0x5b4] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov al, byte [ebp - 0x5f0] sub esp, 0xc mov byte [ebp - 0x5af], al @@ -5056,7 +4993,7 @@ jne loc_fffa532b ; jne 0xfffa532b mov edx, 7 lea eax, [ebp - 0x5ef] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem cmp bl, 1 mov byte [ebp - 0x5e9], bl jne loc_fffa520e ; jne 0xfffa520e @@ -5100,7 +5037,7 @@ lea eax, [ebp - 0x5c4] mov byte [ebp - 0x668], cl movzx esi, word [ebp - 0x5ed] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem mov cl, byte [ebp - 0x668] mov eax, esi mov byte [ebp - 0x5b4], cl @@ -5136,7 +5073,7 @@ mov word [ebp - 0x5b2], ax lea edx, [ebp - 0x5b4] lea eax, [ebp - 0x5c4] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov dl, byte [ebp - 0x65a] mov eax, 2 mov byte [ebp - 0x5bf], dl @@ -5190,7 +5127,7 @@ lea eax, [ebp - 0x5e8] mov dword [ebp - 0x5b8], esi or byte [ebp - 0x5b5], 0x80 -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov eax, dword [ebp - 0x5e8] mov edx, dword [ebp - 0x5e4] mov ecx, 0x150 @@ -5204,7 +5141,7 @@ mov dword [ebp - 0x5e4], edx lea eax, [ebp - 0x5bc] lea edx, [ebp - 0x5e8] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov eax, 0xa call fcn_fffc5e98 ; call 0xfffc5e98 mov edx, dword [ebp - 0x648] @@ -5214,7 +5151,7 @@ lea edx, [ebp - 0x5e8] mov ecx, 8 lea eax, [ebp - 0x5b4] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov ecx, dword [ebp - 0x5b0] cmp dword [ebp - 0x5b8], ecx je short loc_fffa531e ; je 0xfffa531e @@ -5576,16 +5513,16 @@ mov edx, 2 lea eax, [ebp - 0x5e] mov dword [ebp - 0xd4], esi -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem lea edx, [ebp - 0x3b] mov ecx, 5 lea eax, [ebp - 0x36] mov esi, 0xcf8 -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy lea edx, [ebp - 0x4d] mov ecx, 4 lea eax, [ebp - 0x49] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy lea edx, [ebx + 0x2974] mov eax, 0x80000000 mov dword [ebp - 0xa4], edx @@ -7811,7 +7748,7 @@ mov edi, dword [ebp - 0x24] cmp dword [ebp - 0x28], edi jne short loc_fffa761b ; jne 0xfffa761b -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit mov edi, dword [ebp - 0x70] sub eax, 9 or edi, 0x40 @@ -9358,31 +9295,31 @@ mov dword [ebp - 0x48], ref_fffcb78c ; mov dword [ebp - 0x48], 0xfffcb78c mov dword [ebp - 0x44], ref_fffcb7ec ; mov dword [ebp - 0x44], 0xfffcb7ec mov dword [ebp - 0xc4], 0 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 8 lea eax, [ebp - 0x38] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 8 lea eax, [ebp - 0x30] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 8 lea eax, [ebp - 0x28] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 8 lea eax, [ebp - 0x20] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0xff mov edx, 4 lea eax, [ebp - 0x58] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 4 lea eax, [ebp - 0x54] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp dword [edi + 0x1749], 2 jne short loc_fffa8917 ; jne 0xfffa8917 mov word [ebp - 0x5c], 8 @@ -10018,7 +9955,7 @@ pop ebp mov ecx, 4 mov edx, ref_fffcb7f8 ; mov edx, 0xfffcb7f8 -jmp near fcn_fffa115e ; jmp 0xfffa115e +jmp mrc_memcpy loc_fffa91ad: pop ebp @@ -10340,7 +10277,7 @@ mov byte [ebp - 0x1f5], 0 mov dword [ebp - 0x248], ebx movzx edi, byte [esi + 0x176b] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov eax, dword [esi + 0x1005] cmp eax, 0x40650 je short loc_fffa95ba ; je 0xfffa95ba @@ -11238,7 +11175,7 @@ mov word [ebp - 0x206], 0x1000 mov word [ebp - 0x204], 0x1000 mov word [ebp - 0x202], 0x1000 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov edi, dword [ebp - 0x250] mov eax, 2 cmp dword [edi + 0x297c], 2 @@ -11551,7 +11488,7 @@ lea edx, [esi + eax + 0xa] lea eax, [ecx + eax + 8] mov ecx, 0x2a -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy cmp edi, 4 jne short loc_fffaa747 ; jne 0xfffaa747 xor di, di @@ -11574,13 +11511,13 @@ mov ecx, 0xfb lea eax, [edx + eax + 0x1151] mov edx, dword [ebp - 0x3c] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy imul eax, edi, 0x1f mov ecx, 0x1f lea edx, [esi + eax + 0x2a8] mov eax, dword [ebp - 0x34] add eax, 0x81 -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy loc_fffaa7ca: ; not directly referenced inc edi @@ -11771,7 +11708,7 @@ mov dword [ebp - 0x48], 0 mov byte [ebp - 0x56], 0 mov byte [ebp - 0x55], 0 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp byte [ebx + 0x1740], 1 je short loc_fffaaa2c ; je 0xfffaaa2c cmp byte [ebx + 0x16b8], 1 @@ -12109,7 +12046,7 @@ xor ecx, ecx mov edx, 0x2c lea eax, [ebp - 0x44] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp byte [ebx + 0x1740], 1 jne short loc_fffaae92 ; jne 0xfffaae92 cmp dword [ebx + 0x297c], 2 @@ -12311,7 +12248,7 @@ imul eax, dword [ebp - 0x74] mov dword [ebp - 0x90], edx dec eax -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit mov edx, dword [ebp - 0x90] mov ecx, dword [ebx + 0x103f] add ecx, edx @@ -12517,28 +12454,28 @@ mov ecx, 0x2a lea edx, [esi + eax + 8] lea eax, [edi + eax + 0xa] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy inc dword [ebp - 0x20] cmp dword [ebp - 0x20], 4 jne short loc_fffab320 ; jne 0xfffab320 lea edx, [esi + 0x1151] mov ecx, 0xfb lea eax, [edi + 0xb2] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov edx, dword [ebp - 0x24] mov ecx, 0x1f add edx, 0xa1 lea eax, [edi + 0x2a8] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy lea edx, [esi + 0x124c] mov ecx, 0xfb lea eax, [edi + 0x1ad] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov edx, dword [ebp - 0x24] lea eax, [edi + 0x2c7] add edx, 0x1f0 mov ecx, 0x1f -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy inc dword [ebp - 0x1c] cmp dword [ebp - 0x1c], 2 jne loc_fffab2cd ; jne 0xfffab2cd @@ -12625,7 +12562,7 @@ lea eax, [ebp - 0x218] push ebx lea esp, [esp - 0x39c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ebx, dword [ebp + 8] add ebx, 0x16be mov dword [ebp - 0x380], ebx @@ -12648,14 +12585,14 @@ rep movsd ; rep movsd dword es:[edi], dword ptr [esi] lea eax, [ebp - 0x2a8] lea ebx, [ebp - 0x2a8] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0xc lea eax, [ebp - 0x2c8] mov byte [ebp - 0x2a7], 1 lea esi, [ebp - 0x298] mov edi, 1 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem jmp short loc_fffab5b9 ; jmp 0xfffab5b9 loc_fffab57e: ; not directly referenced @@ -12736,7 +12673,7 @@ imul eax, edi, 0x2fa mov esi, dword [ebp - 0x344] lea eax, [esi + eax + 0x2b3] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem lea eax, [ebx - 0x3010] mov dword [ebp - 0x33c], eax xor eax, eax @@ -12975,11 +12912,11 @@ lea eax, [ebp - 0x2a8] mov bl, byte [ebx + 0x176a] mov byte [ebp - 0x37c], bl -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x48 lea eax, [ebp - 0x260] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ebx, dword [ebp + 8] mov eax, 0x3074 add ebx, 0x2974 @@ -13188,17 +13125,17 @@ mov edx, 0x10 lea ebx, [ebp - 0x2e8] mov eax, ebx -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x10 lea eax, [ebp - 0x308] lea esi, [ebp - 0x330] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x10 lea eax, [ebp - 0x2c8] lea edi, [ebp - 0x338] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov eax, dword [ebp + 8] mov dword [ebp - 0x368], esi mov dword [ebp - 0x344], edi @@ -13532,11 +13469,11 @@ lea eax, [ebp - 0x2a8] mov bl, byte [ebx + 0x176a] mov byte [ebp - 0x348], bl -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x48 lea eax, [ebp - 0x260] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ebx, dword [ebp + 8] mov eax, 0x3074 add ebx, 0x2974 @@ -13762,12 +13699,12 @@ mov edx, 4 lea eax, [ebp - 0x2c8] lea ebx, [ebp - 0x308] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 4 lea eax, [ebp - 0x2e8] lea esi, [ebp - 0x2a8] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov eax, dword [ebp + 8] mov dword [ebp - 0x340], ebx add eax, 0x10b7 @@ -14270,7 +14207,7 @@ mov eax, dword [ebp - 0x340] xor edx, edx add eax, 0xf9 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffacafd: ; not directly referenced inc edi @@ -14820,7 +14757,7 @@ movzx ecx, byte [ebx + 0x1755] add eax, 0xf9 xor edx, edx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffad2d3: ; not directly referenced inc esi @@ -14889,11 +14826,11 @@ xor ecx, ecx lea eax, [ebp - 0x21] mov edi, dword [ebp + 0x10] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 1 mov edx, 7 lea eax, [ebp - 0x1f] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem movzx eax, byte [ebp - 0x2a] mov dl, byte [ebp - 0x48] shr edx, 1 @@ -15100,19 +15037,19 @@ mov ebx, dword [ebp + 0xc] mov byte [ebp - 0x1a], 0xf8 mov byte [ebp - 0x19], 8 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 lea eax, [ebp - 0x22] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 lea eax, [ebp - 0x1e] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0x7f mov edx, 2 lea eax, [ebp - 0x1c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem movzx esi, byte [ebp - 0x35] xor edx, edx mov ecx, esi @@ -15864,7 +15801,7 @@ mov esi, dword [ebp + 8] mov bl, byte [esi + 0x176a] mov byte [ebp - 0x31], bl -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp dword [esi + 0x1749], 2 mov eax, esi movzx edx, byte [esi + 0x176b] @@ -15898,7 +15835,7 @@ xor edx, edx movzx ecx, byte [esi + 0x1755] add eax, 0x107 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffade76: ; not directly referenced inc edi @@ -16173,7 +16110,7 @@ mov eax, dword [ebp - 0x160] xor edx, edx add eax, 0xf9 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffae176: ; not directly referenced inc edi @@ -16540,7 +16477,7 @@ lea eax, [ebx + 0xf9] xor edx, edx movzx ecx, byte [esi + 0x1755] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword add ebx, dword [ebp - 0x148] xor eax, eax mov dword [ebp - 0x144], ebx @@ -19215,7 +19152,7 @@ mov ecx, 1 mov bl, byte [ebp + 8] mov edi, dword [ebp + 0xc] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp byte [ebp - 0x155], 0xb mov al, byte [ebp - 0x155] setne byte [ebp - 0x156] @@ -19355,7 +19292,7 @@ loc_fffb05cf: ; not directly referenced lea eax, [ebx + 0xf9] xor edx, edx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov edx, edi mov eax, dword [esi + 0x103f] shl edx, 0xa @@ -20023,7 +19960,7 @@ ja loc_fffb1cc4 ; ja 0xfffb1cc4 mov edx, 0x10 lea eax, [ebp - 0xc68] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor eax, eax loc_fffb0e06: ; not directly referenced @@ -20057,14 +19994,14 @@ xor ecx, ecx mov edx, 0x1c lea eax, [ebp - 0xc04] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem jmp short loc_fffb0ea6 ; jmp 0xfffb0ea6 loc_fffb0e90: ; not directly referenced mov ecx, 0x1c lea edx, [ebp - 0xc20] lea eax, [ebp - 0xc04] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy loc_fffb0ea6: ; not directly referenced mov dword [ebp - 0xcd0], 0 @@ -20117,7 +20054,7 @@ movzx ecx, byte [eax + 0x1755] imul eax, ebx, 0x1347 lea eax, [esi + eax + 0x101] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb0fa2: ; not directly referenced inc ebx @@ -20165,7 +20102,7 @@ mov edx, 0x18 movzx ecx, byte [eax + 0x1755] mov eax, ebx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov eax, dword [ebp - 0xc7c] mov edx, 0x18 movzx ecx, byte [eax + 0x1755] @@ -20176,24 +20113,24 @@ mov edx, 1 movzx ecx, byte [eax + 0x1755] lea eax, [ebp - 0xba0] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov eax, dword [ebp - 0xc7c] mov edx, 1 movzx ecx, byte [eax + 0x1755] lea eax, [ebp - 0xbe8] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov eax, dword [ebp - 0xc7c] mov edx, 1 movzx ecx, byte [eax + 0x1755] lea eax, [ebp - 0xb7c] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov eax, dword [ebp - 0xc7c] mov edx, 1 movzx ecx, byte [eax + 0x1755] loc_fffb10d3: ; not directly referenced lea eax, [ebp - 0xbc4] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb10de: ; not directly referenced push eax @@ -20556,7 +20493,7 @@ mov eax, dword [ebp - 0xc84] xor edx, edx add eax, 0xf9 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb1640: ; not directly referenced inc esi @@ -20595,12 +20532,12 @@ mov edx, 0x18 movzx ecx, byte [eax + 0x1755] mov eax, ebx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov eax, dword [ebp - 0xc7c] mov edx, 0x18 movzx ecx, byte [eax + 0x1755] lea eax, [ebp - 0xbc4] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb16f9: ; not directly referenced mov bl, byte [ebp - 0xca8] @@ -20638,7 +20575,7 @@ add eax, esi mov edx, 8 inc ebx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword add dword [ebp - 0xc90], 0x24 cmp ebx, 2 jne short loc_fffb175b ; jne 0xfffb175b @@ -20936,7 +20873,7 @@ mov eax, dword [ebp - 0xc94] xor edx, edx add eax, 0xf9 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb1bd2: ; not directly referenced inc edi @@ -21465,42 +21402,6 @@ pop ebp ret -fcn_fffb21bf: ; not directly referenced -cmp eax, 0xffffffffffffffff -je short loc_fffb21e7 ; je 0xfffb21e7 -push ebp -xor ecx, ecx -xor edx, edx -mov ebp, esp -push edi -push esi -push ebx -mov ebx, 1 - -loc_fffb21d3: ; not directly referenced -mov edi, ebx -lea esi, [ecx + 1] -shl edi, cl -test edi, eax -cmovne edx, esi -inc ecx -cmp ecx, 0x20 -jne short loc_fffb21d3 ; jne 0xfffb21d3 -jmp short loc_fffb21ec ; jmp 0xfffb21ec - -loc_fffb21e7: ; not directly referenced -xor edx, edx -mov al, dl -ret - -loc_fffb21ec: ; not directly referenced -pop ebx -mov al, dl -pop esi -pop edi -pop ebp -ret - fcn_fffb21f3: ; not directly referenced push ebp mov ebp, esp @@ -21516,19 +21417,19 @@ mov ecx, 1 mov edx, 8 lea eax, [ebp - 0x38] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 8 lea eax, [ebp - 0x30] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 9 mov edx, 8 lea eax, [ebp - 0x28] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor edx, edx mov ecx, 2 lea eax, [ebp - 0x20] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword cmp byte [ebp - 0x49], 1 jne short loc_fffb2278 ; jne 0xfffb2278 mov byte [ebp - 0x35], 0xa @@ -21615,7 +21516,7 @@ mov byte [ebp - 0x70], dl movzx eax, dl dec eax -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit mov dl, byte [ebp - 0x70] cmp dl, 0x1f jbe short loc_fffb2368 ; jbe 0xfffb2368 @@ -21924,7 +21825,7 @@ mov dword [ebp - 0x41], 0 mov dword [ebp - 0x3d], 0 mov ebx, dword [ebp + 0x24] -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit mov cl, byte [ebp - 0x49] mov byte [ebp - 0x5d], al inc ecx @@ -21963,7 +21864,7 @@ jbe short loc_fffb271d ; jbe 0xfffb271d movzx edx, dx lea eax, [edx - 1] -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit mov byte [ebp - 0x98], al loc_fffb271d: ; not directly referenced @@ -21971,7 +21872,7 @@ mov si, word [eax] movzx eax, si dec eax -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit cmp si, 0x1f jbe short loc_fffb273d ; jbe 0xfffb273d mov edx, dword [ebp + 0x18] @@ -22662,7 +22563,7 @@ add edi, 0x1774 mov dword [ebp - 0x40], edi xor edi, edi -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem sub esp, 0xc mov eax, dword [ebp + 8] push 0 @@ -22700,7 +22601,7 @@ mov edx, dword [ebp - 0x3c] lea eax, [edx + eax + 0x101] xor edx, edx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb2f0f: ; not directly referenced cmp byte [ebp - 0x29], 0 @@ -24237,19 +24138,19 @@ xor ecx, ecx mov dword [ebp - 0x1f8], ebx lea esi, [edi + 0x2974] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0xf8 mov edx, 0x12 lea eax, [ebp - 0x1a4] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0xff mov edx, 0x12 lea eax, [ebp - 0x16e] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x12 lea eax, [ebp - 0x180] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov dword [ebp - 0x1c4], 0x64 xor eax, eax mov dword [ebp - 0x1c0], esi @@ -24578,11 +24479,11 @@ mov edx, 0xa2 lea eax, [ebp - 0x15c] lea esi, [edi + 0x2974] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0xa2 lea eax, [ebp - 0xba] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp dword [ebp - 0x1f8], 1 mov dword [ebp - 0x1c0], 1 sbb ebx, ebx @@ -24949,11 +24850,11 @@ mov byte [ebp - 0x42], 2 mov byte [ebp - 0x41], 3 mov dword [ebp - 0x54], esi -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov ecx, 6 lea edx, [ebp - 0x3c] lea eax, [ebp - 0x36] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov eax, dword [ebp - 0x4c] xor edx, edx cmp dword [eax + 0x1749], 2 @@ -26710,23 +26611,23 @@ mov byte [ebp - 0xbd65], 0 mov byte [ebp - 0xbd7f], 6 mov byte [ebp - 0xbd7e], 5 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0xb77a lea eax, [ebp - 0xb792] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x15e lea eax, [ebp - 0xbd52] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 lea eax, [ebp - 0xbd85] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 8 lea eax, [ebp - 0xbd64] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov edi, dword [ebp + 8] mov dl, bl xor edx, 1 @@ -29647,16 +29548,16 @@ push ebx lea esp, [esp - 0x19c] mov ebx, dword [ebp + 8] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 lea eax, [ebp - 0x15e] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x130 lea eax, [ebp - 0x148] lea esi, [ebx + 0x16be] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor eax, eax cmp dword [ebx + 0x1749], 2 sete al @@ -29694,7 +29595,7 @@ movzx ecx, byte [ebx + 0x1755] lea eax, [edx + eax + 0x13b7] xor edx, edx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffb8136: ; not directly referenced inc esi @@ -29764,11 +29665,11 @@ mov edx, 2 lea eax, [ebp - 0x15c] lea esi, [ebp - 0x15a] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 mov eax, esi -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem lea ecx, [ebp - 0x15c] xor edx, edx push ecx @@ -30808,7 +30709,7 @@ mov dword [ebp - 0x34], eax mov edx, 4 mov eax, dword [ebp + 0xc] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov eax, dword [ebp - 0x2c] shl eax, 0xa mov ebx, eax @@ -31876,7 +31777,7 @@ mov edx, ebx mov byte [eax + 0x1c], 1 add eax, 0x1d -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy jmp near loc_fffb9cc6 ; jmp 0xfffb9cc6 loc_fffb9a24: @@ -33405,11 +33306,11 @@ mov dword [ebp - 0x229], 0 mov dword [ebp - 0x225], 3 mov byte [ebp - 0x221], 0 -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy xor ecx, ecx mov edx, 8 lea eax, [ebp - 0x24c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor edx, edx cmp dword [ebx + 0x1749], 2 sete dl @@ -34015,11 +33916,11 @@ lea eax, [esi + 0x16be] mov dword [ebp - 0x54], eax lea eax, [ebp - 0x28] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 1 mov edx, 3 lea eax, [ebp - 0x3b] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem sub esp, 0xc mov ecx, 0x11 movzx edx, byte [esi + 0x176b] @@ -34056,7 +33957,7 @@ movzx ecx, byte [esi + 0x1755] add eax, 0x107 xor edx, edx -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffbb8d9: ; not directly referenced inc ebx @@ -34252,7 +34153,7 @@ add eax, 0x107 xor edx, edx movzx ecx, byte [esi + 0x1755] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffbbad1: ; not directly referenced inc ebx @@ -37937,27 +37838,27 @@ mov edx, 0x4ee4 mov byte [ebp - 0x6b58], bl mov bl, byte [ebp + 0x2c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0xff mov edx, 0x3e mov eax, dword [ebp - 0x6b98] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0xf0 lea eax, [ebp - 0x6aec] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x30 lea eax, [ebp - 0x6b1c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 lea eax, [ebp - 0x6b37] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x10 lea eax, [ebp - 0x6b2c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor eax, eax loc_fffbe31a: ; not directly referenced @@ -38016,7 +37917,7 @@ xor ecx, ecx movzx edx, byte [eax + 0x1755] lea eax, [edi + 0x101] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem loc_fffbe3e4: ; not directly referenced inc ebx @@ -38920,11 +38821,11 @@ mov byte [ebp - 0x4fc], 0 mov byte [ebp - 0x4fb], 0 mov dword [ebp - 0x503], 0 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0xff mov edx, 0x53e mov eax, dword [ebp - 0x524] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov eax, dword [ebp - 0x52c] mov dl, byte [ebp - 0x520] mov byte [ebp - 0x50d], 0 @@ -39697,27 +39598,27 @@ mov edx, 1 lea eax, [ebp - 0x34c] movzx ebx, byte [ebp + 8] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov ecx, 5 mov edx, 1 lea eax, [ebp - 0x338] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov ecx, 5 or edx, 0xffffffff lea eax, [ebp - 0x324] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov ecx, 5 xor edx, edx lea eax, [ebp - 0x310] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov ecx, 5 xor edx, edx lea eax, [ebp - 0x2fc] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword mov ecx, 5 xor edx, edx lea eax, [ebp - 0x2e8] -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword xor ecx, ecx mov edx, 0x2bc lea eax, [ebp - 0x2d4] @@ -39726,11 +39627,11 @@ mov word [ebp - 0x352], 0 mov word [ebp - 0x350], 0 mov word [ebp - 0x34e], 0 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x462 mov eax, dword [ebp - 0x370] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem movsx ecx, byte [ebp - 0x371] mov dword [ebp - 0x398], ebx mov ebx, dword [ebp - 0x378] @@ -40041,7 +39942,7 @@ mov eax, esi loc_fffbffae: ; not directly referenced -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit inc edi add ebx, eax cmp edi, 5 @@ -40358,7 +40259,7 @@ mov byte [ebp - 0x2a], dl lea eax, [ebp - 0x1d] mov edx, 5 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem cmp dword [ebp + 0xc], 0 mov al, 0 mov cl, byte [ebp - 0x2a] @@ -40601,7 +40502,7 @@ mov edx, 0x26 mov dword [ebp - 0x88], eax lea eax, [ebp - 0x3e] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem movzx ecx, byte [ebp - 0x77] mov edx, esi movzx eax, dl @@ -41033,11 +40934,11 @@ xor ecx, ecx mov edx, 4 lea eax, [ebp - 0x28] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov edx, 2 xor ecx, ecx lea eax, [ebp - 0x40] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem imul eax, dword [ebp - 0x64], 0x24 mov edx, dword [ebp - 0x50] add edx, eax @@ -41813,7 +41714,7 @@ mov ecx, 1 mov edx, 7 lea eax, [ebp - 0x4f] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem movsx si, byte [ebp - 0x6c] cmp dword [edi + 0x1749], 2 mov word [ebp - 0x78], si @@ -42169,7 +42070,7 @@ lea eax, [ebp - 0x27] mov dword [ebp - 0x1c], 0 mov dword [ebp - 0x20], 0 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, esi mov eax, esi and ecx, 1 @@ -42449,12 +42350,12 @@ lea esp, [esp - 0x50bc] mov dword [ebp - 0x50bc], eax lea eax, [ebp - 0x503a] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem lea eax, [ebp - 0x5079] mov ecx, 0x3f mov edx, ref_fffcbee8 ; mov edx, 0xfffcbee8 mov dword [ebp - 0x38ce], eax -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov edx, dword [ebp - 0x50bc] push edi push edi @@ -42484,7 +42385,7 @@ lea edi, [eax + 8] add eax, 0x18 rep movsd ; rep movsd dword es:[edi], dword ptr [esi] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem jmp short loc_fffc1c07 ; jmp 0xfffc1c07 loc_fffc1bfd: @@ -42929,7 +42830,7 @@ jne loc_fffc2251 ; jne 0xfffc2251 lea eax, [ebp - 0x397c] mov edx, 0x395c -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem lea eax, [ebp - 0x5079] inc byte [ebp - 0x4022] mov dword [ebp - 0x38ce], eax @@ -43092,7 +42993,7 @@ mov eax, dword [ebp - 0x50a0] mov edx, 1 add eax, 0x503a -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem add esp, 0x10 loc_fffc2355: @@ -43110,7 +43011,7 @@ loc_fffc2376: mov edx, 0xfd4 lea eax, [ebp - 0x5036] -call fcn_fffa118a ; call 0xfffa118a +call mrc_zeromem xor edi, edi jmp near loc_fffc1f53 ; jmp 0xfffc1f53 @@ -44274,7 +44175,7 @@ movzx ecx, byte [ebx + 0x1755] mov edx, dword [ebp - 0x34] mov eax, esi -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffc32a3: ; not directly referenced inc byte [ebp - 0x2d] @@ -44331,7 +44232,7 @@ mov byte [ebp - 0x933], 1 mov byte [ebp - 0x932], 1 mov dword [ebp - 0x944], ebx -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor eax, eax loc_fffc3355: ; not directly referenced @@ -44404,7 +44305,7 @@ xor edx, edx movzx ecx, byte [esi + 0x1755] add eax, 0x107 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffc3457: ; not directly referenced inc ebx @@ -44743,7 +44644,7 @@ mov eax, dword [ebp - 0x950] xor edx, edx add eax, 0xf9 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword sub esp, 0xc mov ecx, 1 push 0 @@ -45042,7 +44943,7 @@ mov eax, dword [ebp - 0x950] xor edx, edx add eax, 0xf9 -call fcn_fffc83ab ; call 0xfffc83ab +call mrc_fillword loc_fffc3d05: ; not directly referenced inc edi @@ -45358,7 +45259,7 @@ loc_fffc406a: ; not directly referenced dec eax -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit movzx eax, al jmp short loc_fffc4078 ; jmp 0xfffc4078 @@ -45383,7 +45284,7 @@ lea eax, [edx + 0x80] jbe short loc_fffc40b6 ; jbe 0xfffc40b6 lea eax, [edx - 1] -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit movzx eax, al loc_fffc40b6: ; not directly referenced @@ -45404,7 +45305,7 @@ lea eax, [edx + 0x20] jbe short loc_fffc40f3 ; jbe 0xfffc40f3 lea eax, [edx - 1] -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit movzx eax, al loc_fffc40f3: ; not directly referenced @@ -45423,7 +45324,7 @@ lea eax, [edx + 0x80] jbe short loc_fffc4125 ; jbe 0xfffc4125 lea eax, [edx - 1] -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit movzx eax, al loc_fffc4125: ; not directly referenced @@ -46153,19 +46054,19 @@ mov dword [ebp - 0x32a], 0 mov dword [ebp - 0x326], 7 mov byte [ebp - 0x322], 0 -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 2 lea eax, [ebp - 0x337] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 0x10 lea eax, [ebp - 0x314] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, 0x2c lea edx, [ebp - 0x2e0] lea eax, [ebp - 0x2b4] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy xor eax, eax loc_fffc49a5: ; not directly referenced @@ -46348,7 +46249,7 @@ call fcn_fffb2650 ; call 0xfffb2650 add esp, 0x20 lea eax, [esi - 1] -call fcn_fffb21bf ; call 0xfffb21bf +call mrc_highest_bit movzx eax, al mov ecx, ebx sub ecx, eax @@ -48817,10 +48718,10 @@ fcn_fffc6986: mov ecx, 0xce -rdmsr +rdmsr ; rdmsr(MSR_PLATFORM_INFO) movzx ecx, ah xor edx, edx -imul ecx, ecx, 0x186a0 +imul ecx, ecx, 0x186a0 ; 100000 xor eax, eax test ecx, ecx je short loc_fffc69ba ; je 0xfffc69ba @@ -48928,11 +48829,11 @@ mov edx, 4 lea eax, [ebp - 0xa2] lea esi, [ebp - 0x72] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem xor ecx, ecx mov edx, 4 lea eax, [ebp - 0x9e] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov dword [ebp - 0xbc], esi xor esi, esi @@ -50948,24 +50849,6 @@ pop ebp ret -fcn_fffc83ab: ; not directly referenced -push ebp -mov ebp, esp -push ebx -xor ebx, ebx -jmp short loc_fffc83b7 ; jmp 0xfffc83b7 - -loc_fffc83b3: ; not directly referenced -mov dword [eax + ebx*4], edx -inc ebx - -loc_fffc83b7: ; not directly referenced -cmp ebx, ecx -jne short loc_fffc83b3 ; jne 0xfffc83b3 -pop ebx -pop ebp -ret - fcn_fffc83be: push ebp mov ecx, edx @@ -52109,7 +51992,7 @@ mov ecx, 8 lea edx, [ebp - 0x28] lea eax, [ebp - 0x20] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov bl, byte [ebp - 0x19] shr bl, 7 jmp short loc_fffc8ed7 ; jmp 0xfffc8ed7 @@ -52201,7 +52084,7 @@ mov ecx, 8 lea eax, [ebp - 0x30] or byte [ebp - 0x21], 0x80 -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov eax, dword [ebp - 0x30] mov edx, dword [ebp - 0x2c] mov ecx, 0x150 @@ -52218,7 +52101,7 @@ mov dword [ebp - 0x2c], edx lea eax, [ebp - 0x28] lea edx, [ebp - 0x30] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov eax, 0xa call fcn_fffc5e98 ; call 0xfffc5e98 mov eax, dword [ebp - 0x40] @@ -52228,7 +52111,7 @@ mov ecx, 8 lea edx, [ebp - 0x30] lea eax, [ebp - 0x20] -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy mov edx, dword [ebp - 0x1c] cmp dword [ebp - 0x24], edx je short loc_fffc904d ; je 0xfffc904d @@ -52245,7 +52128,7 @@ loc_fffc905e: mov eax, esi -call fcn_fffa115e ; call 0xfffa115e +call mrc_memcpy jmp short loc_fffc906c ; jmp 0xfffc906c loc_fffc9067: @@ -53068,7 +52951,7 @@ mov byte [ebp - 0x5d], al xor ecx, ecx lea eax, [ebp - 0x2c] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov ecx, edi mov eax, 1 movzx edx, cl @@ -53460,7 +53343,7 @@ mov byte [ebp - 0x3b], al xor ecx, ecx lea eax, [ebp - 0x1a] -call fcn_fffa119f ; call 0xfffa119f +call mrc_setmem mov cl, bl mov dword [ebp - 0x40], 1 movzx edx, bl diff --git a/src/northbridge/intel/haswell/mrc_utils.c b/src/northbridge/intel/haswell/mrc_utils.c new file mode 100644 index 0000000..f4c125a --- /dev/null +++ b/src/northbridge/intel/haswell/mrc_utils.c @@ -0,0 +1,43 @@ +#include <string.h> + +void __attribute((regparm(3))) mrc_setmem(void *s, size_t n, int c); +void __attribute((regparm(3))) mrc_memcpy(void *dst, const void *src, size_t n); +void __attribute((regparm(3))) mrc_fillword(int *s, int c, size_t n); +void __attribute((regparm(3))) mrc_zeromem(void *s, size_t n); +char __attribute((regparm(3))) mrc_highest_bit(int a); + +void __attribute((regparm(3))) mrc_setmem(void *s, size_t n, int c) +{ + memset(s, c, n); +} + +void __attribute((regparm(3))) mrc_fillword(int *s, int c, size_t n) +{ + for (size_t i = 0; i < n; i++) + s[i] = c; +} + +void __attribute((regparm(3))) mrc_memcpy(void *dst, const void *src, size_t n) +{ + memcpy(dst, src, n); +} + +void __attribute((regparm(3))) mrc_zeromem(void *s, size_t n) +{ + memset(s, 0, n); +} + +char __attribute((regparm(3))) mrc_highest_bit(int a) +{ + int result = 0; + + if (a == -1) + return 0; + + for (int i = 0; i < 32; i++) { + if (a & (1 << i)) + result = i + 1; + } + + return result; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/30188 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifebe96f655c13d7c17ac09f520581d7df7e3cf7d Gerrit-Change-Number: 30188 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: rename two haswell cpuid functions
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30187 Change subject: rename two haswell cpuid functions ...................................................................... rename two haswell cpuid functions from cpu/intel/haswell/haswell_init.c Change-Id: I1871c73c1855a8f3a3313a92daa7f91db782c565 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/northbridge/intel/haswell/mrc.asm 1 file changed, 17 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/30187/1 diff --git a/src/northbridge/intel/haswell/mrc.asm b/src/northbridge/intel/haswell/mrc.asm index c9a109e..cc4361b 100644 --- a/src/northbridge/intel/haswell/mrc.asm +++ b/src/northbridge/intel/haswell/mrc.asm @@ -549,9 +549,9 @@ lea esp, [esp - 0x1c] mov dword [ebp - 0x20], edx mov word [ebp - 0x1a], cx -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov ebx, eax -call fcn_fffc9077 ; call 0xfffc9077 +call haswell_stepping dec eax sete dl cmp ebx, 0x306c0 @@ -674,7 +674,7 @@ and eax, 0xfc000000 mov eax, dword [eax + 0x48] mov dword [ebp - 0x6c], eax -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov dword [ebp - 0x70], eax mov eax, dword [0xf0000060] mov edx, dword [0xf0000060] @@ -1698,8 +1698,8 @@ push ebp mov ebp, esp lea esp, [esp - 8] -call fcn_fffc9077 ; call 0xfffc9077 -call fcn_fffc908a ; call 0xfffc908a +call haswell_stepping +call haswell_family_model mov edx, 4 mov eax, ref_fffcd4a4 ; mov eax, 0xfffcd4a4 call fcn_fffa11b3 ; call 0xfffa11b3 @@ -3932,7 +3932,7 @@ call mrc_printk ; call 0xfffa1253 mov edx, dword [0xff7d7538] mov dword [ebp - 0x640], edx -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov ecx, dword [ebp - 0x640] lea edx, [ebp - 0x628] mov dword [ebp - 0x648], eax @@ -3945,7 +3945,7 @@ call dword [eax + 0x20] ; ucall mov ebx, dword [ebp - 0x628] add esp, 0x20 -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov ecx, eax mov esi, dword [0xf0000060] and esi, 0xfc000000 @@ -4057,9 +4057,9 @@ loc_fffa3fd4: mov ebx, dword [ebp - 0x628] -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov esi, eax -call fcn_fffc9077 ; call 0xfffc9077 +call haswell_stepping dec eax sete dl cmp esi, 0x306c0 @@ -4088,7 +4088,7 @@ je loc_fffa4d64 ; je 0xfffa4d64 mov eax, dword [ebp - 0x628] mov dword [ebp - 0x660], eax -call fcn_fffc9077 ; call 0xfffc9077 +call haswell_stepping mov eax, dword [0xf0000060] sub esp, 0xc and eax, 0xfc000000 @@ -4117,9 +4117,9 @@ and eax, 0xfffffffe and ebx, 0xfffffffe mov dword [ebp - 0x648], eax -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov edi, eax -call fcn_fffc9077 ; call 0xfffc9077 +call haswell_stepping mov edx, 0xa00 loc_fffa40d3: @@ -4896,7 +4896,7 @@ mov edx, dword [eax + 0x6c] mov eax, dword [eax + 0x68] mov edi, eax -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov edx, dword [ebp - 0x640] sub esp, 0xc mov ebx, eax @@ -42664,9 +42664,9 @@ cmove ebx, eax loc_fffc1e18: -call fcn_fffc908a ; call 0xfffc908a +call haswell_family_model mov esi, eax -call fcn_fffc9077 ; call 0xfffc9077 +call haswell_stepping cmp esi, 0x40650 jne short loc_fffc1e38 ; jne 0xfffc1e38 mov dword [ebp - 0x4035], 0x40650 @@ -52260,7 +52260,7 @@ pop ebp ret -fcn_fffc9077: +haswell_stepping: push ebp xor ecx, ecx mov eax, 1 @@ -52272,7 +52272,7 @@ pop ebp ret -fcn_fffc908a: +haswell_family_model: push ebp xor ecx, ecx mov eax, 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30187 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1871c73c1855a8f3a3313a92daa7f91db782c565 Gerrit-Change-Number: 30187 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: replace the printf function in mrc.bin
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30186 Change subject: replace the printf function in mrc.bin ...................................................................... replace the printf function in mrc.bin Change-Id: I0d4667232357e6a74459d946de42cf695a69c162 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/console/printk.c M src/northbridge/intel/haswell/mrc.asm 2 files changed, 36 insertions(+), 1,221 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/30186/1 diff --git a/src/console/printk.c b/src/console/printk.c index 735876e..4b39374 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -78,6 +78,20 @@ return i; } +int mrc_printk(const char *fmt, ...); +int mrc_printk(const char *fmt, ...) +{ + int i; + va_list args; + + va_start(args, fmt); + i = vtxprintf(wrap_putchar, fmt, args, NULL); + va_end(args); + console_tx_flush(); + + return i; +} + #if IS_ENABLED(CONFIG_VBOOT) void do_printk_va_list(int msg_level, const char *fmt, va_list args) { diff --git a/src/northbridge/intel/haswell/mrc.asm b/src/northbridge/intel/haswell/mrc.asm index 6176b98..c9a109e 100644 --- a/src/northbridge/intel/haswell/mrc.asm +++ b/src/northbridge/intel/haswell/mrc.asm @@ -4,6 +4,8 @@ global mrc_entry +extern mrc_printk + mrc_entry: mov ecx, esp mov esp, 0xff800000 @@ -1710,1014 +1712,6 @@ leave ret -fcn_fffa1253: -push ebp -mov ebp, esp -push edi -push esi -lea edx, [ebp + 0xc] -mov edi, edx -push ebx -lea esp, [esp - 0xec] -mov eax, dword [ebp + 8] -test eax, eax -mov dword [ebp - 0xa4], edx -mov dword [ebp - 0xa0], 0 -lea edx, [ebp - 0x9a] -mov dword [ebp - 0xcc], 0 -mov dword [ebp - 0xdc], 0 -mov dword [ebp - 0xac], edx -jne loc_fffa1cbd ; jne 0xfffa1cbd - -loc_fffa12a0: -or eax, 0xffffffff -jmp near loc_fffa1d18 ; jmp 0xfffa1d18 - -loc_fffa12a8: -inc ebx - -loc_fffa12a9: -mov dl, byte [ebx] -cmp dl, 0x25 -setne cl -test dl, dl -setne dl -test cl, dl -jne short loc_fffa12a8 ; jne 0xfffa12a8 -mov esi, ebx -sub esi, eax -je short loc_fffa12d7 ; je 0xfffa12d7 -lea ecx, [ebp - 0xa0] -mov edx, esi -call fcn_fffc199b ; call 0xfffc199b -test eax, eax -js short loc_fffa12a0 ; js 0xfffa12a0 -add dword [ebp - 0xcc], esi - -loc_fffa12d7: -cmp byte [ebx], 0 -mov eax, ebx -je loc_fffa1cbd ; je 0xfffa1cbd -lea esi, [ebx + 1] -mov dword [ebp - 0xb0], 0 - -loc_fffa12ef: -mov dl, byte [esi] -test dl, dl -jne short loc_fffa1308 ; jne 0xfffa1308 - -loc_fffa12f5: -mov dword [ebp - 0xc0], 0 -jmp short loc_fffa1350 ; jmp 0xfffa1350 - -loc_fffa1301: -test cl, cl -je short loc_fffa1318 ; je 0xfffa1318 -inc eax -jmp short loc_fffa130d ; jmp 0xfffa130d - -loc_fffa1308: -mov eax, ref_fffc9e9c ; mov eax, 0xfffc9e9c - -loc_fffa130d: -mov cl, byte [eax] -cmp cl, dl -jne short loc_fffa1301 ; jne 0xfffa1301 -jmp near loc_fffa1cd1 ; jmp 0xfffa1cd1 - -loc_fffa1318: -cmp dl, 0x2a -jne short loc_fffa12f5 ; jne 0xfffa12f5 -lea eax, [edi + 4] -mov edi, dword [edi] -test edi, edi -mov dword [ebp - 0xc0], edi -jns short loc_fffa1339 ; jns 0xfffa1339 -neg dword [ebp - 0xc0] -or dword [ebp - 0xb0], 4 - -loc_fffa1339: -inc esi -mov edi, eax -jmp short loc_fffa136b ; jmp 0xfffa136b - -loc_fffa133e: -imul edx, dword [ebp - 0xc0], 0xa -inc esi -lea eax, [edx + eax - 0x30] -mov dword [ebp - 0xc0], eax - -loc_fffa1350: -movsx eax, byte [esi] -test al, al -je short loc_fffa136b ; je 0xfffa136b -lea edx, [eax - 0x30] -cmp dl, 9 -ja short loc_fffa136b ; ja 0xfffa136b -cmp dword [ebp - 0xc0], 0x1f3 -jle short loc_fffa133e ; jle 0xfffa133e - -loc_fffa136b: -cmp dword [ebp - 0xc0], 0x1f4 -jg loc_fffa12a0 ; jg 0xfffa12a0 -cmp byte [esi], 0x2e -mov dword [ebp - 0xbc], 0xffffffff -jne short loc_fffa13fa ; jne 0xfffa13fa -cmp byte [esi + 1], 0x2a -lea eax, [esi + 1] -mov dword [ebp - 0xbc], 0 -jne short loc_fffa13cd ; jne 0xfffa13cd -lea eax, [edi + 4] -mov edi, dword [edi] -cmp edi, 0x1f4 -mov dword [ebp - 0xbc], edi -jg loc_fffa12a0 ; jg 0xfffa12a0 -add esi, 2 -mov edi, eax -jmp short loc_fffa13fa ; jmp 0xfffa13fa - -loc_fffa13bb: -imul esi, dword [ebp - 0xbc], 0xa -inc eax -lea edx, [esi + edx - 0x30] -mov dword [ebp - 0xbc], edx - -loc_fffa13cd: -movsx edx, byte [eax] -test dl, dl -je short loc_fffa13e8 ; je 0xfffa13e8 -lea ecx, [edx - 0x30] -cmp cl, 9 -ja short loc_fffa13e8 ; ja 0xfffa13e8 -cmp dword [ebp - 0xbc], 0x1f3 -jle short loc_fffa13bb ; jle 0xfffa13bb - -loc_fffa13e8: -cmp dword [ebp - 0xbc], 0x1f4 -jg loc_fffa12a0 ; jg 0xfffa12a0 -mov esi, eax - -loc_fffa13fa: -xor ebx, ebx -cmp byte [esi], 0x3a -jne short loc_fffa144d ; jne 0xfffa144d -cmp byte [esi + 1], 0x2a -lea eax, [esi + 1] -jne short loc_fffa142e ; jne 0xfffa142e -mov ebx, dword [edi] -lea eax, [edi + 4] -test ebx, ebx -js short loc_fffa141d ; js 0xfffa141d -cmp ebx, 0x24 -jle short loc_fffa141f ; jle 0xfffa141f -jmp near loc_fffa12a0 ; jmp 0xfffa12a0 - -loc_fffa141d: -xor ebx, ebx - -loc_fffa141f: -add esi, 2 -mov edi, eax -jmp short loc_fffa144d ; jmp 0xfffa144d - -loc_fffa1426: -imul ebx, ebx, 0xa -inc eax -lea ebx, [ebx + edx - 0x30] - -loc_fffa142e: -movsx edx, byte [eax] -test dl, dl -je short loc_fffa1442 ; je 0xfffa1442 -lea ecx, [edx - 0x30] -cmp cl, 9 -ja short loc_fffa1442 ; ja 0xfffa1442 -cmp ebx, 0x23 -jle short loc_fffa1426 ; jle 0xfffa1426 - -loc_fffa1442: -cmp ebx, 0x24 -jg loc_fffa12a0 ; jg 0xfffa12a0 -mov esi, eax - -loc_fffa144d: -cmp byte [esi], 0x5b -mov dword [ebp - 0xc4], 0 -jne short loc_fffa1489 ; jne 0xfffa1489 -lea ecx, [esi + 1] -not esi -mov dword [ebp - 0xdc], ecx -mov eax, ecx - -loc_fffa1469: -lea edx, [esi + eax] -mov dword [ebp - 0xc4], edx -mov dl, byte [eax] -mov ecx, eax -test dl, dl -je loc_fffa12a0 ; je 0xfffa12a0 -inc eax -cmp dl, 0x5d -jne short loc_fffa1469 ; jne 0xfffa1469 -jmp near loc_fffa1ce9 ; jmp 0xfffa1ce9 - -loc_fffa1489: -mov dl, byte [esi] -test dl, dl -je short loc_fffa14ba ; je 0xfffa14ba -jmp short loc_fffa1498 ; jmp 0xfffa1498 - -loc_fffa1491: -test al, al -je short loc_fffa14b4 ; je 0xfffa14b4 -inc ecx -jmp short loc_fffa149d ; jmp 0xfffa149d - -loc_fffa1498: -mov ecx, ref_fffcc45c ; mov ecx, 0xfffcc45c - -loc_fffa149d: -mov al, byte [ecx] -cmp al, dl -jne short loc_fffa1491 ; jne 0xfffa1491 -jmp near loc_fffa1cf1 ; jmp 0xfffa1cf1 - -loc_fffa14a8: -cmp al, dl -jne short loc_fffa14b8 ; jne 0xfffa14b8 -or edx, 1 -add esi, 2 -jmp short loc_fffa14ba ; jmp 0xfffa14ba - -loc_fffa14b4: -xor edx, edx -jmp short loc_fffa14ba ; jmp 0xfffa14ba - -loc_fffa14b8: -mov esi, ecx - -loc_fffa14ba: -mov al, byte [esi] -test al, al -jne short loc_fffa14ca ; jne 0xfffa14ca -mov eax, dword [edi] -add edi, 4 -jmp near loc_fffa1cbd ; jmp 0xfffa1cbd - -loc_fffa14ca: -cmp al, 0x43 -mov byte [ebp - 0xb8], 0 -jne short loc_fffa14f5 ; jne 0xfffa14f5 -lea ecx, [esi + 1] -mov dword [ebp - 0xb4], ecx -mov cl, byte [esi + 1] -test cl, cl -mov byte [ebp - 0xb8], cl -je loc_fffa12a0 ; je 0xfffa12a0 -mov esi, dword [ebp - 0xb4] - -loc_fffa14f5: -cmp al, 0x6e -mov byte [ebp - 0xa8], al -jne short loc_fffa155b ; jne 0xfffa155b -mov eax, dword [edi] -test eax, eax -je loc_fffa1d11 ; je 0xfffa1d11 -cmp dl, 0x68 -jne short loc_fffa151c ; jne 0xfffa151c -mov edx, dword [ebp - 0xcc] -mov word [eax], dx -jmp near loc_fffa1d11 ; jmp 0xfffa1d11 - -loc_fffa151c: -cmp dl, 0x69 -jne short loc_fffa152e ; jne 0xfffa152e -mov cl, byte [ebp - 0xcc] -mov byte [eax], cl -jmp near loc_fffa1d11 ; jmp 0xfffa1d11 - -loc_fffa152e: -cmp dl, 0x6c -jne short loc_fffa1535 ; jne 0xfffa1535 -jmp short loc_fffa154e ; jmp 0xfffa154e - -loc_fffa1535: -cmp dl, 0x6a -jne short loc_fffa154e ; jne 0xfffa154e -mov ecx, dword [ebp - 0xcc] -mov dword [eax + 4], 0 -mov dword [eax], ecx -jmp near loc_fffa1d11 ; jmp 0xfffa1d11 - -loc_fffa154e: -mov edx, dword [ebp - 0xcc] -mov dword [eax], edx -jmp near loc_fffa1d11 ; jmp 0xfffa1d11 - -loc_fffa155b: -cmp al, 0x25 -jne short loc_fffa158a ; jne 0xfffa158a -sub esp, 0xc -lea eax, [ebp - 0xa8] -push 0 -xor ecx, ecx -xor edx, edx -push 1 -push eax -lea eax, [ebp - 0xa0] -push 0 -push 0 -call fcn_fffc19d8 ; call 0xfffc19d8 -mov ebx, eax -add esp, 0x20 -jmp near loc_fffa1cac ; jmp 0xfffa1cac - -loc_fffa158a: -mov cl, al -and ecx, 0xffffffdf -cmp cl, 0x43 -jne short loc_fffa160f ; jne 0xfffa160f -cmp al, 0x63 -jne short loc_fffa15a5 ; jne 0xfffa15a5 -mov eax, dword [edi] -add edi, 4 -mov byte [ebp - 0xa7], al -jmp short loc_fffa15b1 ; jmp 0xfffa15b1 - -loc_fffa15a5: -mov al, byte [ebp - 0xb8] -mov byte [ebp - 0xa7], al - -loc_fffa15b1: -mov eax, 1 -cmp dword [ebp - 0xbc], 0 -mov edx, dword [ebp - 0xbc] -cmovs edx, eax -test edx, edx -cmovg eax, edx -xor ebx, ebx -mov dword [ebp - 0xb0], eax - -loc_fffa15d3: -sub esp, 0xc -lea ecx, [ebp - 0xa7] -push 0 -xor edx, edx -lea eax, [ebp - 0xa0] -push 1 -push ecx -xor ecx, ecx -push 0 -push 0 -call fcn_fffc19d8 ; call 0xfffc19d8 -add esp, 0x20 -cmp eax, 0xffffffffffffffff -je loc_fffa12a0 ; je 0xfffa12a0 -add ebx, eax -dec dword [ebp - 0xb0] -jne short loc_fffa15d3 ; jne 0xfffa15d3 -jmp near loc_fffa1cac ; jmp 0xfffa1cac - -loc_fffa160f: -cmp al, 0x73 -jne loc_fffa16ad ; jne 0xfffa16ad -mov ecx, dword [edi] -lea eax, [edi + 4] -test ecx, ecx -mov dword [ebp - 0xb4], eax -mov eax, ref_fffcc463 ; mov eax, 0xfffcc463 -cmove ecx, eax -mov ebx, ecx -jmp short loc_fffa1631 ; jmp 0xfffa1631 - -loc_fffa1630: -inc ebx - -loc_fffa1631: -cmp byte [ebx], 0 -jne short loc_fffa1630 ; jne 0xfffa1630 -sub ebx, ecx -cmp dword [ebp - 0xbc], 0 -js short loc_fffa164e ; js 0xfffa164e -cmp ebx, dword [ebp - 0xbc] -cmovg ebx, dword [ebp - 0xbc] - -loc_fffa164e: -mov edx, dword [ebp - 0xc0] -xor eax, eax -sub edx, ebx -cmp ebx, dword [ebp - 0xc0] -cmovl eax, edx -mov edx, dword [ebp - 0xb0] -xor edi, edi -and edx, 4 -je short loc_fffa1672 ; je 0xfffa1672 -mov edi, eax -xor eax, eax - -loc_fffa1672: -test byte [ebp - 0xb0], 0x40 -je short loc_fffa169c ; je 0xfffa169c -add edi, eax -xor eax, eax -test edx, edx -mov dword [ebp - 0xb0], edi -sete al -add eax, edi -mov edi, 2 -cdq -idiv edi -mov edi, dword [ebp - 0xb0] -sub edi, eax - -loc_fffa169c: -sub esp, 0xc -push edi -push ebx -push ecx -xor ecx, ecx -push 0 -push 0 -jmp near loc_fffa1c94 ; jmp 0xfffa1c94 - -loc_fffa16ad: -cmp al, 0x70 -jne short loc_fffa16d8 ; jne 0xfffa16d8 -mov byte [ebp - 0xa8], 0x58 -xor edx, edx -mov dword [ebp - 0xbc], 8 -mov dword [ebp - 0xc0], 8 -mov dword [ebp - 0xb0], 0x28 - -loc_fffa16d8: -mov al, byte [ebp - 0xa8] -cmp al, 0x69 -mov byte [ebp - 0xb8], al -sete byte [ebp - 0xd0] -cmp al, 0x64 -sete al -or al, byte [ebp - 0xd0] -jne short loc_fffa1705 ; jne 0xfffa1705 -xor ecx, ecx -cmp byte [ebp - 0xb8], 0x49 -jne short loc_fffa172d ; jne 0xfffa172d - -loc_fffa1705: -mov al, byte [ebp - 0xb8] -and dword [ebp - 0xb0], 0xfffffff7 -and eax, 0xffffffdf -or dword [ebp - 0xb0], 0x80 -cmp al, 0x49 -mov ecx, 0xa -jne short loc_fffa172d ; jne 0xfffa172d -test ebx, ebx -cmovne ecx, ebx - -loc_fffa172d: -mov al, byte [ebp - 0xb8] -and eax, 0xffffffdf -cmp al, 0x58 -mov byte [ebp - 0xb4], al -sete byte [ebp - 0xc8] -mov eax, 0x10 -cmp byte [ebp - 0xc8], 0 -cmovne ecx, eax -cmp byte [ebp - 0xb4], 0x55 -jne short loc_fffa1767 ; jne 0xfffa1767 -test ebx, ebx -mov ecx, 0xa -cmovne ecx, ebx - -loc_fffa1767: -cmp byte [ebp - 0xb8], 0x6f -je short loc_fffa1783 ; je 0xfffa1783 -cmp byte [ebp - 0xb8], 0x62 -je short loc_fffa178a ; je 0xfffa178a -cmp ecx, 1 -ja short loc_fffa178f ; ja 0xfffa178f -jmp near loc_fffa12a0 ; jmp 0xfffa12a0 - -loc_fffa1783: -mov ecx, 8 -jmp short loc_fffa178f ; jmp 0xfffa178f - -loc_fffa178a: -mov ecx, 2 - -loc_fffa178f: -test byte [ebp - 0xb0], 0x80 -je loc_fffa184b ; je 0xfffa184b -cmp dl, 0x6c -jne short loc_fffa17ac ; jne 0xfffa17ac -lea edx, [edi + 4] -mov dword [ebp - 0xb4], edx -jmp short loc_fffa17ba ; jmp 0xfffa17ba - -loc_fffa17ac: -cmp dl, 0x6a -jne short loc_fffa17be ; jne 0xfffa17be -lea eax, [edi + 8] - -loc_fffa17b4: -mov dword [ebp - 0xb4], eax - -loc_fffa17ba: -mov ebx, dword [edi] -jmp short loc_fffa17ea ; jmp 0xfffa17ea - -loc_fffa17be: -cmp dl, 0x7a -lea eax, [edi + 4] -jne short loc_fffa17c8 ; jne 0xfffa17c8 -jmp short loc_fffa17b4 ; jmp 0xfffa17b4 - -loc_fffa17c8: -cmp dl, 0x74 -mov dword [ebp - 0xb4], eax -mov ebx, dword [edi] -jne short loc_fffa17d7 ; jne 0xfffa17d7 -jmp short loc_fffa17ea ; jmp 0xfffa17ea - -loc_fffa17d7: -cmp dl, 0x68 -jne short loc_fffa17e1 ; jne 0xfffa17e1 -movsx ebx, bx -jmp short loc_fffa17ea ; jmp 0xfffa17ea - -loc_fffa17e1: -movsx eax, bl -cmp dl, 0x69 -cmove ebx, eax - -loc_fffa17ea: -mov eax, ebx -cdq -mov eax, edx -xor eax, ebx -sub eax, edx -test ebx, ebx -jns short loc_fffa1800 ; jns 0xfffa1800 -mov byte [ebp - 0xa6], 0x2d -jmp short loc_fffa1825 ; jmp 0xfffa1825 - -loc_fffa1800: -test byte [ebp - 0xb0], 2 -je short loc_fffa1812 ; je 0xfffa1812 -mov byte [ebp - 0xa6], 0x2b -jmp short loc_fffa1825 ; jmp 0xfffa1825 - -loc_fffa1812: -test byte [ebp - 0xb0], 1 -setne dl -shl edx, 5 -mov byte [ebp - 0xa6], dl - -loc_fffa1825: -cmp byte [ebp - 0xa6], 0 -mov dword [ebp - 0xd4], 0 -je short loc_fffa18ac ; je 0xfffa18ac -or dword [ebp - 0xb0], 8 -mov dword [ebp - 0xd4], 1 -jmp short loc_fffa18ac ; jmp 0xfffa18ac - -loc_fffa184b: -cmp dl, 0x6c -jne short loc_fffa185b ; jne 0xfffa185b -lea edx, [edi + 4] -mov dword [ebp - 0xb4], edx -jmp short loc_fffa1869 ; jmp 0xfffa1869 - -loc_fffa185b: -cmp dl, 0x6a -jne short loc_fffa186d ; jne 0xfffa186d -lea eax, [edi + 8] - -loc_fffa1863: -mov dword [ebp - 0xb4], eax - -loc_fffa1869: -mov eax, dword [edi] -jmp short loc_fffa189b ; jmp 0xfffa189b - -loc_fffa186d: -cmp dl, 0x7a -lea eax, [edi + 4] -jne short loc_fffa1877 ; jne 0xfffa1877 -jmp short loc_fffa1863 ; jmp 0xfffa1863 - -loc_fffa1877: -cmp dl, 0x74 -mov dword [ebp - 0xb4], eax -mov eax, dword [edi] -jne short loc_fffa1886 ; jne 0xfffa1886 -jmp short loc_fffa189b ; jmp 0xfffa189b - -loc_fffa1886: -cmp dl, 0x68 -jne short loc_fffa1892 ; jne 0xfffa1892 -and eax, 0xffff -jmp short loc_fffa189b ; jmp 0xfffa189b - -loc_fffa1892: -movzx ebx, al -cmp dl, 0x69 -cmove eax, ebx - -loc_fffa189b: -mov byte [ebp - 0xa6], 0x30 -mov dword [ebp - 0xd4], 0 - -loc_fffa18ac: -test eax, eax -setne dl -cmp byte [ebp - 0xb8], 0x6f -sete bl -test dl, bl -mov ebx, 1 -cmove ebx, dword [ebp - 0xd4] -cmp byte [ebp - 0xc8], 0 -mov dword [ebp - 0xd4], ebx -jne short loc_fffa18e1 ; jne 0xfffa18e1 -cmp byte [ebp - 0xb8], 0x62 -jne short loc_fffa1913 ; jne 0xfffa1913 - -loc_fffa18e1: -mov ebx, dword [ebp - 0xb0] -and ebx, 0x20 -jne short loc_fffa18f0 ; jne 0xfffa18f0 -test dl, dl -je short loc_fffa1913 ; je 0xfffa1913 - -loc_fffa18f0: -mov dl, byte [ebp - 0xb8] -test ebx, ebx -mov byte [ebp - 0xa5], dl -je short loc_fffa1909 ; je 0xfffa1909 -or edx, 0x20 -mov byte [ebp - 0xa5], dl - -loc_fffa1909: -mov dword [ebp - 0xd4], 2 - -loc_fffa1913: -test byte [ebp - 0xb0], 8 -je short loc_fffa192a ; je 0xfffa192a -lea edx, [ebp - 0xa6] -mov dword [ebp - 0xe4], edx -jmp short loc_fffa193e ; jmp 0xfffa193e - -loc_fffa192a: -mov dword [ebp - 0xe4], 0 -mov dword [ebp - 0xd4], 0 - -loc_fffa193e: -cmp ecx, 0xa -jne short loc_fffa1967 ; jne 0xfffa1967 -jmp short loc_fffa1957 ; jmp 0xfffa1957 - -loc_fffa1945: -xor edx, edx -inc edi -div ecx -mov ebx, edi -neg ebx -add edx, 0x30 -mov byte [ebx + ebp - 0x18], dl -jmp short loc_fffa195e ; jmp 0xfffa195e - -loc_fffa1957: -xor edi, edi -mov ecx, 0xa - -loc_fffa195e: -test eax, eax -jne short loc_fffa1945 ; jne 0xfffa1945 -jmp near loc_fffa1a29 ; jmp 0xfffa1a29 - -loc_fffa1967: -cmp byte [ebp - 0xb8], 0x75 -sete byte [ebp - 0xc8] -cmp ecx, 8 -sete bl -cmp ecx, 2 -sete dl -or dl, bl -jne short loc_fffa19a2 ; jne 0xfffa19a2 -xor edi, edi -mov dl, byte [ebp - 0xc8] -or edx, dword [ebp - 0xd0] -cmp ecx, 0x10 -mov byte [ebp - 0xd8], dl -jne loc_fffa1a25 ; jne 0xfffa1a25 - -loc_fffa19a2: -cmp ecx, 0x10 -lea edx, [ecx - 1] -mov dword [ebp - 0xd8], edx -je short loc_fffa19bd ; je 0xfffa19bd -cmp bl, 1 -sbb ecx, ecx -and ecx, 0xfffffffe -add ecx, 3 -jmp short loc_fffa19c2 ; jmp 0xfffa19c2 - -loc_fffa19bd: -mov ecx, 4 - -loc_fffa19c2: -xor edi, edi -jmp short loc_fffa19fd ; jmp 0xfffa19fd - -loc_fffa19c6: -mov ebx, dword [ebp - 0xd8] -and ebx, eax -cmp byte [ebp - 0xb8], 0x78 -mov dl, byte [ebx + ref_fffc9ec4] ; mov dl, byte [ebx - 0x3613c] -sete bl -or bl, byte [ebp - 0xd0] -jne short loc_fffa19ef ; jne 0xfffa19ef -cmp byte [ebp - 0xc8], 0 -je short loc_fffa19f2 ; je 0xfffa19f2 - -loc_fffa19ef: -or edx, 0x20 - -loc_fffa19f2: -shr eax, cl -inc edi -mov ebx, edi -neg ebx -mov byte [ebx + ebp - 0x18], dl - -loc_fffa19fd: -test eax, eax -jne short loc_fffa19c6 ; jne 0xfffa19c6 -jmp short loc_fffa1a29 ; jmp 0xfffa1a29 - -loc_fffa1a03: -xor edx, edx -div ecx -mov dl, byte [edx + ref_fffc9ec4] ; mov dl, byte [edx - 0x3613c] -mov bl, dl -or ebx, 0x20 -cmp byte [ebp - 0xd8], 0 -cmovne edx, ebx -inc edi -mov ebx, edi -neg ebx -mov byte [ebx + ebp - 0x18], dl - -loc_fffa1a25: -test eax, eax -jne short loc_fffa1a03 ; jne 0xfffa1a03 - -loc_fffa1a29: -cmp dword [ebp - 0xc4], 0 -mov dword [ebp - 0xd8], 0 -je loc_fffa1bdf ; je 0xfffa1bdf -mov eax, dword [ebp - 0xdc] -mov ecx, dword [ebp - 0xc4] -mov dword [ebp - 0xd0], 0x82 -mov dword [ebp - 0xc8], edi -sub dword [ebp - 0xd0], edi -xor ebx, ebx -mov byte [ebp - 0xe5], 0 -lea ecx, [eax + ecx - 1] -mov dword [ebp - 0xb8], ecx -jmp near loc_fffa1bca ; jmp 0xfffa1bca - -loc_fffa1a7a: -cmp dword [ebp - 0xc4], 0 -je loc_fffa1d04 ; je 0xfffa1d04 -mov edx, dword [ebp - 0xb8] -mov al, byte [edx] -cmp al, 0x2d -je loc_fffa1bdf ; je 0xfffa1bdf -cmp al, 0x2a -jne short loc_fffa1af1 ; jne 0xfffa1af1 -mov eax, dword [ebp - 0xb4] -mov ecx, dword [ebp - 0xb4] -add ecx, 4 -mov ebx, dword [eax] -test ebx, ebx -js loc_fffa1bd9 ; js 0xfffa1bd9 -mov eax, dword [ebp - 0xc4] -dec edx -dec eax -mov dword [ebp - 0xec], edx -mov dword [ebp - 0xb4], ecx -je loc_fffa1bdf ; je 0xfffa1bdf -jmp short loc_fffa1b35 ; jmp 0xfffa1b35 - -loc_fffa1ad0: -sub ecx, 0x30 -imul ecx, dword [ebp - 0xc4] -imul edx, dword [ebp - 0xc4], 0xa -add ebx, ecx -dec eax -mov dword [ebp - 0xc4], edx -jne short loc_fffa1b11 ; jne 0xfffa1b11 -jmp near loc_fffa1bdf ; jmp 0xfffa1bdf - -loc_fffa1af1: -mov eax, dword [ebp - 0xc4] -mov ecx, dword [ebp - 0xb8] -sub ecx, eax -mov dword [ebp - 0xc4], 1 -xor ebx, ebx -mov dword [ebp - 0xb8], ecx - -loc_fffa1b11: -mov edx, dword [ebp - 0xb8] -add edx, eax -mov dword [ebp - 0xec], edx -mov edx, dword [ebp - 0xb8] -movsx ecx, byte [edx + eax] -test cl, cl -je short loc_fffa1b35 ; je 0xfffa1b35 -lea edx, [ecx - 0x30] -cmp dl, 9 -jbe short loc_fffa1ad0 ; jbe 0xfffa1ad0 - -loc_fffa1b35: -mov ecx, dword [ebp - 0xec] -mov edx, dword [ebp - 0xec] -dec edx -dec eax -test ebx, ebx -mov dword [ebp - 0xb8], edx -mov dword [ebp - 0xc4], eax -mov cl, byte [ecx] -mov byte [ebp - 0xe5], cl -je short loc_fffa1bc1 ; je 0xfffa1bc1 - -loc_fffa1b5b: -cmp dword [ebp - 0xc8], ebx -jle short loc_fffa1bdf ; jle 0xfffa1bdf -mov ecx, dword [ebp - 0xc8] -lea edx, [ebp - 0x9a] -sub ecx, ebx -xor eax, eax -mov dword [ebp - 0xe0], ecx -add edx, dword [ebp - 0xd0] -jmp short loc_fffa1b89 ; jmp 0xfffa1b89 - -loc_fffa1b81: -mov cl, byte [edx + eax] -mov byte [edx + eax - 1], cl -inc eax - -loc_fffa1b89: -cmp eax, dword [ebp - 0xe0] -jne short loc_fffa1b81 ; jne 0xfffa1b81 -dec dword [ebp - 0xd0] -mov edx, dword [ebp - 0xd0] -add edx, dword [ebp - 0xc8] -mov cl, byte [ebp - 0xe5] -sub edx, ebx -inc edi -inc dword [ebp - 0xd8] -mov dword [ebp - 0xc8], eax -mov byte [ebp + edx - 0x9a], cl -jmp short loc_fffa1bca ; jmp 0xfffa1bca - -loc_fffa1bc1: -cmp dword [ebp - 0xc4], 0 -je short loc_fffa1bdf ; je 0xfffa1bdf - -loc_fffa1bca: -cmp dword [ebp - 0xc8], 0 -jne loc_fffa1a7a ; jne 0xfffa1a7a -jmp short loc_fffa1bdf ; jmp 0xfffa1bdf - -loc_fffa1bd9: -mov dword [ebp - 0xb4], ecx - -loc_fffa1bdf: -cmp dword [ebp - 0xbc], 0 -js short loc_fffa1bf1 ; js 0xfffa1bf1 -and dword [ebp - 0xb0], 0xffffffef -jmp short loc_fffa1bfb ; jmp 0xfffa1bfb - -loc_fffa1bf1: -mov dword [ebp - 0xbc], 1 - -loc_fffa1bfb: -mov eax, dword [ebp - 0xbc] -add eax, dword [ebp - 0xd8] -cmp eax, edi -mov ebx, edi -mov edx, dword [ebp - 0xd4] -mov ecx, dword [ebp - 0xc0] -cmovge ebx, eax -xor eax, eax -add edx, ebx -sub ecx, edx -cmp edx, dword [ebp - 0xc0] -mov edx, dword [ebp - 0xb0] -cmovl eax, ecx -xor ecx, ecx -and edx, 4 -je short loc_fffa1c3a ; je 0xfffa1c3a -mov ecx, eax -xor eax, eax - -loc_fffa1c3a: -test byte [ebp - 0xb0], 0x40 -je short loc_fffa1c64 ; je 0xfffa1c64 -add ecx, eax -xor eax, eax -test edx, edx -mov dword [ebp - 0xb8], ecx -sete al -add eax, ecx -mov ecx, 2 -cdq -idiv ecx -mov ecx, dword [ebp - 0xb8] -sub ecx, eax - -loc_fffa1c64: -sub ebx, edi -test byte [ebp - 0xb0], 0x10 -je short loc_fffa1c73 ; je 0xfffa1c73 -add ebx, eax -xor eax, eax - -loc_fffa1c73: -sub esp, 0xc -mov edx, dword [ebp - 0xac] -push ecx -sub edx, edi -mov ecx, dword [ebp - 0xe4] -push edi -add edx, 0x82 -push edx -push ebx -push dword [ebp - 0xd4] - -loc_fffa1c94: -mov edx, eax -lea eax, [ebp - 0xa0] -call fcn_fffc19d8 ; call 0xfffc19d8 -mov ebx, eax -add esp, 0x20 -mov edi, dword [ebp - 0xb4] - -loc_fffa1cac: -test ebx, ebx -js loc_fffa12a0 ; js 0xfffa12a0 - -loc_fffa1cb4: -add dword [ebp - 0xcc], ebx -lea eax, [esi + 1] - -loc_fffa1cbd: -cmp byte [eax], 0 -je short loc_fffa1cc9 ; je 0xfffa1cc9 -mov ebx, eax -jmp near loc_fffa12a9 ; jmp 0xfffa12a9 - -loc_fffa1cc9: -mov eax, dword [ebp - 0xcc] -jmp short loc_fffa1d18 ; jmp 0xfffa1d18 - -loc_fffa1cd1: -sub eax, ref_fffc9e9c ; sub eax, 0xfffc9e9c -inc esi -mov edx, dword [eax*4 + ref_fffc9ea4] ; mov edx, dword [eax*4 - 0x3615c] -or dword [ebp - 0xb0], edx -jmp near loc_fffa12ef ; jmp 0xfffa12ef - -loc_fffa1ce9: -lea esi, [ecx + 1] -jmp near loc_fffa1489 ; jmp 0xfffa1489 - -loc_fffa1cf1: -mov al, byte [esi + 1] -lea ecx, [esi + 1] -test al, al -jne loc_fffa14a8 ; jne 0xfffa14a8 -jmp near loc_fffa14b8 ; jmp 0xfffa14b8 - -loc_fffa1d04: -test ebx, ebx -jne loc_fffa1b5b ; jne 0xfffa1b5b -jmp near loc_fffa1bdf ; jmp 0xfffa1bdf - -loc_fffa1d11: -add edi, 4 -xor ebx, ebx -jmp short loc_fffa1cb4 ; jmp 0xfffa1cb4 - -loc_fffa1d18: -lea esp, [ebp - 0xc] -pop ebx -pop esi -pop edi -pop ebp -ret - fcn_fffa1d20: push ebp mov ebp, esp @@ -3478,7 +2472,7 @@ mov dword [ebp - 0x30], edx push esi push ref_fffcc46a ; push 0xfffcc46a -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov edx, dword [ebp - 0x30] mov ecx, 0x100 lea eax, [edx + 0x40] @@ -3571,7 +2565,7 @@ push 0x35 push ref_fffc9e88 ; push 0xfffc9e88 push ref_fffcc48b ; push 0xfffcc48b -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 loc_fffa297d: @@ -3592,7 +2586,7 @@ push 0x43 push ref_fffc9e88 ; push 0xfffc9e88 push ref_fffcc4ab ; push 0xfffcc4ab -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 loc_fffa29b6: @@ -3679,7 +2673,7 @@ push edx push dword [eax] push ref_fffcc4d1 ; push 0xfffcc4d1 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x30 leave ret @@ -3808,7 +2802,7 @@ push eax push ref_fffc9eec ; push 0xfffc9eec push ref_fffcc505 ; push 0xfffcc505 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov edx, dword [ebp + 0xc] mov eax, dword [edx + 4] call fcn_fffa2a2c ; call 0xfffa2a2c @@ -3831,7 +2825,7 @@ push eax push ref_fffc9eec ; push 0xfffc9eec push ref_fffcc519 ; push 0xfffcc519 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 mov eax, 0x80000009 jmp near loc_fffa2c49 ; jmp 0xfffa2c49 @@ -4504,7 +3498,7 @@ lea eax, [ebp - 0x62c] push ref_fffcc534 ; push 0xfffcc534 mov dword [0xff7d7538], eax -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 cmp dword [ebp - 0x20c], 2 jne short loc_fffa39a6 ; jne 0xfffa39a6 @@ -4514,7 +3508,7 @@ sub esp, 0xc mov dword [ebp - 0x20c], 0x11 push ref_fffcc552 ; push 0xfffcc552 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov eax, dword [ebp - 0x63c] add esp, 0x10 cmp dword [eax + 0x6e], 0 @@ -4564,7 +3558,7 @@ push edx push eax push ref_fffcc574 ; push 0xfffcc574 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 mov eax, 0xfffffffe jmp near loc_fffa56a4 ; jmp 0xfffa56a4 @@ -4634,7 +3628,7 @@ loc_fffa3ab5: sub esp, 0xc push ref_fffcc5c7 ; push 0xfffcc5c7 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov eax, dword [0xf0000060] mov ebx, dword [0xff7d7538] and eax, 0xfc000000 @@ -4880,7 +3874,7 @@ push dword [0xff7d7538] call fcn_fffb9720 ; call 0xfffb9720 mov dword [esp], ref_fffcc5e7 ; mov dword [esp], 0xfffcc5e7 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov eax, 0x10f mov esi, dword [0xff7d7538] call fcn_fffa2937 ; call 0xfffa2937 @@ -4930,12 +3924,12 @@ loc_fffa3def: sub esp, 0xc push ref_fffcc60f ; push 0xfffcc60f -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 pop ebx push dword [0xff7d7538] call fcn_fffaea18 ; call 0xfffaea18 mov dword [esp], ref_fffcc635 ; mov dword [esp], 0xfffcc635 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov edx, dword [0xff7d7538] mov dword [ebp - 0x640], edx call fcn_fffc908a ; call 0xfffc908a @@ -6409,7 +5403,7 @@ push ecx call dword [eax + 0x18] ; ucall mov dword [esp], ref_fffcc65f ; mov dword [esp], 0xfffcc65f -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov eax, dword [0xff7d7538] pop edx pop ecx @@ -6418,7 +5412,7 @@ push eax call dword [edx + 0x18] ; ucall mov dword [esp], ref_fffcc688 ; mov dword [esp], 0xfffcc688 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov eax, dword [0xff7d7538] call fcn_fffc1b54 ; call 0xfffc1b54 mov edx, 0xfffe @@ -6431,7 +5425,7 @@ je short loc_fffa555d ; je 0xfffa555d sub esp, 0xc push ref_fffcc6ab ; push 0xfffcc6ab -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 loc_fffa555d: @@ -6450,7 +5444,7 @@ loc_fffa5585: sub esp, 0xc push ref_fffcc6dd ; push 0xfffcc6dd -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 xor eax, eax jmp near loc_fffa56a4 ; jmp 0xfffa56a4 @@ -43353,7 +42347,7 @@ loc_fffc1940: sub esp, 0xc push ref_fffcc6f2 ; push 0xfffcc6f2 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 loc_fffc1950: @@ -43371,7 +42365,7 @@ shl ebx, 2 push ebx push ref_fffcc725 ; push 0xfffcc725 -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 add esp, 0x10 test esi, esi je short loc_fffc1940 ; je 0xfffc1940 @@ -43379,7 +42373,7 @@ loc_fffc197a: sub esp, 0xc push ref_fffcc70e ; push 0xfffcc70e -call fcn_fffa1253 ; call 0xfffa1253 +call mrc_printk ; call 0xfffa1253 mov eax, 8 call fcn_fffa2937 ; call 0xfffa2937 lea esp, [ebp - 0xc] @@ -43390,171 +42384,6 @@ pop ebp ret -fcn_fffc199b: -push ebp -mov ebp, esp -push edi -mov edi, ecx -push esi -lea esi, [eax + edx] -push ebx -mov ebx, eax -lea esp, [esp - 0xc] -jmp short loc_fffc19c4 ; jmp 0xfffc19c4 - -loc_fffc19ae: -movzx edx, byte [ebx] -mov eax, dword [0xff7d753c] -inc ebx -test eax, eax -je short loc_fffc19c4 ; je 0xfffc19c4 -sub esp, 0xc -push edx -call eax ; ucall -add esp, 0x10 - -loc_fffc19c4: -cmp ebx, esi -jne short loc_fffc19ae ; jne 0xfffc19ae -mov dword [edi], 0xffffffff -lea esp, [ebp - 0xc] -pop ebx -xor eax, eax -pop esi -pop edi -pop ebp -ret - -fcn_fffc19d8: -push ebp -mov ebp, esp -push edi -push esi -mov esi, edx -push ebx -mov ebx, edx -lea esp, [esp - 0x1c] -test edx, edx -mov dword [ebp - 0x1c], eax -mov dword [ebp - 0x20], ecx -jne short loc_fffc1a2c ; jne 0xfffc1a2c - -loc_fffc19f0: -cmp dword [ebp + 8], 0 -setne dl -cmp dword [ebp - 0x20], 0 -setne al -test dl, al -je short loc_fffc1a47 ; je 0xfffc1a47 -jmp short loc_fffc1a32 ; jmp 0xfffc1a32 - -loc_fffc1a04: -cmp esi, 0x10 -mov edi, 0x10 -mov ecx, dword [ebp - 0x1c] -mov eax, ref_fffcbec0 ; mov eax, 0xfffcbec0 -cmovle edi, esi -mov edx, edi -call fcn_fffc199b ; call 0xfffc199b -test eax, eax -jns short loc_fffc1a2a ; jns 0xfffc1a2a - -loc_fffc1a22: -or eax, 0xffffffff -jmp near loc_fffc1ad9 ; jmp 0xfffc1ad9 - -loc_fffc1a2a: -sub esi, edi - -loc_fffc1a2c: -test esi, esi -jg short loc_fffc1a04 ; jg 0xfffc1a04 -jmp short loc_fffc19f0 ; jmp 0xfffc19f0 - -loc_fffc1a32: -mov ecx, dword [ebp - 0x1c] -mov edx, dword [ebp + 8] -mov eax, dword [ebp - 0x20] -call fcn_fffc199b ; call 0xfffc199b -test eax, eax -js short loc_fffc1a22 ; js 0xfffc1a22 -add ebx, dword [ebp + 8] - -loc_fffc1a47: -cmp dword [ebp + 0xc], 0 -je short loc_fffc1a52 ; je 0xfffc1a52 -mov esi, dword [ebp + 0xc] -jmp short loc_fffc1a7d ; jmp 0xfffc1a7d - -loc_fffc1a52: -add ebx, dword [ebp + 0xc] -cmp dword [ebp + 0x14], 0 -je short loc_fffc1a83 ; je 0xfffc1a83 -jmp short loc_fffc1a91 ; jmp 0xfffc1a91 - -loc_fffc1a5d: -cmp esi, 0x10 -mov edi, 0x10 -mov ecx, dword [ebp - 0x1c] -mov eax, ref_fffcbed4 ; mov eax, 0xfffcbed4 -cmovle edi, esi -mov edx, edi -call fcn_fffc199b ; call 0xfffc199b -test eax, eax -js short loc_fffc1a22 ; js 0xfffc1a22 -sub esi, edi - -loc_fffc1a7d: -test esi, esi -jg short loc_fffc1a5d ; jg 0xfffc1a5d -jmp short loc_fffc1a52 ; jmp 0xfffc1a52 - -loc_fffc1a83: -add ebx, dword [ebp + 0x14] -cmp dword [ebp + 0x18], 0 -je short loc_fffc1aa8 ; je 0xfffc1aa8 -mov esi, dword [ebp + 0x18] -jmp short loc_fffc1ad3 ; jmp 0xfffc1ad3 - -loc_fffc1a91: -mov ecx, dword [ebp - 0x1c] -mov edx, dword [ebp + 0x14] -mov eax, dword [ebp + 0x10] -call fcn_fffc199b ; call 0xfffc199b -test eax, eax -jns short loc_fffc1a83 ; jns 0xfffc1a83 -jmp near loc_fffc1a22 ; jmp 0xfffc1a22 - -loc_fffc1aa8: -mov eax, dword [ebp + 0x18] -add eax, ebx -jmp short loc_fffc1ad9 ; jmp 0xfffc1ad9 - -loc_fffc1aaf: -cmp esi, 0x10 -mov edi, 0x10 -mov ecx, dword [ebp - 0x1c] -mov eax, ref_fffcbec0 ; mov eax, 0xfffcbec0 -cmovle edi, esi -mov edx, edi -call fcn_fffc199b ; call 0xfffc199b -test eax, eax -js loc_fffc1a22 ; js 0xfffc1a22 -sub esi, edi - -loc_fffc1ad3: -test esi, esi -jg short loc_fffc1aaf ; jg 0xfffc1aaf -jmp short loc_fffc1aa8 ; jmp 0xfffc1aa8 - -loc_fffc1ad9: -lea esp, [esp + 0x1c] -pop ebx -pop esi -pop edi -pop ebp -ret - fcn_fffc1ae2: push ebp mov ebp, esp @@ -54867,22 +53696,6 @@ ref_fffc9e88: db 'GlueAllocatePool',0x00,0x00,0x00,0x00 -ref_fffc9e9c: -db ' +-#0!^',0x00 - -ref_fffc9ea4: -dd 0x00000001 -dd 0x00000002 -dd 0x00000004 -dd 0x00000008 -dd 0x00000010 -dd 0x00000020 -dd 0x00000040 -dd 0x00000000 - -ref_fffc9ec4: -db '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ',0x00,0x00,0x00,0x00 - ref_fffc9eec: db 'install_ppi',0x00 @@ -57068,12 +55881,6 @@ dd 0x00010001 dd 0x00350049 -ref_fffcbec0: -db ' ',0x00,0x00,0x00,0x00 - -ref_fffcbed4: -db '0000000000000000',0x00,0x00,0x00,0x00 - ref_fffcbee8: dd 0x4000f001 dd 0x02005a01 @@ -57482,12 +56289,6 @@ dd loc_fffc8692 dd loc_fffc85f0 -ref_fffcc45c: -db 'hljztL',0x00 - -ref_fffcc463: -db '(null)',0x00 - ref_fffcc46a: db 'Copy SPD for Channel %d Dimm %d',0x0a,0x00 -- To view, visit https://review.coreboot.org/c/coreboot/+/30186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d4667232357e6a74459d946de42cf695a69c162 Gerrit-Change-Number: 30186 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: add mrc.asm
by Iru Cai (Code Review) 12 Dec '18

12 Dec '18

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30185 Change subject: add mrc.asm ...................................................................... add mrc.asm Change-Id: I76ecc2cd734af1c24ce4a923967048b92ebdc9f1 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/northbridge/intel/haswell/Makefile.inc A src/northbridge/intel/haswell/mrc.asm M src/northbridge/intel/haswell/raminit.c 3 files changed, 59,719 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/30185/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76ecc2cd734af1c24ce4a923967048b92ebdc9f1 Gerrit-Change-Number: 30185 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
by Ivy Jian (Code Review) 12 Dec '18

12 Dec '18

Ivy Jian has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30183 ) Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/30183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf731bfefd550e9b94b6404bc870d4d76451deb1 Gerrit-Change-Number: 30183 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
by Ivy Jian (Code Review) 12 Dec '18

12 Dec '18

Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30184 Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD ...................................................................... mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD Add SPD file for sdp micron_dimm_MT40A256M16LY-075F (ram id: 11) BUG=b:120884302 BRANCH=firmware-nami-10775.B TEST=emerge-nami coreboot chromeos-bootimage Change-Id: I6ac023934e455fdc82de611eaea63630eb447a69 Signed-off-by: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> --- A src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex M src/mainboard/google/poppy/variants/nami/Makefile.inc 2 files changed, 33 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/30184/1 diff --git a/src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex b/src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex new file mode 100644 index 0000000..8babded --- /dev/null +++ b/src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 44 19 00 08 00 60 00 03 02 03 00 00 +00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E 20 08 +00 05 70 03 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 D4 35 +0F 01 02 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 C0 E2 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +80 2C 00 00 00 00 00 00 00 34 41 54 46 32 35 36 +36 34 48 5A 2D 32 47 36 46 31 20 20 20 31 80 2C +46 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc index 690b9c8..3175f02 100644 --- a/src/mainboard/google/poppy/variants/nami/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc @@ -12,7 +12,7 @@ SPD_SOURCES += samsung_dimm_K4A8G165WC-BCTD # 0b1000 SPD_SOURCES += samsung_dimm_K4AAG165WB-MCRC # 0b1001 SPD_SOURCES += hynix_dimm_H5ANAG6NAFR-UHC # 0b1010 -SPD_SOURCES += empty_ddr4 # 0b1011 +SPD_SOURCES += micron_dimm_MT40A256M16LY-075F # 0b1011 SPD_SOURCES += empty_ddr4 # 0b1100 SPD_SOURCES += micron_dimm_MT40A1G16KNR-075E # 0b1101 SPD_SOURCES += micron_dimm_MT40A512M16LY-075E # 0b1110 -- To view, visit https://review.coreboot.org/c/coreboot/+/30184 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ac023934e455fdc82de611eaea63630eb447a69 Gerrit-Change-Number: 30184 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD
by build bot (Jenkins) (Code Review) 12 Dec '18

12 Dec '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30183 ) Change subject: mb/google/poppy/variants/nami: Add micron_dimm_MT40A256M16LY-075F SPD ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30183/1/src/mainboard/google/poppy/spd/micr… File src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16LY-075F.spd.hex: https://review.coreboot.org/#/c/30183/1/src/mainboard/google/poppy/spd/micr… PS1, Line 2: 00 00 06 0D F8 FF 01 00 6E 6E 6E 11 00 6E 20 08 trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/30183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf731bfefd550e9b94b6404bc870d4d76451deb1 Gerrit-Change-Number: 30183 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 12 Dec 2018 09:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018