coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support
by Patrick Rudolph (Code Review) 17 Nov '18

17 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29662 ) Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support ...................................................................... Patch Set 2: (2 comments) I don't see where C_ENVIRONMENT_BOOTBLOCK is selected. Is it part of another commit ? https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/include/soc/… File src/soc/intel/braswell/include/soc/bootblock.h: https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/include/soc/… PS2, Line 18: obsolete file. should be removed. https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car… File src/soc/intel/braswell/romstage/car_stage.S: https://review.coreboot.org/#/c/29662/2/src/soc/intel/braswell/romstage/car… PS2, Line 23: call romstage_c_entry please replace romstage_c_entry with car_stage_entry of all affected mainboards and get rid of this file -- To view, visit https://review.coreboot.org/29662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab48ad72f1514c93f20d70db5ef4fd8fa2383e8c Gerrit-Change-Number: 29662 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 17 Nov 2018 08:19:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Patrick Georgi (Code Review) 17 Nov '18

17 Nov '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28953 ) Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py File util/ipqheader/mbn_tools.py: https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py@1 PS1, Line 1: #!/usr/bin/env python > This was not addressed, but the patch was merged anyway. […] oops, sorry - I missed this. can you put up a commit to fix this? -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 2 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Nov 2018 07:58:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Angel Pons (Code Review) 17 Nov '18

17 Nov '18

Angel Pons has posted comments on this change. ( https://review.coreboot.org/28953 ) Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py File util/ipqheader/mbn_tools.py: https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py@1 PS1, Line 1: #!/usr/bin/env python > Yes, it definitely was. Thanks. This was not addressed, but the patch was merged anyway. (!) -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 2 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Nov 2018 07:44:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Patrick Georgi (Code Review) 17 Nov '18

17 Nov '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28953 ) Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... treewide: use /usr/bin/env where appropriate Some Unix systems (GuixSD, NixOS) do not install programs like Bash and Python to /usr/bin, and /usr/bin/env has to be used to locate these instead. Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Signed-off-by: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Reviewed-on: https://review.coreboot.org/28953 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/acpi/acpidump-all M util/amdtools/k8-compare-pci-space.pl M util/amdtools/k8-interpret-extended-memory-settings.pl M util/amdtools/k8-read-mem-settings.sh M util/amdtools/parse-bkdg.pl M util/board_status/set_up_live_image.sh M util/broadcom/secimage/test/hmac.sh M util/cavium/devicetree_convert.py M util/cbfstool/Makefile M util/cbmem/Makefile M util/chromeos/crosfirmware.sh M util/chromeos/extract_blobs.sh M util/ectool/Makefile M util/genprof/log2dress M util/gitconfig/gitconfig.sh M util/ifdtool/Makefile M util/intelmetool/Makefile M util/inteltool/Makefile M util/ipqheader/createxbl.py M util/ipqheader/mbn_tools.py M util/k8resdump/Makefile M util/kconfig/miniconfig M util/lint/check_lint_tests M util/lint/checkpatch_json.py M util/lint/kconfig_lint M util/me_cleaner/me_cleaner.py M util/me_cleaner/setup.py M util/mma/mma_automated_test.sh M util/mma/mma_get_result.sh M util/mma/mma_setup_test.sh M util/nvramtool/Makefile M util/pmh7tool/Makefile M util/release/build-release M util/release/genrelnotes M util/riscv/sifive-gpt.py M util/scripts/config M util/scripts/dts-to-fmd.sh M util/scripts/gerrit-rebase M util/scripts/get_maintainer.pl M util/scripts/parse-maintainers.pl M util/scripts/prepare-commit-msg.clang-format M util/scripts/ucode_h_to_bin.sh M util/scripts/update_submodules M util/superiotool/Makefile M util/util_readme/util_readme.sh M util/viatool/Makefile 46 files changed, 53 insertions(+), 46 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/util/acpi/acpidump-all b/util/acpi/acpidump-all index 2a04af0..f43b7ef 100755 --- a/util/acpi/acpidump-all +++ b/util/acpi/acpidump-all @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # Copyright (C) 2007-2010 by coresystems GmbH # diff --git a/util/amdtools/k8-compare-pci-space.pl b/util/amdtools/k8-compare-pci-space.pl index 77fdb59..505d5b4 100755 --- a/util/amdtools/k8-compare-pci-space.pl +++ b/util/amdtools/k8-compare-pci-space.pl @@ -1,7 +1,8 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl use Getopt::Long; use strict; +use warnings; my $NAME = $0; my $VERSION = '0.01'; diff --git a/util/amdtools/k8-interpret-extended-memory-settings.pl b/util/amdtools/k8-interpret-extended-memory-settings.pl index 176defc..104e669 100755 --- a/util/amdtools/k8-interpret-extended-memory-settings.pl +++ b/util/amdtools/k8-interpret-extended-memory-settings.pl @@ -1,7 +1,8 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl use Getopt::Long; use strict; +use warnings; my $NAME = $0; my $VERSION = '0.01'; diff --git a/util/amdtools/k8-read-mem-settings.sh b/util/amdtools/k8-read-mem-settings.sh index a0e6254..55b7071 100755 --- a/util/amdtools/k8-read-mem-settings.sh +++ b/util/amdtools/k8-read-mem-settings.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # This is an example that generates data files that are understood by the # k8-interpret-extended-memory-settings.pl script. Adjust the pci ids for your diff --git a/util/amdtools/parse-bkdg.pl b/util/amdtools/parse-bkdg.pl index d0bb4c7..31f3873 100755 --- a/util/amdtools/parse-bkdg.pl +++ b/util/amdtools/parse-bkdg.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl my $NAME = $0; my $VERSION = '0.01'; @@ -11,6 +11,7 @@ my $DEBUG = 0; use strict; +use warnings; # Run the bkdg for k8 through pdftotext first (from the poppler package) diff --git a/util/board_status/set_up_live_image.sh b/util/board_status/set_up_live_image.sh index d80434e..9fac153 100755 --- a/util/board_status/set_up_live_image.sh +++ b/util/board_status/set_up_live_image.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # This script is used to set up a ubuntu-based live image to be used # with coreboot's board_status script. It modifies the system so that diff --git a/util/broadcom/secimage/test/hmac.sh b/util/broadcom/secimage/test/hmac.sh index 21176bd..ded0eb7 100755 --- a/util/broadcom/secimage/test/hmac.sh +++ b/util/broadcom/secimage/test/hmac.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash ## ## This file is part of the coreboot project. diff --git a/util/cavium/devicetree_convert.py b/util/cavium/devicetree_convert.py index 70d89af..656fdf6 100644 --- a/util/cavium/devicetree_convert.py +++ b/util/cavium/devicetree_convert.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # devicetree_convert Tool to convert a DTB to a static C file # Copyright (C) 2018 Facebook Inc. diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index f4dca3f..d7137e9 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -6,7 +6,7 @@ HOSTCC ?= $(CC) PREFIX ?= /usr/local BINDIR ?= $(PREFIX)/bin -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install OBJCOPY ?= objcopy VBOOT_SOURCE ?= $(top)/3rdparty/vboot diff --git a/util/cbmem/Makefile b/util/cbmem/Makefile index 44756de..eed08a4 100644 --- a/util/cbmem/Makefile +++ b/util/cbmem/Makefile @@ -16,7 +16,7 @@ PROGRAM = cbmem ROOT = ../../src CC ?= $(CROSS_COMPILE)gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 CFLAGS += -Wall -Werror diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index 9e00ba6..ba0c259 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. # diff --git a/util/chromeos/extract_blobs.sh b/util/chromeos/extract_blobs.sh index af9d026..a674ada 100755 --- a/util/chromeos/extract_blobs.sh +++ b/util/chromeos/extract_blobs.sh @@ -1,4 +1,4 @@ -#!/bin/bash -x +#!/usr/bin/env bash # # This file is part of the coreboot project. # @@ -14,6 +14,8 @@ # GNU General Public License for more details. # +set -x + IMAGE=$1 if [ ! -r "$IMAGE" ]; then diff --git a/util/ectool/Makefile b/util/ectool/Makefile index 234e931..c4b94da 100644 --- a/util/ectool/Makefile +++ b/util/ectool/Makefile @@ -17,7 +17,7 @@ CC = gcc CFLAGS = -O2 -Wall -W PROGRAM = ectool -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local OS_ARCH = $(shell uname) diff --git a/util/genprof/log2dress b/util/genprof/log2dress index 99d1f2f..a7ec4bf 100755 --- a/util/genprof/log2dress +++ b/util/genprof/log2dress @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash #Parse a log and get back the function names and line numbers #Provide a log file as first argument diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh index 5d6fe36..4df93cf 100755 --- a/util/gitconfig/gitconfig.sh +++ b/util/gitconfig/gitconfig.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash ## ## This file is part of the coreboot project. diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index cf6d378..e1188b2 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -16,7 +16,7 @@ PROGRAM = ifdtool CC = gcc -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -W -Werror -I../../src/commonlib/include LDFLAGS = diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile index d8c056c..128c1fe 100644 --- a/util/intelmetool/Makefile +++ b/util/intelmetool/Makefile @@ -15,7 +15,7 @@ PROGRAM = intelmetool CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O0 -g -Wall -W -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function LDFLAGS += -lpci -lz diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index 96fd140..d88063b 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -20,7 +20,7 @@ top ?= $(abspath ../..) CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -g -Wall -W LDFLAGS += -lpci -lz diff --git a/util/ipqheader/createxbl.py b/util/ipqheader/createxbl.py index b01e628..7f2d987 100755 --- a/util/ipqheader/createxbl.py +++ b/util/ipqheader/createxbl.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python #============================================================================ # #/** @file createxbl.py diff --git a/util/ipqheader/mbn_tools.py b/util/ipqheader/mbn_tools.py index c4d26c1..8a17563 100755 --- a/util/ipqheader/mbn_tools.py +++ b/util/ipqheader/mbn_tools.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python #=============================================================================== # # MBN TOOLS diff --git a/util/k8resdump/Makefile b/util/k8resdump/Makefile index e260351..a1d4dfa 100644 --- a/util/k8resdump/Makefile +++ b/util/k8resdump/Makefile @@ -16,7 +16,7 @@ PROGRAM = k8resdump CC = gcc -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local #CFLAGS = -O2 -g -Wall -Werror CFLAGS = -Os -Wall -Werror diff --git a/util/kconfig/miniconfig b/util/kconfig/miniconfig index 065a784..29a4035 100755 --- a/util/kconfig/miniconfig +++ b/util/kconfig/miniconfig @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # miniconfig - utility to minimize your coreboot config files # diff --git a/util/lint/check_lint_tests b/util/lint/check_lint_tests index 741d245..5ba33c8 100755 --- a/util/lint/check_lint_tests +++ b/util/lint/check_lint_tests @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # test to make sure the lint tests fail SPACE=' ' diff --git a/util/lint/checkpatch_json.py b/util/lint/checkpatch_json.py index 44b2a8b..74ad96a 100755 --- a/util/lint/checkpatch_json.py +++ b/util/lint/checkpatch_json.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # Copyright (C) 2018 Intel Corporation. # written by Naresh G Solanki<naresh.solanki(a)intel.com> and # Maulik V Vaghela <maulik.v.vaghela(a)intel.com> diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 62997dd..eddd8de 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # # This file is part of the coreboot project. diff --git a/util/me_cleaner/me_cleaner.py b/util/me_cleaner/me_cleaner.py index 03fbbcb..f592863 100755 --- a/util/me_cleaner/me_cleaner.py +++ b/util/me_cleaner/me_cleaner.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python # me_cleaner - Tool for partial deblobbing of Intel ME/TXE firmware images # Copyright (C) 2016-2018 Nicola Corna <nicola(a)corna.info> diff --git a/util/me_cleaner/setup.py b/util/me_cleaner/setup.py index 92fd359..c831ef8 100755 --- a/util/me_cleaner/setup.py +++ b/util/me_cleaner/setup.py @@ -1,4 +1,4 @@ -#!/usr/bin/python +#!/usr/bin/env python from setuptools import setup diff --git a/util/mma/mma_automated_test.sh b/util/mma/mma_automated_test.sh index b43325b..1c324f3 100755 --- a/util/mma/mma_automated_test.sh +++ b/util/mma/mma_automated_test.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. diff --git a/util/mma/mma_get_result.sh b/util/mma/mma_get_result.sh index cb30a80..f797e7f 100755 --- a/util/mma/mma_get_result.sh +++ b/util/mma/mma_get_result.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. diff --git a/util/mma/mma_setup_test.sh b/util/mma/mma_setup_test.sh index ec7baf9..b2a0de9 100755 --- a/util/mma/mma_setup_test.sh +++ b/util/mma/mma_setup_test.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. diff --git a/util/nvramtool/Makefile b/util/nvramtool/Makefile index 8da7c76..f5a4fd5 100644 --- a/util/nvramtool/Makefile +++ b/util/nvramtool/Makefile @@ -17,7 +17,7 @@ PROGRAM = nvramtool CC = gcc -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local CFLAGS = -O2 -g -Wall -W -I. -DCMOS_HAL=1 #CFLAGS = -Os -Wall diff --git a/util/pmh7tool/Makefile b/util/pmh7tool/Makefile index 091fbc5..384d3d9 100644 --- a/util/pmh7tool/Makefile +++ b/util/pmh7tool/Makefile @@ -16,7 +16,7 @@ CC = gcc CFLAGS = -O2 -Wall -W -Werror PROGRAM = pmh7tool -INSTALL = /usr/bin/install +INSTALL = /usr/bin/env install PREFIX = /usr/local all: $(PROGRAM) diff --git a/util/release/build-release b/util/release/build-release index a3cec3e..e4330d4 100755 --- a/util/release/build-release +++ b/util/release/build-release @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # ${VERSION_NAME}: new version name # ${COMMIT_ID}: commit id (if not master) # ${USERNAME}: username (if not default to https) diff --git a/util/release/genrelnotes b/util/release/genrelnotes index 3038eb3..42848a1 100755 --- a/util/release/genrelnotes +++ b/util/release/genrelnotes @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. # diff --git a/util/riscv/sifive-gpt.py b/util/riscv/sifive-gpt.py index fd82997..7f522d9 100755 --- a/util/riscv/sifive-gpt.py +++ b/util/riscv/sifive-gpt.py @@ -1,4 +1,4 @@ -#!/usr/bin/python3 +#!/usr/bin/env python3 # This file is part of the coreboot project. # # Copyright (C) 2018 Jonathan Neuschäfer diff --git a/util/scripts/config b/util/scripts/config index e0e3982..ba11e35 100755 --- a/util/scripts/config +++ b/util/scripts/config @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # SPDX-License-Identifier: GPL-2.0 # Manipulate options in a .config file from the command line diff --git a/util/scripts/dts-to-fmd.sh b/util/scripts/dts-to-fmd.sh index 00e718be..b468b35 100755 --- a/util/scripts/dts-to-fmd.sh +++ b/util/scripts/dts-to-fmd.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # Copyright 2015 Google Inc. # diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index c4f8a80..276142d 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # Copyright 2016 Google Inc. # diff --git a/util/scripts/get_maintainer.pl b/util/scripts/get_maintainer.pl index 4f34a4e..c24a6d4 100755 --- a/util/scripts/get_maintainer.pl +++ b/util/scripts/get_maintainer.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl # (c) 2007, Joe Perches <joe(a)perches.com> # created from checkpatch.pl # @@ -11,6 +11,7 @@ # Licensed under the terms of the GNU GPL License version 2 use strict; +use warnings; my $P = $0; my $V = '0.26'; diff --git a/util/scripts/parse-maintainers.pl b/util/scripts/parse-maintainers.pl index a0fe343..c0fd88c 100755 --- a/util/scripts/parse-maintainers.pl +++ b/util/scripts/parse-maintainers.pl @@ -1,6 +1,7 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl use strict; +use warnings; my %map; diff --git a/util/scripts/prepare-commit-msg.clang-format b/util/scripts/prepare-commit-msg.clang-format index 7033f3c..a6b3d08 100755 --- a/util/scripts/prepare-commit-msg.clang-format +++ b/util/scripts/prepare-commit-msg.clang-format @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash files=`git diff --cached --name-only | grep '\.[ch]$'` if [ -z "$files" ]; then exit 0 diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh index 2d7f5fa..f08b053 100755 --- a/util/scripts/ucode_h_to_bin.sh +++ b/util/scripts/ucode_h_to_bin.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # # This file is part of the coreboot project. # diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index b555495..68d8a94 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # This file is part of the coreboot project. # diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index cedd631..3a0bcf0 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -17,7 +17,7 @@ PROGRAM = superiotool CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local # Set the superiotool version string to the output of 'git describe'. diff --git a/util/util_readme/util_readme.sh b/util/util_readme/util_readme.sh index 420ffae..cdd94dc 100755 --- a/util/util_readme/util_readme.sh +++ b/util/util_readme/util_readme.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/usr/bin/env bash # Creates `./util/README.md` and `./Documentation/Util.md` of description files # in `./util` subdirectories diff --git a/util/viatool/Makefile b/util/viatool/Makefile index 365497a..b2a6291 100644 --- a/util/viatool/Makefile +++ b/util/viatool/Makefile @@ -19,7 +19,7 @@ PROGRAM = viatool CC ?= gcc -INSTALL ?= /usr/bin/install +INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local CFLAGS ?= -O2 -g -Wall -W -I$(CURDIR) LDFLAGS += -lpci -lz -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 2 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in coreboot[master]: treewide: use /usr/bin/env where appropriate
by Patrick Georgi (Code Review) 17 Nov '18

17 Nov '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28953 ) Change subject: treewide: use /usr/bin/env where appropriate ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7546bcb881c532adc984577ecb0ee2ec4f2efe00 Gerrit-Change-Number: 28953 Gerrit-PatchSet: 1 Gerrit-Owner: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Yegor Timoshenko <yegortimoshenko(a)riseup.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 17 Nov 2018 07:31:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/sarien: Set SMBIOS mainboard SKU
by Patrick Georgi (Code Review) 17 Nov '18

17 Nov '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/29649 ) Change subject: mb/google/sarien: Set SMBIOS mainboard SKU ...................................................................... mb/google/sarien: Set SMBIOS mainboard SKU Setting sku_id() is not enough to get a value to show up in the SMBIOS tables, it also needs to be returned as a string for the table creation to consume. This change defines the smbios_mainboard_sku() function and returns a string constant of "sku#" as expected. Change-Id: I03013bab89d53d1eba969c6ffb7e95fcbb315a81 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> Reviewed-on: https://review.coreboot.org/29649 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Trent Begin <tbegin(a)google.com> --- M src/mainboard/google/sarien/sku.c M src/mainboard/google/sarien/variants/arcada/include/variant/variant.h M src/mainboard/google/sarien/variants/sarien/include/variant/variant.h 3 files changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Trent Begin: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/sarien/sku.c b/src/mainboard/google/sarien/sku.c index 9fc61a3..c064c02 100644 --- a/src/mainboard/google/sarien/sku.c +++ b/src/mainboard/google/sarien/sku.c @@ -14,9 +14,15 @@ */ #include <boardid.h> +#include <smbios.h> #include <variant/variant.h> uint32_t sku_id(void) { return VARIANT_SKU_ID; } + +const char *smbios_mainboard_sku(void) +{ + return VARIANT_SKU_NAME; +} diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h index f1e551a..d128432 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h @@ -18,5 +18,6 @@ /* Arcada is SKU ID 2 */ #define VARIANT_SKU_ID 2 +#define VARIANT_SKU_NAME "sku2" #endif diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h index d0be7fc..d367505 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h @@ -18,5 +18,6 @@ /* Sarien is SKU ID 1 */ #define VARIANT_SKU_ID 1 +#define VARIANT_SKU_NAME "sku1" #endif -- To view, visit https://review.coreboot.org/29649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I03013bab89d53d1eba969c6ffb7e95fcbb315a81 Gerrit-Change-Number: 29649 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Trent Begin <tbegin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/kahlee/variants/delan: Enable Weida touchscreen device
by Ivy Jian (Code Review) 17 Nov '18

17 Nov '18

Ivy Jian has posted comments on this change. ( https://review.coreboot.org/29656 ) Change subject: mb/google/kahlee/variants/delan: Enable Weida touchscreen device ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29656/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/delan/devicetree.cb: https://review.coreboot.org/#/c/29656/1/src/mainboard/google/kahlee/variant… PS1, Line 179: 130 > this looks pretty long compared to the other touchscreens? That is required from vendor and described in datasheet. refer to : issue https://issuetracker.google.com/issues/111102092#comment8 -- To view, visit https://review.coreboot.org/29656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1484a482de6282c97f3aac329f217bbcb7dbd18 Gerrit-Change-Number: 29656 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Comment-Date: Sat, 17 Nov 2018 02:08:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee/variants/delan: Enable Weida touchscreen device
by Daniel Kurtz (Code Review) 16 Nov '18

16 Nov '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/29656 ) Change subject: mb/google/kahlee/variants/delan: Enable Weida touchscreen device ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29656/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/delan/devicetree.cb: https://review.coreboot.org/#/c/29656/1/src/mainboard/google/kahlee/variant… PS1, Line 179: 130 this looks pretty long compared to the other touchscreens? -- To view, visit https://review.coreboot.org/29656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1484a482de6282c97f3aac329f217bbcb7dbd18 Gerrit-Change-Number: 29656 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Comment-Date: Fri, 16 Nov 2018 23:20:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Split FP MCU Wake and IRQ GPIOS
by Shelley Chen (Code Review) 16 Nov '18

16 Nov '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/29665 Change subject: mb/google/poppy/variants/nami: Split FP MCU Wake and IRQ GPIOS ...................................................................... mb/google/poppy/variants/nami: Split FP MCU Wake and IRQ GPIOS We are seeing problems (interrupt storm) with using the same gpio for FP MCU wake and irq signals. Reverting back to using separate gpios for wake and irq until we resolve the issue. BUG=b:119447525, b:115706071 BRANCH=Nami TEST=Run powerd_dbus_suspend from kernel and make sure see DUT drop into S0ix in the EC console. Also, unlock from lock screen with fingerprint. Change-Id: Id7987f28526256808b8ed49e66f66298f7cdbcee Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nami/gpio.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/29665/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index de00522..49e35b2 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -455,7 +455,7 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_D6_IRQ)" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)" register "wake" = "GPE0_DW1_06" # GPP_D6 device spi 0 on end end # FPMCU diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c index f48033a..1288758 100644 --- a/src/mainboard/google/poppy/variants/nami/gpio.c +++ b/src/mainboard/google/poppy/variants/nami/gpio.c @@ -421,12 +421,14 @@ PAD_CFG_NF(GPP_B22, NONE, DEEP, NF1), /* C3 : SML0CLK ==> TOUCHSCREEN_DIS# */ PAD_CFG_GPO(GPP_C3, 0, DEEP), + /* C8 : UART0_RXD ==> FPMCU_INT_L */ + PAD_CFG_GPI_APIC(GPP_C8, 20K_PU, DEEP), /* C9 : UART0_TXD ==> FP_RST_ODL */ PAD_CFG_GPO(GPP_C9, 1, DEEP), /* D5 : ISH_I2C0_SDA ==> FPMCU_BOOT0 */ PAD_CFG_GPO(GPP_D5, 0, DEEP), /* D6 : ISH_I2C0_SCL ==> FPMCU_INT_L */ - PAD_CFG_GPI_IRQ_WAKE(GPP_D6, 20K_PU, DEEP, LEVEL, INVERT), + PAD_CFG_GPI_ACPI_SCI(GPP_D6, NONE, DEEP, INVERT), /* D17 : DMIC_CLK1 ==> NC */ PAD_CFG_NC(GPP_D17), }; -- To view, visit https://review.coreboot.org/29665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id7987f28526256808b8ed49e66f66298f7cdbcee Gerrit-Change-Number: 29665 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: enable eist
by Matt Delco (Code Review) 16 Nov '18

16 Nov '18

Matt Delco has uploaded this change for review. ( https://review.coreboot.org/29664 Change subject: mb/google/poppy/variants/atlas: enable eist ...................................................................... mb/google/poppy/variants/atlas: enable eist Enable Enhanced Intel SpeedStep (EIST) on Atlas. There's also a redundant dptf_enable line (the other instance is earlier in the file with a comment), so I just renamed the setting to kill two birds with one commit. Change-Id: I57dca346c43feebcddf88f38d4e9f3105775b398 Signed-off-by: Matt Delco <delco(a)chromium.org> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/29664/1 diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 229838f..6bdaa18 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -63,7 +63,7 @@ register "VmxEnable" = "1" register "speed_shift_enable" = "1" - register "dptf_enable" = "1" + register "eist_enable" = "1" register "tdp_pl2_override" = "15" register "psys_pmax" = "45" register "tcc_offset" = "10" -- To view, visit https://review.coreboot.org/29664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I57dca346c43feebcddf88f38d4e9f3105775b398 Gerrit-Change-Number: 29664 Gerrit-PatchSet: 1 Gerrit-Owner: Matt Delco <delco(a)chromium.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018