coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Update USB port info
by David Wu (Code Review) 29 Nov '18

29 Nov '18

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29912 ) Change subject: mb/google/fizz/variants/karma: Update USB port info ...................................................................... Patch Set 2: (1 comment) Thanks. https://review.coreboot.org/#/c/29912/1/src/mainboard/google/fizz/variants/… File src/mainboard/google/fizz/variants/karma/overridetree.cb: https://review.coreboot.org/#/c/29912/1/src/mainboard/google/fizz/variants/… PS1, Line 14: register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Camera > no changes required here? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/29912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7383b3d676fd7c775a6d749c70af65b28cf941eb Gerrit-Change-Number: 29912 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 07:28:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: include/device/smbus.h: Don't use device_t
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29914 Change subject: include/device/smbus.h: Don't use device_t ...................................................................... include/device/smbus.h: Don't use device_t Use of device_t is deprecated. Change-Id: I2c88642133d3cbf33015e3e1e855fb2c786878d6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/device/smbus.h 1 file changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/29914/1 diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h index 50857fe..639e938 100644 --- a/src/include/device/smbus.h +++ b/src/include/device/smbus.h @@ -8,12 +8,13 @@ /* Common SMBus bus operations */ struct smbus_bus_operations { - int (*recv_byte)(device_t dev); - int (*send_byte)(device_t dev, u8 value); - int (*read_byte)(device_t dev, u8 addr); - int (*write_byte)(device_t dev, u8 addr, u8 value); - int (*block_read)(device_t dev, u8 cmd, u8 bytes, u8 *buffer); - int (*block_write)(device_t dev, u8 cmd, u8 bytes, const u8 *buffer); + int (*recv_byte)(struct device *dev); + int (*send_byte)(struct device *dev, u8 value); + int (*read_byte)(struct device *dev, u8 addr); + int (*write_byte)(struct device *dev, u8 addr, u8 value); + int (*block_read)(struct device *dev, u8 cmd, u8 bytes, u8 *buffer); + int (*block_write)(struct device *dev, u8 cmd, u8 bytes, + const u8 *buffer); }; static inline const struct smbus_bus_operations *ops_smbus_bus(struct bus *bus) @@ -27,8 +28,8 @@ return bops; } -struct bus *get_pbus_smbus(device_t dev); -int smbus_set_link(device_t dev); +struct bus *get_pbus_smbus(struct device *dev); +int smbus_set_link(struct device *dev); static inline int smbus_recv_byte(struct device *const dev) { -- To view, visit https://review.coreboot.org/c/coreboot/+/29914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c88642133d3cbf33015e3e1e855fb2c786878d6 Gerrit-Change-Number: 29914 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Update USB port info
by David Wu (Code Review) 29 Nov '18

29 Nov '18

Hello Zhuohao Lee, Shelley Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29912 to look at the new patch set (#2). Change subject: mb/google/fizz/variants/karma: Update USB port info ...................................................................... mb/google/fizz/variants/karma: Update USB port info Update USB port info according to the schematic file. BUG=none BRANCH=master TEST=Compiles successfully and boot on DUT. Change-Id: I7383b3d676fd7c775a6d749c70af65b28cf941eb Signed-off-by: David Wu <David_Wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/fizz/variants/baseboard/devicetree.cb M src/mainboard/google/fizz/variants/fizz/overridetree.cb M src/mainboard/google/fizz/variants/karma/overridetree.cb 3 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/29912/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7383b3d676fd7c775a6d749c70af65b28cf941eb Gerrit-Change-Number: 29912 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Update USB port info
by Furquan Shaikh (Code Review) 29 Nov '18

29 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29912 ) Change subject: mb/google/fizz/variants/karma: Update USB port info ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29912/1/src/mainboard/google/fizz/variants/… File src/mainboard/google/fizz/variants/karma/overridetree.cb: https://review.coreboot.org/#/c/29912/1/src/mainboard/google/fizz/variants/… PS1, Line 14: no changes required here? -- To view, visit https://review.coreboot.org/c/coreboot/+/29912 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7383b3d676fd7c775a6d749c70af65b28cf941eb Gerrit-Change-Number: 29912 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 07:07:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: util/xcompile/xcompile: Enable x86_64 support
by Patrick Rudolph (Code Review) 29 Nov '18

29 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29877 ) Change subject: util/xcompile/xcompile: Enable x86_64 support ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29877/2/util/xcompile/xcompile File util/xcompile/xcompile: https://review.coreboot.org/#/c/29877/2/util/xcompile/xcompile@241 PS2, Line 241: nocona > why this specific chip? I had to look up what nocona means ;-) It's like i686 on x86. The oldest CPU that has x86_64 support. I'll update the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/29877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407 Gerrit-Change-Number: 29877 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 07:04:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer
by Philipp Deppenwiese (Code Review) 29 Nov '18

29 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29913 ) Change subject: MAINTAINERS: Add myself as a maintainer ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70df3b9e4e36c2e5d73f8888fe0ec220aa8a91b7 Gerrit-Change-Number: 29913 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 04:55:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer
by Matt DeVillier (Code Review) 29 Nov '18

29 Nov '18

Matt DeVillier has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/29913 ) Change subject: MAINTAINERS: Add myself as a maintainer ...................................................................... MAINTAINERS: Add myself as a maintainer Add myself as a maintainer for legacy Intel-based ChromeOS devices for which I provide coreboot images as a comminuty member, and as a maintainer for Purism devices in a professional capacity. Change-Id: I70df3b9e4e36c2e5d73f8888fe0ec220aa8a91b7 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M MAINTAINERS 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/29913/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70df3b9e4e36c2e5d73f8888fe0ec220aa8a91b7 Gerrit-Change-Number: 29913 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: MAINTAINERS: Add myself as a maintainer
by Matt DeVillier (Code Review) 29 Nov '18

29 Nov '18

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29913 Change subject: MAINTAINERS: Add myself as a maintainer ...................................................................... MAINTAINERS: Add myself as a maintainer Add myself as a maintainer for legacy Intel-based ChromeOS devices for which I provide coreboot images as a comminuty member, and as a maintainer for Purism devices in a professional capacity. Change-Id: I70df3b9e4e36c2e5d73f8888fe0ec220aa8a91b7 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M MAINTAINERS 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/29913/1 diff --git a/MAINTAINERS b/MAINTAINERS index ad94bc1..697b358 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -193,6 +193,19 @@ S: Supported F: src/mainboard/google/panther/ +GOOGLE MAINBOARDS (Intel-based, legacy/inactive) +M: Matt DeVillier <MrChromebox(a)gmail.com> +S: Maintained +F: src/mainboard/google/auron/ +F: src/mainboard/google/beltino/ +F: src/mainboard/google/butterfly/ +F: src/mainboard/google/cyan/ +F: src/mainboard/google/glados/ +F: src/mainboard/google/jecht/ +F: src/mainboard/google/link/ +F: src/mainboard/google/parrot/ +F: src/mainboard/google/stout/ + OCP MAINBOARDS M: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> M: Patrick Rudolph <patrick.rudolph(a)9elements.com> @@ -207,6 +220,17 @@ F: src/mainboard/opencellular/rotundu/ F: src/mainboard/opencellular/elgon/ +PURISM MAINBOARDS +M: Matt DeVillier <matt.devillier(a)puri.sm> +S: Supported +F: src/mainboard/purism + +SAMSUNG CHROMEOS MAINBOARDS +M: Matt DeVillier <MrChromebox(a)gmail.com> +S: Maintained +F: src/mainboard/samsung/lumpy/ +F: src/mainboard/samsung/stumpy/ + INTEL MINNOWBOARD MAX MAINBOARD M: Huang Jin <huang.jin(a)intel.com> M: York Yang <york.yang(a)intel.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/29913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70df3b9e4e36c2e5d73f8888fe0ec220aa8a91b7 Gerrit-Change-Number: 29913 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: cpu/intel/fit: Make FIT microcode updates selectable
by Philipp Deppenwiese (Code Review) 29 Nov '18

29 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29863 ) Change subject: cpu/intel/fit: Make FIT microcode updates selectable ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29863/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29863/2//COMMIT_MSG@7 PS2, Line 7: Make FIT microcode updates selectable > Interesting. I need to read up on that path. […] ID: 558294, figure 5-4. We try to implement it as generic TXT support. The ACMs are platform dependent but the init code should stay the same -- To view, visit https://review.coreboot.org/c/coreboot/+/29863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7da926943aef89e49e98d0b990ab46f5f8200e6e Gerrit-Change-Number: 29863 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 29 Nov 2018 04:10:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: [TESTME]soc/intel/fsp_broadwell_de: Implement postcar stage
by Philipp Deppenwiese (Code Review) 29 Nov '18

29 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29908 ) Change subject: [TESTME]soc/intel/fsp_broadwell_de: Implement postcar stage ...................................................................... Patch Set 2: Werner and I can test it -- To view, visit https://review.coreboot.org/c/coreboot/+/29908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic31702514cf84e3480b622c28cd2857e613869d9 Gerrit-Change-Number: 29908 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 04:01:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018