coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: [WIP, DONOTMERGE] Remove -Wno-unused-but-set-variable
by Angel Pons (Code Review) 29 Nov '18

29 Nov '18

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29920 Change subject: [WIP, DONOTMERGE] Remove -Wno-unused-but-set-variable ...................................................................... [WIP, DONOTMERGE] Remove -Wno-unused-but-set-variable It should work properly now. Right now, this would break pretty much everything. Change-Id: I893e00079b85c82dc9f43fefb00fc00b4d078928 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/29920/1 diff --git a/Makefile.inc b/Makefile.inc index aaae7bc..2ef0851 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -395,7 +395,7 @@ CFLAGS_common += -Wno-packed-not-aligned CFLAGS_common += -fconserve-stack # cf. commit f69a99db (coreboot: x86: enable gc-sections) -CFLAGS_common += -Wno-unused-but-set-variable +# CFLAGS_common += -Wno-unused-but-set-variable endif endif -- To view, visit https://review.coreboot.org/c/coreboot/+/29920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I893e00079b85c82dc9f43fefb00fc00b4d078928 Gerrit-Change-Number: 29920 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: arch/x86/Makefile.inc: Fix typo
by Hellsenberg (Code Review) 29 Nov '18

29 Nov '18

Hellsenberg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29878 ) Change subject: arch/x86/Makefile.inc: Fix typo ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/29878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0c06f494dcc035d182ab9034e910ceceb236198 Gerrit-Change-Number: 29878 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hellsenberg <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 09:02:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/drivers/spi: Remove not used variable
by Hellsenberg (Code Review) 29 Nov '18

29 Nov '18

Hellsenberg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 ) Change subject: src/drivers/spi: Remove not used variable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Hellsenberg <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 09:01:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/fizz/variants/karma: Disable native SD card controller
by David Wu (Code Review) 29 Nov '18

29 Nov '18

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29918 Change subject: mb/google/fizz/variants/karma: Disable native SD card controller ...................................................................... mb/google/fizz/variants/karma: Disable native SD card controller This change selects Kconfig option to disable native SD card controller in ACPI tables. BUG=b:119798840 BRANCH=master TEST=Compiles successfully and boot on DUT. Change-Id: I68dc9be511a370d882e4656c165efbe5dc6ee52e Signed-off-by: David Wu <David_Wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/fizz/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/29918/1 diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index e1fc38d..26f6f3a 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -11,6 +11,7 @@ select EC_GOOGLE_CHROMEEC_ACPI_USB_PORT_POWER select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_LPC + select EXCLUDE_NATIVE_SD_INTERFACE if BOARD_GOOGLE_KARMA select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_GMA_HAVE_VBT -- To view, visit https://review.coreboot.org/c/coreboot/+/29918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68dc9be511a370d882e4656c165efbe5dc6ee52e Gerrit-Change-Number: 29918 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: [TESTME]soc/intel/fsp_broadwell_de: Implement postcar stage
by Arthur Heymans (Code Review) 29 Nov '18

29 Nov '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29908 ) Change subject: [TESTME]soc/intel/fsp_broadwell_de: Implement postcar stage ...................................................................... Patch Set 2: > Patch Set 2: > > Werner and I can test it Thx. It's a rather naive attempt and could amongst not booting at all result in a significant slowdown so checking the timestamps could be interesting. -- To view, visit https://review.coreboot.org/c/coreboot/+/29908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic31702514cf84e3480b622c28cd2857e613869d9 Gerrit-Change-Number: 29908 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 08:47:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/drivers/spi: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

Hello Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29917 to look at the new patch set (#2). Change subject: src/drivers/spi: Remove not used variable ...................................................................... src/drivers/spi: Remove not used variable Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/spi/sst.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/29917/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: src/drivers/spi: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29917 Change subject: src/drivers/spi: Remove not used variable ...................................................................... src/drivers/spi: Remove not used variable Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Makefile.inc M src/drivers/spi/sst.c 2 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/29917/1 diff --git a/Makefile.inc b/Makefile.inc index aaae7bc..df3e227 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -395,7 +395,7 @@ CFLAGS_common += -Wno-packed-not-aligned CFLAGS_common += -fconserve-stack # cf. commit f69a99db (coreboot: x86: enable gc-sections) -CFLAGS_common += -Wno-unused-but-set-variable +CFLAGS_common += -Wall endif endif diff --git a/src/drivers/spi/sst.c b/src/drivers/spi/sst.c index 559969a..7a0428f 100644 --- a/src/drivers/spi/sst.c +++ b/src/drivers/spi/sst.c @@ -172,7 +172,7 @@ static int sst_write_256(const struct spi_flash *flash, u32 offset, size_t len, const void *buf) { - size_t actual, chunk_len, cmd_len; + size_t actual, chunk_len; unsigned long byte_addr; unsigned long page_size; int ret = 0; @@ -193,7 +193,6 @@ if (ret) goto done; - cmd_len = 4; cmd[0] = CMD_SST_AAI_WP; cmd[1] = offset >> 16; cmd[2] = offset >> 8; -- To view, visit https://review.coreboot.org/c/coreboot/+/29917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Fix coreboot table record alignment to 8-byte boundary
by Xiang Wang (Code Review) 29 Nov '18

29 Nov '18

Xiang Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29916 Change subject: Fix coreboot table record alignment to 8-byte boundary ...................................................................... Fix coreboot table record alignment to 8-byte boundary I found that I triggered an unaligned memory access exception when debugging riscv's coreboot code. Because some records are aligned to a 4-byte boundary, such as lb_timestamp. It is defined as follows struct lb_timestamp { uint32_t tag; uint32_t size; uint32_t timestamp; }; This may causes data misaligned access exceptions at 64bit machine. Change-Id: I1846be0e26ab3c81858d8cf727517e1462035e64 Signed-off-by: Xiang Wang <wxjstz(a)126.com> --- M src/lib/coreboot_table.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/29916/1 diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index c2ae094..20f9aae 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -84,8 +84,10 @@ { struct lb_record *rec; rec = lb_last_record(header); - if (header->table_entries) + if (header->table_entries) { + rec->size = ALIGN_UP(rec->size, 8); header->table_bytes += rec->size; + } rec = lb_last_record(header); header->table_entries++; rec->tag = LB_TAG_UNUSED; @@ -358,9 +360,9 @@ mainboard = (struct lb_mainboard *)rec; mainboard->tag = LB_TAG_MAINBOARD; - mainboard->size = ALIGN_UP(sizeof(*mainboard) + + mainboard->size = sizeof(*mainboard) + strlen(mainboard_vendor) + 1 + - strlen(mainboard_part_number) + 1, 8); + strlen(mainboard_part_number) + 1; mainboard->vendor_idx = 0; mainboard->part_number_idx = strlen(mainboard_vendor) + 1; @@ -411,7 +413,7 @@ rec = (struct lb_string *)lb_new_record(header); len = strlen(strings[i].string); rec->tag = strings[i].tag; - rec->size = ALIGN_UP(sizeof(*rec) + len + 1, 8); + rec->size = sizeof(*rec) + len + 1; memcpy(rec->string, strings[i].string, len+1); } -- To view, visit https://review.coreboot.org/c/coreboot/+/29916 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1846be0e26ab3c81858d8cf727517e1462035e64 Gerrit-Change-Number: 29916 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: mb/google/dragonegg: Don't use device_t
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29915 Change subject: mb/google/dragonegg: Don't use device_t ...................................................................... mb/google/dragonegg: Don't use device_t Use of device_t is deprecated. Change-Id: Ief858f6612d1c7b4b0c286cf5938f8c29055f1b5 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/dragonegg/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/29915/1 diff --git a/src/mainboard/google/dragonegg/mainboard.c b/src/mainboard/google/dragonegg/mainboard.c index 3e8fd9f..c4df94b 100644 --- a/src/mainboard/google/dragonegg/mainboard.c +++ b/src/mainboard/google/dragonegg/mainboard.c @@ -26,7 +26,7 @@ mainboard_ec_init(); } -static void mainboard_enable(device_t dev) +static void mainboard_enable(struct device *dev) { dev->ops->write_acpi_tables = NULL; dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; -- To view, visit https://review.coreboot.org/c/coreboot/+/29915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief858f6612d1c7b4b0c286cf5938f8c29055f1b5 Gerrit-Change-Number: 29915 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: tss: implement Cr50 vendor-specific VENDOR_CC_TPM_MODE
by build bot (Jenkins) (Code Review) 29 Nov '18

29 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29648 ) Change subject: tss: implement Cr50 vendor-specific VENDOR_CC_TPM_MODE ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/#/c/29648/6/src/security/tpm/tss/tcg-2.0/tss_ma… File src/security/tpm/tss/tcg-2.0/tss_marshaling.c: https://review.coreboot.org/#/c/29648/6/src/security/tpm/tss/tcg-2.0/tss_ma… PS6, Line 482: break; break is not useful after a goto or return -- To view, visit https://review.coreboot.org/c/coreboot/+/29648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd55708797d2b17336fcbe80c0724957f7052e90 Gerrit-Change-Number: 29648 Gerrit-PatchSet: 6 Gerrit-Owner: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Vadim Bendebury <vbendeb(a)chromium.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 07:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018