Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29926 )
Change subject: Crash Test
......................................................................
Patch Set 2:
Good check. We should get those fixed - no need for these to be ignored.
--
To view, visit https://review.coreboot.org/c/coreboot/+/29926
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3dde296ab4b84add8a8ab6a3bb5ecb65da2c158
Gerrit-Change-Number: 29926
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 29 Nov 2018 18:17:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29936
to look at the new patch set (#2).
Change subject: Documentation: Add disassembly guide for x220
......................................................................
Documentation: Add disassembly guide for x220
Add pictures and basic information.
Copyright CC BY-SA 2016 Karl Cordes
Change-Id: I06618092817b91062b35f3b054a82cf573f641b8
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
A Documentation/mainboard/lenovo/diss_x220_1.jpg
A Documentation/mainboard/lenovo/diss_x220_2.jpg
M Documentation/mainboard/lenovo/xx20_series.md
3 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/29936/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06618092817b91062b35f3b054a82cf573f641b8
Gerrit-Change-Number: 29936
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29873 )
Change subject: google/grunt: Update hynix-H5ANAG6NAMR-UH.spd.hex SPD file Module Part Number
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29873
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59d920498ff6b73e9e7b2887771ad6bc6c6c0b66
Gerrit-Change-Number: 29873
Gerrit-PatchSet: 1
Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 29 Nov 2018 18:07:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29936 )
Change subject: Documentation: Add disassembly guide for x220
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/29936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06618092817b91062b35f3b054a82cf573f641b8
Gerrit-Change-Number: 29936
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 29 Nov 2018 17:59:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29936
Change subject: Documentation: Add disassembly guide for x220
......................................................................
Documentation: Add disassembly guide for x220
Add pictures and basic information.
Copyright CC BY-SA 2016 Karl Cordes
Change-Id: I06618092817b91062b35f3b054a82cf573f641b8
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
A Documentation/mainboard/lenovo/diss_x220_1.jpg
A Documentation/mainboard/lenovo/diss_x220_2.jpg
M Documentation/mainboard/lenovo/xx20_series.md
3 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/29936/1
diff --git a/Documentation/mainboard/lenovo/diss_x220_1.jpg b/Documentation/mainboard/lenovo/diss_x220_1.jpg
new file mode 100644
index 0000000..7e81373
--- /dev/null
+++ b/Documentation/mainboard/lenovo/diss_x220_1.jpg
Binary files differ
diff --git a/Documentation/mainboard/lenovo/diss_x220_2.jpg b/Documentation/mainboard/lenovo/diss_x220_2.jpg
new file mode 100644
index 0000000..8e3b252
--- /dev/null
+++ b/Documentation/mainboard/lenovo/diss_x220_2.jpg
Binary files differ
diff --git a/Documentation/mainboard/lenovo/xx20_series.md b/Documentation/mainboard/lenovo/xx20_series.md
index 8603853..cc835d1 100644
--- a/Documentation/mainboard/lenovo/xx20_series.md
+++ b/Documentation/mainboard/lenovo/xx20_series.md
@@ -37,6 +37,28 @@
Please also have a look at :doc:`../../flash_tutorial/index`.
```
+## Dissasemble instructions
+
+1. Remove the keyboard.
+2. Remove the palm rest.
+
+The disassembled device looks like:
+![][dis1]
+
+[dis1]: diss_x220_1.jpg
+
+3. Remove the foil right next to the SD-Card reader.
+4. On x220: you'll find one flash IC
+ On x230: you'll find two flash ICs
+5. You can easily flash it using a pomona test clip
+
+Closeup view of the flash IC:
+![][dis2]
+
+[dis2]: diss_x220_2.jpg
+
+Pictures by `Copyright 2016 Karl Cordes`
+
## Flash layout
There's one 8MiB flash which contains IFD, GBE, ME and BIOS regions.
On Lenovo's UEFI the EC firmware update is placed at the start of the BIOS
--
To view, visit https://review.coreboot.org/c/coreboot/+/29936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06618092817b91062b35f3b054a82cf573f641b8
Gerrit-Change-Number: 29936
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29877
to look at the new patch set (#3).
Change subject: util/xcompile/xcompile: Enable x86_64 support
......................................................................
util/xcompile/xcompile: Enable x86_64 support
Similar to i686 on x86_32, compile for nocona on x86_64.
Nocona is the first Pentium 4 CPU that has long mode support.
Required for 64bit support.
Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
M util/xcompile/xcompile
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/29877/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/29877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied28f98f89610a748be8d66cf35814e9112a4407
Gerrit-Change-Number: 29877
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29935
Change subject: LinuxBoot: fix initramfs xz compression
......................................................................
LinuxBoot: fix initramfs xz compression
Add the flag '--check=crc32' to the xz compression to use CRC32 for the
integrity check. The linux kernel does not support CRC64 for integrity
checks, which is the default flag on most xz applications.
Change-Id: I738bd99ef22aa053dc198df5595e1878069de13e
Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com>
---
M payloads/external/LinuxBoot/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/29935/1
diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile
index 8016095..a67b16a 100644
--- a/payloads/external/LinuxBoot/Makefile
+++ b/payloads/external/LinuxBoot/Makefile
@@ -39,7 +39,7 @@
initramfs_compressed: initramfs
ifeq ($(CONFIG_LINUXBOOT_INITRAMFS_COMPRESSION_XZ),y)
- xz --keep --force --lzma2=dict=1MiB $(top)/$(CONFIG_LINUXBOOT_INITRAMFS)
+ xz --keep --force --check=crc32 --lzma2=dict=1MiB $(top)/$(CONFIG_LINUXBOOT_INITRAMFS)
endif
ifeq ($(CONFIG_LINUXBOOT_COMPILE_KERNEL),y)
--
To view, visit https://review.coreboot.org/c/coreboot/+/29935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I738bd99ef22aa053dc198df5595e1878069de13e
Gerrit-Change-Number: 29935
Gerrit-PatchSet: 1
Gerrit-Owner: Marcello Sylvester Bauer <sylvblck(a)sylv.io>
Gerrit-MessageType: newchange