coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in ...coreboot[master]: arch/arm64/boot.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29940 ) Change subject: arch/arm64/boot.c: Remove not used variable ...................................................................... Abandoned see 29917 -- To view, visit https://review.coreboot.org/c/coreboot/+/29940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic275f3d3377b4bd40ca9fb591332dc9b2fd9effe Gerrit-Change-Number: 29940 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: sb/amd/common/amd_pci_util.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29942 ) Change subject: sb/amd/common/amd_pci_util.c: Remove not used variable ...................................................................... Abandoned see 29917 -- To view, visit https://review.coreboot.org/c/coreboot/+/29942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie239d067529f6cdea2bea5ae7327562ccb080196 Gerrit-Change-Number: 29942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: {sb, lib, drivers, device, arch}: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

Hello Angel Pons, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29917 to look at the new patch set (#4). Change subject: {sb,lib,drivers,device,arch}: Remove not used variable ...................................................................... {sb,lib,drivers,device,arch}: Remove not used variable Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm64/boot.c M src/device/dram/ddr3.c M src/drivers/spi/sst.c M src/lib/selfboot.c M src/southbridge/amd/common/amd_pci_util.c M src/southbridge/intel/i82371eb/fadt.c 6 files changed, 5 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/29917/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837 Gerrit-Change-Number: 29917 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: cpu/amd/quadcore/quadcore.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29941 ) Change subject: cpu/amd/quadcore/quadcore.c: Remove not used variable ...................................................................... Patch Set 1: > Would it be possible to group these into reasonable sized patches - > maybe 15 or 20 changes in a patch? Say do all of the ones in the > src/cpu/amd or src/cpu subdirectory instead of doing them > one-by-one? If that's not needed, and there are really only a few > issues, I'm fine with them being done one-off, but I'm doubtful > that that's the case. Sure ! :) -- To view, visit https://review.coreboot.org/c/coreboot/+/29941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I826ba637c77dcdac04d0494c00b1b90e5303c63e Gerrit-Change-Number: 29941 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 29 Nov 2018 20:12:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/amd/common/amd_pci_util.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29942 Change subject: sb/amd/common/amd_pci_util.c: Remove not used variable ...................................................................... sb/amd/common/amd_pci_util.c: Remove not used variable Change-Id: Ie239d067529f6cdea2bea5ae7327562ccb080196 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/amd/common/amd_pci_util.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/29942/1 diff --git a/src/southbridge/amd/common/amd_pci_util.c b/src/southbridge/amd/common/amd_pci_util.c index ca76809..acec116 100644 --- a/src/southbridge/amd/common/amd_pci_util.c +++ b/src/southbridge/amd/common/amd_pci_util.c @@ -100,7 +100,6 @@ u16 target_pin = 0; /* Pin we will search our tables for */ u16 int_line = 0; /* IRQ number read from PCI_INTR table and programmed to INT_LINE reg 0x3C */ u16 pci_intr_idx = 0; /* Index into PCI_INTR table, 0xC00/0xC01 */ - u8 bus = 0; /* A PCI Device Bus number */ u16 devfn = 0; /* A PCI Device and Function number */ u8 bridged_device = 0; /* This device is on a PCI bridge */ u32 i = 0; @@ -132,7 +131,6 @@ if (int_pin < 1 || int_pin > 4) continue; /* Device has invalid INT_PIN so skip it */ - bus = target_dev->bus->secondary; devfn = target_dev->path.pci.devfn; /* -- To view, visit https://review.coreboot.org/c/coreboot/+/29942 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie239d067529f6cdea2bea5ae7327562ccb080196 Gerrit-Change-Number: 29942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: Crash Test
by Martin Roth (Code Review) 29 Nov '18

29 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29926 ) Change subject: Crash Test ...................................................................... Patch Set 4: You might want to turn off warnings-as-errors to see the entire list of issues instead of having the build stop on the first one. Also, why are you disabling the other warnings in this patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/29926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3dde296ab4b84add8a8ab6a3bb5ecb65da2c158 Gerrit-Change-Number: 29926 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:55:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: cpu/amd/quadcore/quadcore.c: Remove not used variable
by Martin Roth (Code Review) 29 Nov '18

29 Nov '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29941 ) Change subject: cpu/amd/quadcore/quadcore.c: Remove not used variable ...................................................................... Patch Set 1: Would it be possible to group these into reasonable sized patches - maybe 15 or 20 changes in a patch? Say do all of the ones in the src/cpu/amd or src/cpu subdirectory instead of doing them one-by-one? If that's not needed, and there are really only a few issues, I'm fine with them being done one-off, but I'm doubtful that that's the case. -- To view, visit https://review.coreboot.org/c/coreboot/+/29941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I826ba637c77dcdac04d0494c00b1b90e5303c63e Gerrit-Change-Number: 29941 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:54:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: cpu/amd/quadcore/quadcore.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29941 Change subject: cpu/amd/quadcore/quadcore.c: Remove not used variable ...................................................................... cpu/amd/quadcore/quadcore.c: Remove not used variable Change-Id: I826ba637c77dcdac04d0494c00b1b90e5303c63e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/quadcore/quadcore.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29941/1 diff --git a/src/cpu/amd/quadcore/quadcore.c b/src/cpu/amd/quadcore/quadcore.c index c2d277a..e47c4a3 100644 --- a/src/cpu/amd/quadcore/quadcore.c +++ b/src/cpu/amd/quadcore/quadcore.c @@ -94,13 +94,10 @@ */ /* Wait for the first core of each compute unit to start... */ - uint32_t timeout; for (i = 1; i < cores + 1; i++) { if (!(i & 0x1)) { uint32_t ap_apicid = get_boot_apic_id(nodeid, i); - timeout = wait_cpu_state(ap_apicid, - F10_APSTATE_ASLEEP, F10_APSTATE_ASLEEP); } } -- To view, visit https://review.coreboot.org/c/coreboot/+/29941 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I826ba637c77dcdac04d0494c00b1b90e5303c63e Gerrit-Change-Number: 29941 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: arch/arm64/boot.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29940 Change subject: arch/arm64/boot.c: Remove not used variable ...................................................................... arch/arm64/boot.c: Remove not used variable Change-Id: Ic275f3d3377b4bd40ca9fb591332dc9b2fd9effe Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm64/boot.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/29940/1 diff --git a/src/arch/arm64/boot.c b/src/arch/arm64/boot.c index 54a33e0..261a562 100644 --- a/src/arch/arm64/boot.c +++ b/src/arch/arm64/boot.c @@ -40,7 +40,6 @@ void arch_prog_run(struct prog *prog) { void (*doit)(void *); - void *arg; if (ENV_RAMSTAGE && prog_type(prog) == PROG_PAYLOAD) { run_payload(prog); @@ -48,7 +47,6 @@ } doit = prog_entry(prog); - arg = prog_entry_arg(prog); doit(prog_entry_arg(prog)); } -- To view, visit https://review.coreboot.org/c/coreboot/+/29940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic275f3d3377b4bd40ca9fb591332dc9b2fd9effe Gerrit-Change-Number: 29940 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: sb/intel/i82371eb/fadt.c: Remove not used variable
by HAOUAS Elyes (Code Review) 29 Nov '18

29 Nov '18

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29939 Change subject: sb/intel/i82371eb/fadt.c: Remove not used variable ...................................................................... sb/intel/i82371eb/fadt.c: Remove not used variable Change-Id: I06c693a6b95532df7bbe6b007c048e9526485a74 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/i82371eb/fadt.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/29939/1 diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c index 41ad31c..35ee083 100644 --- a/src/southbridge/intel/i82371eb/fadt.c +++ b/src/southbridge/intel/i82371eb/fadt.c @@ -31,11 +31,8 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { acpi_header_t *header = &(fadt->header); - struct device *dev; /* Power management controller */ - dev = dev_find_device(PCI_VENDOR_ID_INTEL, - PCI_DEVICE_ID_INTEL_82371AB_SMB_ACPI, 0); memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); -- To view, visit https://review.coreboot.org/c/coreboot/+/29939 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06c693a6b95532df7bbe6b007c048e9526485a74 Gerrit-Change-Number: 29939 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018