Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29281
to look at the new patch set (#2).
Change subject: util/bincfg: fix regressions introduced within last modification
......................................................................
util/bincfg: fix regressions introduced within last modification
After I652a8da75498f871a53eb7509f6145c4842e3373, there are undefined
types 'field_t' and 'field_ptr_t' used in bincfg.h and files including
it, and 'sym_table' are not initialized to NULL in main(), making it a
dangling pointer and resulting in crash.
Change-Id: I14d47aff149e18f8f86e78dc4e9beb3bbaac3670
Signed-off-by: Bill XIE <persmule(a)gmail.com>
---
M util/bincfg/bincfg.h
M util/bincfg/bincfg.y
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/29281/2
--
To view, visit https://review.coreboot.org/29281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I14d47aff149e18f8f86e78dc4e9beb3bbaac3670
Gerrit-Change-Number: 29281
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Bill XIE has uploaded this change for review. ( https://review.coreboot.org/29281
Change subject: util/bincfg: replenish missing definitions
......................................................................
util/bincfg: replenish missing definitions
There are types 'field_t' and 'field_ptr_t' used in bincfg.h and/or
files including it, but these types are defined nowhere, which makes
build failed at least on my environments.
Adding their definitions to bincfg.h results in successful builds.
Change-Id: I14d47aff149e18f8f86e78dc4e9beb3bbaac3670
Signed-off-by: Bill XIE <persmule(a)gmail.com>
---
M util/bincfg/bincfg.h
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/29281/1
diff --git a/util/bincfg/bincfg.h b/util/bincfg/bincfg.h
index c0e1242..2081f36 100644
--- a/util/bincfg/bincfg.h
+++ b/util/bincfg/bincfg.h
@@ -28,6 +28,9 @@
struct field *next;
};
+typedef struct field *field_t;
+typedef struct field **field_ptr_t;
+
/* Bit array intermediary representation */
struct blob {
unsigned int bloblen;
--
To view, visit https://review.coreboot.org/29281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14d47aff149e18f8f86e78dc4e9beb3bbaac3670
Gerrit-Change-Number: 29281
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <persmule(a)gmail.com>
Lijian Zhao has abandoned this change. ( https://review.coreboot.org/28688 )
Change subject: [DoNotMerge]Local changes to make a platform working
......................................................................
Abandoned
Not necessary any more
--
To view, visit https://review.coreboot.org/28688
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5449981baabcbb891e1036177307c58f5e2008ac
Gerrit-Change-Number: 28688
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>
Julius Werner has posted comments on this change. ( https://review.coreboot.org/29253 )
Change subject: security/vboot: build vboot_fw20.a per stage
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29253/1/src/security/vboot/Makefile.inc
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/#/c/29253/1/src/security/vboot/Makefile.inc@87
PS1, Line 87: vboot_reference-$(1)
Isn't there a way to map multiple stages to vboot_reference-$(ARCH-$(1)-y) or something like that, so that you don't end up building the same code multiple times in the vast majority of cases where the architecture will be the same? There may be some differences in $(CFLAGS_$(1)) and such (e.g. -D__VERSTAGE__ vs. -D__ROMSTAGE__), but none that should affect vboot in any way. So you could just pick one of them or throw them all together or something and it should still work.
--
To view, visit https://review.coreboot.org/29253
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6807ff73c2713f3b23f43055325b2c40ff1a17d
Gerrit-Change-Number: 29253
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 25 Oct 2018 01:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Richard Spiegel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29243
to look at the new patch set (#13).
Change subject: {cpu,drivers,nb,sb}/amd: Replace {MSR,MTRR} addresses with macros
......................................................................
{cpu,drivers,nb,sb}/amd: Replace {MSR,MTRR} addresses with macros
Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/cpu/amd/agesa/family12/fixme.c
M src/cpu/amd/agesa/family14/fixme.c
M src/cpu/amd/agesa/family15tn/fixme.c
M src/cpu/amd/agesa/family16kb/fixme.c
M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c
M src/cpu/amd/mtrr/amd_mtrr.c
M src/cpu/amd/pi/00630F01/fixme.c
M src/cpu/amd/pi/00660F01/fixme.c
M src/cpu/amd/pi/00730F01/fixme.c
M src/drivers/amd/agesa/s3_mtrr.c
M src/include/cpu/amd/mtrr.h
M src/northbridge/amd/amdmct/mct/mct_d.c
M src/northbridge/amd/amdmct/mct/mctdqs_d.c
M src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
M src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c
M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c
M src/southbridge/amd/rs780/gfx.c
M src/southbridge/amd/sr5650/sr5650.c
18 files changed, 57 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29243/13
--
To view, visit https://review.coreboot.org/29243
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e8de35dcdad52bb311b34bfa9b272d17ed3186b
Gerrit-Change-Number: 29243
Gerrit-PatchSet: 13
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Richard Spiegel has abandoned this change. ( https://review.coreboot.org/29257 )
Change subject: soc/amd/stoneyridge: SMBUS access through MMIO
......................................................................
Abandoned
Also wrong...
--
To view, visit https://review.coreboot.org/29257
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id7accc33005a45ef31d260ad2499a4732b567242
Gerrit-Change-Number: 29257
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>