coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: sb/intel/i82801ix: Support VBOOT
by Nico Huber (Code Review) 01 Oct '18

01 Oct '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28862 ) Change subject: sb/intel/i82801ix: Support VBOOT ...................................................................... Patch Set 1: I would rather see the reset code in a common place. -- To view, visit https://review.coreboot.org/28862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590 Gerrit-Change-Number: 28862 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 Oct 2018 17:41:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801ix: Support VBOOT
by Patrick Rudolph (Code Review) 01 Oct '18

01 Oct '18

Patrick Rudolph has removed Alexander Couzens from this change. ( https://review.coreboot.org/28862 ) Change subject: sb/intel/i82801ix: Support VBOOT ...................................................................... Removed reviewer Alexander Couzens. -- To view, visit https://review.coreboot.org/28862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590 Gerrit-Change-Number: 28862 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: sb/intel/i82801ix: Support VBOOT
by Patrick Rudolph (Code Review) 01 Oct '18

01 Oct '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/28862 Change subject: sb/intel/i82801ix: Support VBOOT ...................................................................... sb/intel/i82801ix: Support VBOOT Include reset.c in romstage to build with VBOOT enabled. Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/i82801ix/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/28862/1 diff --git a/src/southbridge/intel/i82801ix/Makefile.inc b/src/southbridge/intel/i82801ix/Makefile.inc index 32d8221..127eec2 100644 --- a/src/southbridge/intel/i82801ix/Makefile.inc +++ b/src/southbridge/intel/i82801ix/Makefile.inc @@ -41,5 +41,6 @@ romstage-y += early_init.c romstage-y += early_smbus.c romstage-y += dmi_setup.c +romstage-y += ../i82801gx/reset.c endif -- To view, visit https://review.coreboot.org/28862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590 Gerrit-Change-Number: 28862 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: google/kahlee: Enable IOMMU device
by Martin Roth (Code Review) 01 Oct '18

01 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28754 ) Change subject: google/kahlee: Enable IOMMU device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18b9ba1a970c6973226e736d72f82fd53010f31c Gerrit-Change-Number: 28754 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 Oct 2018 15:34:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add IOMMU support
by Martin Roth (Code Review) 01 Oct '18

01 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28753 ) Change subject: soc/amd/stoneyridge: Add IOMMU support ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c File src/soc/amd/stoneyridge/iommu.c: https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@30 PS1, Line 30: 0x44 Any reason this value was chosen? https://review.coreboot.org/#/c/28753/1/src/soc/amd/stoneyridge/iommu.c@38 PS1, Line 38: static void iommu_set_resources(struct device *dev) : { : pci_dev_set_resources(dev); : } Get rid of this and call pci_dev_set_resources directly from the ops table? -- To view, visit https://review.coreboot.org/28753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I688d867c7bd4949a57b27c1b6a793c6a6e4a717a Gerrit-Change-Number: 28753 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 Oct 2018 15:33:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: src/Kconfig: Drop a superfluous word
by Martin Roth (Code Review) 01 Oct '18

01 Oct '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28798 ) Change subject: src/Kconfig: Drop a superfluous word ...................................................................... src/Kconfig: Drop a superfluous word Change-Id: I2d658e57d52f79c77be08599b9e525a46e30f732 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Reviewed-on: https://review.coreboot.org/28798 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/src/Kconfig b/src/Kconfig index ca75c0b..2777d26 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -153,7 +153,7 @@ a small self-decompression stub to its front. This can drastically reduce boot time on platforms where the bootblock is loaded over a very slow connection and bootblock size trumps all other factors for - speed. Since this using this option usually requires changes to the + speed. Since using this option usually requires changes to the SoC memlayout and possibly extra support code, it should not be user-selectable. (There's no real point in offering this to the user anyway... if it works and saves boot time, you would always want it.) -- To view, visit https://review.coreboot.org/28798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d658e57d52f79c77be08599b9e525a46e30f732 Gerrit-Change-Number: 28798 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/Kconfig: Drop a superfluous word
by Martin Roth (Code Review) 01 Oct '18

01 Oct '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28798 ) Change subject: src/Kconfig: Drop a superfluous word ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d658e57d52f79c77be08599b9e525a46e30f732 Gerrit-Change-Number: 28798 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 01 Oct 2018 15:28:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/soc/intel/cannonlake: Fix IA32_PLATFORM_DCA_CAP addresse
by Elyes HAOUAS (Code Review) 01 Oct '18

01 Oct '18

Hello build bot (Jenkins), Lijian Zhao, Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28847 to look at the new patch set (#6). Change subject: src/soc/intel/cannonlake: Fix IA32_PLATFORM_DCA_CAP addresse ...................................................................... src/soc/intel/cannonlake: Fix IA32_PLATFORM_DCA_CAP addresse Change-Id: Id4f99e82bb97a260d654b49a2ba94fde207d318b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/cannonlake/include/soc/msr.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/28847/6 -- To view, visit https://review.coreboot.org/28847 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id4f99e82bb97a260d654b49a2ba94fde207d318b Gerrit-Change-Number: 28847 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src: Move IA32_{FEATURE_CONTROL, MCG_CAP} to x86/msr.h
by Elyes HAOUAS (Code Review) 01 Oct '18

01 Oct '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28852 ) Change subject: src: Move IA32_{FEATURE_CONTROL,MCG_CAP} to x86/msr.h ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28852 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I36a84896187558e16f6a960839c890a89ff2ac09 Gerrit-Change-Number: 28852 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src: Move IA32_THERM_INTERRUPT to x86/msr.h
by Elyes HAOUAS (Code Review) 01 Oct '18

01 Oct '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28854 ) Change subject: src: Move IA32_THERM_INTERRUPT to x86/msr.h ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9d0a36d07d114f48894977c0b80ff0ff9f776ed4 Gerrit-Change-Number: 28854 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018