coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: google/coral: Set SKU ID to EC
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21625 ) Change subject: google/coral: Set SKU ID to EC ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60860/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16046/ : SUCCESS -- To view, visit https://review.coreboot.org/21625 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id427c9d714969d23f96e6be992f3344ade82b43e Gerrit-Change-Number: 21625 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 08:36:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/coral: Set SKU ID to EC
by Tim Chen (Code Review) 21 Sep '17

21 Sep '17

Tim Chen has uploaded this change for review. ( https://review.coreboot.org/21625 Change subject: google/coral: Set SKU ID to EC ...................................................................... google/coral: Set SKU ID to EC Set AP SKU ID by ec command EC_CMD_SET_SKU_ID to update EC keyboard backlight flag. BUG=b:64705535 BRANCH=master TEST=build and test on coral/bruce dut Change-Id: Id427c9d714969d23f96e6be992f3344ade82b43e Signed-off-by: Tim Chen <Tim-Chen(a)quantatw.com> --- M src/mainboard/google/reef/variants/coral/mainboard.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/21625/1 diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c index c60c083..fd8f33b 100644 --- a/src/mainboard/google/reef/variants/coral/mainboard.c +++ b/src/mainboard/google/reef/variants/coral/mainboard.c @@ -39,6 +39,11 @@ *oem_revision = variant_board_sku(); } +void variant_board_ec_set_skuid(void) +{ + google_chromeec_set_sku_id(variant_board_sku()); +} + void mainboard_devtree_update(struct device *dev) { /* Override dev tree settings per board */ -- To view, visit https://review.coreboot.org/21625 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id427c9d714969d23f96e6be992f3344ade82b43e Gerrit-Change-Number: 21625 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <Tim-Chen(a)quantatw.com>

1 0

Change in coreboot[master]: soc/intel/apollolake: Make SCI configurable
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21584 ) Change subject: soc/intel/apollolake: Make SCI configurable ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60859/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16045/ : SUCCESS -- To view, visit https://review.coreboot.org/21584 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4a7ce7d68a6f1f16f27d0902d83dc8774e785b1 Gerrit-Change-Number: 21584 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 08:27:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/i945/raminit: Don't fall back to smbus read on failed SPD decode
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21621 ) Change subject: nb/i945/raminit: Don't fall back to smbus read on failed SPD decode ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60855/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16041/ : SUCCESS -- To view, visit https://review.coreboot.org/21621 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230aa22964c452cf28a9370c927b82c57e39cc62 Gerrit-Change-Number: 21621 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 07:25:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/i945/raminit: Don't fall back to smbus read on failed SPD decode
by Arthur Heymans (Code Review) 21 Sep '17

21 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21621 Change subject: nb/i945/raminit: Don't fall back to smbus read on failed SPD decode ...................................................................... nb/i945/raminit: Don't fall back to smbus read on failed SPD decode SPD decoding problems are no longer a good method for detecting if i2c byte read failed, since the return value of i2c_block_read is checked. Change-Id: I230aa22964c452cf28a9370c927b82c57e39cc62 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/21621/1 diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index a9d183c..b7d2108 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -387,8 +387,7 @@ printk(BIOS_DEBUG, "Reading SPD using i2c block operation.\n"); if (IS_ENABLED(CONFIG_DEBUG_RAM_SETUP) && bytes_read > 0) hexdump(raw_spd, bytes_read); - if (bytes_read != 64 || spd_decode_ddr2(&dimm_info, raw_spd) - != SPD_STATUS_OK) { + if (bytes_read != 64) { /* Try again with SMBUS byte read */ printk(BIOS_DEBUG, "i2c block operation failed," "trying smbus byte operation.\n"); @@ -396,10 +395,14 @@ raw_spd[j] = spd_read_byte(device, j); if (IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)) hexdump(raw_spd, 64); - if (spd_decode_ddr2(&dimm_info, raw_spd) - != SPD_STATUS_OK) - continue; } + + if (spd_decode_ddr2(&dimm_info, raw_spd) != SPD_STATUS_OK) { + printk(BIOS_WARNING, "Encountered problems with SPD, " + "skipping this dimm.\n"); + continue; + } + if (IS_ENABLED(CONFIG_DEBUG_RAM_SETUP)) dram_print_spd_ddr2(&dimm_info); -- To view, visit https://review.coreboot.org/21621 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I230aa22964c452cf28a9370c927b82c57e39cc62 Gerrit-Change-Number: 21621 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: device/dram/ddr2.c: Decoding byte[12] bit7 as self refresh flag
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21620 ) Change subject: device/dram/ddr2.c: Decoding byte[12] bit7 as self refresh flag ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60854/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16040/ : SUCCESS -- To view, visit https://review.coreboot.org/21620 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5 Gerrit-Change-Number: 21620 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 07:14:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2.c: Be more lax about bit7 for tRR byte in SPD
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21620 ) Change subject: device/dram/ddr2.c: Be more lax about bit7 for tRR byte in SPD ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60853/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16039/ : SUCCESS -- To view, visit https://review.coreboot.org/21620 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5 Gerrit-Change-Number: 21620 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 06:39:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2.c: Be more lax about bit7 for tRR byte in SPD
by Arthur Heymans (Code Review) 21 Sep '17

21 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21620 Change subject: device/dram/ddr2.c: Be more lax about bit7 for tRR byte in SPD ...................................................................... device/dram/ddr2.c: Be more lax about bit7 for tRR byte in SPD At least one dimm was found to have an SPD with valid checksum (so otherwise sane) but without bit7 set. Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/device/dram/ddr2.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/21620/1 diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index 6f43563..0a6574f 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -188,6 +188,12 @@ */ static int spd_decode_tRR_time(u32 *tRR, u8 c) { + if (!(c & (1 << 7))) { + printk(BIOS_DEBUG, "SPD byte12 (tRR) bit7 not set," + " ignoring..."); + c |= (1 << 7); + } + switch (c) { default: printk(BIOS_WARNING, "Invalid tRR value 0x%x\n", c); -- To view, visit https://review.coreboot.org/21620 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I091121a5d08159cea4befdedb5f3a92ce132c6e5 Gerrit-Change-Number: 21620 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 34: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60849/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16035/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 34 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 02:29:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60847/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16033/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 6 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 02:29:09 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017