coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: soc/intel/cannonlake: Add FSP GOP support.
by Abhay Kumar (Code Review) 21 Sep '17

21 Sep '17

Abhay Kumar has posted comments on this change. ( https://review.coreboot.org/21628 ) Change subject: soc/intel/cannonlake: Add FSP GOP support. ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/21628/1/src/soc/intel/cannonlake/chip.c File src/soc/intel/cannonlake/chip.c: https://review.coreboot.org/#/c/21628/1/src/soc/intel/cannonlake/chip.c@172 PS1, Line 172: if (vbt) > that will be working? Seems like different scope. Yeah this will free memory and since VBT is global we can access. This is same as reef. -- To view, visit https://review.coreboot.org/21628 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf836d683ae00cd034c853bc9ce965d4de5f7413 Gerrit-Change-Number: 21628 Gerrit-PatchSet: 2 Gerrit-Owner: Abhay Kumar <abhay.kumar(a)intel.com> Gerrit-Reviewer: Abhay Kumar <abhay.kumar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Surendranath R Gurivireddy <surendranath.r.gurivireddy(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 18:55:47 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add FSP GOP support.
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21628 ) Change subject: soc/intel/cannonlake: Add FSP GOP support. ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60886/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/16072/ : SUCCESS -- To view, visit https://review.coreboot.org/21628 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf836d683ae00cd034c853bc9ce965d4de5f7413 Gerrit-Change-Number: 21628 Gerrit-PatchSet: 2 Gerrit-Owner: Abhay Kumar <abhay.kumar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Surendranath R Gurivireddy <surendranath.r.gurivireddy(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 18:55:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add FSP GOP support.
by Abhay Kumar (Code Review) 21 Sep '17

21 Sep '17

Hello Bora Guvendik, Lijian Zhao, Surendranath R Gurivireddy, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21628 to look at the new patch set (#2). Change subject: soc/intel/cannonlake: Add FSP GOP support. ...................................................................... soc/intel/cannonlake: Add FSP GOP support. 1. Add FSP GOP config. 2. Pass VBT to FSP. Change-Id: Icf836d683ae00cd034c853bc9ce965d4de5f7413 Signed-off-by: Abhay Kumar <abhay.kumar(a)intel.com> --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/chip.c 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/21628/2 -- To view, visit https://review.coreboot.org/21628 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf836d683ae00cd034c853bc9ce965d4de5f7413 Gerrit-Change-Number: 21628 Gerrit-PatchSet: 2 Gerrit-Owner: Abhay Kumar <abhay.kumar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Surendranath R Gurivireddy <surendranath.r.gurivireddy(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/skylake: Use common/block/gpio
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19201 ) Change subject: soc/intel/skylake: Use common/block/gpio ...................................................................... Patch Set 43: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60885/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/16071/ : SUCCESS -- To view, visit https://review.coreboot.org/19201 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06e06dbcb6d0d6fe277dfad57b82aca51f94b099 Gerrit-Change-Number: 19201 Gerrit-PatchSet: 43 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: sowmya v <sowmyav235(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Sep 2017 18:11:13 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/celes: add new board as variant of cyan baseboard
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21572 ) Change subject: google/celes: add new board as variant of cyan baseboard ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60882/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16068/ : SUCCESS -- To view, visit https://review.coreboot.org/21572 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id52d3c523bae7745b3dc04da012ab65c1fb37887 Gerrit-Change-Number: 21572 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 18:00:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoney: Allow alternative placement for AMD FW directory
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21456 ) Change subject: soc/amd/stoney: Allow alternative placement for AMD FW directory ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60883/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16069/ : SUCCESS -- To view, visit https://review.coreboot.org/21456 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c95b9805c60ab6204750f7929049c7382e0c6cd Gerrit-Change-Number: 21456 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 17:57:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Set SuperIO gpio correctly
by build bot (Jenkins) (Code Review) 21 Sep '17

21 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21627 ) Change subject: mb/intel/dg43gt: Set SuperIO gpio correctly ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60884/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16070/ : SUCCESS -- To view, visit https://review.coreboot.org/21627 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46a48776382eb0d9be9727691c68912991e14dfe Gerrit-Change-Number: 21627 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 21 Sep 2017 17:55:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Makefile: Don't rebuild when generating tags or file list
by Martin Roth (Code Review) 21 Sep '17

21 Sep '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/21585 ) Change subject: Makefile: Don't rebuild when generating tags or file list ...................................................................... Makefile: Don't rebuild when generating tags or file list Generating a project file list used to do a rebuild of the project. Instead, just make sure there's a coreboot.rom file present and if it is, generate the list. Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/21585 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M Makefile 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/Makefile b/Makefile index 383d583..4ad0177 100644 --- a/Makefile +++ b/Makefile @@ -369,13 +369,16 @@ $(shell mkdir -p $(KCONFIG_SPLITCONFIG) $(objk)/lxdialog $(additional-dirs) $(alldirs)) endif -$(obj)/project_filelist.txt: all +$(obj)/project_filelist.txt: + if [ -z "$(wildcard $(obj)/coreboot.rom)" ]; then \ + echo "*** Error: Project must be built before generating file list ***"; \ + exit 1; \ + fi find $(obj) -name "*.d" -exec cat {} \; | \ sed 's/[:\\]/ /g' | sed 's/ /\n/g' | sort | uniq | \ grep -v '\.o$$' > $(obj)/project_filelist.txt -filelist: clean - $(MAKE) $(obj)/project_filelist.txt +filelist: $(obj)/project_filelist.txt printf "\nFiles used in build:\n" cat $(obj)/project_filelist.txt -- To view, visit https://review.coreboot.org/21585 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c Gerrit-Change-Number: 21585 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: amd/gardenia: Fix number of memory channels
by Martin Roth (Code Review) 21 Sep '17

21 Sep '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/21602 ) Change subject: amd/gardenia: Fix number of memory channels ...................................................................... amd/gardenia: Fix number of memory channels Gardenia (with Stoney Processor) has a single memory channel, not two. This corrects DMI type 17 reporting and the memory clear functions. Change-Id: If49b6a9f37b2687ea2f64105fb9e476a89aa87ed Signed-off-by: Marc Jones <marcj303(a)gmail.com> Reviewed-on: https://review.coreboot.org/21602 Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/amd/gardenia/OemCustomize.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marshall Dawson: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/amd/gardenia/OemCustomize.c b/src/mainboard/amd/gardenia/OemCustomize.c index 3893e5d..6ca84b4 100644 --- a/src/mainboard/amd/gardenia/OemCustomize.c +++ b/src/mainboard/amd/gardenia/OemCustomize.c @@ -21,7 +21,7 @@ static const PSO_ENTRY DDR4PlatformMemoryConfiguration[] = { DRAM_TECHNOLOGY(ANY_SOCKET, DDR4_TECHNOLOGY), NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, 2), - NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, 2), + NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, 1), MOTHER_BOARD_LAYERS(LAYERS_6), MEMCLK_DIS_MAP(ANY_SOCKET, ANY_CHANNEL, 0xff, 0xff, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00), -- To view, visit https://review.coreboot.org/21602 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If49b6a9f37b2687ea2f64105fb9e476a89aa87ed Gerrit-Change-Number: 21602 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Makefile.inc: Add left shift macro
by Martin Roth (Code Review) 21 Sep '17

21 Sep '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/21601 ) Change subject: Makefile.inc: Add left shift macro ...................................................................... Makefile.inc: Add left shift macro Add a macro to shift a value to the left by a specified number of bits. Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6 Signed-off-by: Martin Roth <martinroth(a)google.com> Reviewed-on: https://review.coreboot.org/21601 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Makefile.inc 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Jonathan Neuschäfer: Looks good to me, but someone else must approve diff --git a/Makefile.inc b/Makefile.inc index 88a9a63..cdebd1b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -113,19 +113,20 @@ # macros work on all formats understood by printf(1) # values are space separated if using more than one value # -# int-add: adds an arbitrary length list of integers -# int-subtract: subtracts the the second of two integers from the first -# int-multiply: multiplies an arbitrary length list of integers -# int-divide: divides the first integer by the second -# int-remainder: arithmetic remainder of the first number divided by the second -# int-lt: 1 if the first value is less than the second. 0 otherwise -# int-gt: 1 if the first values is greater than the second. 0 otherwise -# int-eq: 1 if the two values are equal. 0 otherwise -# int-align: align $1 to $2 units -# file-size: returns the filesize of the given file -# tolower: returns the value in all lowercase -# toupper: returns the value in all uppercase -# ws_to_under: returns the value with any whitespace changed to underscores +# int-add: adds an arbitrary length list of integers +# int-subtract: subtracts the the second of two integers from the first +# int-multiply: multiplies an arbitrary length list of integers +# int-divide: divides the first integer by the second +# int-remainder: arithmetic remainder of the first number divided by the second +# int-shift-left: Shift $1 left by $2 bits +# int-lt: 1 if the first value is less than the second. 0 otherwise +# int-gt: 1 if the first values is greater than the second. 0 otherwise +# int-eq: 1 if the two values are equal. 0 otherwise +# int-align: align $1 to $2 units +# file-size: returns the filesize of the given file +# tolower: returns the value in all lowercase +# toupper: returns the value in all uppercase +# ws_to_under: returns the value with any whitespace changed to underscores _toint=$(shell printf "%d" $1) _int-add2=$(shell expr $(call _toint,$1) + $(call _toint,$2)) int-add=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-add,$(call _int-add2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) @@ -134,6 +135,7 @@ int-multiply=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-multiply,$(call _int-multiply2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) int-divide=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) / $(call _toint,$(word 2,$1)))) int-remainder=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) % $(call _toint,$(word 2,$1)))) +int-shift-left=$(shell echo "$(call _toint,$(word 1, $1)) * (2 ^ $(call _toint,$(word 2, $1)))" | bc) int-lt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \< $(call _toint,$(word 2,$1)))) int-gt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \> $(call _toint,$(word 2,$1)))) int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1)))) -- To view, visit https://review.coreboot.org/21601 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6 Gerrit-Change-Number: 21601 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017