coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: soc/intel/common: Add intel common EBDA support
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21538 ) Change subject: soc/intel/common: Add intel common EBDA support ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60916/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16102/ : SUCCESS -- To view, visit https://review.coreboot.org/21538 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8355a1dd528b111f1391e6d28a9b174edddc9ca0 Gerrit-Change-Number: 21538 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 08:46:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/fizz: Enable cros_ec_keyb device
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21633 ) Change subject: mainboard/google/fizz: Enable cros_ec_keyb device ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60914/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16100/ : SUCCESS -- To view, visit https://review.coreboot.org/21633 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cd524aec47ca988d6044cb089e7aa7636e64ab2 Gerrit-Change-Number: 21633 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Cheng <kevin.cheng(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 08:11:19 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/fizz: Enable cros_ec_keyb device
by Kevin Cheng (Code Review) 22 Sep '17

22 Sep '17

Kevin Cheng has uploaded this change for review. ( https://review.coreboot.org/21633 Change subject: mainboard/google/fizz: Enable cros_ec_keyb device ...................................................................... mainboard/google/fizz: Enable cros_ec_keyb device This is required to transmit button information from EC to kernel. BUG=b:65980005 BRANCH=None TEST=Verified using evtest that kernel is able to get button press/release information from EC. Change-Id: I3cd524aec47ca988d6044cb089e7aa7636e64ab2 Signed-off-by: Kevin Cheng <kevin.cheng(a)intel.com> --- M src/mainboard/google/fizz/ec.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/21633/1 diff --git a/src/mainboard/google/fizz/ec.h b/src/mainboard/google/fizz/ec.h index b95a772..4b40445 100644 --- a/src/mainboard/google/fizz/ec.h +++ b/src/mainboard/google/fizz/ec.h @@ -28,6 +28,7 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)) @@ -63,4 +64,6 @@ #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ +#define EC_ENABLE_MKBP_DEVICE /* Enable cros_ec_keyb device */ + #endif -- To view, visit https://review.coreboot.org/21633 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3cd524aec47ca988d6044cb089e7aa7636e64ab2 Gerrit-Change-Number: 21633 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Cheng <kevin.cheng(a)intel.com>

1 0

Change in coreboot[master]: Add disable SPD option to coreboot menuconfig.
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21632 ) Change subject: Add disable SPD option to coreboot menuconfig. ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60913/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16099/ : SUCCESS -- To view, visit https://review.coreboot.org/21632 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72774f296bb977ddb7aedd77ccbd6f1ad6b30916 Gerrit-Change-Number: 21632 Gerrit-PatchSet: 1 Gerrit-Owner: Micha? ?ygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 07:42:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Add disable SPD option to coreboot menuconfig.
by Micha? ?ygowski (Code Review) 22 Sep '17

22 Sep '17

Micha? ?ygowski has uploaded this change for review. ( https://review.coreboot.org/21632 Change subject: Add disable SPD option to coreboot menuconfig. ...................................................................... Add disable SPD option to coreboot menuconfig. Running memtest86+ with RAM SPD retrieval on mainboards and chipsets that do not support retrieving SPD info leads to unexpected behaviours or freezes platforms (e.g. APU2). This option allows to run Memtest86+ on such platforms. Change-Id: I72774f296bb977ddb7aedd77ccbd6f1ad6b30916 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M payloads/Kconfig M payloads/external/Makefile.inc M payloads/external/Memtest86Plus/Makefile 3 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/21632/1 diff --git a/payloads/Kconfig b/payloads/Kconfig index bb9348b..b8f8b5c 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -109,6 +109,15 @@ non-reproducible, as it can fetch different code each time. endchoice +config MEMTEST_SPD + bool "Disable retrieving SPD info" + depends on MEMTEST_SECONDARY_PAYLOAD + help + Disables retrieving RAM SPD info in Memtest86+. + + Some chipsets and mainboards does not support this feature and it + should be disabled in Memtest86+ to avoid unwanted behaviour. + config NVRAMCUI_SECONDARY_PAYLOAD bool "Load nvramcui as a secondary payload" default n diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 0a9b3d6..bcd5911 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -201,6 +201,7 @@ AS="$(AS_x86_32)" \ CONFIG_MEMTEST_MASTER=$(CONFIG_MEMTEST_MASTER) \ CONFIG_MEMTEST_STABLE=$(CONFIG_MEMTEST_STABLE) \ + CONFIG_MEMTEST_SPD=$(CONFIG_MEMTEST_SPD) \ $(MEMTEST_SERIAL_OPTIONS) \ MFLAGS= MAKEFLAGS= diff --git a/payloads/external/Memtest86Plus/Makefile b/payloads/external/Memtest86Plus/Makefile index 2136495..a8fd7cf 100644 --- a/payloads/external/Memtest86Plus/Makefile +++ b/payloads/external/Memtest86Plus/Makefile @@ -43,7 +43,9 @@ build: checkout echo " MAKE $(project_name) $(NAME-y)" - $(MAKE) -C $(project_dir) all + if [ "$(CONFIG_MEMTEST_SPD)" = "y" ]; then \ + $(MAKE) -C $(project_dir) CB_NOSPD=1 all; \ + else $(MAKE) -C $(project_dir) all; fi clean: test -d $(project_dir) && $(MAKE) -C $(project_dir) clean || exit 0 -- To view, visit https://review.coreboot.org/21632 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I72774f296bb977ddb7aedd77ccbd6f1ad6b30916 Gerrit-Change-Number: 21632 Gerrit-PatchSet: 1 Gerrit-Owner: Micha? ?ygowski <michal.zygowski(a)3mdeb.com>

1 0

Change in coreboot[master]: ifdtool: improve the "new layout" feature
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: improve the "new layout" feature ...................................................................... Patch Set 52: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60912/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16098/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 52 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Christopher Douglass <cdouglass.orion(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 06:44:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting
by Matt DeVillier (Code Review) 22 Sep '17

22 Sep '17

Matt DeVillier has submitted this change and it was merged. ( https://review.coreboot.org/21591 ) Change subject: mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting ...................................................................... mb/purism/librem13v2: Remove redundant MAINBOARD_VENDOR setting Unlike Chromebooks, Purism laptops are only sold under one vendor name, so MAINBOARD_VENDOR only needs to be set in src/mainboard/purism/Kconfig. Change-Id: If0b33df01ff3327272d089b7efb8e64fa1233fdf Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Reviewed-on: https://review.coreboot.org/21591 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Youness Alaoui <snifikino(a)gmail.com> --- M src/mainboard/purism/librem13v2/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Matt DeVillier: Looks good to me, but someone else must approve build bot (Jenkins): Verified Youness Alaoui: Looks good to me, approved diff --git a/src/mainboard/purism/librem13v2/Kconfig b/src/mainboard/purism/librem13v2/Kconfig index 4138865..bdb294d 100644 --- a/src/mainboard/purism/librem13v2/Kconfig +++ b/src/mainboard/purism/librem13v2/Kconfig @@ -14,10 +14,6 @@ int default 18 -config MAINBOARD_VENDOR - string - default "Purism" - config MAINBOARD_FAMILY string default "Librem 13" -- To view, visit https://review.coreboot.org/21591 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If0b33df01ff3327272d089b7efb8e64fa1233fdf Gerrit-Change-Number: 21591 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy: Modify HID and add device tree support for VCM device
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21508 ) Change subject: mb/google/poppy: Modify HID and add device tree support for VCM device ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60907/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16093/ : SUCCESS -- To view, visit https://review.coreboot.org/21508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a59dd2027267fbd3837fcd7dbc00551a69f7d6 Gerrit-Change-Number: 21508 Gerrit-PatchSet: 4 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 04:50:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Modify the HID for VCM device
by V Sowmya (Code Review) 22 Sep '17

22 Sep '17

V Sowmya has abandoned this change. ( https://review.coreboot.org/21535 ) Change subject: mb/google/poppy: Modify the HID for VCM device ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/21535 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I9802e54838b74ba3c580fb68ad6843db974b348c Gerrit-Change-Number: 21535 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Ricky Liang <jcliang(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/skylake: add Kabylake Celeron base SKU
by build bot (Jenkins) (Code Review) 22 Sep '17

22 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21617 ) Change subject: soc/intel/skylake: add Kabylake Celeron base SKU ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60906/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16092/ : SUCCESS -- To view, visit https://review.coreboot.org/21617 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c6f7bf643e0dbeb132fb677fcff461244101a55 Gerrit-Change-Number: 21617 Gerrit-PatchSet: 2 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Kevin Cheng <kevin.cheng(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: T.H. Lin <T.H_Lin(a)quantatw.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 22 Sep 2017 01:43:41 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017