coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: Port the feature to jail ME from me_cleaner
by build bot (Jenkins) (Code Review) 24 Sep '17

24 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21607 ) Change subject: ifdtool: Port the feature to jail ME from me_cleaner ...................................................................... Patch Set 12: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60998/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16176/ : SUCCESS -- To view, visit https://review.coreboot.org/21607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00533f4e2569c4763fbfc302bb460db1e60e5564 Gerrit-Change-Number: 21607 Gerrit-PatchSet: 12 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Sep 2017 03:03:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region-permission-related functions
by build bot (Jenkins) (Code Review) 24 Sep '17

24 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related functions ...................................................................... Patch Set 47: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60997/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16175/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 47 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Sep 2017 02:56:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 24 Sep '17

24 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 40: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60999/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16177/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 40 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Sep 2017 02:51:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: improve the "new layout" feature
by build bot (Jenkins) (Code Review) 24 Sep '17

24 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: improve the "new layout" feature ...................................................................... Patch Set 56: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60996/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16174/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 56 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Christopher Douglass <cdouglass.orion(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 24 Sep 2017 02:43:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/riscv: hls_init: Initialize time{, cmp} with dummy pointers
by build bot (Jenkins) (Code Review) 23 Sep '17

23 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21657 ) Change subject: arch/riscv: hls_init: Initialize time{,cmp} with dummy pointers ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60995/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16173/ : SUCCESS -- To view, visit https://review.coreboot.org/21657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e6565145f0b2252deb1f4658221a4f816e2af4 Gerrit-Change-Number: 21657 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Anonymous Coward #1001664 Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 23 Sep 2017 23:16:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: arch/riscv: hls_init: Initialize time{, cmp} with dummy pointers
by Jonathan Neuschäfer (Code Review) 23 Sep '17

23 Sep '17

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/21657 Change subject: arch/riscv: hls_init: Initialize time{,cmp} with dummy pointers ...................................................................... arch/riscv: hls_init: Initialize time{,cmp} with dummy pointers In current versions of spike, the config string is not available anymore, because RISC-V is moving toward OpenFirmware-derived device trees (either in FDT or text format). Using query_config_string leads to a crash in these versions of spike. With this commit and If0bea4bf52d ("riscv: Update register address"), coreboot reaches the romstage again, on spike. Change-Id: Ib1e6565145f0b2252deb1f4658221a4f816e2af4 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/mcall.c 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/21657/1 diff --git a/src/arch/riscv/mcall.c b/src/arch/riscv/mcall.c index 7728fba..111cb64 100644 --- a/src/arch/riscv/mcall.c +++ b/src/arch/riscv/mcall.c @@ -92,16 +92,13 @@ void hls_init(uint32_t hart_id) { - query_result res; - printk(BIOS_SPEW, "hart %d: HLS is %p\n", hart_id, HLS()); memset(HLS(), 0, sizeof(*HLS())); HLS()->hart_id = hart_id; - res = query_config_string(configstring(), "rtc{addr"); - HLS()->time = (void *)get_uint(res); - res = query_config_string(configstring(), "core{0{0{timecmp"); - HLS()->timecmp = (void *)get_uint(res); + /* Initialize these pointers with dummy values, for now */ + HLS()->time = NULL; + HLS()->timecmp = NULL; printk(BIOS_SPEW, "Time is %p and timecmp is %p\n", HLS()->time, HLS()->timecmp); -- To view, visit https://review.coreboot.org/21657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1e6565145f0b2252deb1f4658221a4f816e2af4 Gerrit-Change-Number: 21657 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Move dummy reads after JEDEC init
by build bot (Jenkins) (Code Review) 23 Sep '17

23 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20979 ) Change subject: nb/intel/x4x/raminit: Move dummy reads after JEDEC init ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60993/ : SUCCESS -- To view, visit https://review.coreboot.org/20979 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8069f9c08ad5e5268ddbe3711d58bc42522f938c Gerrit-Change-Number: 20979 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 23 Sep 2017 22:47:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/intel/dg43gt: Fix very long boot delays with USE_OPTION_TABLE
by build bot (Jenkins) (Code Review) 23 Sep '17

23 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21641 ) Change subject: mb/intel/dg43gt: Fix very long boot delays with USE_OPTION_TABLE ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60994/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16172/ : SUCCESS -- To view, visit https://review.coreboot.org/21641 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a23ef9577161084521b569fc3870a27f50624d1 Gerrit-Change-Number: 21641 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 23 Sep 2017 22:36:29 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel: lpc: Use IS_POWER_OF_2 instead of open-coding it
by Arthur Heymans (Code Review) 23 Sep '17

23 Sep '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21655 ) Change subject: soc/intel: lpc: Use IS_POWER_OF_2 instead of open-coding it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21655 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a10a3fa5e1e9140a558f61109d0c9094d46e521 Gerrit-Change-Number: 21655 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 23 Sep 2017 22:26:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/x4x/raminit: Rewrite SPD decode and timing selection
by build bot (Jenkins) (Code Review) 23 Sep '17

23 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19143 ) Change subject: nb/x4x/raminit: Rewrite SPD decode and timing selection ...................................................................... Patch Set 22: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60992/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16171/ : SUCCESS -- To view, visit https://review.coreboot.org/19143 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760eeaa3bd4f2bc25a517ddb1b9533c971454071 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Sat, 23 Sep 2017 22:23:23 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017