coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: refactor region-permission-related feature
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21416 ) Change subject: ifdtool: refactor region-permission-related feature ...................................................................... Patch Set 15: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15423/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60195/ : SUCCESS -- To view, visit https://review.coreboot.org/21416 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d34606545db4d970ce3ec202da4bf4c5cbad18c Gerrit-Change-Number: 21416 Gerrit-PatchSet: 15 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 08:23:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data types
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data types ...................................................................... Patch Set 32: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15421/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60194/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 32 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 08:22:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21457 ) Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15420/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60192/ : SUCCESS -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 07:16:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/i945/raminit.c: Replace numbers with macros
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21472 ) Change subject: nb/intel/i945/raminit.c: Replace numbers with macros ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60193/ : SUCCESS -- To view, visit https://review.coreboot.org/21472 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife1aff0a5cf311881b3a11533b71a74c518a633f Gerrit-Change-Number: 21472 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 07:14:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: device/dram/ddr2: Fix decoding tRR
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21457 ) Change subject: device/dram/ddr2: Fix decoding tRR ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60191/ : ABORTED -- To view, visit https://review.coreboot.org/21457 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a698ec9c15a2611a34c5965edf93638553775f0 Gerrit-Change-Number: 21457 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 06:40:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: winbond/w83627hf: Drop early_init.c
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21474 ) Change subject: winbond/w83627hf: Drop early_init.c ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15414/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60185/ : SUCCESS -- To view, visit https://review.coreboot.org/21474 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a5e27fdd48c6e002c3a39dc92fef77e85aea209 Gerrit-Change-Number: 21474 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 03:49:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: winbond/w83627hf: Drop early_init.c
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21474 ) Change subject: winbond/w83627hf: Drop early_init.c ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60183/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15412/ : SUCCESS -- To view, visit https://review.coreboot.org/21474 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a5e27fdd48c6e002c3a39dc92fef77e85aea209 Gerrit-Change-Number: 21474 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 03:30:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: winbond/w83627hf: Drop early_init.c
by Keith Hui (Code Review) 10 Sep '17

10 Sep '17

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/21474 Change subject: winbond/w83627hf: Drop early_init.c ...................................................................... winbond/w83627hf: Drop early_init.c Once w83627hf_set_clksel_48() is unified into winbond/common/early_init.c by /c/21331 (Unify w*_set_clksel_48()), this file is no longer needed and can be dropped. Build tested on select affected mainboards. Change-Id: I6a5e27fdd48c6e002c3a39dc92fef77e85aea209 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/superio/winbond/w83627hf/Makefile.inc D src/superio/winbond/w83627hf/early_init.c M src/superio/winbond/w83627hf/w83627hf.h 3 files changed, 0 insertions(+), 56 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/21474/1 diff --git a/src/superio/winbond/w83627hf/Makefile.inc b/src/superio/winbond/w83627hf/Makefile.inc index 93d011e..09b9368 100644 --- a/src/superio/winbond/w83627hf/Makefile.inc +++ b/src/superio/winbond/w83627hf/Makefile.inc @@ -16,5 +16,4 @@ ## GNU General Public License for more details. ## -romstage-$(CONFIG_SUPERIO_WINBOND_W83627HF) += early_init.c ramstage-$(CONFIG_SUPERIO_WINBOND_W83627HF) += superio.c diff --git a/src/superio/winbond/w83627hf/early_init.c b/src/superio/winbond/w83627hf/early_init.c deleted file mode 100644 index 1ec9810..0000000 --- a/src/superio/winbond/w83627hf/early_init.c +++ /dev/null @@ -1,51 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright (C) 2000 AG Electronics Ltd. - * Copyright (C) 2003-2004 Linux Networx - * Copyright (C) 2004 Tyan - * Copyright (C) 2010 Win Enterprises (anishp(a)win-ent.com) - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include <arch/io.h> -#include <device/pnp.h> -#include "w83627hf.h" - -static void pnp_enter_ext_func_mode(pnp_devfn_t dev) -{ - u16 port = dev >> 8; - outb(0x87, port); - outb(0x87, port); -} - -static void pnp_exit_ext_func_mode(pnp_devfn_t dev) -{ - u16 port = dev >> 8; - outb(0xaa, port); -} - -/* - * We duplicate this function, for non-ROMCC boards, from early_serial.c to - * work around a limitation of ROMCC where we can no make early_serial.c into - * link-time symbols and #include early_serial.c. - */ -void w83627hf_set_clksel_48(pnp_devfn_t dev) -{ - u8 reg8; - - pnp_enter_ext_func_mode(dev); - reg8 = pnp_read_config(dev, 0x24); - reg8 |= (1 << 6); /* Set CLKSEL (clock input on pin 1) to 48MHz. */ - pnp_write_config(dev, 0x24, reg8); - pnp_exit_ext_func_mode(dev); -} diff --git a/src/superio/winbond/w83627hf/w83627hf.h b/src/superio/winbond/w83627hf/w83627hf.h index 4b55e0f..ecbf050 100644 --- a/src/superio/winbond/w83627hf/w83627hf.h +++ b/src/superio/winbond/w83627hf/w83627hf.h @@ -109,8 +109,4 @@ #define W83627HF_XSCNF 0x15 #define W83627HF_XWBCNF 0x16 -#include <arch/io.h> - -void w83627hf_set_clksel_48(pnp_devfn_t dev); - #endif /* SUPERIO_WINBOND_W83627HF_H */ -- To view, visit https://review.coreboot.org/21474 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6a5e27fdd48c6e002c3a39dc92fef77e85aea209 Gerrit-Change-Number: 21474 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com>

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Add awareness of ME's AltDisable
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21466 ) Change subject: sb/intel/bd82x6x: Add awareness of ME's AltDisable ...................................................................... Patch Set 3: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60182/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15411/ : SUCCESS -- To view, visit https://review.coreboot.org/21466 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdda6b2dbb8ae3a650be6d5df6c60475a3fa74aa Gerrit-Change-Number: 21466 Gerrit-PatchSet: 3 Gerrit-Owner: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 02:01:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 10 Sep '17

10 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15410/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60181/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 8 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 10 Sep 2017 01:33:31 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017