coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ifdtool: refacter some code
by Bill XIE (Code Review) 12 Sep '17

12 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21511 to look at the new patch set (#2). Change subject: ifdtool: refacter some code ...................................................................... ifdtool: refacter some code add find_fcba(), find_frba(), find_fmba(), find_fpsba() and find_fmsba() to replace those copy-pasted addressings. This commit is one separated from the original I6d05418c. Change-Id: I98965711e4cb9792e5cc86cc4c1035559e0274f5 Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M util/ifdtool/ifdtool.c 1 file changed, 111 insertions(+), 54 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/21511/2 -- To view, visit https://review.coreboot.org/21511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I98965711e4cb9792e5cc86cc4c1035559e0274f5 Gerrit-Change-Number: 21511 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/usb/Kconfig: remove USBDEBUG_DONGLE_BEAGLEBONE_BLACK
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21486 ) Change subject: drivers/usb/Kconfig: remove USBDEBUG_DONGLE_BEAGLEBONE_BLACK ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15532/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60309/ : SUCCESS -- To view, visit https://review.coreboot.org/21486 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3093a6d2c39e7b5e81785028e436109090d9e6dd Gerrit-Change-Number: 21486 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 11:05:20 +0000 Gerrit-HasComments: No

1 0

Change in libgfxinit[master]: hw-gfx-gma.adb: Fix decoding Stolen Memory on Gen4
by Arthur Heymans (Code Review) 12 Sep '17

12 Sep '17

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/21514 ) Change subject: hw-gfx-gma.adb: Fix decoding Stolen Memory on Gen4 ...................................................................... hw-gfx-gma.adb: Fix decoding Stolen Memory on Gen4 Stolen memory needs to be decoded in MB. Change-Id: I1ceb9ffd85d6ebb54a0e099e200a5068c34a6251 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M common/hw-gfx-gma.adb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/14/21514/2 -- To view, visit https://review.coreboot.org/21514 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1ceb9ffd85d6ebb54a0e099e200a5068c34a6251 Gerrit-Change-Number: 21514 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in libgfxinit[master]: hw-gfx-gma.adb: Fix decoding Stolen Memory on Gen4
by Arthur Heymans (Code Review) 12 Sep '17

12 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21514 Change subject: hw-gfx-gma.adb: Fix decoding Stolen Memory on Gen4 ...................................................................... hw-gfx-gma.adb: Fix decoding Stolen Memory on Gen4 Stolen memory needs to be decoded in MB. Change-Id: I1ceb9ffd85d6ebb54a0e099e200a5068c34a6251 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M common/hw-gfx-gma.adb 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/14/21514/1 diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index b188f31..9dba073 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -507,7 +507,7 @@ (1, 4, 8, 16, 32, 48, 64, 128, 256, 96, 160, 224, 352); function Stolen_Size_Gen4 (GGC : Word16) return Stolen_Size_Range is (if GMS_Gen4 (GGC) in Valid_Stolen_Size_Gen4'Range then - Valid_Stolen_Size_Gen4 (GMS_Gen4 (GGC)) else 0); + Valid_Stolen_Size_Gen4 (GMS_Gen4 (GGC)) * 2 ** 20 else 0); function GTT_Size_Gen6 (GGC : Word16) return Natural is (Natural (Shift_Right (GGC, 8) and 16#03#) * 2 ** 20); @@ -537,7 +537,7 @@ is GGC_Reg : constant := (case Config.CPU is - when G45 | Ironlake => 16#52#, + when G45 | Ironlake => 16#52#, when Sandybridge .. Skylake => 16#50#); GGC : Word16; begin @@ -575,7 +575,7 @@ Valid := FB_Last_Page (FB) < GTT_Size / Config.GTT_PTE_Size and FB_Last_Page (FB) < Natural (Stolen_Size / GTT_Page_Size) and - FB_Last_Page (FB) < Aperture_Size / GTT_Page_Size; + FB_Last_Page (FB) < Aperture_Size / GTT_Page_Size; pragma Debug (not Valid, Debug.Put ("Stolen memory too small to hold framebuffer.")); end if; -- To view, visit https://review.coreboot.org/21514 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1ceb9ffd85d6ebb54a0e099e200a5068c34a6251 Gerrit-Change-Number: 21514 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: intel/common/acpi: Use UART_BASE_0_ADDR macro for LPSS UART
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21513 ) Change subject: intel/common/acpi: Use UART_BASE_0_ADDR macro for LPSS UART ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15531/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60308/ : SUCCESS -- To view, visit https://review.coreboot.org/21513 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib31174701c56c88829ae0e725b546b66ea1ed16d Gerrit-Change-Number: 21513 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 09:52:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/common/acpi: Use UART_BASE_0_ADDR macro for LPSS UART
by V Sowmya (Code Review) 12 Sep '17

12 Sep '17

V Sowmya has uploaded this change for review. ( https://review.coreboot.org/21513 Change subject: intel/common/acpi: Use UART_BASE_0_ADDR macro for LPSS UART ...................................................................... intel/common/acpi: Use UART_BASE_0_ADDR macro for LPSS UART This patch fixes the build issue by replacing UART_DEBUG_BASE_ADDRESS macro with UART_BASE_0_ADDR macro to configure LPSS UART base adress for ACPI debug prints. TEST= Build and boot soraka and fetch the ASL debug prints. Change-Id: Ib31174701c56c88829ae0e725b546b66ea1ed16d Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/soc/intel/common/acpi/acpi_debug.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/21513/1 diff --git a/src/soc/intel/common/acpi/acpi_debug.asl b/src/soc/intel/common/acpi/acpi_debug.asl index aa7a1af..146696d 100644 --- a/src/soc/intel/common/acpi/acpi_debug.asl +++ b/src/soc/intel/common/acpi/acpi_debug.asl @@ -58,7 +58,7 @@ Store (INDX, LENG) /* Length of the String */ #if IS_ENABLED(CONFIG_DRIVERS_UART_8250MEM_32) - OperationRegion (UBAR, SystemMemory, UART_DEBUG_BASE_ADDRESS, 24) + OperationRegion (UBAR, SystemMemory, UART_BASE_0_ADDR(2), 24) Field (UBAR, AnyAcc, NoLock, Preserve) { TDR, 8, /* Transmit Data Register BAR + 0x000 */ -- To view, visit https://review.coreboot.org/21513 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib31174701c56c88829ae0e725b546b66ea1ed16d Gerrit-Change-Number: 21513 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>

1 0

Change in coreboot[master]: ifdtool: redesign some structures
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21510 ) Change subject: ifdtool: redesign some structures ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15528/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60305/ : SUCCESS -- To view, visit https://review.coreboot.org/21510 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I161c9a2ae83d26e658d67d0804e943fff95fe076 Gerrit-Change-Number: 21510 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 09:13:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Add lens_focus property for OV13858 camera module
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21512 ) Change subject: mb/google/poppy: Add lens_focus property for OV13858 camera module ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15530/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60307/ : SUCCESS -- To view, visit https://review.coreboot.org/21512 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib22403f668dd07d6b9226fe2c22b533223b69473 Gerrit-Change-Number: 21512 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 09:04:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refacter some code
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21511 ) Change subject: ifdtool: refacter some code ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15529/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60306/ : SUCCESS -- To view, visit https://review.coreboot.org/21511 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98965711e4cb9792e5cc86cc4c1035559e0274f5 Gerrit-Change-Number: 21511 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 08:55:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: port the feature to set AltMeDisable/HAP bit here
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21437 ) Change subject: ifdtool: port the feature to set AltMeDisable/HAP bit here ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15527/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60304/ : SUCCESS -- To view, visit https://review.coreboot.org/21437 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a2ecc60cfbb9ee9d96f15be3d53226cb428729a Gerrit-Change-Number: 21437 Gerrit-PatchSet: 12 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 08:51:42 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017