coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 14: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60336/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15559/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 14 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 17:14:22 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: MAINTAINERS: Remove extra unnecessary space
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21521 ) Change subject: MAINTAINERS: Remove extra unnecessary space ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15558/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60335/ : SUCCESS -- To view, visit https://review.coreboot.org/21521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27688c3b8df71b875f1dc1020465d838756362be Gerrit-Change-Number: 21521 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 17:10:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Code clean up for Stoney Ridge hda/sata/usb
by Richard Spiegel (Code Review) 12 Sep '17

12 Sep '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/21522 Change subject: Code clean up for Stoney Ridge hda/sata/usb ...................................................................... Code clean up for Stoney Ridge hda/sata/usb Removed empty functions. On function pointer structure "device_operations", replaced the 0 equality by NULL equality. Change-Id: I9f8dc7681ab2e651872e69a8b2e990e59ebe80c9 Signed-off-by: Richard Spiegel <richard.spiegel(a)amd.corp-partner.google.com> --- M src/soc/amd/stoneyridge/hda.c M src/soc/amd/stoneyridge/sata.c M src/soc/amd/stoneyridge/usb.c 3 files changed, 5 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/21522/1 diff --git a/src/soc/amd/stoneyridge/hda.c b/src/soc/amd/stoneyridge/hda.c index b41b999..1774a4a 100644 --- a/src/soc/amd/stoneyridge/hda.c +++ b/src/soc/amd/stoneyridge/hda.c @@ -28,10 +28,6 @@ 0 }; -static void hda_init(struct device *dev) -{ -} - static struct pci_operations lops_pci = { .set_subsystem = pci_dev_set_subsystem, }; @@ -40,8 +36,8 @@ .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, - .init = hda_init, - .scan_bus = 0, + .init = NULL, + .scan_bus = NULL, .ops_pci = &lops_pci, }; diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c index e2de3e6..c1e5493 100644 --- a/src/soc/amd/stoneyridge/sata.c +++ b/src/soc/amd/stoneyridge/sata.c @@ -63,7 +63,7 @@ .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = sata_init, - .scan_bus = 0, + .scan_bus = NULL, .ops_pci = &lops_pci, }; diff --git a/src/soc/amd/stoneyridge/usb.c b/src/soc/amd/stoneyridge/usb.c index c1caf7d..82984b9 100644 --- a/src/soc/amd/stoneyridge/usb.c +++ b/src/soc/amd/stoneyridge/usb.c @@ -26,16 +26,12 @@ .set_subsystem = pci_dev_set_subsystem, }; -static void usb_init(struct device *dev) -{ -} - static struct device_operations usb_ops = { .read_resources = pci_ehci_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, - .init = usb_init, - .scan_bus = 0, + .init = NULL, + .scan_bus = NULL, .ops_pci = &lops_pci, }; -- To view, visit https://review.coreboot.org/21522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9f8dc7681ab2e651872e69a8b2e990e59ebe80c9 Gerrit-Change-Number: 21522 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: CleanMsg
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21520 ) Change subject: CleanMsg ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15557/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60334/ : SUCCESS -- To view, visit https://review.coreboot.org/21520 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e0a75fedfa25b33425e1725ac2617c0a0523be Gerrit-Change-Number: 21520 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 17:01:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 13: No Builds Executed -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 13 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 16:57:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT support
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT support ...................................................................... Patch Set 12: Verified+1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/15556/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 12 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 16:51:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: MAINTAINERS: Remove extra unnecessary space
by Sumeet R Pawnikar (Code Review) 12 Sep '17

12 Sep '17

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/21521 Change subject: MAINTAINERS: Remove extra unnecessary space ...................................................................... MAINTAINERS: Remove extra unnecessary space Remove extra unnecessary space at end of line. Change-Id: I27688c3b8df71b875f1dc1020465d838756362be Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> --- M MAINTAINERS 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/21521/1 diff --git a/MAINTAINERS b/MAINTAINERS index 76510cc..27d6529 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -520,14 +520,14 @@ # This is intended to let people know who they should contact for issues with various infrastructure pieces. # Hardware # Owners: Stefan, Patrick -# Backups: +# Backups: # Web Server # Owners: Stefan, Patrick # Backups: # Website -# Owners: Martin, Philipp +# Owners: Martin, Philipp # Backups: Patrick, Stefan # Documentation Website -- To view, visit https://review.coreboot.org/21521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I27688c3b8df71b875f1dc1020465d838756362be Gerrit-Change-Number: 21521 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>

1 0

Change in coreboot[master]: CleanMsg
by Richard Spiegel (Code Review) 12 Sep '17

12 Sep '17

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/21520 Change subject: CleanMsg ...................................................................... CleanMsg Change-Id: Ia6e0a75fedfa25b33425e1725ac2617c0a0523be Signed-off-by: Richard Spiegel <richard.spiegel(a)amd.corp-partner.google.com> --- M src/soc/amd/stoneyridge/hda.c M src/soc/amd/stoneyridge/sata.c M src/soc/amd/stoneyridge/usb.c 3 files changed, 5 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/21520/1 diff --git a/src/soc/amd/stoneyridge/hda.c b/src/soc/amd/stoneyridge/hda.c index b41b999..1774a4a 100644 --- a/src/soc/amd/stoneyridge/hda.c +++ b/src/soc/amd/stoneyridge/hda.c @@ -28,10 +28,6 @@ 0 }; -static void hda_init(struct device *dev) -{ -} - static struct pci_operations lops_pci = { .set_subsystem = pci_dev_set_subsystem, }; @@ -40,8 +36,8 @@ .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, - .init = hda_init, - .scan_bus = 0, + .init = NULL, + .scan_bus = NULL, .ops_pci = &lops_pci, }; diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c index e2de3e6..c1e5493 100644 --- a/src/soc/amd/stoneyridge/sata.c +++ b/src/soc/amd/stoneyridge/sata.c @@ -63,7 +63,7 @@ .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = sata_init, - .scan_bus = 0, + .scan_bus = NULL, .ops_pci = &lops_pci, }; diff --git a/src/soc/amd/stoneyridge/usb.c b/src/soc/amd/stoneyridge/usb.c index c1caf7d..82984b9 100644 --- a/src/soc/amd/stoneyridge/usb.c +++ b/src/soc/amd/stoneyridge/usb.c @@ -26,16 +26,12 @@ .set_subsystem = pci_dev_set_subsystem, }; -static void usb_init(struct device *dev) -{ -} - static struct device_operations usb_ops = { .read_resources = pci_ehci_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, - .init = usb_init, - .scan_bus = 0, + .init = NULL, + .scan_bus = NULL, .ops_pci = &lops_pci, }; -- To view, visit https://review.coreboot.org/21520 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6e0a75fedfa25b33425e1725ac2617c0a0523be Gerrit-Change-Number: 21520 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 11: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/60329/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/15551/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 11 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 16:40:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/i440bx: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21351 ) Change subject: intel/i440bx: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15550/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60328/ : SUCCESS -- To view, visit https://review.coreboot.org/21351 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e69901ed83502894f6794b3c1d7bab9aab95e51 Gerrit-Change-Number: 21351 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 16:35:46 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017