coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: intel/i440bx: Implement EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20977 ) Change subject: intel/i440bx: Implement EARLY_CBMEM_INIT ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15548/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60326/ : SUCCESS -- To view, visit https://review.coreboot.org/20977 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I432f145a5343c1bb5f2b0de3b6b88f57124d1bd9 Gerrit-Change-Number: 20977 Gerrit-PatchSet: 10 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 15:56:40 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Update EC keyboard backlight flag by SKU ID
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21400 ) Change subject: google/snappy: Update EC keyboard backlight flag by SKU ID ...................................................................... Patch Set 15: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15547/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60325/ : SUCCESS -- To view, visit https://review.coreboot.org/21400 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 15 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 15:19:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers: Add qcom wifi driver
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21506 ) Change subject: drivers: Add qcom wifi driver ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15545/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60323/ : SUCCESS -- To view, visit https://review.coreboot.org/21506 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c5f5a8a8c480dcfc75d25aa275e26ab0728df3 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 14:04:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: reef: Add qcom wifi device
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21507 ) Change subject: reef: Add qcom wifi device ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15546/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60324/ : SUCCESS -- To view, visit https://review.coreboot.org/21507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I875a95d7844377e523341498bcbfbf9dcd1ee3c7 Gerrit-Change-Number: 21507 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 14:01:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Add delay to wait for legacy devices
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21518 ) Change subject: siemens/mc_apl1: Add delay to wait for legacy devices ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15544/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60322/ : SUCCESS -- To view, visit https://review.coreboot.org/21518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia91babc81e3a347bbc498c3def97b2ea70e10922 Gerrit-Change-Number: 21518 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 13:54:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vendorcode/siemens: Add LegacyDelay to hwilib
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21517 ) Change subject: vendorcode/siemens: Add LegacyDelay to hwilib ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15542/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60321/ : SUCCESS -- To view, visit https://review.coreboot.org/21517 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0386fdea0ecfb3c1ff6ec1c456071246529950a Gerrit-Change-Number: 21517 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 13:52:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: timestamp: Add function to get time since boot
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21516 ) Change subject: timestamp: Add function to get time since boot ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15543/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60320/ : SUCCESS -- To view, visit https://review.coreboot.org/21516 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib93ad89078645c0ebe256048cb48f9622c90451f Gerrit-Change-Number: 21516 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 13:52:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: siemens/mc_apl1: Add delay to wait for legacy devices
by Werner Zeh (Code Review) 12 Sep '17

12 Sep '17

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/21518 Change subject: siemens/mc_apl1: Add delay to wait for legacy devices ...................................................................... siemens/mc_apl1: Add delay to wait for legacy devices There are old legacy onboard devices which are too slow for a coreboot boot with log level BIOS_ERR. In this case coreboot is so fast that these devices do not have enough time to become visible on the PCI bus and this in turn leads to missing resource allocation for this devices. The most generic way to work around this problem on existing hardware is to introduce a delay right before the PCI enumeration starts. The needed delay time depends on the hardware and will therefore be get from hwinfo. Change-Id: Ia91babc81e3a347bbc498c3def97b2ea70e10922 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/mainboard/siemens/mc_apl1/mainboard.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/21518/1 diff --git a/src/mainboard/siemens/mc_apl1/mainboard.c b/src/mainboard/siemens/mc_apl1/mainboard.c index d8374fc..fb849f9 100644 --- a/src/mainboard/siemens/mc_apl1/mainboard.c +++ b/src/mainboard/siemens/mc_apl1/mainboard.c @@ -23,6 +23,9 @@ #include <intelblocks/lpc_lib.h> #include <soc/pci_devs.h> #include <string.h> +#include <bootstate.h> +#include <timer.h> +#include <timestamp.h> #include "brd_gpio.h" #include "ptn3460.h" @@ -141,6 +144,34 @@ } } +static void wait_for_legacy_dev(void *unused) +{ + uint32_t legacy_delay, us_since_boot; + struct stopwatch sw; + + /* Open main hwinfo block. */ + if (hwilib_find_blocks("hwinfo.hex") != CB_SUCCESS) + return; + + /* Get legacy delay parameter from hwinfo. */ + if (hwilib_get_field(LegacyDelay, (uint8_t *) &legacy_delay, + sizeof(legacy_delay)) != sizeof(legacy_delay)) + return; + + us_since_boot = get_us_since_boot(); + /* No need to wait if the time since boot is already long enough.*/ + if (us_since_boot > legacy_delay) + return; + stopwatch_init_msecs_expire(&sw, (legacy_delay - us_since_boot) / 1000); + printk(BIOS_NOTICE, "Wait remaining %d of %d us for legacy devices...", + legacy_delay - us_since_boot, legacy_delay); + while (!stopwatch_expired(&sw)) + ; + printk(BIOS_NOTICE, "done!\n"); +} + +BOOT_STATE_INIT_ENTRY(BS_DEV_ENUMERATE, BS_ON_ENTRY, wait_for_legacy_dev, NULL); + struct chip_operations mainboard_ops = { .init = mainboard_init, .final = mainboard_final, -- To view, visit https://review.coreboot.org/21518 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia91babc81e3a347bbc498c3def97b2ea70e10922 Gerrit-Change-Number: 21518 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: vendorcode/siemens: Add LegacyDelay to hwilib
by Werner Zeh (Code Review) 12 Sep '17

12 Sep '17

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/21517 Change subject: vendorcode/siemens: Add LegacyDelay to hwilib ...................................................................... vendorcode/siemens: Add LegacyDelay to hwilib Add a new parameter to hwilib called LegacyDelay. It will be used to define a delay time to wait for legacy devices if coreboot is too fast for old and slow onboard devices. Change-Id: Id0386fdea0ecfb3c1ff6ec1c456071246529950a Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/vendorcode/siemens/hwilib/hwilib.c M src/vendorcode/siemens/hwilib/hwilib.h 2 files changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/21517/1 diff --git a/src/vendorcode/siemens/hwilib/hwilib.c b/src/vendorcode/siemens/hwilib/hwilib.c index 0d4a7a0..4c0cd63 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.c +++ b/src/vendorcode/siemens/hwilib/hwilib.c @@ -385,7 +385,9 @@ [FANSensorCfg7] = { .pos[0] = {.blk_type = BLK_XIB, .offset = 0xd8, .len = 20}, .get_field = hwilib_read_bytes }, - + [LegacyDelay] = { + .pos[0] = {.blk_type = BLK_XIB, .offset = 0x20c, .len = 4}, + .get_field = hwilib_read_bytes }, }; /** \brief This functions reads the given field from the first valid hwinfo diff --git a/src/vendorcode/siemens/hwilib/hwilib.h b/src/vendorcode/siemens/hwilib/hwilib.h index 9739cf3..6850f07 100644 --- a/src/vendorcode/siemens/hwilib/hwilib.h +++ b/src/vendorcode/siemens/hwilib/hwilib.h @@ -115,8 +115,8 @@ netKind7, netKind8, netKind9, - netKind10 - + netKind10, + LegacyDelay } hwinfo_field_t; /* Define used values in supported fields */ -- To view, visit https://review.coreboot.org/21517 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id0386fdea0ecfb3c1ff6ec1c456071246529950a Gerrit-Change-Number: 21517 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: timestamp: Add function to get time since boot
by Werner Zeh (Code Review) 12 Sep '17

12 Sep '17

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/21516 Change subject: timestamp: Add function to get time since boot ...................................................................... timestamp: Add function to get time since boot Add a function to retrieve the elapsed time since boot. For that purpose use the base time in the timestamp table among with the current timestamp at call time of the function. So more precise the returned time is the elapsed time since the timestamp was initialized scaled in microseconds. This was chosen to get a reliable value even on platforms where the TSC might not be reset on software reset or warm start. Change-Id: Ib93ad89078645c0ebe256048cb48f9622c90451f Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M src/include/timestamp.h M src/lib/timestamp.c 2 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/21516/1 diff --git a/src/include/timestamp.h b/src/include/timestamp.h index 95470f5..f8a5297 100644 --- a/src/include/timestamp.h +++ b/src/include/timestamp.h @@ -40,11 +40,20 @@ /* Apply a factor of N/M to all timestamps recorded so far. */ void timestamp_rescale_table(uint16_t N, uint16_t M); +/* + * Get the time since boot scaled in microseconds. Therefore use the base time + * of the timestamps to get the initial value which is subtracted from + * current timestamp at call time.This will provide a more reliable value even + * if the TSC is not reset on soft reset or warm start. + */ +uint32_t get_us_since_boot(void); + #else #define timestamp_init(base) #define timestamp_add(id, time) #define timestamp_add_now(id) #define timestamp_rescale_table(N, M) +#define get_us_since_boot() 0 #endif /* Implemented by the architecture code */ diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c index 30f7c13..76a9aca 100644 --- a/src/lib/timestamp.c +++ b/src/lib/timestamp.c @@ -327,6 +327,19 @@ } } +/* + * Get the time in microseconds since boot (or more precise: since timestamp + * table was initialized). + */ +uint32_t get_us_since_boot(void) +{ + struct timestamp_table *ts = timestamp_table_get(); + + if (ts == NULL) + return 0; + return ((timestamp_get() - ts->base_time) / ts->tick_freq_mhz); +} + ROMSTAGE_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem) RAMSTAGE_CBMEM_INIT_HOOK(timestamp_sync_cache_to_cbmem) -- To view, visit https://review.coreboot.org/21516 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib93ad89078645c0ebe256048cb48f9622c90451f Gerrit-Change-Number: 21516 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017