coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: mb/google/poppy: Modify the HID and add DSD for VCM device
by V Sowmya (Code Review) 12 Sep '17

12 Sep '17

V Sowmya has uploaded this change for review. ( https://review.coreboot.org/21508 Change subject: mb/google/poppy: Modify the HID and add DSD for VCM device ...................................................................... mb/google/poppy: Modify the HID and add DSD for VCM device Modify the HID to align with ACPI spec and add the DSD object for the device tree support in kernel which will probe the DW9714 device based on the PRP0001 HID. BUG=none BRANCH=none TEST=Build and boot soraka. Verified that the VCM device probe is successful. Change-Id: Ic4a59dd2027267fbd3837fcd7dbc00551a69f7d6 Signed-off-by: V Sowmya <v.sowmya(a)intel.com> --- M src/mainboard/google/poppy/acpi/mipi_camera.asl 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/21508/1 diff --git a/src/mainboard/google/poppy/acpi/mipi_camera.asl b/src/mainboard/google/poppy/acpi/mipi_camera.asl index 3cf4ec0..0732abb 100644 --- a/src/mainboard/google/poppy/acpi/mipi_camera.asl +++ b/src/mainboard/google/poppy/acpi/mipi_camera.asl @@ -703,7 +703,7 @@ Device (VCM0) { - Name (_HID, "DWDWD000") /* _HID: Hardware ID */ + Name (_HID, "PRP0001") /* _HID: Hardware ID */ Name (_UID, Zero) /* _UID: Unique ID */ Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03) @@ -722,6 +722,13 @@ ) }) + Name (_DSD, Package () { + ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () { "compatible", "dongwoon,dw9714" }, + } + }) + Name (_PR0, Package () { ^PMIC.VCMP }) Name (_PR3, Package () { ^PMIC.VCMP }) } -- To view, visit https://review.coreboot.org/21508 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4a59dd2027267fbd3837fcd7dbc00551a69f7d6 Gerrit-Change-Number: 21508 Gerrit-PatchSet: 1 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>

1 0

Change in coreboot[master]: drivers: Add qcom wifi driver
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21506 ) Change subject: drivers: Add qcom wifi driver ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15519/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60296/ : SUCCESS -- To view, visit https://review.coreboot.org/21506 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c5f5a8a8c480dcfc75d25aa275e26ab0728df3 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 04:08:18 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: reef: Add qcom wifi device
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21507 ) Change subject: reef: Add qcom wifi device ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15520/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60297/ : SUCCESS -- To view, visit https://review.coreboot.org/21507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I875a95d7844377e523341498bcbfbf9dcd1ee3c7 Gerrit-Change-Number: 21507 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 04:06:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: reef: Add qcom wifi device
by Furquan Shaikh (Code Review) 12 Sep '17

12 Sep '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/21507 Change subject: reef: Add qcom wifi device ...................................................................... reef: Add qcom wifi device Change-Id: I875a95d7844377e523341498bcbfbf9dcd1ee3c7 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/reef/Kconfig M src/mainboard/google/reef/variants/baseboard/devicetree.cb 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/21507/1 diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index 41d3dcb..136c364 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -8,6 +8,7 @@ select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID select DRIVERS_PS2_KEYBOARD + select DRIVERS_QCOM_WIFI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC select HAVE_ACPI_RESUME diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb index d5f546c..65bf1d3 100644 --- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb @@ -144,6 +144,10 @@ register "wake" = "GPE0_DW3_00" device pci 00.0 on end end + chip drivers/qcom/wifi + register "wake" = "GPE0_DW3_00" + device pci 00.0 on end + end end # - Root Port 0 - PCIe-B 0 - Wifi device pci 14.1 off end # - Root Port 1 - PCIe-B 1 device pci 15.0 on end # - XHCI -- To view, visit https://review.coreboot.org/21507 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I875a95d7844377e523341498bcbfbf9dcd1ee3c7 Gerrit-Change-Number: 21507 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: drivers: Add qcom wifi driver
by Furquan Shaikh (Code Review) 12 Sep '17

12 Sep '17

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/21506 Change subject: drivers: Add qcom wifi driver ...................................................................... drivers: Add qcom wifi driver Change-Id: I84c5f5a8a8c480dcfc75d25aa275e26ab0728df3 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- A src/drivers/qcom/wifi/Kconfig A src/drivers/qcom/wifi/Makefile.inc A src/drivers/qcom/wifi/chip.h A src/drivers/qcom/wifi/wifi.c 4 files changed, 136 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/21506/1 diff --git a/src/drivers/qcom/wifi/Kconfig b/src/drivers/qcom/wifi/Kconfig new file mode 100644 index 0000000..ac24a90 --- /dev/null +++ b/src/drivers/qcom/wifi/Kconfig @@ -0,0 +1,3 @@ +config DRIVERS_QCOM_WIFI + bool + depends on HAVE_ACPI_TABLES diff --git a/src/drivers/qcom/wifi/Makefile.inc b/src/drivers/qcom/wifi/Makefile.inc new file mode 100644 index 0000000..fbf5a0e --- /dev/null +++ b/src/drivers/qcom/wifi/Makefile.inc @@ -0,0 +1,14 @@ +# +# This file is part of the coreboot project. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# + +ramstage-$(CONFIG_DRIVERS_QCOM_WIFI) += wifi.c diff --git a/src/drivers/qcom/wifi/chip.h b/src/drivers/qcom/wifi/chip.h new file mode 100644 index 0000000..4cefa15 --- /dev/null +++ b/src/drivers/qcom/wifi/chip.h @@ -0,0 +1,23 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2017 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __DRIVERS_QCOM_WIFI_CHIP_H__ +#define __DRIVERS_QCOM_WIFI_CHIP_H__ + +struct drivers_qcom_wifi_config { + unsigned wake; /* Wake pin for ACPI _PRW */ +}; + +#endif /* __DRIVERS_QCOM_WIFI_CHIP_H__ */ diff --git a/src/drivers/qcom/wifi/wifi.c b/src/drivers/qcom/wifi/wifi.c new file mode 100644 index 0000000..626e31f --- /dev/null +++ b/src/drivers/qcom/wifi/wifi.c @@ -0,0 +1,96 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2017 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 or (at your option) + * any later version of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <arch/acpi_device.h> +#include <arch/acpigen.h> +#include <console/console.h> +#include <device/device.h> +#include <device/path.h> +#include <device/pci.h> +#include "chip.h" + +static void qcom_wifi_fill_ssdt(struct device *dev) +{ + struct drivers_qcom_wifi_config *config = dev->chip_info; + const char *path = acpi_device_path(dev->bus->dev); + u32 address; + + if (!dev->enabled || !path) + return; + + /* Device */ + acpigen_write_scope(path); + acpigen_write_device(acpi_device_name(dev)); + acpigen_write_name_integer("_UID", 0); + if (dev->chip_ops) + acpigen_write_name_string("_DDN", dev->chip_ops->name); + + /* Address */ + address = PCI_SLOT(dev->path.pci.devfn) & 0xffff; + address <<= 16; + address |= PCI_FUNC(dev->path.pci.devfn) & 0xffff; + acpigen_write_name_dword("_ADR", address); + + /* Wake capabilities */ + if (config && config->wake) + acpigen_write_PRW(config->wake, 3); + + acpigen_pop_len(); /* Device */ + acpigen_pop_len(); /* Scope */ + + printk(BIOS_INFO, "%s.%s: %s %s\n", path, acpi_device_name(dev), + dev->chip_ops ? dev->chip_ops->name : "", dev_path(dev)); +} + +static const char *qcom_wifi_acpi_name(struct device *dev) +{ + return "QWFI"; +} + +static struct pci_operations pci_ops = { + .set_subsystem = pci_dev_set_subsystem, +}; + +struct device_operations qcom_wifi_ops = { + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .init = pci_dev_init, + .ops_pci = &pci_ops, + .acpi_name = &qcom_wifi_acpi_name, + .acpi_fill_ssdt_generator = &qcom_wifi_fill_ssdt, +}; + +static const unsigned short pci_device_ids[] = { + 0x003E, + 0 +}; + +static const struct pci_driver qcom_wifi __pci_driver = { + .ops = &qcom_wifi_ops, + .vendor = 0x168C, + .devices = pci_device_ids, +}; + +static void qcom_wifi_enable(struct device *dev) +{ + dev->ops = &qcom_wifi_ops; +} + +struct chip_operations drivers_qcom_wifi_ops = { + CHIP_NAME("QCOM WiFi") + .enable_dev = &qcom_wifi_enable +}; -- To view, visit https://review.coreboot.org/21506 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84c5f5a8a8c480dcfc75d25aa275e26ab0728df3 Gerrit-Change-Number: 21506 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: ec/google: Add command to set APU SKU ID to EC
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21504 ) Change subject: ec/google: Add command to set APU SKU ID to EC ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15517/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60294/ : SUCCESS -- To view, visit https://review.coreboot.org/21504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cd3b8f646d4134d6bfff2869f6df2d9c615c157 Gerrit-Change-Number: 21504 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 02:18:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Update EC keyboard backlight flag by SKU ID
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21400 ) Change subject: google/snappy: Update EC keyboard backlight flag by SKU ID ...................................................................... Patch Set 14: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15518/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60295/ : SUCCESS -- To view, visit https://review.coreboot.org/21400 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1153aa0b89250c55f311dd93a01fcef47afd7292 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 14 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 02:11:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add postcar stage
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20966 ) Change subject: soc/amd/stoneyridge: Add postcar stage ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15515/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60292/ : SUCCESS -- To view, visit https://review.coreboot.org/20966 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1045446655b81b806d75903d75288ab17b5e77d1 Gerrit-Change-Number: 20966 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 02:05:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Revert CAR teardown wbinvd
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20967 ) Change subject: soc/amd/stoneyridge: Revert CAR teardown wbinvd ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15516/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60293/ : SUCCESS -- To view, visit https://review.coreboot.org/20967 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e6bcb3947f508b1db1a42fd0714bba70074837a Gerrit-Change-Number: 20967 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 02:03:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Enable SMM in TSEG
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21501 ) Change subject: amd/stoneyridge: Enable SMM in TSEG ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15514/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60291/ : SUCCESS -- To view, visit https://review.coreboot.org/21501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dc03ed27d0d109ab919a4f0861de9c7420d03ce Gerrit-Change-Number: 21501 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 02:01:42 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017