coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: ec/google: Add command to set APU SKU ID to EC
by Kevin Chiu (Code Review) 12 Sep '17

12 Sep '17

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/21504 Change subject: ec/google: Add command to set APU SKU ID to EC ...................................................................... ec/google: Add command to set APU SKU ID to EC BUG=b:65359225 BRANCH=reef TEST=emerge-snappy coreboot Change-Id: I8cd3b8f646d4134d6bfff2869f6df2d9c615c157 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_commands.h 3 files changed, 27 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/21504/1 diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 4d47982..03d4c3b 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -263,6 +263,27 @@ return r.flags[feature / 32] & EC_FEATURE_MASK_0(feature); } +int google_chromeec_set_sku_id(u32 skuid) +{ + struct chromeec_command cmd; + struct ec_sku_id_info set_skuid = { + .sku_id = skuid + }; + + cmd.cmd_code = EC_CMD_SET_SKU_ID; + cmd.cmd_version = 0; + cmd.cmd_size_in = sizeof(set_skuid); + cmd.cmd_data_in = &set_skuid; + cmd.cmd_data_out = NULL; + cmd.cmd_size_out = 0; + cmd.cmd_dev_index = 0; + + if (google_chromeec_command(&cmd) != 0) + return -1; + + return 0; +} + #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_RTC) int rtc_get(struct rtc_time *time) { @@ -389,7 +410,7 @@ u32 google_chromeec_get_sku_id(void) { struct chromeec_command cmd; - struct ec_response_sku_id sku_v; + struct ec_sku_id_info sku_v; cmd.cmd_code = EC_CMD_GET_SKU_ID; cmd.cmd_version = 0; diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index 60d5a32..3a7cadd 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -50,6 +50,7 @@ uint8_t google_chromeec_calc_checksum(const uint8_t *data, int size); u16 google_chromeec_get_board_version(void); u32 google_chromeec_get_sku_id(void); +int google_chromeec_set_sku_id(u32 skuid); u32 google_chromeec_get_events_b(void); int google_chromeec_clear_events_b(u32 mask); int google_chromeec_kbbacklight(int percent); diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 46ab905..c5d27d2 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -1124,7 +1124,10 @@ /* Get the board's SKU ID from EC */ #define EC_CMD_GET_SKU_ID 0x000E -struct __ec_align4 ec_response_sku_id { +/* Set SKU ID from AP */ +#define EC_CMD_SET_SKU_ID 0x000F + +struct __ec_align4 ec_sku_id_info { uint32_t sku_id; }; -- To view, visit https://review.coreboot.org/21504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8cd3b8f646d4134d6bfff2869f6df2d9c615c157 Gerrit-Change-Number: 21504 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Change in coreboot[master]: mainboard/lenovo: add Lenovo Z61t laptop
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21019 ) Change subject: mainboard/lenovo: add Lenovo Z61t laptop ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15503/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60280/ : SUCCESS -- To view, visit https://review.coreboot.org/21019 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84c89cc47d3db126d827f92d50270954bc42f224 Gerrit-Change-Number: 21019 Gerrit-PatchSet: 12 Gerrit-Owner: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Andrey Korolyov <andrey(a)xdel.ru> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 01:21:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Add config to enable EC EFS support
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21489 ) Change subject: vboot: Add config to enable EC EFS support ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15502/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60279/ : SUCCESS -- To view, visit https://review.coreboot.org/21489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 6 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 01:14:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Update vboot submodule to upstream master
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21490 ) Change subject: Update vboot submodule to upstream master ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60278/ : SUCCESS -- To view, visit https://review.coreboot.org/21490 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17d034e87fa642c5e30e933eb98bcfe5ceaaa3a8 Gerrit-Change-Number: 21490 Gerrit-PatchSet: 3 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 01:10:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/stoneyridge: Enable SMM in TSEG
by Marshall Dawson (Code Review) 12 Sep '17

12 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21501 to look at the new patch set (#2). Change subject: amd/stoneyridge: Enable SMM in TSEG ...................................................................... amd/stoneyridge: Enable SMM in TSEG Add necessary features to allow mp_init_with_smm() to install and relocate an SMM handler. SMM region functions are added to easily identify SMM the attributes. Add relocation attributes to be set by each core a relocation handler Modify the definition of smi_southbridge_handler() to match TSEG prototype. BUG=b:62103112 Change-Id: I4dc03ed27d0d109ab919a4f0861de9c7420d03ce Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/cpu.c M src/soc/amd/stoneyridge/include/soc/northbridge.h M src/soc/amd/stoneyridge/northbridge.c M src/soc/amd/stoneyridge/ramtop.c M src/soc/amd/stoneyridge/smihandler.c 6 files changed, 136 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/21501/2 -- To view, visit https://review.coreboot.org/21501 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4dc03ed27d0d109ab919a4f0861de9c7420d03ce Gerrit-Change-Number: 21501 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: amd/stoneyridge: Remove multi-node support
by Marshall Dawson (Code Review) 12 Sep '17

12 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21495 to look at the new patch set (#2). Change subject: amd/stoneyridge: Remove multi-node support ...................................................................... amd/stoneyridge: Remove multi-node support The Stoney Ridge APU can never be used in a multi-node system. Reduce the feature set to a single node. Remove the static variables for each D18Fn device and replace the routines with coreboot config read and write functions. Strip down domain_set_resources() to consider only a single node. A follow-on patch will further simplify this. Change-Id: I1982b3fbf8dbb44ca75112c57afa59a2b4e4cf5a Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/northbridge.c 1 file changed, 36 insertions(+), 88 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/21495/2 -- To view, visit https://review.coreboot.org/21495 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1982b3fbf8dbb44ca75112c57afa59a2b4e4cf5a Gerrit-Change-Number: 21495 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Update vboot submodule to upstream master
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21490 ) Change subject: Update vboot submodule to upstream master ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15501/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60277/ : SUCCESS -- To view, visit https://review.coreboot.org/21490 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17d034e87fa642c5e30e933eb98bcfe5ceaaa3a8 Gerrit-Change-Number: 21490 Gerrit-PatchSet: 2 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 00:46:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: vboot: Add config to enable EC EFS support
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21489 ) Change subject: vboot: Add config to enable EC EFS support ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/15500/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/60276/ : SUCCESS -- To view, visit https://review.coreboot.org/21489 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic51ddd4819262162a8d8519461c4ace57ee01cb5 Gerrit-Change-Number: 21489 Gerrit-PatchSet: 5 Gerrit-Owner: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 00:44:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: cpu/intel/car/cache_as_ram.inc: Fix long standing issues
by build bot (Jenkins) (Code Review) 12 Sep '17

12 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21503 ) Change subject: cpu/intel/car/cache_as_ram.inc: Fix long standing issues ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/60275/ : SUCCESS -- To view, visit https://review.coreboot.org/21503 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6cf6a2adbe3a1f28bf2903d852ddc19e09b484 Gerrit-Change-Number: 21503 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 12 Sep 2017 00:38:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Add awareness of ME's AltDisable
by build bot (Jenkins) (Code Review) 11 Sep '17

11 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21466 ) Change subject: sb/intel/bd82x6x: Add awareness of ME's AltDisable ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/60274/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/15499/ : SUCCESS -- To view, visit https://review.coreboot.org/21466 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdda6b2dbb8ae3a650be6d5df6c60475a3fa74aa Gerrit-Change-Number: 21466 Gerrit-PatchSet: 4 Gerrit-Owner: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Nathaniel Roach <nroach44(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 11 Sep 2017 23:57:13 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017