coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: Update vboot submodule to upstream master
by build bot (Jenkins) (Code Review) 20 Aug '17

20 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21074 ) Change subject: Update vboot submodule to upstream master ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58950/ : SUCCESS -- To view, visit https://review.coreboot.org/21074 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7769035453796a162c6313cd0c87661ef1e64f89 Gerrit-Change-Number: 21074 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 21:54:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd: Standardize guards on header files
by build bot (Jenkins) (Code Review) 20 Aug '17

20 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21073 ) Change subject: soc/amd: Standardize guards on header files ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58954/ : SUCCESS -- To view, visit https://review.coreboot.org/21073 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4466df529ab201c922096a31d7438381778b582f Gerrit-Change-Number: 21073 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 21:53:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd: Standardize guards on header files
by build bot (Jenkins) (Code Review) 20 Aug '17

20 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21073 ) Change subject: soc/amd: Standardize guards on header files ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58953/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14301/ : SUCCESS -- To view, visit https://review.coreboot.org/21073 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4466df529ab201c922096a31d7438381778b582f Gerrit-Change-Number: 21073 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 21:39:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Remove MPS IMPV8 workaround
by build bot (Jenkins) (Code Review) 20 Aug '17

20 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21104 ) Change subject: mainboard/google/poppy: Remove MPS IMPV8 workaround ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58951/ : SUCCESS -- To view, visit https://review.coreboot.org/21104 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6fb1890e024e1488d278bbe0a71a1a63ee321af Gerrit-Change-Number: 21104 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 21:39:00 +0000 Gerrit-HasComments: No

1 0

Change in libhwbase[master]: posix file: Add procedure to query the size of a file
by Nico Huber (Code Review) 20 Aug '17

20 Aug '17

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21095 ) Change subject: posix file: Add procedure to query the size of a file ...................................................................... posix file: Add procedure to query the size of a file Change-Id: Ib3b31e90ca98dc09185463ce467a70770e0f222d Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/21095 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M ada/posix/hw-file.adb M common/hw-file.ads 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Nico Huber: Verified Arthur Heymans: Looks good to me, approved diff --git a/ada/posix/hw-file.adb b/ada/posix/hw-file.adb index e2384be..dd9d7f3 100644 --- a/ada/posix/hw-file.adb +++ b/ada/posix/hw-file.adb @@ -14,6 +14,7 @@ with Interfaces.C; with Interfaces.C.Strings; +with Ada.Directories; with HW.Debug; @@ -68,4 +69,18 @@ pragma Debug (not Success, Debug.New_Line); end Map; + procedure Size (Length : out Natural; Path : String) + with + SPARK_Mode => Off + is + use type Ada.Directories.File_Size; + Res_Size : Ada.Directories.File_Size; + begin + Res_Size := Ada.Directories.Size (Path); + Length := Natural (Res_Size); + exception + when others => + Length := 0; + end Size; + end HW.File; diff --git a/common/hw-file.ads b/common/hw-file.ads index 9dbfcf7..bc2242c 100644 --- a/common/hw-file.ads +++ b/common/hw-file.ads @@ -39,4 +39,8 @@ Pre => (Readable or Writable) and (if Map_Copy then Readable and not Writable); + -- Sets `Length` to the size of the file given by `Path` or 0 if an + -- error occurs. + procedure Size (Length : out Natural; Path : String); + end HW.File; -- To view, visit https://review.coreboot.org/21095 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib3b31e90ca98dc09185463ce467a70770e0f222d Gerrit-Change-Number: 21095 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: [NOTFORMERGE, TESTONLY] Use MRC cache on Thinkpad X60
by build bot (Jenkins) (Code Review) 20 Aug '17

20 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21114 ) Change subject: [NOTFORMERGE,TESTONLY] Use MRC cache on Thinkpad X60 ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58949/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14299/ : SUCCESS -- To view, visit https://review.coreboot.org/21114 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b2d07727899a514d338d3cdbad04b7af4a16640 Gerrit-Change-Number: 21114 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 19:57:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [NOTFORMERGE, TESTONLY] Use MRC cache on Thinkpad X60
by Arthur Heymans (Code Review) 20 Aug '17

20 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21114 ) Change subject: [NOTFORMERGE,TESTONLY] Use MRC cache on Thinkpad X60 ...................................................................... Patch Set 3: Code-Review-2 -- To view, visit https://review.coreboot.org/21114 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b2d07727899a514d338d3cdbad04b7af4a16640 Gerrit-Change-Number: 21114 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 19:45:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/beltino: fix LED polarity for mccloud variant
by Martin Roth (Code Review) 20 Aug '17

20 Aug '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21102 ) Change subject: google/beltino: fix LED polarity for mccloud variant ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21102 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e Gerrit-Change-Number: 21102 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 19:21:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx
by build bot (Jenkins) (Code Review) 20 Aug '17

20 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21113 ) Change subject: sb/intel/common/spi.c: Port to i82801gx ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58948/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14298/ : SUCCESS -- To view, visit https://review.coreboot.org/21113 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 Gerrit-Change-Number: 21113 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 19:19:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx
by Arthur Heymans (Code Review) 20 Aug '17

20 Aug '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21113 ) Change subject: sb/intel/common/spi.c: Port to i82801gx ...................................................................... Patch Set 3: here is the log: https://paste.debian.net/982271/ -- To view, visit https://review.coreboot.org/21113 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 Gerrit-Change-Number: 21113 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 20 Aug 2017 19:18:43 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017