coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: drivers/i2c/generic: Support additional device properties
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21270 ) Change subject: drivers/i2c/generic: Support additional device properties ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14782/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59478/ : SUCCESS -- To view, visit https://review.coreboot.org/21270 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b8ceb208f4aba01053746547def6d07c8f8f3a2 Gerrit-Change-Number: 21270 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 16:27:15 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/eve: rt5514: Add 16ms delay on dmic init
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21271 ) Change subject: mb/google/eve: rt5514: Add 16ms delay on dmic init ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14783/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59479/ : SUCCESS -- To view, visit https://review.coreboot.org/21271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9160ce6992153ba49719029de336595bbf4ae72 Gerrit-Change-Number: 21271 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 16:23:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi_device: Provide a new function to add a list of properties
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21269 ) Change subject: acpi_device: Provide a new function to add a list of properties ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14781/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59477/ : SUCCESS -- To view, visit https://review.coreboot.org/21269 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id272256639a8525406635e168a3db5ab1ba4df6b Gerrit-Change-Number: 21269 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 16:23:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/i2c/generic: Support additional device properties
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21270 ) Change subject: drivers/i2c/generic: Support additional device properties ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14780/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59475/ : SUCCESS -- To view, visit https://review.coreboot.org/21270 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b8ceb208f4aba01053746547def6d07c8f8f3a2 Gerrit-Change-Number: 21270 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 15:54:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: acpi_device: New function to add a list of properties
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21269 ) Change subject: acpi_device: New function to add a list of properties ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14778/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59474/ : SUCCESS -- To view, visit https://review.coreboot.org/21269 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id272256639a8525406635e168a3db5ab1ba4df6b Gerrit-Change-Number: 21269 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 15:53:21 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/eve: rt5514: Add 16ms delay on dmic init
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21271 ) Change subject: mb/google/eve: rt5514: Add 16ms delay on dmic init ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14779/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59476/ : SUCCESS -- To view, visit https://review.coreboot.org/21271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9160ce6992153ba49719029de336595bbf4ae72 Gerrit-Change-Number: 21271 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 15:51:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/eve: rt5514: Add 16ms delay on dmic init
by Duncan Laurie (Code Review) 29 Aug '17

29 Aug '17

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/21271 Change subject: mb/google/eve: rt5514: Add 16ms delay on dmic init ...................................................................... mb/google/eve: rt5514: Add 16ms delay on dmic init Add a 16ms delay to DMIC init by the kernel driver in order to prevent an audible 'pop' noise when starting to record. BUG=b:63413023 TEST=manual testing to ensure this device property is present in SSDT: Name (_DSD, Package () { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") Package () { Package () { "realtek,dmic-init-delay", 0x10 } } }) Change-Id: If9160ce6992153ba49719029de336595bbf4ae72 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/mainboard/google/eve/devicetree.cb 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/21271/1 diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index 2e017f8..37e3b1e 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -300,6 +300,11 @@ register "hid" = ""10EC5514"" register "name" = ""RT54"" register "desc" = ""Realtek RT5514"" + register "property_count" = "1" + # Set the DMIC initial delay to 16ms to avoid pop noise + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,dmic-init-delay"" + register "property_list[0].integer" = "16" device i2c 57 on end end end # I2C #4 -- To view, visit https://review.coreboot.org/21271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If9160ce6992153ba49719029de336595bbf4ae72 Gerrit-Change-Number: 21271 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: drivers/i2c/generic: Support additional device properties
by Duncan Laurie (Code Review) 29 Aug '17

29 Aug '17

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/21270 Change subject: drivers/i2c/generic: Support additional device properties ...................................................................... drivers/i2c/generic: Support additional device properties Add support for providing additional free form device properties via devicetree in order to make this driver suitable for kernel drivers that need additional board-specific device properties. This currently allows adding up to 10 additional properties to a device. BUG=b:63413023 TEST=manual testing to ensure that newly added properties are in SSDT Change-Id: I2b8ceb208f4aba01053746547def6d07c8f8f3a2 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/21270/1 diff --git a/src/drivers/i2c/generic/chip.h b/src/drivers/i2c/generic/chip.h index c5d458b..8b285f0 100644 --- a/src/drivers/i2c/generic/chip.h +++ b/src/drivers/i2c/generic/chip.h @@ -19,6 +19,8 @@ #include <arch/acpi_device.h> #include <device/i2c_simple.h> +#define MAX_GENERIC_PROPERTY_LIST 10 + struct drivers_i2c_generic_config { const char *hid; /* ACPI _HID (required) */ const char *cid; /* ACPI _CID */ @@ -59,6 +61,10 @@ struct acpi_gpio enable_gpio; /* Delay to be inserted after device is enabled. */ unsigned enable_delay_ms; + + /* Generic properties for exporting device-specific data to the OS */ + struct acpi_dp property_list[MAX_GENERIC_PROPERTY_LIST]; + int property_count; }; /* diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index b7a535e..fa27b0e 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -116,7 +116,8 @@ } /* DSD */ - if (config->probed || (reset_gpio_index != -1) || + if (config->probed || config->property_count || + (reset_gpio_index != -1) || (enable_gpio_index != -1) || (irq_gpio_index != -1)) { dsd = acpi_dp_new_table("_DSD"); if (config->probed) @@ -134,6 +135,9 @@ acpi_dp_add_gpio(dsd, "enable-gpios", path, enable_gpio_index, 0, config->enable_gpio.polarity); + /* Add generic property list */ + acpi_dp_add_property_list(dsd, config->property_list, + config->property_count); acpi_dp_write(dsd); } -- To view, visit https://review.coreboot.org/21270 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2b8ceb208f4aba01053746547def6d07c8f8f3a2 Gerrit-Change-Number: 21270 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: acpi_device: New function to add a list of properties
by Duncan Laurie (Code Review) 29 Aug '17

29 Aug '17

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/21269 Change subject: acpi_device: New function to add a list of properties ...................................................................... acpi_device: New function to add a list of properties Provide a new function that will allow adding arbitrary properties to devicetree entries without needing a custom driver for the device. This will allow the 'generic i2c' driver to support kernel drivers that need additional device properties exposed and have those board specific properties set with values from devicetree. BUG=b:63413023 TEST=not used yet, compiles cleanly Change-Id: Id272256639a8525406635e168a3db5ab1ba4df6b Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/arch/x86/acpi_device.c M src/arch/x86/include/arch/acpi_device.h 2 files changed, 68 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/21269/1 diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index aac7b88..13fcd5b 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -26,29 +26,6 @@ #define ACPI_DP_UUID "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" #define ACPI_DP_CHILD_UUID "dbb8e3e6-5886-4ba6-8795-1319f52a966b" -enum acpi_dp_type { - ACPI_DP_TYPE_INTEGER, - ACPI_DP_TYPE_STRING, - ACPI_DP_TYPE_REFERENCE, - ACPI_DP_TYPE_TABLE, - ACPI_DP_TYPE_ARRAY, - ACPI_DP_TYPE_CHILD, -}; - -struct acpi_dp { - enum acpi_dp_type type; - const char *name; - struct acpi_dp *next; - union { - struct acpi_dp *child; - struct acpi_dp *array; - }; - union { - uint64_t integer; - const char *string; - }; -}; - /* Write empty word value and return pointer to it */ static void *acpi_device_write_zero_len(void) { @@ -705,6 +682,45 @@ return acpi_dp_new(NULL, ACPI_DP_TYPE_TABLE, name); } +int acpi_dp_add_property_list(struct acpi_dp *dp, + struct acpi_dp *property_list, + size_t property_count) +{ + struct acpi_dp *prop; + int i, properties_added = 0; + + for (i = 0; i < property_count; i++) { + prop = &property_list[i]; + + if (prop->type == ACPI_DP_TYPE_UNKNOWN || !prop->name) + continue; + + switch (prop->type) { + case ACPI_DP_TYPE_INTEGER: + acpi_dp_add_integer(dp, prop->name, prop->integer); + break; + case ACPI_DP_TYPE_STRING: + acpi_dp_add_string(dp, prop->name, prop->string); + break; + case ACPI_DP_TYPE_REFERENCE: + acpi_dp_add_string(dp, prop->name, prop->string); + break; + case ACPI_DP_TYPE_ARRAY: + acpi_dp_add_array(dp, prop->array); + break; + case ACPI_DP_TYPE_CHILD: + acpi_dp_add_child(dp, prop->name, prop->child); + break; + default: + continue; + } + + ++properties_added; + } + + return properties_added; +} + struct acpi_dp *acpi_dp_add_integer(struct acpi_dp *dp, const char *name, uint64_t value) { diff --git a/src/arch/x86/include/arch/acpi_device.h b/src/arch/x86/include/arch/acpi_device.h index f904cc6..e8fe722 100644 --- a/src/arch/x86/include/arch/acpi_device.h +++ b/src/arch/x86/include/arch/acpi_device.h @@ -20,6 +20,30 @@ #include <stdint.h> #include <spi-generic.h> +enum acpi_dp_type { + ACPI_DP_TYPE_UNKNOWN, + ACPI_DP_TYPE_INTEGER, + ACPI_DP_TYPE_STRING, + ACPI_DP_TYPE_REFERENCE, + ACPI_DP_TYPE_TABLE, + ACPI_DP_TYPE_ARRAY, + ACPI_DP_TYPE_CHILD, +}; + +struct acpi_dp { + enum acpi_dp_type type; + const char *name; + struct acpi_dp *next; + union { + struct acpi_dp *child; + struct acpi_dp *array; + }; + union { + uint64_t integer; + const char *string; + }; +}; + #define ACPI_DESCRIPTOR_LARGE (1 << 7) #define ACPI_DESCRIPTOR_INTERRUPT (ACPI_DESCRIPTOR_LARGE | 9) #define ACPI_DESCRIPTOR_GPIO (ACPI_DESCRIPTOR_LARGE | 12) @@ -370,6 +394,11 @@ struct acpi_dp *acpi_dp_add_child(struct acpi_dp *dp, const char *name, struct acpi_dp *child); +/* Add a list of Device Properties, returns the number of properties added */ +int acpi_dp_add_property_list(struct acpi_dp *dp, + struct acpi_dp *property_list, + size_t property_count); + /* Write Device Property hierarchy and clean up resources */ void acpi_dp_write(struct acpi_dp *table); -- To view, visit https://review.coreboot.org/21269 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id272256639a8525406635e168a3db5ab1ba4df6b Gerrit-Change-Number: 21269 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: soc/intel/common: Add functions into common SMM library
by build bot (Jenkins) (Code Review) 29 Aug '17

29 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21268 ) Change subject: soc/intel/common: Add functions into common SMM library ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14777/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59473/ : SUCCESS -- To view, visit https://review.coreboot.org/21268 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If10af4a3f6a5bd22db5a03bcd3033a01b1cce0b4 Gerrit-Change-Number: 21268 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 29 Aug 2017 14:58:48 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017