coreboot-gerrit August 2017

coreboot-gerrit@coreboot.org

1 participants
1999 discussions

Change in coreboot[master]: amd/padmelon: Begin new mainboard
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21035 ) Change subject: amd/padmelon: Begin new mainboard ...................................................................... Patch Set 3: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58791/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14156/ : SUCCESS -- To view, visit https://review.coreboot.org/21035 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81d20adc675df1c0b00b9becd68d418740c005c Gerrit-Change-Number: 21035 Gerrit-PatchSet: 3 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:47:50 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/padmelon: Enable DRAM
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21036 ) Change subject: amd/padmelon: Enable DRAM ...................................................................... Patch Set 3: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58790/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14155/ : SUCCESS -- To view, visit https://review.coreboot.org/21036 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f0cf3c24a9d0311432f9224b45296ef5167ed91 Gerrit-Change-Number: 21036 Gerrit-PatchSet: 3 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:47:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Expand 48MHz for both osc signals
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21034 ) Change subject: amd/pi/hudson: Expand 48MHz for both osc signals ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58789/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14154/ : SUCCESS -- To view, visit https://review.coreboot.org/21034 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaee093d05fa712f62052a3787e56c5eaf4045483 Gerrit-Change-Number: 21034 Gerrit-PatchSet: 5 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:46:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: amd/pi/hudson: Convert 48Mhz en to read/write32
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21033 ) Change subject: amd/pi/hudson: Convert 48Mhz en to read/write32 ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58788/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14153/ : SUCCESS -- To view, visit https://review.coreboot.org/21033 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e09757e5eea1eaf9b76921ad032ad2b79c14c5 Gerrit-Change-Number: 21033 Gerrit-PatchSet: 3 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:46:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: fintek/f81803a: Add new superio - Fintek F81803A
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21032 ) Change subject: fintek/f81803a: Add new superio - Fintek F81803A ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58787/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14152/ : SUCCESS -- To view, visit https://review.coreboot.org/21032 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fb1a1d42d004123c3b12caf26cf0b03cd4046ec Gerrit-Change-Number: 21032 Gerrit-PatchSet: 3 Gerrit-Owner: John E. Kabat <sljkrr(a)gmail.com> Gerrit-Reviewer: John E. Kabat Jr. <john.kabat(a)scarletltd.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:45:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18692 ) Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... Patch Set 25: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58783/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14148/ : SUCCESS -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-Change-Number: 18692 Gerrit-PatchSet: 25 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:40:39 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Update depthcharge stable to upstream master
by Marshall Dawson (Code Review) 18 Aug '17

18 Aug '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21075 ) Change subject: Update depthcharge stable to upstream master ...................................................................... Patch Set 1: Code-Review+2 Working for me. -- To view, visit https://review.coreboot.org/21075 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If030bc3e75dd470838590540880213bd841154b8 Gerrit-Change-Number: 21075 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:40:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/common: Modifies common block acpi files
by build bot (Jenkins) (Code Review) 18 Aug '17

18 Aug '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21077 ) Change subject: src/soc/intel/common: Modifies common block acpi files ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58782/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/14147/ : SUCCESS -- To view, visit https://review.coreboot.org/21077 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05f01278df0ccfdcafed0b3f32040c8c1a05be7e Gerrit-Change-Number: 21077 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:39:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Update vboot submodule to upstream master
by Marshall Dawson (Code Review) 18 Aug '17

18 Aug '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21074 ) Change subject: Update vboot submodule to upstream master ...................................................................... Patch Set 1: Little bit of a nit. Is it valuable to show the time & date, and extend the width of the commit message? And FWIW, I'm not sure where they came from, e.g. the commit date for 8c4b8285 looks like 7/31 14:28:42. Maybe they're googlesource dates? -- To view, visit https://review.coreboot.org/21074 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7769035453796a162c6313cd0c87661ef1e64f89 Gerrit-Change-Number: 21074 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 17 Aug 2017 22:37:10 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/soc/intel/common: Modifies common block acpi files
by Shaunak Saha (Code Review) 18 Aug '17

18 Aug '17

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/21077 Change subject: src/soc/intel/common: Modifies common block acpi files ...................................................................... src/soc/intel/common: Modifies common block acpi files This patch modifies the common acpi files as few cpu specific functions are moved from common acpi to cpu library. TEST= System boots properly and no regression observed. Change-Id: I05f01278df0ccfdcafed0b3f32040c8c1a05be7e Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/soc/intel/common/acpi.h M src/soc/intel/common/acpi/acpi.c 2 files changed, 1 insertion(+), 101 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/21077/1 diff --git a/src/soc/intel/common/acpi.h b/src/soc/intel/common/acpi.h index 845e0f0..19ab926 100644 --- a/src/soc/intel/common/acpi.h +++ b/src/soc/intel/common/acpi.h @@ -32,47 +32,6 @@ #if IS_ENABLED(CONFIG_SOC_INTEL_COMMON_ACPI) /* - * cpu_get_bus_clock returns the bus clock frequency in KHz. - * This is the value the clock ratio is multiplied with. - */ -uint32_t cpu_get_bus_clock(void); - -/* - * cpu_get_coord_type returns coordination type (SW_ANY or SW_ALL or HW_ALL) - * which is used to populate _PSD object. - */ -int cpu_get_coord_type(void); - -/* - * cpu_config_tdp_levels returns the number of TDP levels supported - * by this processor - */ -int cpu_config_tdp_levels(void); - -/* - * cpu_get_min_ratio returns the minimum frequency ratio that is supported - * by this processor - */ -uint32_t cpu_get_min_ratio(void); - -/* - * cpu_get_max_ratio returns the nominal TDP ratio if available or the - * maximum non turbo frequency ratio for this processor - */ -uint32_t cpu_get_max_ratio(void); - -/* - * cpu_get_power_max calculates CPU TDP in mW - */ -uint32_t cpu_get_power_max(void); - -/* - * cpu_get_max_turbo_ratio returns the maximum turbo ratio limit for the - * processor - */ -uint32_t cpu_get_max_turbo_ratio(void); - -/* * get_cstate_map returns a table of processor specific acpi_cstate_t entries * and number of entries in the table */ diff --git a/src/soc/intel/common/acpi/acpi.c b/src/soc/intel/common/acpi/acpi.c index 458b95f..0934dbd 100644 --- a/src/soc/intel/common/acpi/acpi.c +++ b/src/soc/intel/common/acpi/acpi.c @@ -18,6 +18,7 @@ #include <arch/cpu.h> #include <cpu/intel/turbo.h> #include <cpu/x86/msr.h> +#include <intelblocks/cpulib.h> #include <soc/intel/common/acpi.h> #include <soc/pm.h> @@ -33,66 +34,6 @@ #define PSS_LATENCY_TRANSITION 10 #define PSS_LATENCY_BUSMASTER 10 - -__attribute__((weak)) int cpu_get_coord_type(void) -{ - return HW_ALL; -} - -__attribute__((weak)) int cpu_config_tdp_levels(void) -{ - return 0; -} - -__attribute__((weak)) uint32_t cpu_get_min_ratio(void) -{ - msr_t msr; - /* Get bus ratio limits and calculate clock speeds */ - msr = rdmsr(MSR_PLATFORM_INFO); - return ((msr.hi >> 8) & 0xff); /* Max Efficiency Ratio */ -} - -__attribute__((weak)) uint32_t cpu_get_max_ratio(void) -{ - msr_t msr; - uint32_t ratio_max; - if (cpu_config_tdp_levels()) { - /* Set max ratio to nominal TDP ratio */ - msr = rdmsr(MSR_CONFIG_TDP_NOMINAL); - ratio_max = msr.lo & 0xff; - } else { - msr = rdmsr(MSR_PLATFORM_INFO); - /* Max Non-Turbo Ratio */ - ratio_max = (msr.lo >> 8) & 0xff; - } - return ratio_max; -} - -__attribute__((weak)) uint32_t cpu_get_bus_clock(void) -{ - /* CPU bus clock is set by default here to 100MHz. - * This function returns the bus clock in KHz. - */ - return 100 * KHz; -} - -__attribute__((weak)) uint32_t cpu_get_power_max(void) -{ - msr_t msr; - int power_unit; - - msr = rdmsr(MSR_RAPL_POWER_UNIT); - power_unit = 2 << ((msr.lo & 0xf) - 1); - msr = rdmsr(MSR_PKG_POWER_INFO); - return ((msr.lo & 0x7fff) / power_unit) * 1000; -} - -__attribute__((weak)) uint32_t cpu_get_max_turbo_ratio(void) -{ - msr_t msr; - msr = rdmsr(MSR_TURBO_RATIO_LIMIT); - return msr.lo & 0xff; -} __attribute__((weak)) acpi_cstate_t *soc_get_cstate_map(int *entries) { -- To view, visit https://review.coreboot.org/21077 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I05f01278df0ccfdcafed0b3f32040c8c1a05be7e Gerrit-Change-Number: 21077 Gerrit-PatchSet: 1 Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2017