July 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: intel/sandybridge: Clean VGA BIOS ids up a little
by James Ye (Code Review) July 28, 2017

July 28, 2017

James Ye has posted comments on this change. ( https://review.coreboot.org/20814 ) Change subject: intel/sandybridge: Clean VGA BIOS ids up a little ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/20814/2/src/northbridge/intel/sandybridge/g… File src/northbridge/intel/sandybridge/gma.c: https://review.coreboot.org/#/c/20814/2/src/northbridge/intel/sandybridge/g… PS2, Line 270: case 0x80860152: /* IVB Desktop */ : case 0x80860156: /* IVB Mobile */ : case 0x80860162: /* IVB Desktop */ : case 0x80860166: /* IVB Mobile */ Inconsistent indenting? https://review.coreboot.org/#/c/20814/2/util/autoport/sandybridge.go File util/autoport/sandybridge.go: https://review.coreboot.org/#/c/20814/2/util/autoport/sandybridge.go@145 PS2, Line 145: 0x0112, 0x0116, 0x0122, 0x0126, : 0x0152, 0x0156, 0x0162, 0x0166, Should probably be spaces after the comma, not a tab. -- To view, visit https://review.coreboot.org/20814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Gerrit-Change-Number: 20814 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 01:37:41 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: intel/sandybridge: Clean VGA BIOS ids up a little
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20814 ) Change subject: intel/sandybridge: Clean VGA BIOS ids up a little ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57994/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13432/ : SUCCESS -- To view, visit https://review.coreboot.org/20814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Gerrit-Change-Number: 20814 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 00:11:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20813 ) Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57993/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13431/ : SUCCESS -- To view, visit https://review.coreboot.org/20813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Gerrit-Change-Number: 20813 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 00:07:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/sandybridge: Clean VGA BIOS ids up a little
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20814 ) Change subject: intel/sandybridge: Clean VGA BIOS ids up a little ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57992/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13430/ : SUCCESS -- To view, visit https://review.coreboot.org/20814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Gerrit-Change-Number: 20814 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 00:02:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/sandybridge: Clean VGA BIOS ids up a little
by Nico Huber (Code Review) July 28, 2017

July 28, 2017

Hello Alexander Couzens, Patrick Rudolph, James Ye, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20814 to look at the new patch set (#2). Change subject: intel/sandybridge: Clean VGA BIOS ids up a little ...................................................................... intel/sandybridge: Clean VGA BIOS ids up a little Sync map_oprom_vendev() with the list of PCI ids in the `gma.c` driver, remove one obsolete Kconfig default override. v2: Sync autoport too. Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/lenovo/t530/Kconfig M src/northbridge/intel/sandybridge/gma.c M util/autoport/sandybridge.go 3 files changed, 9 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/20814/2 -- To view, visit https://review.coreboot.org/20814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Gerrit-Change-Number: 20814 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
by Nico Huber (Code Review) July 28, 2017

July 28, 2017

Hello Alexander Couzens, Patrick Rudolph, James Ye, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/20813 to look at the new patch set (#2). Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ...................................................................... intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults All affected boards did the same USE_NATIVE_RAMINIT distinction or actually selected USE_NATIVE_RAMINIT. v2: Update autoport. Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig M src/mainboard/gigabyte/ga-b75m-d3v/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/roda/rv11/Kconfig M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/northbridge/intel/sandybridge/Kconfig M util/autoport/sandybridge.go 23 files changed, 1 insertion(+), 85 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/20813/2 -- To view, visit https://review.coreboot.org/20813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Gerrit-Change-Number: 20813 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20813 ) Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57991/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13429/ : SUCCESS -- To view, visit https://review.coreboot.org/20813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Gerrit-Change-Number: 20813 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 23:57:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/sandybridge: Clean VGA BIOS ids up a little
by Nico Huber (Code Review) July 28, 2017

July 28, 2017

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20814 Change subject: intel/sandybridge: Clean VGA BIOS ids up a little ...................................................................... intel/sandybridge: Clean VGA BIOS ids up a little Sync map_oprom_vendev() with the list of PCI ids in the `gma.c` driver, remove one obsolete Kconfig default override. Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/lenovo/t530/Kconfig M src/northbridge/intel/sandybridge/gma.c 2 files changed, 6 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/20814/1 diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 84ebe86..065fd3c 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -52,10 +52,6 @@ int default 10 -config VGA_BIOS_ID - string - default "8086,0106" - config VGA_BIOS_FILE string default "pci8086,0106.rom" diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 6d1044c..097df14 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -258,7 +258,7 @@ u32 map_oprom_vendev(u32 vendev) { - u32 new_vendev=vendev; + u32 new_vendev = vendev; switch (vendev) { case 0x80860102: /* GT1 Desktop */ @@ -267,9 +267,11 @@ case 0x80860116: /* GT2 Mobile */ case 0x80860122: /* GT2 Desktop >=1.3GHz */ case 0x80860126: /* GT2 Mobile >=1.3GHz */ - case 0x80860156: /* IVB */ - case 0x80860166: /* IVB */ - new_vendev=0x80860106; /* GT1 Mobile */ + case 0x80860152: /* IVB Desktop */ + case 0x80860156: /* IVB Mobile */ + case 0x80860162: /* IVB Desktop */ + case 0x80860166: /* IVB Mobile */ + new_vendev = 0x80860106;/* GT1 Mobile */ break; } -- To view, visit https://review.coreboot.org/20814 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I12f24f415b695c516fbb947114e09c873af2e439 Gerrit-Change-Number: 20814 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
by Nico Huber (Code Review) July 28, 2017

July 28, 2017

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20813 Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ...................................................................... intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults All affected boards did the same USE_NATIVE_RAMINIT distinction or actually selected USE_NATIVE_RAMINIT. Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/apple/macbookair4_2/Kconfig M src/mainboard/gigabyte/ga-b75m-d3h/Kconfig M src/mainboard/gigabyte/ga-b75m-d3v/Kconfig M src/mainboard/google/butterfly/Kconfig M src/mainboard/google/link/Kconfig M src/mainboard/google/parrot/Kconfig M src/mainboard/google/stout/Kconfig M src/mainboard/intel/emeraldlake2/Kconfig M src/mainboard/kontron/ktqm77/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/roda/rv11/Kconfig M src/mainboard/samsung/lumpy/Kconfig M src/mainboard/samsung/stumpy/Kconfig M src/northbridge/intel/sandybridge/Kconfig 22 files changed, 1 insertion(+), 84 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/20813/1 diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 08e7166..bdfe667 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -47,10 +47,6 @@ hex default 0x8086 -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config DRAM_RESET_GATE_GPIO int default 60 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index ef66418..36c7158 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -20,10 +20,6 @@ select MAINBOARD_HAS_LPC_TPM select TPM -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config DRAM_RESET_GATE_GPIO int default 25 diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig index 8e83deb..33b7ed7 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig @@ -17,10 +17,6 @@ select INTEL_INT15 select SERIRQ_CONTINUOUS_MODE -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config DRAM_RESET_GATE_GPIO int default 25 diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index ffd0c03..1f4547d 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -28,10 +28,6 @@ string default "Butterfly" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index 217e6c1..66b7421 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -30,10 +30,6 @@ string default "Link" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index 5ce1f24..fa45e4a 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -28,10 +28,6 @@ string default "Parrot" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index d34f595..eca4eae 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -28,10 +28,6 @@ string default "Stout" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 7b5528a..66c8329 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -24,10 +24,6 @@ string default "EMERALD LAKE 2" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 16 diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 115a0fa..17c2803 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -24,10 +24,6 @@ string default "KTQM77/mITX" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index 7669077..784d38a 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -42,10 +42,6 @@ string default "ThinkPad T420" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index feacb51..08052b1 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -39,10 +39,6 @@ string default "ThinkPad T420s" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index df22c3e..a621fdb 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -53,10 +53,6 @@ hex default 0x17aa -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config DRAM_RESET_GATE_GPIO int default 10 diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index bb898cf..51c39e6 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -39,10 +39,6 @@ string default "ThinkPad T430s" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index ee5dd81..8c19c62 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -39,10 +39,6 @@ string default "ThinkPad T520" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index d1c924a..84ebe86 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -40,10 +40,6 @@ string default "ThinkPad T530" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index 8d59079..4f9d7fb 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -41,10 +41,6 @@ string default "ThinkPad X1 carbon gen 1" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 9b70ef0..4b9451b 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -41,10 +41,6 @@ string default "ThinkPad X220" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 480bb9a..39af0e3 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -41,10 +41,6 @@ string default "ThinkPad X230" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 - config MAX_CPUS int default 8 diff --git a/src/mainboard/roda/rv11/Kconfig b/src/mainboard/roda/rv11/Kconfig index d6cb6bd..4f8a438 100644 --- a/src/mainboard/roda/rv11/Kconfig +++ b/src/mainboard/roda/rv11/Kconfig @@ -35,10 +35,6 @@ default "Lizard RW11" if BOARD_RODA_RW11 default "Lizard RV11" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index bd7078d..0c5fce4 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -33,10 +33,6 @@ string default "Lumpy" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index 4f3d1e9..f12de6e 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -30,10 +30,6 @@ string default "Stumpy" -config MMCONF_BASE_ADDRESS - hex - default 0xf8000000 if USE_NATIVE_RAMINIT - config MAX_CPUS int default 8 diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index ae5ddfc..8cbdd5a 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -117,6 +117,7 @@ config MMCONF_BASE_ADDRESS hex + default 0xf8000000 if USE_NATIVE_RAMINIT default 0xf0000000 endif # !USE_NATIVE_RAMINIT -- To view, visit https://review.coreboot.org/20813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Gerrit-Change-Number: 20813 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: intel/bd82x6x: Replace magic IOBP constants with known names
by build bot (Jenkins) (Code Review) July 28, 2017

July 28, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/16214 ) Change subject: intel/bd82x6x: Replace magic IOBP constants with known names ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57990/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13428/ : SUCCESS -- To view, visit https://review.coreboot.org/16214 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91a828ed076ca10733b47db876fabf5adaa63638 Gerrit-Change-Number: 16214 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 21:39:22 +0000 Gerrit-HasComments: No

1 0