July 2017 - coreboot-gerrit - mail.coreboot.org

Change in coreboot[master]: buildgcc: Update GCC to 7.1.0
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20809 ) Change subject: buildgcc: Update GCC to 7.1.0 ...................................................................... Patch Set 2: Build Unstable https://qa.coreboot.org/job/coreboot-toolchain/346/ : UNSTABLE https://qa.coreboot.org/job/coreboot-gerrit/58004/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13439/ : SUCCESS -- To view, visit https://review.coreboot.org/20809 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85ee0efc6497ba8a38f6295e30524c90c689d909 Gerrit-Change-Number: 20809 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 08:39:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: northbridge/amd/{lx, gx2}: Fix function setShadowRCONF
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20808 ) Change subject: northbridge/amd/{lx,gx2}: Fix function setShadowRCONF ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58002/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13438/ : SUCCESS -- To view, visit https://review.coreboot.org/20808 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d7720121d4730254542372282f5561739e7214b Gerrit-Change-Number: 20808 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 07:27:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20792 ) Change subject: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58000/ : SUCCESS -- To view, visit https://review.coreboot.org/20792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie467f9a18b35ab3b8a523dbf51c5575db5b374a5 Gerrit-Change-Number: 20792 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 07:17:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t*00/romstage: Switch to new hybrid driver
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20794 ) Change subject: mb/lenovo/t*00/romstage: Switch to new hybrid driver ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58001/ : SUCCESS -- To view, visit https://review.coreboot.org/20794 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73 Gerrit-Change-Number: 20794 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 07:02:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t400: Switch to new hybrid graphics driver
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20793 ) Change subject: mb/lenovo/t400: Switch to new hybrid graphics driver ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57999/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13436/ : SUCCESS -- To view, visit https://review.coreboot.org/20793 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad2eccaab19c71f11308853ba9326d8186e67c93 Gerrit-Change-Number: 20793 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 07:01:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20792 ) Change subject: drvs/lenovo/hybrid_graphics: Add new hybrid graphics driver ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57996/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13434/ : SUCCESS -- To view, visit https://review.coreboot.org/20792 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie467f9a18b35ab3b8a523dbf51c5575db5b374a5 Gerrit-Change-Number: 20792 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 06:53:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/t*00/romstage: Switch to new hybrid driver
by build bot (Jenkins) (Code Review) July 29, 2017

July 29, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20794 ) Change subject: mb/lenovo/t*00/romstage: Switch to new hybrid driver ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57997/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13435/ : SUCCESS -- To view, visit https://review.coreboot.org/20794 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf18b75e8afe2568de8498b39a608dac8db3ba73 Gerrit-Change-Number: 20794 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 06:52:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: lib/program.ld: Guard .id section placement
by Raptor Engineering Automated Test Stand (Code Review) July 29, 2017

July 29, 2017

Raptor Engineering Automated Test Stand has posted comments on this change. ( https://review.coreboot.org/20810 ) Change subject: lib/program.ld: Guard .id section placement ...................................................................... Patch Set 1: Verified+1 ASUS KFSN4-DRE: Boot and extended test successful. Boot log: https://testlab.coreboot.org/raptor/1501308964-0-20810,1.log.bz2 QEMU x86_64 Q35: Boot successful. Boot log: https://testlab.coreboot.org/raptor/1501309048-1-20810,1.log.bz2 ASUS KGPE-D16: Boot and extended test successful. Boot log: https://testlab.coreboot.org/raptor/1501309378-3-20810,1.log.bz2 -- To view, visit https://review.coreboot.org/20810 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc7cbd670ce4f75b7790ff8d95578683e355ba7e Gerrit-Change-Number: 20810 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Comment-Date: Sat, 29 Jul 2017 06:23:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
by Felix Held (Code Review) July 29, 2017

July 29, 2017

Felix Held has posted comments on this change. ( https://review.coreboot.org/20813 ) Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/K… File src/northbridge/intel/sandybridge/Kconfig: https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/K… PS2, Line 120: default 0xf8000000 if USE_NATIVE_RAMINIT > this is inside the "if !USE_NATIVE_RAMINIT" block, so if I understand this haven't read the code completely, but it's probably a good idea to leave MMCONF_BASE_ADDRESS at 0xf8000000 for the native ram init in this patch... -- To view, visit https://review.coreboot.org/20813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Gerrit-Change-Number: 20813 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 02:41:38 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults
by Felix Held (Code Review) July 29, 2017

July 29, 2017

Felix Held has posted comments on this change. ( https://review.coreboot.org/20813 ) Change subject: intel/sandybridge: Gather MMCONF_BASE_ADDRESS defaults ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/K… File src/northbridge/intel/sandybridge/Kconfig: https://review.coreboot.org/#/c/20813/2/src/northbridge/intel/sandybridge/K… PS2, Line 120: default 0xf8000000 if USE_NATIVE_RAMINIT this is inside the "if !USE_NATIVE_RAMINIT" block, so if I understand this right, this statement will never be used and MMCONF_BASE_ADDRESS will evaluate to 0. also why don't we also use 0xf0000000 in the native raminit path? -- To view, visit https://review.coreboot.org/20813 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I924c43cec1e36e84db40e4b8e1dd0e05cad2b978 Gerrit-Change-Number: 20813 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: James Ye <jye836(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 01:40:52 +0000 Gerrit-HasComments: Yes

1 0