coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in libgfxinit[master]: gma hsw+: Don't use DDI E if DDI A uses all lanes
by Nico Huber (Code Review) 30 Jul '17

30 Jul '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20821 Change subject: gma hsw+: Don't use DDI E if DDI A uses all lanes ...................................................................... gma hsw+: Don't use DDI E if DDI A uses all lanes DDI E shares its two lanes with DDI A. If DDI A is configured to use all four lanes, DDI E is disabled. As DDI E is the only DDI that can be configured in FDI mode to feed the PCH DAC, treat `Analog` as in- valid in this configuration. Change-Id: I94e9537c9f30d0cbf757b816f38d44e1b43805b3 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/haswell_shared/hw-gfx-gma-port_detect.adb M common/hw-gfx-gma-config.ads.template 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/21/20821/1 diff --git a/common/haswell_shared/hw-gfx-gma-port_detect.adb b/common/haswell_shared/hw-gfx-gma-port_detect.adb index d8a1d07..1302cf0 100644 --- a/common/haswell_shared/hw-gfx-gma-port_detect.adb +++ b/common/haswell_shared/hw-gfx-gma-port_detect.adb @@ -19,6 +19,8 @@ package body HW.GFX.GMA.Port_Detect is + DDI_BUF_CTL_A_LANE_CAPABILITY_X4 : constant := 1 * 2 ** 4; + SFUSE_STRAP_CRT_DAC_CAP_DISABLE : constant := 1 * 2 ** 6; HOTPLUG_CTL_DDI_A_HPD_INPUT_ENABLE : constant := 1 * 2 ** 4; @@ -55,6 +57,7 @@ procedure Initialize is + DDI_A_X4, DAC_Disabled, Internal_Detected, DDI_Detected : Boolean; @@ -71,13 +74,17 @@ DIGI_C => DP2, DIGI_D => DP3); begin - if Config.Has_PCH_DAC then + if Config.Has_DDI_E and Config.Has_PCH_DAC then -- PCH_DAC (_A) + Registers.Is_Set_Mask + (Register => Registers.DDI_BUF_CTL_A, + Mask => DDI_BUF_CTL_A_LANE_CAPABILITY_X4, + Result => DDI_A_X4); Registers.Is_Set_Mask (Register => Registers.SFUSE_STRAP, Mask => SFUSE_STRAP_CRT_DAC_CAP_DISABLE, Result => DAC_Disabled); - Config.Valid_Port (Analog) := not DAC_Disabled; + Config.Valid_Port (Analog) := not (DDI_A_X4 or DAC_Disabled); end if; if Config.Internal_Is_EDP then diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index aba00bb..55696c7 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -91,6 +91,8 @@ Has_DDI_D : constant Boolean := CPU >= Haswell and CPU_Var = Normal and not Has_DDI_PHYs; + Has_DDI_E : constant Boolean := -- might be disabled by x4 eDP + Has_DDI_D; Has_Low_Voltage_Swing : constant Boolean := CPU >= Broxton; -- To view, visit https://review.coreboot.org/20821 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I94e9537c9f30d0cbf757b816f38d44e1b43805b3 Gerrit-Change-Number: 20821 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in libgfxinit[master]: gma hsw+: Revise Has_DDI_D flag
by Nico Huber (Code Review) 30 Jul '17

30 Jul '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/20820 Change subject: gma hsw+: Revise Has_DDI_D flag ...................................................................... gma hsw+: Revise Has_DDI_D flag The GFX Programmer's Reference Manuals (PRMs) aren't clear on this but it's pretty clear from the processor datasheets which SKUs expose which pins: All U/Y processors lack DDI D. Change-Id: I84c40b6bc01091de8a512e21354243c74643e0f5 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-gma-config.ads.template 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/20/20820/1 diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 2bb916a..aba00bb 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -86,15 +86,15 @@ and CPU_Var = ULT) or CPU >= Skylake; - Has_DDI_D : constant Boolean := (CPU in Haswell .. Broadwell - and CPU_Var = Normal) - or CPU >= Skylake; + Has_DDI_PHYs : constant Boolean := CPU = Broxton; + + Has_DDI_D : constant Boolean := CPU >= Haswell and + CPU_Var = Normal and + not Has_DDI_PHYs; Has_Low_Voltage_Swing : constant Boolean := CPU >= Broxton; Need_DP_Aux_Mutex : constant Boolean := False; -- Skylake & (PSR | GTC) - - Has_DDI_PHYs : constant Boolean := CPU = Broxton; ----- GMBUS: ----------- Ungate_GMBUS_Unit_Level : constant Boolean := CPU >= Skylake; -- To view, visit https://review.coreboot.org/20820 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I84c40b6bc01091de8a512e21354243c74643e0f5 Gerrit-Change-Number: 20820 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: CI test: Payloads
by build bot (Jenkins) (Code Review) 29 Jul '17

29 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20668 ) Change subject: CI test: Payloads ...................................................................... Patch Set 3: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58033/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13468/ : SUCCESS -- To view, visit https://review.coreboot.org/20668 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7298595313a8f62b8c94361fb8ec6a3bca86d5ea Gerrit-Change-Number: 20668 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 21:55:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: CI test: Lint-stable
by build bot (Jenkins) (Code Review) 29 Jul '17

29 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/14197 ) Change subject: CI test: Lint-stable ...................................................................... Patch Set 8: Build Failed https://qa.coreboot.org/job/coreboot-gerrit/58034/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/13469/ : SUCCESS -- To view, visit https://review.coreboot.org/14197 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38db15c4d169bfebc443007da883e17a08fadc01 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 8 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 21:50:51 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: CI test: Tools
by build bot (Jenkins) (Code Review) 29 Jul '17

29 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20657 ) Change subject: CI test: Tools ...................................................................... Patch Set 3: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/58032/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/13467/ : SUCCESS -- To view, visit https://review.coreboot.org/20657 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9e479584be451ef7352bdf68694245f822b8da5 Gerrit-Change-Number: 20657 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 21:49:20 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: CI test: Lint-stable
by Martin Roth (Code Review) 29 Jul '17

29 Jul '17

Martin Roth has removed WANG Siyuan from this change. ( https://review.coreboot.org/14197 ) Change subject: CI test: Lint-stable ...................................................................... Removed reviewer WANG Siyuan. -- To view, visit https://review.coreboot.org/14197 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I38db15c4d169bfebc443007da883e17a08fadc01 Gerrit-Change-Number: 14197 Gerrit-PatchSet: 7 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/braswell/Kconfig: select RELOCATABLE_RAMSTAGE
by build bot (Jenkins) (Code Review) 29 Jul '17

29 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20819 ) Change subject: soc/intel/braswell/Kconfig: select RELOCATABLE_RAMSTAGE ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58031/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13466/ : SUCCESS -- To view, visit https://review.coreboot.org/20819 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9071d9b4e3e3a156281d95fae059947c4c26f744 Gerrit-Change-Number: 20819 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 21:11:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/braswell/Kconfig: select RELOCATABLE_RAMSTAGE
by Matt DeVillier (Code Review) 29 Jul '17

29 Jul '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/20819 Change subject: soc/intel/braswell/Kconfig: select RELOCATABLE_RAMSTAGE ...................................................................... soc/intel/braswell/Kconfig: select RELOCATABLE_RAMSTAGE Without RELOCATABLE_RAMSTAGE selected, S3 resume will hang under Linux and Windows. All other Intel SoCs have this selected by default, so this change simply corrects an omission on Braswell. TEST: boot Linux on google/cyan with and without RELOCATABLE_RAMSTAGE selected; observe that S3 resume fails without and succeeds with. Change-Id: I9071d9b4e3e3a156281d95fae059947c4c26f744 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/intel/braswell/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/20819/1 diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig index 36af3fe..cc537e7 100644 --- a/src/soc/intel/braswell/Kconfig +++ b/src/soc/intel/braswell/Kconfig @@ -23,6 +23,7 @@ select HAVE_HARD_RESET select NO_FIXED_XIP_ROM_SIZE select RELOCATABLE_MODULES + select RELOCATABLE_RAMSTAGE select PARALLEL_MP select PCIEXP_ASPM select PCIEXP_CLK_PM -- To view, visit https://review.coreboot.org/20819 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9071d9b4e3e3a156281d95fae059947c4c26f744 Gerrit-Change-Number: 20819 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: board_status: Show help if no arguments are specified
by build bot (Jenkins) (Code Review) 29 Jul '17

29 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20818 ) Change subject: board_status: Show help if no arguments are specified ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/58030/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13465/ : SUCCESS -- To view, visit https://review.coreboot.org/20818 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7d358771b21eaf7fbfefbd62d5da3ffbc44c733 Gerrit-Change-Number: 20818 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 29 Jul 2017 18:41:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: board_status: Show help if no arguments are specified
by David Hendricks (Code Review) 29 Jul '17

29 Jul '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/20818 Change subject: board_status: Show help if no arguments are specified ...................................................................... board_status: Show help if no arguments are specified Change-Id: Ib7d358771b21eaf7fbfefbd62d5da3ffbc44c733 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> --- M util/board_status/board_status.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/20818/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 1dcca71..d8931f5 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -199,6 +199,11 @@ exit $EXIT_FAILURE fi +if [ $# -eq 0 ]; then + show_help + exit $EXIT_SUCCESS +fi + LONGOPTS="clobber,help,image:,remote-host:,upload-results" LONGOPTS="${LONGOPTS},serial-device:,serial-speed:" LONGOPTS="${LONGOPTS},ssh-port:" -- To view, visit https://review.coreboot.org/20818 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7d358771b21eaf7fbfefbd62d5da3ffbc44c733 Gerrit-Change-Number: 20818 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
166
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017