coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: util/crossgcc: Fix typo
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20487 ) Change subject: util/crossgcc: Fix typo ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56646/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12217/ : SUCCESS https://qa.coreboot.org/job/coreboot-toolchain/327/ : SUCCESS -- To view, visit https://review.coreboot.org/20487 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83d2074b6466b0d99507845dc714a11ab2c58271 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 14:17:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/crossgcc: Fix typo
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20487 ) Change subject: util/crossgcc: Fix typo ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-toolchain/326/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/56646/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12217/ : SUCCESS -- To view, visit https://review.coreboot.org/20487 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83d2074b6466b0d99507845dc714a11ab2c58271 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 11:10:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: strip unused data at the end of Tianocore FVs
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20470 ) Change subject: util/cbfstool: strip unused data at the end of Tianocore FVs ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56645/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12216/ : SUCCESS -- To view, visit https://review.coreboot.org/20470 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f128eca10bd56f5a0eb1302903de4a4c78aa568 Gerrit-Change-Number: 20470 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 09:25:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/crossgcc: Fix typo
by Patrick Georgi (Code Review) 07 Jul '17

07 Jul '17

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20487 Change subject: util/crossgcc: Fix typo ...................................................................... util/crossgcc: Fix typo buildgcc was copied to $DEST/share/buildgcc-$VERSION-, missing the commit id description. Change-Id: I83d2074b6466b0d99507845dc714a11ab2c58271 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/20487/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index d04fe5f..d009417 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -1147,7 +1147,7 @@ # for reproducibility PROGNAME=$(basename "$0") rm -f "$DESTDIR$TARGETDIR/share/$PROGNAME-*" -cp "$PROGNAME" "$DESTDIR$TARGETDIR/share/$PROGNAME-$CROSSGCC_VERSION-$CROSGCC_COMMIT" +cp "$PROGNAME" "$DESTDIR$TARGETDIR/share/$PROGNAME-$CROSSGCC_VERSION-$CROSSGCC_COMMIT" cleanup -- To view, visit https://review.coreboot.org/20487 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I83d2074b6466b0d99507845dc714a11ab2c58271 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: autoport: move spi_uvscc and spi_lvscc to devicetree.cb
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20486 ) Change subject: autoport: move spi_uvscc and spi_lvscc to devicetree.cb ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56644/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12215/ : SUCCESS -- To view, visit https://review.coreboot.org/20486 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36866cc793b3ddf9a78fed2e2840958d08327e7d Gerrit-Change-Number: 20486 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 06:04:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: move spi_uvscc and spi_lvscc to devicetree.cb
by Iru Cai (Code Review) 07 Jul '17

07 Jul '17

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/20486 Change subject: autoport: move spi_uvscc and spi_lvscc to devicetree.cb ...................................................................... autoport: move spi_uvscc and spi_lvscc to devicetree.cb Change-Id: I36866cc793b3ddf9a78fed2e2840958d08327e7d Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M util/autoport/bd82x6x.go 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/20486/1 diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 026ae51..0186564 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -179,10 +179,6 @@ /* SPI init */ MainboardIncludes = append(MainboardIncludes, "southbridge/intel/bd82x6x/pch.h") - /* FIXME:XX Move this to runtime. */ - for _, addr := range []uint16{0x38c8, 0x38c4} { - MainboardInit += fmt.Sprintf("\tRCBA32(0x%04x) = 0x%08x;\n", addr, inteltool.RCBA[addr]) - } FADT := ctx.InfoSource.GetACPI()["FACP"] @@ -220,6 +216,8 @@ "p_cnt_throttling_supported": (FormatBool(FADT[104] == 1 && FADT[105] == 3)), "c2_latency": FormatHexLE16(FADT[96:98]), "docking_supported": (FormatBool((FADT[113] & (1 << 1)) != 0)), + "spi_uvscc": fmt.Sprintf("0x%x", inteltool.RCBA[0x38c8]), + "spi_lvscc": fmt.Sprintf("0x%x", inteltool.RCBA[0x38c4] &^ (1 << 23)), }, PCISlots: []PCISlot{ PCISlot{PCIAddr: PCIAddr{Dev: 0x14, Func: 0}, writeEmpty: false, additionalComment: "USB 3.0 Controller"}, -- To view, visit https://review.coreboot.org/20486 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I36866cc793b3ddf9a78fed2e2840958d08327e7d Gerrit-Change-Number: 20486 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com>

1 0

Change in coreboot[master]: [WIP]: mainboard/google/soraka: wacom touchscreen support
by Furquan Shaikh (Code Review) 07 Jul '17

07 Jul '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20476 ) Change subject: [WIP]: mainboard/google/soraka: wacom touchscreen support ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants… PS1, Line 237: 1 Why take the device out of reset here? It should be taken care of by the ACPI power resource. https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/devicetree.cb: https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants… PS1, Line 217: : : : : : : : : : I don't think we should get rid of this node right away. Older proto boards would still be using this. https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants… PS1, Line 218: WCOMNTN2 Is this supposed to be WCOM50C1? https://review.coreboot.org/#/c/20476/1/src/mainboard/google/poppy/variants… PS1, Line 223: " As per datasheet, this should be at least 100ms. -- To view, visit https://review.coreboot.org/20476 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fbae4782c6442149cda57d23c61ed87546621bb Gerrit-Change-Number: 20476 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 05:35:51 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: samsung/lumpy: change HDA codec SSID to fix Windows
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20485 ) Change subject: samsung/lumpy: change HDA codec SSID to fix Windows ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56643/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12214/ : SUCCESS -- To view, visit https://review.coreboot.org/20485 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4195d00d6b18dcd0039747d9883cdf8e1a76f461 Gerrit-Change-Number: 20485 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 03:34:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: samsung/lumpy: change HDA codec SSID to fix Windows
by Matt DeVillier (Code Review) 07 Jul '17

07 Jul '17

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/20485 Change subject: samsung/lumpy: change HDA codec SSID to fix Windows ...................................................................... samsung/lumpy: change HDA codec SSID to fix Windows With the existing SSID, the driver loaded by Windows results in the headphone jack and internal mic being non-functional. With the new SSID, the a functional driver is loaded and everything works correctly. Linux works correctly with either SSID so the change has no impact there. New SSID extracted from Windows drivers (.inf). Change-Id: I4195d00d6b18dcd0039747d9883cdf8e1a76f461 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/samsung/lumpy/hda_verb.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/20485/1 diff --git a/src/mainboard/samsung/lumpy/hda_verb.c b/src/mainboard/samsung/lumpy/hda_verb.c index 9c97f12..252d872 100644 --- a/src/mainboard/samsung/lumpy/hda_verb.c +++ b/src/mainboard/samsung/lumpy/hda_verb.c @@ -18,11 +18,11 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10134210, // Codec Vendor / Device ID: Cirrus Logic CS4210 - 0x144db082, // Subsystem ID + 0x152D0924, // Subsystem ID 0x00000007, // Number of jacks - /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x144db082 */ - AZALIA_SUBVENDOR(0x0, 0x144db082), + /* NID 0x01, HDA Codec Subsystem ID Verb Table: 0x152D0924 */ + AZALIA_SUBVENDOR(0x0, 0x152D0924), 0x00170500, -- To view, visit https://review.coreboot.org/20485 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4195d00d6b18dcd0039747d9883cdf8e1a76f461 Gerrit-Change-Number: 20485 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/purism/librem13v2: Use common gpio macros
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20233 ) Change subject: mainboard/purism/librem13v2: Use common gpio macros ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56642/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12213/ : SUCCESS -- To view, visit https://review.coreboot.org/20233 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib59feff18c8031f48c779d075285f5fa292e6f85 Gerrit-Change-Number: 20233 Gerrit-PatchSet: 9 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 00:49:16 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017