coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 2760p
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18241 ) Change subject: mainboards/hp: Add HP Elitebook 2760p ...................................................................... Patch Set 23: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56651/ : SUCCESS -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 23 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:02:04 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec: add support for KBC1126 in HP laptops
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19072 ) Change subject: ec: add support for KBC1126 in HP laptops ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56654/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12221/ : SUCCESS -- To view, visit https://review.coreboot.org/19072 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b16eb7e26303eda740f52d667dedb7cc04b4ef0 Gerrit-Change-Number: 19072 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:01:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 2760p
by Iru Cai (Code Review) 07 Jul '17

07 Jul '17

Iru Cai has uploaded a new patch set (#23). ( https://review.coreboot.org/18241 ) Change subject: mainboards/hp: Add HP Elitebook 2760p ...................................................................... mainboards/hp: Add HP Elitebook 2760p The code is generated by autoport. The flash chip is socketed beside the WLAN slot. The EHCI debug port is on right side of the laptop beside the RJ11 connector. Things that work: - memory: 0+8G, 4G+8G - Linux (Linux Mint 18.1 with Linux 4.4) - native graphics init + SeaBIOS payload with SeaVGABIOS - all 3 USB ports - WLAN - WWAN - expresscard - S3 suspend and resume - internal flashing after IFD is unlocked and coreboot is flashed - keyboard, trackpoint and touchpad - fan control - AC and battery status Issues: - wacom digitizer - caps lock and num lock LED blink on boot - GRUB payload will freeze (in previous patch sets) Things that are not tested: - WWAN - SD card reader - smart card reader - cable modem (EC) blobs: This laptop uses SMSC KBC1126-NU as EC. It needs two blobs in the flash chip. You can use the tools in util/kbc1126 to extract them from OEM firmware, and use the following configuration to insert them to coreboot image: -> Chipset -> Add firmware images for KBC1126 firmware Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- A src/mainboard/hp/2760p/Kconfig A src/mainboard/hp/2760p/Kconfig.name A src/mainboard/hp/2760p/Makefile.inc A src/mainboard/hp/2760p/acpi/ec.asl A src/mainboard/hp/2760p/acpi/platform.asl A src/mainboard/hp/2760p/acpi/superio.asl A src/mainboard/hp/2760p/acpi_tables.c A src/mainboard/hp/2760p/board_info.txt A src/mainboard/hp/2760p/devicetree.cb A src/mainboard/hp/2760p/dsdt.asl A src/mainboard/hp/2760p/gma-mainboard.ads A src/mainboard/hp/2760p/gpio.c A src/mainboard/hp/2760p/hda_verb.c A src/mainboard/hp/2760p/mainboard.c A src/mainboard/hp/2760p/romstage.c 15 files changed, 756 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/18241/23 -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 23 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/kbc1126: Refactor kbc1126_ec_insert
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20474 ) Change subject: util/kbc1126: Refactor kbc1126_ec_insert ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56650/ : SUCCESS -- To view, visit https://review.coreboot.org/20474 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I053c55253eee00558071d15923e3eb17b1e8410c Gerrit-Change-Number: 20474 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 15:57:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec: add support for KBC1126 in HP laptops
by Iru Cai (Code Review) 07 Jul '17

07 Jul '17

Iru Cai has uploaded a new patch set (#9). ( https://review.coreboot.org/19072 ) Change subject: ec: add support for KBC1126 in HP laptops ...................................................................... ec: add support for KBC1126 in HP laptops - let the coreboot build system insert the two blobs to the coreboot image - fan control support (works on hp/2760p and hp/8470p) - ACPI support Change-Id: I6b16eb7e26303eda740f52d667dedb7cc04b4ef0 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- A src/ec/hp/kbc1126/Kconfig A src/ec/hp/kbc1126/Makefile.inc A src/ec/hp/kbc1126/acpi/ac.asl A src/ec/hp/kbc1126/acpi/battery.asl A src/ec/hp/kbc1126/acpi/ec.asl A src/ec/hp/kbc1126/acpi/lid.asl A src/ec/hp/kbc1126/chip.h A src/ec/hp/kbc1126/early_init.c A src/ec/hp/kbc1126/ec.c A src/ec/hp/kbc1126/ec.h 10 files changed, 1,313 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/19072/9 -- To view, visit https://review.coreboot.org/19072 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b16eb7e26303eda740f52d667dedb7cc04b4ef0 Gerrit-Change-Number: 19072 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/kbc1126: Refactor kbc1126_ec_insert
by Iru Cai (Code Review) 07 Jul '17

07 Jul '17

Iru Cai has uploaded a new patch set (#2). ( https://review.coreboot.org/20474 ) Change subject: util/kbc1126: Refactor kbc1126_ec_insert ...................................................................... util/kbc1126: Refactor kbc1126_ec_insert Add support for setting addresses of blobs only, and using address in memory when ROM is mapped Change-Id: I053c55253eee00558071d15923e3eb17b1e8410c Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M util/kbc1126/kbc1126_ec_insert.c 1 file changed, 62 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/20474/2 -- To view, visit https://review.coreboot.org/20474 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I053c55253eee00558071d15923e3eb17b1e8410c Gerrit-Change-Number: 20474 Gerrit-PatchSet: 2 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/cbfstool: strip unused data at the end of Tianocore FVs
by Patrick Georgi (Code Review) 07 Jul '17

07 Jul '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/20470 ) Change subject: util/cbfstool: strip unused data at the end of Tianocore FVs ...................................................................... Patch Set 2: Thanks for the report! It worked for me on qemu, so I thought I put it out in the open. Let's see what the required minimum of 0xff bytes is to keep things alive (or which field to patch so the code knows when to stop looking) -- To view, visit https://review.coreboot.org/20470 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f128eca10bd56f5a0eb1302903de4a4c78aa568 Gerrit-Change-Number: 20470 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 15:52:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/cbfstool: strip unused data at the end of Tianocore FVs
by Matt DeVillier (Code Review) 07 Jul '17

07 Jul '17

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/20470 ) Change subject: util/cbfstool: strip unused data at the end of Tianocore FVs ...................................................................... Patch Set 2: Code-Review-1 Resulting coreboot image with stripped payload doesn't boot (tested on google/link) -- To view, visit https://review.coreboot.org/20470 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6f128eca10bd56f5a0eb1302903de4a4c78aa568 Gerrit-Change-Number: 20470 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 15:49:59 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Fix keyboard init on first boot
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20488 ) Change subject: ec/lenovo/h8: Fix keyboard init on first boot ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56648/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12219/ : SUCCESS -- To view, visit https://review.coreboot.org/20488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba7e5cb67f3dfeb2bc3d50b28757efa63c84391 Gerrit-Change-Number: 20488 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 15:11:46 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Fix keyboard init on first boot
by Patrick Rudolph (Code Review) 07 Jul '17

07 Jul '17

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/20488 Change subject: ec/lenovo/h8: Fix keyboard init on first boot ...................................................................... ec/lenovo/h8: Fix keyboard init on first boot On first boot after power failure the keyboard does not initialize. After Linux has been booted and the power is kept the keyboard controller can be initialized. Disable keyboard and mouse port and issue a self test. Tested on Lenovo T430. The keyboard is initialized on every boot, even after power failure (no AC and removed battery). Needs tests on other Lenovos. Change-Id: I1ba7e5cb67f3dfeb2bc3d50b28757efa63c84391 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/h8.c 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/20488/1 diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index b259d9a..9b569a5 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -193,8 +193,34 @@ } #endif +#define KBD_DATA 0x60 +#define KBD_COMMAND 0x64 +#define KBD_STATUS 0x64 + +static bool h8_wait_kb_ready(void) +{ + size_t timeout = 1000; + while ((inb(KBD_STATUS) & 2) && timeout) + timeout--; + return timeout > 0; +} + static void h8_init(device_t dev) { + /* Lenovo early keyboard controller init sequence */ + /* Disable keyboard */ + if (h8_wait_kb_ready()) + outb(0xad, KBD_COMMAND); + /* Disable mouse */ + if (h8_wait_kb_ready()) + outb(0xa7, KBD_COMMAND); + /* Clear input buffer */ + if (inb(KBD_STATUS) & 1) + inb(KBD_DATA); + /* Self test, don't read result ... */ + if (h8_wait_kb_ready()) + outb(0xaa, KBD_COMMAND); + pc_keyboard_init(NO_AUX_DEVICE); } -- To view, visit https://review.coreboot.org/20488 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1ba7e5cb67f3dfeb2bc3d50b28757efa63c84391 Gerrit-Change-Number: 20488 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017