coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: superio/ite/it8716f: Update init_ec
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20490 ) Change subject: superio/ite/it8716f: Update init_ec ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56661/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12226/ : SUCCESS -- To view, visit https://review.coreboot.org/20490 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d070e3964609947959de60e2686dfe59fe77e1c Gerrit-Change-Number: 20490 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:23:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 8470p
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18985 ) Change subject: mainboards/hp: Add HP Elitebook 8470p ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56660/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12225/ : SUCCESS -- To view, visit https://review.coreboot.org/18985 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc051e2272b8ea73627940db15a56901d737472 Gerrit-Change-Number: 18985 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:20:26 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: superio/ite/it8716f: Update init_ec
by Martin Roth (Code Review) 07 Jul '17

07 Jul '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20490 Change subject: superio/ite/it8716f: Update init_ec ...................................................................... superio/ite/it8716f: Update init_ec This is a follow-on to the superio IS_ENABLED() patch: https://review.coreboot.org/#/c/20351/1 Change-Id: I7d070e3964609947959de60e2686dfe59fe77e1c Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/superio/ite/it8716f/it8716f.h M src/superio/ite/it8716f/superio.c 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20490/1 diff --git a/src/superio/ite/it8716f/it8716f.h b/src/superio/ite/it8716f/it8716f.h index 3531a13..726c4cc 100644 --- a/src/superio/ite/it8716f/it8716f.h +++ b/src/superio/ite/it8716f/it8716f.h @@ -34,9 +34,7 @@ #define IT8716F_GAME 0x09 /* GAME port */ #define IT8716F_IR 0x0a /* Consumer IR */ -#if IS_ENABLED(CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL) /* Provided by mainboard, called by IT8716F superio.c. */ void init_ec(u16 base); -#endif #endif /* SUPERIO_ITE_IT8716F_H */ diff --git a/src/superio/ite/it8716f/superio.c b/src/superio/ite/it8716f/superio.c index 2ec3875..b4cd5e6 100644 --- a/src/superio/ite/it8716f/superio.c +++ b/src/superio/ite/it8716f/superio.c @@ -29,7 +29,7 @@ #if !IS_ENABLED(CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL) -static void init_ec(u16 base) +void init_ec(u16 base) { u8 value; -- To view, visit https://review.coreboot.org/20490 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7d070e3964609947959de60e2686dfe59fe77e1c Gerrit-Change-Number: 20490 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 2760p
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18241 ) Change subject: mainboards/hp: Add HP Elitebook 2760p ...................................................................... Patch Set 24: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56659/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12224/ : SUCCESS -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 24 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:15:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 8470p
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18985 ) Change subject: mainboards/hp: Add HP Elitebook 8470p ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56657/ : SUCCESS -- To view, visit https://review.coreboot.org/18985 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icbc051e2272b8ea73627940db15a56901d737472 Gerrit-Change-Number: 18985 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:13:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 8470p
by Iru Cai (Code Review) 07 Jul '17

07 Jul '17

Iru Cai has uploaded a new patch set (#9). ( https://review.coreboot.org/18985 ) Change subject: mainboards/hp: Add HP Elitebook 8470p ...................................................................... mainboards/hp: Add HP Elitebook 8470p The code is based on the code generated by autoport. The EHCI debug port is between the DP port and eSATA port. The serial port on dock can also be used for debugging. Tested and work: - memory: 0+4G, 4G+0, 4G+4G - Linux (Arch Linux with kernel 4.10.6) boot from SeaBIOS payload with native graphics init - WLAN - keyboard, trackpoint and touchpad - USB - serial port on dock - fan control - AC and battery status (EC) blobs: This laptop uses SMSC KBC1126 EC, and there are two blobs needed by it. You can use the tools in util/kbc1126/ to extract them and insert them to the coreboot image using the following configuration: -> Chipset -> Add firmware images for KBC1126 firmware Change-Id: Icbc051e2272b8ea73627940db15a56901d737472 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- A src/mainboard/hp/8470p/Kconfig A src/mainboard/hp/8470p/Kconfig.name A src/mainboard/hp/8470p/Makefile.inc A src/mainboard/hp/8470p/acpi/ec.asl A src/mainboard/hp/8470p/acpi/platform.asl A src/mainboard/hp/8470p/acpi/superio.asl A src/mainboard/hp/8470p/acpi_tables.c A src/mainboard/hp/8470p/board_info.txt A src/mainboard/hp/8470p/devicetree.cb A src/mainboard/hp/8470p/dsdt.asl A src/mainboard/hp/8470p/gpio.c A src/mainboard/hp/8470p/hda_verb.c A src/mainboard/hp/8470p/mainboard.c A src/mainboard/hp/8470p/romstage.c 14 files changed, 944 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/18985/9 -- To view, visit https://review.coreboot.org/18985 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icbc051e2272b8ea73627940db15a56901d737472 Gerrit-Change-Number: 18985 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 2760p
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18241 ) Change subject: mainboards/hp: Add HP Elitebook 2760p ...................................................................... Patch Set 24: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56658/ : SUCCESS -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 24 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:11:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/northbridge: add IS_ENABLED() around Kconfig symbol refe...
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20347 ) Change subject: src/northbridge: add IS_ENABLED() around Kconfig symbol references ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56656/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12223/ : SUCCESS -- To view, visit https://review.coreboot.org/20347 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1095944e65bfacd9e878840cc88f8a0a24ecde72 Gerrit-Change-Number: 20347 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:11:11 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 2760p
by Iru Cai (Code Review) 07 Jul '17

07 Jul '17

Iru Cai has uploaded a new patch set (#24). ( https://review.coreboot.org/18241 ) Change subject: mainboards/hp: Add HP Elitebook 2760p ...................................................................... mainboards/hp: Add HP Elitebook 2760p The code is generated by autoport. The flash chip is socketed beside the WLAN slot. The EHCI debug port is on right side of the laptop beside the RJ11 connector. Things that work: - memory: 0+8G, 4G+8G - Linux (Linux Mint 18.1 with Linux 4.4) - native graphics init + SeaBIOS payload with SeaVGABIOS - all 3 USB ports - WLAN - WWAN - expresscard - S3 suspend and resume - internal flashing after IFD is unlocked and coreboot is flashed - keyboard, trackpoint and touchpad - fan control - AC and battery status Issues: - wacom digitizer - caps lock and num lock LED blink on boot - GRUB payload will freeze (in previous patch sets) Things that are not tested: - WWAN - SD card reader - smart card reader - cable modem (EC) blobs: This laptop uses SMSC KBC1126-NU as EC. It needs two blobs in the flash chip. You can use the tools in util/kbc1126 to extract them from OEM firmware, and use the following configuration to insert them to coreboot image: -> Chipset -> Add firmware images for KBC1126 firmware Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- A src/mainboard/hp/2760p/Kconfig A src/mainboard/hp/2760p/Kconfig.name A src/mainboard/hp/2760p/Makefile.inc A src/mainboard/hp/2760p/acpi/ec.asl A src/mainboard/hp/2760p/acpi/platform.asl A src/mainboard/hp/2760p/acpi/superio.asl A src/mainboard/hp/2760p/acpi_tables.c A src/mainboard/hp/2760p/board_info.txt A src/mainboard/hp/2760p/devicetree.cb A src/mainboard/hp/2760p/dsdt.asl A src/mainboard/hp/2760p/gma-mainboard.ads A src/mainboard/hp/2760p/gpio.c A src/mainboard/hp/2760p/hda_verb.c A src/mainboard/hp/2760p/mainboard.c A src/mainboard/hp/2760p/romstage.c 15 files changed, 752 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/18241/24 -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 24 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboards/hp: Add HP Elitebook 2760p
by build bot (Jenkins) (Code Review) 07 Jul '17

07 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18241 ) Change subject: mainboards/hp: Add HP Elitebook 2760p ...................................................................... Patch Set 23: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56655/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/12222/ : SUCCESS -- To view, visit https://review.coreboot.org/18241 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ffdb9f9c71f6c9a84e896abc3c424c8dd4bed0e Gerrit-Change-Number: 18241 Gerrit-PatchSet: 23 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Swift Geek <swiftgeek(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Jul 2017 16:06:19 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017