coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: x86/lapic/secondary.S: Align stack for _secondary_start
by Marshall Dawson (Code Review) 11 Jul '17

11 Jul '17

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/20537 Change subject: x86/lapic/secondary.S: Align stack for _secondary_start ...................................................................... x86/lapic/secondary.S: Align stack for _secondary_start At a process _start, the stack is expected to be aligned to a 16-byte boundary. Upon entry to any function the stack frame must have the end of any arguments also aligned. In other words the value of %esp+4 or %rsp+8 is always a multiple of 16 (1). Align the stack down inside _secondary_start and preserve proper alignment for the call to secondary_cpu_init. Although 4-byte alignment is the minimum requirement for i386, some AMD platforms use SSE instructions which expect 16-byte. 1) http://wiki.osdev.org/System_V_ABI See "Initial Stack and Register State" and "The Stack Frame" in the supplements. BUG=chrome-os-partner:62841664 Change-Id: I72b7a474013e5caf67aedfabeb8d8d2553499b73 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/cpu/x86/lapic/secondary.S 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/20537/1 diff --git a/src/cpu/x86/lapic/secondary.S b/src/cpu/x86/lapic/secondary.S index 0c4c0d0..1bb957d 100644 --- a/src/cpu/x86/lapic/secondary.S +++ b/src/cpu/x86/lapic/secondary.S @@ -55,7 +55,6 @@ ljmpl $0x10, $__ap_protected_start __ap_protected_start: - movw $0x18, %ax movw %ax, %ds movw %ax, %es @@ -69,6 +68,10 @@ /* Set the stack pointer, and flag that we are done */ xorl %eax, %eax movl secondary_stack, %esp + andl $0xfffffff0, %esp + pushl $0x0 /* maintain 16-byte alignment for the call below */ + pushl $0x0 + pushl $0x0 movl secondary_cpu_index, %edi pushl %edi movl %eax, secondary_stack -- To view, visit https://review.coreboot.org/20537 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I72b7a474013e5caf67aedfabeb8d8d2553499b73 Gerrit-Change-Number: 20537 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: google/gru: Add Nefario
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20522 ) Change subject: google/gru: Add Nefario ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56872/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12419/ : SUCCESS -- To view, visit https://review.coreboot.org/20522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb80723ea2573df617026a4a5740adb89331892 Gerrit-Change-Number: 20522 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 23:25:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Override PL2 and SysPL2 values
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20420 ) Change subject: google/fizz: Override PL2 and SysPL2 values ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56871/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12418/ : SUCCESS -- To view, visit https://review.coreboot.org/20420 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c46667fdae9d8eed5346a481753bb69f98a071b Gerrit-Change-Number: 20420 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:34:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Enable wake-on-usb attach/detach
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20421 ) Change subject: google/fizz: Enable wake-on-usb attach/detach ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56870/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12417/ : SUCCESS -- To view, visit https://review.coreboot.org/20421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I214d6557998bdaf1d327c2a45532461b95d56a96 Gerrit-Change-Number: 20421 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:32:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Set PsysPL2 MSR
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20418 ) Change subject: soc/intel/skylake: Set PsysPL2 MSR ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56869/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12416/ : SUCCESS -- To view, visit https://review.coreboot.org/20418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847a8458382e7db1689b426f32ff2dcbc5a0899c Gerrit-Change-Number: 20418 Gerrit-PatchSet: 8 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:32:30 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Enable wake-on-usb attach/detach
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20421 ) Change subject: google/fizz: Enable wake-on-usb attach/detach ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56868/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12414/ : SUCCESS -- To view, visit https://review.coreboot.org/20421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I214d6557998bdaf1d327c2a45532461b95d56a96 Gerrit-Change-Number: 20421 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:26:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Set PsysPL2 MSR
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20418 ) Change subject: soc/intel/skylake: Set PsysPL2 MSR ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56866/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12413/ : SUCCESS -- To view, visit https://review.coreboot.org/20418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847a8458382e7db1689b426f32ff2dcbc5a0899c Gerrit-Change-Number: 20418 Gerrit-PatchSet: 7 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:24:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Override PL2 and SysPL2 values
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20420 ) Change subject: google/fizz: Override PL2 and SysPL2 values ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/56867/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/12415/ : SUCCESS -- To view, visit https://review.coreboot.org/20420 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c46667fdae9d8eed5346a481753bb69f98a071b Gerrit-Change-Number: 20420 Gerrit-PatchSet: 5 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:20:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/fizz: Enable wake-on-usb attach/detach
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20421 ) Change subject: google/fizz: Enable wake-on-usb attach/detach ...................................................................... Patch Set 4: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56865/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/12412/ : ABORTED -- To view, visit https://review.coreboot.org/20421 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I214d6557998bdaf1d327c2a45532461b95d56a96 Gerrit-Change-Number: 20421 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:15:25 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Set PsysPL2 MSR
by build bot (Jenkins) (Code Review) 11 Jul '17

11 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20418 ) Change subject: soc/intel/skylake: Set PsysPL2 MSR ...................................................................... Patch Set 6: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/56863/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/12410/ : SUCCESS -- To view, visit https://review.coreboot.org/20418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I847a8458382e7db1689b426f32ff2dcbc5a0899c Gerrit-Change-Number: 20418 Gerrit-PatchSet: 6 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 11 Jul 2017 21:15:24 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017