coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: payloads: change coreboot to lowercase
by Philippe Mathieu-Daudé (Code Review) 04 Jun '17

04 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20028 ) Change subject: payloads: change coreboot to lowercase ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20028 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ec18ca55e0ea672343a951ab81a24a5630f45fd Gerrit-Change-Number: 20028 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 12:54:41 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: Documentation: change coreboot to lowercase
by Philippe Mathieu-Daudé (Code Review) 04 Jun '17

04 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20031 ) Change subject: Documentation: change coreboot to lowercase ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20031 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79824da8a9ed36a1e4fe23a1711a89535267bf5f Gerrit-Change-Number: 20031 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 12:54:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src: change coreboot to lowercase
by Philippe Mathieu-Daudé (Code Review) 04 Jun '17

04 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20029 ) Change subject: src: change coreboot to lowercase ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20029 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7945ddb988262e7483da4e623cedf972380e65a2 Gerrit-Change-Number: 20029 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 12:53:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util: change coreboot to lowercase
by Philippe Mathieu-Daudé (Code Review) 04 Jun '17

04 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20030 ) Change subject: util: change coreboot to lowercase ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/20030/1/util/optionlist/README File util/optionlist/README: https://review.coreboot.org/#/c/20030/1/util/optionlist/README@1 PS1, Line 1: coreboot_Options wiki pages start with caps but this link works as it redirects. -- To view, visit https://review.coreboot.org/20030 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a024d82d331c0794fe087e440b4e1924129a13c Gerrit-Change-Number: 20030 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 12:52:05 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: superio/ite/it8720f: add new IT8720F Super I/O
by Arthur Heymans (Code Review) 04 Jun '17

04 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20026 ) Change subject: superio/ite/it8720f: add new IT8720F Super I/O ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/20026/1/src/superio/ite/common/env_ctrl.c File src/superio/ite/common/env_ctrl.c: https://review.coreboot.org/#/c/20026/1/src/superio/ite/common/env_ctrl.c@1… PS1, Line 101: u8 not related to this patch? -- To view, visit https://review.coreboot.org/20026 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a6fe91a772d78f4d122a6c516feff8658ada0a Gerrit-Change-Number: 20026 Gerrit-PatchSet: 1 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 10:34:23 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/foxconn/g41s-k: add new mainboard
by Arthur Heymans (Code Review) 04 Jun '17

04 Jun '17

1 0

Change in coreboot[master]: mb/foxconn/g41s-k: add new mainboard
by Arthur Heymans (Code Review) 04 Jun '17

04 Jun '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20027 ) Change subject: mb/foxconn/g41s-k: add new mainboard ...................................................................... Patch Set 1: (17 comments) Looks quite ok! just a few suggestions for improvements. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/acpi/i… File src/mainboard/foxconn/g41s-k/acpi/ich7_pci_irqs.asl: https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/acpi/i… PS1, Line 1: /* It looks like there are no PCI devices on this board. did you find this in vendor DSDT? https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/acpi/x… File src/mainboard/foxconn/g41s-k/acpi/x4x_pci_irqs.asl: https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/acpi/x… PS1, Line 26: Package() { 0x0001ffff, 1, 0, 0x11 }, : Package() { 0x0001ffff, 2, 0, 0x12 }, : Package() { 0x0001ffff, 3, 0, 0x13 }, I don't think it has anything but PINA, so can be removed. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/acpi/x… PS1, Line 43: CI Bridge while correct, those IRQ are used for AC ‘97 Audio Pin (AAIP) -> PINA and AC ‘97 Modem Pin (AMIP) -> PINB https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/acpi/x… PS1, Line 54: Package() { 0x0001ffff, 1, \_SB.PCI0.LPCB.LNKB, 0 }, : Package() { 0x0001ffff, 2, \_SB.PCI0.LPCB.LNKC, 0 }, : Package() { 0x0001ffff, 3, \_SB.PCI0.LPCB.LNKD, 0 }, same. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… File src/mainboard/foxconn/g41s-k/devicetree.cb: https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 41: register "pirqa_routing" = "0x0a" : register "pirqb_routing" = "0x0b" : register "pirqc_routing" = "0x0a" : register "pirqd_routing" = "0x05" : register "pirqe_routing" = "0x0a" : register "pirqf_routing" = "0x0b" : register "pirqg_routing" = "0x0a" : register "pirqh_routing" = "0x03" often we set all these to 11. only matters in PIC mode which modern OS don't use by default. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 118: irq 0xf0 = 0x00 : irq 0xf1 = 0x50 default. no need to have this here https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 125: irq 0xf1 = 0x50 default. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 133: irq 0xf1 = 0x00 default https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 135: irq 0xf3 = 0x00 default https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 137: rq 0xf5 = 0x00 : irq 0xf6 = 0x00 default https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 148: irq 0xf0 = 0x00 default https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 154: irq 0xf0 = 0x00 : irq 0xf1 = 0x00 : irq 0xf2 = 0x00 : irq 0xf3 = 0x00 : irq 0xf4 = 0x00 : irq 0xf5 = 0x00 : irq 0xf6 = 0x22 : irq 0xf7 = 0x00 : irq 0xf8 = 0x00 : irq 0xf9 = 0x00 : irq 0xfa = 0x00 : irq 0xfb = 0x00 : irq 0xfd = 0x00 : irq 0xfe = 0x00 default is 0 on all these, so just leave 0xf6? https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/device… PS1, Line 172: irq 0xf0 = 0x00 default https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/dsdt.a… File src/mainboard/foxconn/g41s-k/dsdt.asl: https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/dsdt.a… PS1, Line 36: #include <southbridge/intel/i82801gx/acpi/ich7.asl> maybe remove if there is no PCI device. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/romsta… File src/mainboard/foxconn/g41s-k/romstage.c: https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/romsta… PS1, Line 60: RCBA16(D31IR) = 0x0132; : RCBA16(D30IR) = 0x3241; : RCBA16(D29IR) = 0x0237; no need to do this but if you want you can leave this at defaults, and have A,B,C,D for each relevant pin in ACPI PIRQ routing. https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/romsta… PS1, Line 80: a0 is actually 0xa00 https://review.coreboot.org/#/c/20027/1/src/mainboard/foxconn/g41s-k/romsta… PS1, Line 87: 0x50, 0, 0x52 The board has only one dimm slot? removing it would save a bit of time in raminit since it is one dimm less to probe. -- To view, visit https://review.coreboot.org/20027 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc4c8935b1a11e55f4bf6cfa484a8a8d09b1adda Gerrit-Change-Number: 20027 Gerrit-PatchSet: 1 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 07:50:23 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: Documentation: change coreboot to lowercase
by build bot (Jenkins) (Code Review) 04 Jun '17

04 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20031 ) Change subject: Documentation: change coreboot to lowercase ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10551/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54851/ : SUCCESS -- To view, visit https://review.coreboot.org/20031 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79824da8a9ed36a1e4fe23a1711a89535267bf5f Gerrit-Change-Number: 20031 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 03:45:23 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src: change coreboot to lowercase
by build bot (Jenkins) (Code Review) 04 Jun '17

04 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20029 ) Change subject: src: change coreboot to lowercase ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10550/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54850/ : SUCCESS -- To view, visit https://review.coreboot.org/20029 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7945ddb988262e7483da4e623cedf972380e65a2 Gerrit-Change-Number: 20029 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 03:42:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: util: change coreboot to lowercase
by build bot (Jenkins) (Code Review) 04 Jun '17

04 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20030 ) Change subject: util: change coreboot to lowercase ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10549/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54849/ : SUCCESS -- To view, visit https://review.coreboot.org/20030 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a024d82d331c0794fe087e440b4e1924129a13c Gerrit-Change-Number: 20030 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 03:38:31 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017