coreboot-gerrit June 2017

coreboot-gerrit@coreboot.org

1 participants
2269 discussions

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by build bot (Jenkins) (Code Review) 05 Jun '17

05 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19603 ) Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... Patch Set 68: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10556/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54856/ : SUCCESS -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-Change-Number: 19603 Gerrit-PatchSet: 68 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Jun 2017 05:21:44 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Use common gpio for apollolake[WIP]
by build bot (Jenkins) (Code Review) 05 Jun '17

05 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19949 ) Change subject: soc/intel/apollolake: Use common gpio for apollolake[WIP] ...................................................................... Patch Set 16: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10555/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54855/ : SUCCESS -- To view, visit https://review.coreboot.org/19949 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fcc22df5eaec014f3b89755415f051b05aa554a Gerrit-Change-Number: 19949 Gerrit-PatchSet: 16 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 05 Jun 2017 05:16:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: common/block/cse: Use CSE PCH ID from device/pci_ids.h
by Subrata Banik (Code Review) 05 Jun '17

05 Jun '17

Subrata Banik has abandoned this change. ( https://review.coreboot.org/19568 ) Change subject: common/block/cse: Use CSE PCH ID from device/pci_ids.h ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/19568 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ic92d17b2819c39997bbffff8293c937f3f73776b Gerrit-Change-Number: 19568 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: [WIP]nb/intel/sandybridge/raminit: Advertise correct frequency
by Martin Roth (Code Review) 04 Jun '17

04 Jun '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19995 ) Change subject: [WIP]nb/intel/sandybridge/raminit: Advertise correct frequency ...................................................................... Patch Set 1: Still marked as WIP, so waiting to submit. -- To view, visit https://review.coreboot.org/19995 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8481564fe96af29ac31482a7f03bb88f343326f4 Gerrit-Change-Number: 19995 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 19:39:58 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: payloads: change coreboot to lowercase
by Philipp Deppenwiese (Code Review) 04 Jun '17

04 Jun '17

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/20028 ) Change subject: payloads: change coreboot to lowercase ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/20028 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ec18ca55e0ea672343a951ab81a24a5630f45fd Gerrit-Change-Number: 20028 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 17:02:03 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/ene_kb3940q: correct ACPI battery data fed into ToString()
by Martin Roth (Code Review) 04 Jun '17

04 Jun '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19961 ) Change subject: ec/ene_kb3940q: correct ACPI battery data fed into ToString() ...................................................................... ec/ene_kb3940q: correct ACPI battery data fed into ToString() ToString() requires the input buffer data to be null-terminated, but the data returned by the EC is not, leading Windows to fail to report any battery data at all. Correct this by concatenating a null terminator (0x00) to the end of the buffer data before inputting to ToString() where needed TEST: boot Windows on google/butterfly, observe battery data reported correctly. Change-Id: I395cc7fbdf26c8cc816e47107e552c0533580fa1 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/19961 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/ec/quanta/ene_kb3940q/acpi/battery.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/ec/quanta/ene_kb3940q/acpi/battery.asl b/src/ec/quanta/ene_kb3940q/acpi/battery.asl index bcc9a98..dd9ba2f 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/battery.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/battery.asl @@ -90,9 +90,9 @@ Store(Local0, Index(PBIF, 5)) Multiply(Local1, 0x05, Local0) Store (Local0, Index (PBIF, 6)) - Store (ToString(BATD), Index (PBIF, 9)) // Model Number + Store (ToString(Concatenate(BATD, 0x00)), Index (PBIF, 9)) // Model Number Store (ToDecimalString(BSN0), Index (PBIF, 10)) // Serial Number - Store (ToString(BCHM), Index (PBIF, 11)) // Battery Type + Store (ToString(Concatenate(BCHM, 0x00)), Index (PBIF, 11)) // Battery Type Store (\BATV, Index (PBIF, 12)) // OEM information Return (PBIF) -- To view, visit https://review.coreboot.org/19961 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I395cc7fbdf26c8cc816e47107e552c0533580fa1 Gerrit-Change-Number: 19961 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/parrot: make chromeos.c compilation conditional on CO...
by Martin Roth (Code Review) 04 Jun '17

04 Jun '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19959 ) Change subject: google/parrot: make chromeos.c compilation conditional on CONFIG_CHROMEOS ...................................................................... google/parrot: make chromeos.c compilation conditional on CONFIG_CHROMEOS No reason to compile/include chromeos.c for non-ChromeOS builds Change-Id: Ie8ef1f4c521b2a7308941299f2501073937bdf4a Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/19959 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/parrot/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/parrot/Makefile.inc b/src/mainboard/google/parrot/Makefile.inc index 78e5b98..a76bc12 100644 --- a/src/mainboard/google/parrot/Makefile.inc +++ b/src/mainboard/google/parrot/Makefile.inc @@ -15,6 +15,6 @@ ramstage-y += ec.c -romstage-y += chromeos.c -ramstage-y += chromeos.c +romstage-$(CONFIG_CHROMEOS) += chromeos.c +ramstage-$(CONFIG_CHROMEOS) += chromeos.c romstage-y += gpio.c -- To view, visit https://review.coreboot.org/19959 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie8ef1f4c521b2a7308941299f2501073937bdf4a Gerrit-Change-Number: 19959 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: google/lulu: enable SATA device to sleep in S0
by Martin Roth (Code Review) 04 Jun '17

04 Jun '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19957 ) Change subject: google/lulu: enable SATA device to sleep in S0 ...................................................................... google/lulu: enable SATA device to sleep in S0 sata_devslp_disable was set to work around some buggy SSD firmware, but as it's disabled by default in both Linux and Windows, no reason to disable at the firmware level when many properly-functioning SSDs can take advantage of power savings. Change-Id: Ib15f8b51db19b3d9d2e135f85c71a15a45a2ffbd Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/19957 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/auron/variants/lulu/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/auron/variants/lulu/devicetree.cb b/src/mainboard/google/auron/variants/lulu/devicetree.cb index 9f086a6..84fc8c4 100644 --- a/src/mainboard/google/auron/variants/lulu/devicetree.cb +++ b/src/mainboard/google/auron/variants/lulu/devicetree.cb @@ -43,7 +43,6 @@ register "gpe0_en_4" = "0x00000000" register "sata_port_map" = "0x1" - register "sata_devslp_disable" = "1" register "sio_acpi_mode" = "1" -- To view, visit https://review.coreboot.org/19957 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib15f8b51db19b3d9d2e135f85c71a15a45a2ffbd Gerrit-Change-Number: 19957 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: superiotool: Add SMSC KBC1126
by build bot (Jenkins) (Code Review) 04 Jun '17

04 Jun '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18480 ) Change subject: superiotool: Add SMSC KBC1126 ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10553/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54853/ : SUCCESS -- To view, visit https://review.coreboot.org/18480 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id172ae42411a6d42a4ae7c7f30f96aeda3e6c384 Gerrit-Change-Number: 18480 Gerrit-PatchSet: 7 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 13:23:56 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: superio/ite/it8728f: remove unused header
by Philippe Mathieu-Daudé (Code Review) 04 Jun '17

04 Jun '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/20025 ) Change subject: superio/ite/it8728f: remove unused header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/20025 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbf95ffd6d13cae4e6864e0320ce6ce1cf3ae4d Gerrit-Change-Number: 20025 Gerrit-PatchSet: 1 Gerrit-Owner: Samuel Holland <samuel(a)sholland.org> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 04 Jun 2017 12:54:57 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2017