Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 )
Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/19759/11/src/soc/intel/common/block/include…
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
PS11, Line 20: #define LO 0
: #define HI 1
I was using this in https://review.coreboot.org/#/c/19604/35/src/mainboard/intel/glkrvp/variant…
But can remove this and make the 1 or 0 directly
PS11, Line 176: PAD_CFG_GPO_1
I'll change this to PAD_CFG_GPO_IOSTATE_IOTERM
--
To view, visit https://review.coreboot.org/19759
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com>
Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19887
to look at the new patch set (#2).
Change subject: purism/librem13v2: various devicetree fixes
......................................................................
purism/librem13v2: various devicetree fixes
Also remove a couple of useless uart config options
Change-Id: Id03b1b6abcc8bb326ee7c2484c273422325b34ab
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/purism/librem13v2/Kconfig
M src/mainboard/purism/librem13v2/devicetree.cb
M src/mainboard/purism/librem13v2/romstage.c
3 files changed, 18 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/19887/2
--
To view, visit https://review.coreboot.org/19887
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id03b1b6abcc8bb326ee7c2484c273422325b34ab
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19884
to look at the new patch set (#2).
Change subject: purism/librem13v2: Add memory init code
......................................................................
purism/librem13v2: Add memory init code
Adding code to setup the spd information from sodimm
Change-Id: I7869252710fafef8e207fd99ed0767e709045bd5
Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm>
---
M src/mainboard/purism/librem13v2/Kconfig
M src/mainboard/purism/librem13v2/Makefile.inc
A src/mainboard/purism/librem13v2/bootblock_mainboard.c
M src/mainboard/purism/librem13v2/devicetree.cb
M src/mainboard/purism/librem13v2/gpio.h
M src/mainboard/purism/librem13v2/romstage.c
6 files changed, 98 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/19884/2
--
To view, visit https://review.coreboot.org/19884
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7869252710fafef8e207fd99ed0767e709045bd5
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19603
to look at the new patch set (#53).
Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................
soc/intel/apollolake: Bring in delta for GLK SOC
Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Signed-off-by: Hannah Williams <hannah.williams(a)intel.com>
---
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/apollolake/Makefile.inc
R src/soc/intel/apollolake/acpi/gpio_apl.asl
C src/soc/intel/apollolake/acpi/gpio_glk.asl
M src/soc/intel/apollolake/acpi/gpiolib.asl
R src/soc/intel/apollolake/acpi/lpc_apl.asl
A src/soc/intel/apollolake/acpi/lpc_glk.asl
R src/soc/intel/apollolake/acpi/lpss_apl.asl
A src/soc/intel/apollolake/acpi/lpss_glk.asl
M src/soc/intel/apollolake/acpi/southbridge.asl
M src/soc/intel/apollolake/bootblock/bootblock.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/chip.h
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/apollolake/dsp.c
A src/soc/intel/apollolake/gpio_apl.c
A src/soc/intel/apollolake/gpio_glk.c
M src/soc/intel/apollolake/graphics.c
M src/soc/intel/apollolake/include/soc/cpu.h
M src/soc/intel/apollolake/include/soc/gpio.h
A src/soc/intel/apollolake/include/soc/gpio_apl.h
A src/soc/intel/apollolake/include/soc/gpio_glk.h
A src/soc/intel/apollolake/include/soc/pci_apl_ids.h
A src/soc/intel/apollolake/include/soc/pci_glk_ids.h
M src/soc/intel/apollolake/include/soc/pci_ids.h
M src/soc/intel/apollolake/include/soc/pcr_ids.h
M src/soc/intel/apollolake/lpc.c
M src/soc/intel/apollolake/lpc_lib.c
M src/soc/intel/apollolake/northbridge.c
M src/soc/intel/apollolake/p2sb.c
M src/soc/intel/apollolake/pmc.c
M src/soc/intel/apollolake/pmutil.c
M src/soc/intel/apollolake/romstage.c
M src/soc/intel/apollolake/sd.c
M src/soc/intel/apollolake/uart_early.c
35 files changed, 1,680 insertions(+), 264 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19603/53
--
To view, visit https://review.coreboot.org/19603
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 53
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>