Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/18780 )
Change subject: Makefile: Remove -gnatg from ADAFLAGS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/18780
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9c6d1d5b68168d1608187aad2eae5aead759f9
Gerrit-PatchSet: 2
Gerrit-Project: libhwbase
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-HasComments: No
Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 )
Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................
Patch Set 50:
(1 comment)
https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:
PS50, Line 294: default CAR_CQOS if !SOC_INTEL_GLK
: default CAR_NEM if SOC_INTEL_GLK
> Maybe get rid of the second if?
We need to debug this for GLK - it wasn't working when enabled, so we defaulted it to NEM
--
To view, visit https://review.coreboot.org/19603
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 50
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: Yes