coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/lenovo/t430: Fix hot-plug ports
by Arthur Heymans (Code Review) 26 May '17

26 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19928 ) Change subject: mb/lenovo/t430: Fix hot-plug ports ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/19928/1//COMMIT_MSG Commit Message: Line 7: mb/lenovo/t430: Fix hot-plug ports maybe "PCIe hot-plug ports"? -- To view, visit https://review.coreboot.org/19928 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d3d4c7541683a6c09aac47ca251a6dad23ad1ab Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: [RFC] util/hugo: Add pre-processing
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19922 ) Change subject: [RFC] util/hugo: Add pre-processing ...................................................................... Patch Set 1: so I like the "local" target. As for the line break / hyphenation thing, what is that good for? markdown should do a pretty reasonable job there, no? -- To view, visit https://review.coreboot.org/19922 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bb9365e84348997b04ef027b25e316fdac1ad5d Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: no need to enable an interactive terminal
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19930 ) Change subject: util/hugo: no need to enable an interactive terminal ...................................................................... util/hugo: no need to enable an interactive terminal Change-Id: Iac4cdb003b2fe967b303c1f8e0eeb61673a02858 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: https://review.coreboot.org/19930 Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> Tested-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/hugo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Patrick Georgi: Verified; Looks good to me, approved diff --git a/util/hugo/Makefile b/util/hugo/Makefile index 9a95536..d76c00a 100644 --- a/util/hugo/Makefile +++ b/util/hugo/Makefile @@ -10,4 +10,4 @@ git clone https://github.com/digitalcraftsman/hugo-material-docs.git themes/hugo-material-docs public: themes/hugo-material-docs - docker run --rm -it -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir + docker run --rm -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir -- To view, visit https://review.coreboot.org/19930 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac4cdb003b2fe967b303c1f8e0eeb61673a02858 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/hugo: no need to enable an interactive terminal
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19930 ) Change subject: util/hugo: no need to enable an interactive terminal ...................................................................... Patch Set 1: Verified+1 Code-Review+2 skipping the queue to enable server side updates -- To view, visit https://review.coreboot.org/19930 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac4cdb003b2fe967b303c1f8e0eeb61673a02858 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: mark source mounts read-only
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19929 ) Change subject: util/hugo: mark source mounts read-only ...................................................................... util/hugo: mark source mounts read-only hugo has no need to write there, it should only write to the output directory. Change-Id: Ie320f5017feccfa2e9ecba3c802e040487b44d67 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: https://review.coreboot.org/19929 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/hugo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/util/hugo/Makefile b/util/hugo/Makefile index d49c57d..9a95536 100644 --- a/util/hugo/Makefile +++ b/util/hugo/Makefile @@ -10,4 +10,4 @@ git clone https://github.com/digitalcraftsman/hugo-material-docs.git themes/hugo-material-docs public: themes/hugo-material-docs - docker run --rm -it -v $$PWD:/src -v $$PWD/../../Documentation:/src/content -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir + docker run --rm -it -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir -- To view, visit https://review.coreboot.org/19929 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie320f5017feccfa2e9ecba3c802e040487b44d67 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/hugo: mark source mounts read-only
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/19929 ) Change subject: util/hugo: mark source mounts read-only ...................................................................... Patch Set 1: Code-Review+2 skipping the queue to enable server-side updates -- To view, visit https://review.coreboot.org/19929 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie320f5017feccfa2e9ecba3c802e040487b44d67 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: no need to enable an interactive terminal
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has uploaded a new change for review. ( https://review.coreboot.org/19930 ) Change subject: util/hugo: no need to enable an interactive terminal ...................................................................... util/hugo: no need to enable an interactive terminal Change-Id: Iac4cdb003b2fe967b303c1f8e0eeb61673a02858 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- M util/hugo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/19930/1 diff --git a/util/hugo/Makefile b/util/hugo/Makefile index 9a95536..d76c00a 100644 --- a/util/hugo/Makefile +++ b/util/hugo/Makefile @@ -10,4 +10,4 @@ git clone https://github.com/digitalcraftsman/hugo-material-docs.git themes/hugo-material-docs public: themes/hugo-material-docs - docker run --rm -it -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir + docker run --rm -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir -- To view, visit https://review.coreboot.org/19930 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac4cdb003b2fe967b303c1f8e0eeb61673a02858 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: ec/librem/ec: Fix offset for Bluetooth enable (BTLE)
by Youness Alaoui (Code Review) 26 May '17

26 May '17

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19897 ) Change subject: ec/librem/ec: Fix offset for Bluetooth enable (BTLE) ...................................................................... Patch Set 3: > also ok on librem13v1? Yes. I checked original DSDT on both v1 and v2. The Bluetooth module requires a binary firmware, so there's no BT support in PureOS, which is why I didn't notice it before. -- To view, visit https://review.coreboot.org/19897 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68dc99e72a09f7affbcd691d03dd4607a898313e Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: mark source mounts read-only
by build bot (Jenkins) (Code Review) 26 May '17

26 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19929 ) Change subject: util/hugo: mark source mounts read-only ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10170/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54448/ : SUCCESS -- To view, visit https://review.coreboot.org/19929 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie320f5017feccfa2e9ecba3c802e040487b44d67 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/hugo: mark source mounts read-only
by Patrick Georgi (Code Review) 26 May '17

26 May '17

Patrick Georgi has uploaded a new change for review. ( https://review.coreboot.org/19929 ) Change subject: util/hugo: mark source mounts read-only ...................................................................... util/hugo: mark source mounts read-only hugo has no need to write there, it should only write to the output directory. Change-Id: Ie320f5017feccfa2e9ecba3c802e040487b44d67 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- M util/hugo/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/19929/1 diff --git a/util/hugo/Makefile b/util/hugo/Makefile index d49c57d..9a95536 100644 --- a/util/hugo/Makefile +++ b/util/hugo/Makefile @@ -10,4 +10,4 @@ git clone https://github.com/digitalcraftsman/hugo-material-docs.git themes/hugo-material-docs public: themes/hugo-material-docs - docker run --rm -it -v $$PWD:/src -v $$PWD/../../Documentation:/src/content -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir + docker run --rm -it -v $$PWD:/src:ro -v $$PWD/../../Documentation:/src/content:ro -v /srv/www/vhosts/www.coreboot.org/Documentation:/src/public jguyomard/hugo-builder hugo --forceSyncStatic --cleanDestinationDir -- To view, visit https://review.coreboot.org/19929 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie320f5017feccfa2e9ecba3c802e040487b44d67 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017