Youness Alaoui has uploaded a new change for review. ( https://review.coreboot.org/19936 )
Change subject: purism/librem13v2: Add microcode values in Kconfig
......................................................................
purism/librem13v2: Add microcode values in Kconfig
The FSP Temp RAM init will fail if the mircocode values are set
to 0. A valid microcode update needs to be included and its size
and offset need to be set in the config.
Change-Id: I26d05bd7b37c8d91bf34f399c7c4189f9d3dd34a
Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm>
---
M src/mainboard/purism/librem13v2/Kconfig
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/19936/1
diff --git a/src/mainboard/purism/librem13v2/Kconfig b/src/mainboard/purism/librem13v2/Kconfig
index dd152ad..39866e1 100644
--- a/src/mainboard/purism/librem13v2/Kconfig
+++ b/src/mainboard/purism/librem13v2/Kconfig
@@ -55,5 +55,12 @@
int
default 512
+config CPU_MICROCODE_CBFS_LEN
+ hex
+ default 0x17800
+
+config CPU_MICROCODE_CBFS_LOC
+ hex
+ default 0xFFE115A0
endif
--
To view, visit https://review.coreboot.org/19936
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26d05bd7b37c8d91bf34f399c7c4189f9d3dd34a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>
Hello Matt DeVillier,
I'd like you to do a code review. Please visit
https://review.coreboot.org/19933
to review the following change.
Change subject: purism/librem13v2: Select SERIRQ_CONTINUOUS_MODE
......................................................................
purism/librem13v2: Select SERIRQ_CONTINUOUS_MODE
Like other devices using ENE embedded controllers, the librem13v2
requires this config option for the PS2 keyboard and mouse
(trackpad) to function properly.
Change-Id: Ifba13b93a1fe2e76b2790d1c273fd9e2b5368ab0
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/purism/librem13v2/Kconfig
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/19933/1
diff --git a/src/mainboard/purism/librem13v2/Kconfig b/src/mainboard/purism/librem13v2/Kconfig
index b395b3c..f3cbffc 100644
--- a/src/mainboard/purism/librem13v2/Kconfig
+++ b/src/mainboard/purism/librem13v2/Kconfig
@@ -10,6 +10,8 @@
select HAVE_ACPI_TABLES
select MONOTONIC_TIMER_MSR
select SOC_INTEL_SKYLAKE
+ # Workaround for EC/KBC IRQ1
+ select SERIRQ_CONTINUOUS_MODE
config IRQ_SLOT_COUNT
int
--
To view, visit https://review.coreboot.org/19933
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifba13b93a1fe2e76b2790d1c273fd9e2b5368ab0
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Youness Alaoui has uploaded a new change for review. ( https://review.coreboot.org/19931 )
Change subject: purism/librem13v1: Rename librem13 to librem13v1
......................................................................
purism/librem13v1: Rename librem13 to librem13v1
A simple rename of the directory and the config values
and string in Kconfig/Kconfig.name/board_info.txt
It will be less confusing for users since the first models
are referred to as 'v1' everywhere now.
Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb
Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm>
---
D src/mainboard/purism/librem13/Kconfig.name
R src/mainboard/purism/librem13v1/Kconfig
A src/mainboard/purism/librem13v1/Kconfig.name
R src/mainboard/purism/librem13v1/Makefile.inc
R src/mainboard/purism/librem13v1/acpi/ec.asl
R src/mainboard/purism/librem13v1/acpi/mainboard.asl
R src/mainboard/purism/librem13v1/acpi/superio.asl
R src/mainboard/purism/librem13v1/acpi_tables.c
R src/mainboard/purism/librem13v1/board_info.txt
R src/mainboard/purism/librem13v1/devicetree.cb
R src/mainboard/purism/librem13v1/dsdt.asl
R src/mainboard/purism/librem13v1/fadt.c
R src/mainboard/purism/librem13v1/gpio.h
R src/mainboard/purism/librem13v1/hda_verb.c
R src/mainboard/purism/librem13v1/mainboard.c
R src/mainboard/purism/librem13v1/pei_data.c
R src/mainboard/purism/librem13v1/romstage.c
17 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/19931/1
diff --git a/src/mainboard/purism/librem13/Kconfig.name b/src/mainboard/purism/librem13/Kconfig.name
deleted file mode 100644
index bcc8cd2..0000000
--- a/src/mainboard/purism/librem13/Kconfig.name
+++ /dev/null
@@ -1,2 +0,0 @@
-config BOARD_PURISM_LIBREM13
- bool "Librem 13"
diff --git a/src/mainboard/purism/librem13/Kconfig b/src/mainboard/purism/librem13v1/Kconfig
similarity index 91%
rename from src/mainboard/purism/librem13/Kconfig
rename to src/mainboard/purism/librem13v1/Kconfig
index 747e5ad..299877e 100644
--- a/src/mainboard/purism/librem13/Kconfig
+++ b/src/mainboard/purism/librem13v1/Kconfig
@@ -1,4 +1,4 @@
-if BOARD_PURISM_LIBREM13
+if BOARD_PURISM_LIBREM13_V1
config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y
@@ -31,11 +31,11 @@
config MAINBOARD_DIR
string
- default purism/librem13
+ default purism/librem13v1
config MAINBOARD_PART_NUMBER
string
- default "Librem 13"
+ default "Librem 13 v1"
config MAX_CPUS
int
diff --git a/src/mainboard/purism/librem13v1/Kconfig.name b/src/mainboard/purism/librem13v1/Kconfig.name
new file mode 100644
index 0000000..c32690c
--- /dev/null
+++ b/src/mainboard/purism/librem13v1/Kconfig.name
@@ -0,0 +1,2 @@
+config BOARD_PURISM_LIBREM13_V1
+ bool "Librem 13 v1"
diff --git a/src/mainboard/purism/librem13/Makefile.inc b/src/mainboard/purism/librem13v1/Makefile.inc
similarity index 100%
rename from src/mainboard/purism/librem13/Makefile.inc
rename to src/mainboard/purism/librem13v1/Makefile.inc
diff --git a/src/mainboard/purism/librem13/acpi/ec.asl b/src/mainboard/purism/librem13v1/acpi/ec.asl
similarity index 100%
rename from src/mainboard/purism/librem13/acpi/ec.asl
rename to src/mainboard/purism/librem13v1/acpi/ec.asl
diff --git a/src/mainboard/purism/librem13/acpi/mainboard.asl b/src/mainboard/purism/librem13v1/acpi/mainboard.asl
similarity index 100%
rename from src/mainboard/purism/librem13/acpi/mainboard.asl
rename to src/mainboard/purism/librem13v1/acpi/mainboard.asl
diff --git a/src/mainboard/purism/librem13/acpi/superio.asl b/src/mainboard/purism/librem13v1/acpi/superio.asl
similarity index 100%
rename from src/mainboard/purism/librem13/acpi/superio.asl
rename to src/mainboard/purism/librem13v1/acpi/superio.asl
diff --git a/src/mainboard/purism/librem13/acpi_tables.c b/src/mainboard/purism/librem13v1/acpi_tables.c
similarity index 100%
rename from src/mainboard/purism/librem13/acpi_tables.c
rename to src/mainboard/purism/librem13v1/acpi_tables.c
diff --git a/src/mainboard/purism/librem13/board_info.txt b/src/mainboard/purism/librem13v1/board_info.txt
similarity index 86%
rename from src/mainboard/purism/librem13/board_info.txt
rename to src/mainboard/purism/librem13v1/board_info.txt
index 700f7cc..caaa9d9 100644
--- a/src/mainboard/purism/librem13/board_info.txt
+++ b/src/mainboard/purism/librem13v1/board_info.txt
@@ -1,6 +1,6 @@
Category: laptop
Vendor name: Purism
-Board name: Librem 13
+Board name: Librem 13 v1
Board URL: https://puri.sm/librem-13/
ROM package: SOIC8
ROM protocol: SPI
diff --git a/src/mainboard/purism/librem13/devicetree.cb b/src/mainboard/purism/librem13v1/devicetree.cb
similarity index 100%
rename from src/mainboard/purism/librem13/devicetree.cb
rename to src/mainboard/purism/librem13v1/devicetree.cb
diff --git a/src/mainboard/purism/librem13/dsdt.asl b/src/mainboard/purism/librem13v1/dsdt.asl
similarity index 100%
rename from src/mainboard/purism/librem13/dsdt.asl
rename to src/mainboard/purism/librem13v1/dsdt.asl
diff --git a/src/mainboard/purism/librem13/fadt.c b/src/mainboard/purism/librem13v1/fadt.c
similarity index 100%
rename from src/mainboard/purism/librem13/fadt.c
rename to src/mainboard/purism/librem13v1/fadt.c
diff --git a/src/mainboard/purism/librem13/gpio.h b/src/mainboard/purism/librem13v1/gpio.h
similarity index 100%
rename from src/mainboard/purism/librem13/gpio.h
rename to src/mainboard/purism/librem13v1/gpio.h
diff --git a/src/mainboard/purism/librem13/hda_verb.c b/src/mainboard/purism/librem13v1/hda_verb.c
similarity index 100%
rename from src/mainboard/purism/librem13/hda_verb.c
rename to src/mainboard/purism/librem13v1/hda_verb.c
diff --git a/src/mainboard/purism/librem13/mainboard.c b/src/mainboard/purism/librem13v1/mainboard.c
similarity index 100%
rename from src/mainboard/purism/librem13/mainboard.c
rename to src/mainboard/purism/librem13v1/mainboard.c
diff --git a/src/mainboard/purism/librem13/pei_data.c b/src/mainboard/purism/librem13v1/pei_data.c
similarity index 100%
rename from src/mainboard/purism/librem13/pei_data.c
rename to src/mainboard/purism/librem13v1/pei_data.c
diff --git a/src/mainboard/purism/librem13/romstage.c b/src/mainboard/purism/librem13v1/romstage.c
similarity index 100%
rename from src/mainboard/purism/librem13/romstage.c
rename to src/mainboard/purism/librem13v1/romstage.c
--
To view, visit https://review.coreboot.org/19931
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com>
Julius Werner has posted comments on this change. ( https://review.coreboot.org/19903 )
Change subject: rockchip/rk3399: fix rk_mipi_dsi_phy_init err
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/19903
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie260975ad6ed26c37aa8bb65dfcef4db2407a2da
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang(a)rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-HasComments: No