coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: google/rambi: disable PCI device for unused i2c buses
by Matt DeVillier (Code Review) 28 May '17

28 May '17

Matt DeVillier has uploaded a new change for review. ( https://review.coreboot.org/19956 ) Change subject: google/rambi: disable PCI device for unused i2c buses ...................................................................... google/rambi: disable PCI device for unused i2c buses Light sensor isn't used and ACPI already removed, so disable I2C5 bus interface as well. Disable I2C6 for devices without a touchscreen Change-Id: Ib0e041ae9131615ef1140bad064de5aae91f8ee4 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/rambi/variants/clapper/devicetree.cb M src/mainboard/google/rambi/variants/enguarde/devicetree.cb M src/mainboard/google/rambi/variants/glimmer/devicetree.cb M src/mainboard/google/rambi/variants/gnawty/devicetree.cb M src/mainboard/google/rambi/variants/heli/devicetree.cb M src/mainboard/google/rambi/variants/kip/devicetree.cb M src/mainboard/google/rambi/variants/ninja/devicetree.cb M src/mainboard/google/rambi/variants/quawks/devicetree.cb M src/mainboard/google/rambi/variants/rambi/devicetree.cb M src/mainboard/google/rambi/variants/squawks/devicetree.cb M src/mainboard/google/rambi/variants/swanky/devicetree.cb 11 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/19956/1 diff --git a/src/mainboard/google/rambi/variants/clapper/devicetree.cb b/src/mainboard/google/rambi/variants/clapper/devicetree.cb index a95ddd1..13902b0 100644 --- a/src/mainboard/google/rambi/variants/clapper/devicetree.cb +++ b/src/mainboard/google/rambi/variants/clapper/devicetree.cb @@ -59,7 +59,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 on end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb index f3792fe..89929b0 100644 --- a/src/mainboard/google/rambi/variants/enguarde/devicetree.cb +++ b/src/mainboard/google/rambi/variants/enguarde/devicetree.cb @@ -71,8 +71,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 - device pci 18.6 off end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb index bf01cd9..5148225 100644 --- a/src/mainboard/google/rambi/variants/glimmer/devicetree.cb +++ b/src/mainboard/google/rambi/variants/glimmer/devicetree.cb @@ -68,7 +68,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 on end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb index bb6fcad..0024679 100644 --- a/src/mainboard/google/rambi/variants/gnawty/devicetree.cb +++ b/src/mainboard/google/rambi/variants/gnawty/devicetree.cb @@ -71,8 +71,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 - device pci 18.6 on end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/heli/devicetree.cb b/src/mainboard/google/rambi/variants/heli/devicetree.cb index d9b27e6..8b3c83f 100644 --- a/src/mainboard/google/rambi/variants/heli/devicetree.cb +++ b/src/mainboard/google/rambi/variants/heli/devicetree.cb @@ -72,8 +72,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 off end # I2C5 - device pci 18.6 off end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/kip/devicetree.cb b/src/mainboard/google/rambi/variants/kip/devicetree.cb index f4e0a91..d1d6beb 100644 --- a/src/mainboard/google/rambi/variants/kip/devicetree.cb +++ b/src/mainboard/google/rambi/variants/kip/devicetree.cb @@ -71,7 +71,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/ninja/devicetree.cb b/src/mainboard/google/rambi/variants/ninja/devicetree.cb index 6d56130..5c9595c 100644 --- a/src/mainboard/google/rambi/variants/ninja/devicetree.cb +++ b/src/mainboard/google/rambi/variants/ninja/devicetree.cb @@ -73,7 +73,7 @@ device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 device pci 18.5 off end # I2C5 - device pci 18.6 off end # I2C6 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA diff --git a/src/mainboard/google/rambi/variants/quawks/devicetree.cb b/src/mainboard/google/rambi/variants/quawks/devicetree.cb index cc5146d..320b59b 100644 --- a/src/mainboard/google/rambi/variants/quawks/devicetree.cb +++ b/src/mainboard/google/rambi/variants/quawks/devicetree.cb @@ -68,7 +68,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/rambi/devicetree.cb b/src/mainboard/google/rambi/variants/rambi/devicetree.cb index 5914a62..ddd1914 100644 --- a/src/mainboard/google/rambi/variants/rambi/devicetree.cb +++ b/src/mainboard/google/rambi/variants/rambi/devicetree.cb @@ -72,7 +72,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 on end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/squawks/devicetree.cb b/src/mainboard/google/rambi/variants/squawks/devicetree.cb index 400a551..26a915d 100644 --- a/src/mainboard/google/rambi/variants/squawks/devicetree.cb +++ b/src/mainboard/google/rambi/variants/squawks/devicetree.cb @@ -68,7 +68,7 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 + device pci 18.5 off end # I2C5 device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE diff --git a/src/mainboard/google/rambi/variants/swanky/devicetree.cb b/src/mainboard/google/rambi/variants/swanky/devicetree.cb index 5e78a10..db21bd6 100644 --- a/src/mainboard/google/rambi/variants/swanky/devicetree.cb +++ b/src/mainboard/google/rambi/variants/swanky/devicetree.cb @@ -71,8 +71,8 @@ device pci 18.2 on end # I2C2 device pci 18.3 off end # I2C3 device pci 18.4 off end # I2C4 - device pci 18.5 on end # I2C5 - device pci 18.6 on end # I2C6 + device pci 18.5 off end # I2C5 + device pci 18.6 off end # I2C6 device pci 18.7 off end # I2C7 device pci 1a.0 on end # TXE device pci 1b.0 on end # HDA -- To view, visit https://review.coreboot.org/19956 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0e041ae9131615ef1140bad064de5aae91f8ee4 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: gma/acpi: Fix argument count to _DSS
by Philippe Mathieu-Daudé (Code Review) 28 May '17

28 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19952 ) Change subject: gma/acpi: Fix argument count to _DSS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic05832d412cd0c89ed3a275c4db694a9118dac28 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI: Switch to agesa/heapmanager.c
by Philippe Mathieu-Daudé (Code Review) 28 May '17

28 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19271 ) Change subject: binaryPI: Switch to agesa/heapmanager.c ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/19271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537bd05a3e06ff6896f1ac8be93eed5321ca472b Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI boards: Drop unused header
by Philippe Mathieu-Daudé (Code Review) 28 May '17

28 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19950 ) Change subject: binaryPI boards: Drop unused header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19950 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869d426c1344290a00e2df60e07e9a4a3ae26887 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI: Move EmptyHeap() call
by Philippe Mathieu-Daudé (Code Review) 28 May '17

28 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19270 ) Change subject: binaryPI: Move EmptyHeap() call ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/19270 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf0ec74c390e60122d0b312b5f09f46bb930e085 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name
by Philippe Mathieu-Daudé (Code Review) 28 May '17

28 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19954 ) Change subject: sb/intel/bd82x6x/early_usb: Use register name ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/19954/1/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: PS1, Line 74: inw(DEFAULT_PMBASE | UPRWC) & ~UPRWC_WR_EN your commit description is "Use register name" but this commit actually does a bit more, can you describe that change too? -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/lenovo/*/cmos: Remove unused option and checksum fix
by Arthur Heymans (Code Review) 28 May '17

28 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19955 ) Change subject: mb/lenovo/*/cmos: Remove unused option and checksum fix ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19955/1/src/mainboard/lenovo/l520/cmos.layo… File src/mainboard/lenovo/l520/cmos.layout: PS1, Line 83: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 Given that native raminit is selected in Kconfig (MRC.bin boot path is not an option) do these make sense? -- To view, visit https://review.coreboot.org/19955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f7af13d9c82d7f531d4b49b3bc0e5a20c14b55 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name
by Arthur Heymans (Code Review) 28 May '17

28 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19954 ) Change subject: sb/intel/bd82x6x/early_usb: Use register name ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19954/1/src/southbridge/intel/bd82x6x/pch.h File src/southbridge/intel/bd82x6x/pch.h: PS1, Line 118: remove space? -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name
by Arthur Heymans (Code Review) 28 May '17

28 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19954 ) Change subject: sb/intel/bd82x6x/early_usb: Use register name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*/cmos: Remove unused option and checksum fix
by build bot (Jenkins) (Code Review) 28 May '17

28 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19955 ) Change subject: mb/lenovo/*/cmos: Remove unused option and checksum fix ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10218/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54499/ : SUCCESS -- To view, visit https://review.coreboot.org/19955 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02f7af13d9c82d7f531d4b49b3bc0e5a20c14b55 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017