coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mainboard/google/poppy: Power down camera rails when suspending
by Furquan Shaikh (Code Review) 28 May '17

28 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19953 ) Change subject: mainboard/google/poppy: Power down camera rails when suspending ...................................................................... Patch Set 1: Code-Review-1 Still need to verify this works. -- To view, visit https://review.coreboot.org/19953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba88fed972b847448e01fcfca8c7129d950244c2 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/poppy: Power down camera rails when suspending
by Furquan Shaikh (Code Review) 28 May '17

28 May '17

Furquan Shaikh has uploaded a new change for review. ( https://review.coreboot.org/19953 ) Change subject: mainboard/google/poppy: Power down camera rails when suspending ...................................................................... mainboard/google/poppy: Power down camera rails when suspending BUG=b:62147763 Change-Id: Iba88fed972b847448e01fcfca8c7129d950244c2 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/19953/1 diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index 88aa905..0289742 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -15,8 +15,11 @@ #include <cpu/x86/smm.h> #include <ec/google/chromeec/smm.h> +#include <gpio.h> +#include <soc/gpio.h> #include <soc/smm.h> +#include <variant/gpio.h> #include <variant/ec.h> void mainboard_smi_espi_handler(void) @@ -24,10 +27,17 @@ chromeec_smi_process_events(); } +static void mainboard_gpio_smi_sleep(void) +{ + gpio_set(EN_PP3300_DX_CAM, 0); + gpio_set(EN_CAM_PMIC_RST_L, 0); +} + void mainboard_smi_sleep(u8 slp_typ) { chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); + mainboard_gpio_smi_sleep(); } int mainboard_smi_apmc(u8 apmc) diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h index 628483b..4c9ade3 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/gpio.h @@ -37,4 +37,8 @@ /* eSPI virtual wire reporting */ #define EC_SCI_GPI GPE0_ESPI +/* Power rail control signals */ +#define EN_PP3300_DX_CAM GPP_C11 +#define EN_CAM_PMIC_RST_L GPP_C10 + #endif /* BASEBOARD_GPIO_H */ -- To view, visit https://review.coreboot.org/19953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba88fed972b847448e01fcfca8c7129d950244c2 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: gma/acpi: Fix argument count to _DSS
by build bot (Jenkins) (Code Review) 28 May '17

28 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19952 ) Change subject: gma/acpi: Fix argument count to _DSS ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10211/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54492/ : SUCCESS -- To view, visit https://review.coreboot.org/19952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic05832d412cd0c89ed3a275c4db694a9118dac28 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: gma/acpi: Fix argument count to _DSS
by Matt DeVillier (Code Review) 28 May '17

28 May '17

Matt DeVillier has uploaded a new change for review. ( https://review.coreboot.org/19952 ) Change subject: gma/acpi: Fix argument count to _DSS ...................................................................... gma/acpi: Fix argument count to _DSS As the comment above the change indicates, and per ACPI spec, _DSS has one argument. Change-Id: Ic05832d412cd0c89ed3a275c4db694a9118dac28 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/drivers/intel/gma/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/19952/1 diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index c3a9b8a..f6516c9 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -122,7 +122,7 @@ ^^XDSS(0x5a, Arg0) } */ - acpigen_write_method("_DSS", 0); + acpigen_write_method("_DSS", 1); acpigen_emit_namestring("^^XDSS"); acpigen_write_byte(i); acpigen_emit_byte(0x68); /* Arg0Op. */ -- To view, visit https://review.coreboot.org/19952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic05832d412cd0c89ed3a275c4db694a9118dac28 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: purism/librem13v1: Rename librem13 to librem13v1
by Arthur Heymans (Code Review) 27 May '17

27 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19931 ) Change subject: purism/librem13v1: Rename librem13 to librem13v1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19931 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: MAINTAINERS: Add Felix as superio maintainer
by Felix Held (Code Review) 27 May '17

27 May '17

Felix Held has posted comments on this change. ( https://review.coreboot.org/19951 ) Change subject: MAINTAINERS: Add Felix as superio maintainer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/19951 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib53f591e5c8b03cd45b3fbd3db36ea2c28e4e060 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI boards: Drop unused header
by build bot (Jenkins) (Code Review) 27 May '17

27 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19950 ) Change subject: binaryPI boards: Drop unused header ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10210/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54491/ : SUCCESS -- To view, visit https://review.coreboot.org/19950 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869d426c1344290a00e2df60e07e9a4a3ae26887 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI: Enable RELOCATABLE_RAMSTAGE
by build bot (Jenkins) (Code Review) 27 May '17

27 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19348 ) Change subject: binaryPI: Enable RELOCATABLE_RAMSTAGE ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54490/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10209/ : SUCCESS -- To view, visit https://review.coreboot.org/19348 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c0058be002e409bd16d2d75fd404df94407df4e Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI: Enable EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 27 May '17

27 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19347 ) Change subject: binaryPI: Enable EARLY_CBMEM_INIT ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/54489/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/10208/ : SUCCESS -- To view, visit https://review.coreboot.org/19347 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0263af9561e0367bbbde4d5c3190039f4c3047a0 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: binaryPI: Switch to agesa/heapmanager.c
by build bot (Jenkins) (Code Review) 27 May '17

27 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19271 ) Change subject: binaryPI: Switch to agesa/heapmanager.c ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10205/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54486/ : SUCCESS -- To view, visit https://review.coreboot.org/19271 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I537bd05a3e06ff6896f1ac8be93eed5321ca472b Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017