coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/intel/skylake: Clean up code by using common FAST_SPI mo...
by Subrata Banik (Code Review) 02 May '17

02 May '17

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19055 ) Change subject: soc/intel/skylake: Clean up code by using common FAST_SPI module ...................................................................... Patch Set 23: Code-Review+2 -- To view, visit https://review.coreboot.org/19055 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc90504d322db70ed4ea644b1593cc0605b5fe8 Gerrit-PatchSet: 23 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/apollolake: Clean up code by using common FAST_SPI...
by Subrata Banik (Code Review) 02 May '17

02 May '17

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19080 ) Change subject: soc/intel/apollolake: Clean up code by using common FAST_SPI module ...................................................................... Patch Set 21: Code-Review+2 -- To view, visit https://review.coreboot.org/19080 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd72734dadda541fe4c828e4f1716e532ec69c27 Gerrit-PatchSet: 21 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19494 ) Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53090/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8925/ : SUCCESS -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/s230u: fix sata port map for the msata port
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19523 ) Change subject: mb/lenovo/s230u: fix sata port map for the msata port ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53089/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8924/ : SUCCESS -- To view, visit https://review.coreboot.org/19523 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e9e96f0d0849b1e8c4e02aa4f686ceb5e10b3ab Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: Add tpm support for its onboard tpm...
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19521 ) Change subject: mb/gigabyte/ga-b75m-d3h: Add tpm support for its onboard tpm socket ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53087/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8922/ : SUCCESS -- To view, visit https://review.coreboot.org/19521 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0dee74d945bae5d77eb669d8b9d468a67aee508 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/gigabyte/ga-b75m-d3h: add libgfxinit support
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19522 ) Change subject: mb/gigabyte/ga-b75m-d3h: add libgfxinit support ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53088/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8923/ : SUCCESS -- To view, visit https://review.coreboot.org/19522 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a7247df0c32b3d1f489fb92d86baaa8fdf8ba Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Anonymous Coward #1001586 Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c
by Patrick Rudolph (Code Review) 02 May '17

02 May '17

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19494 to look at the new patch set (#5). Change subject: mb/lenvovo/*: Clean mainboard.c ...................................................................... mb/lenvovo/*: Clean mainboard.c * Move board specific SPI registers to devicetree * Remove unused headers * Remove obsolete methods * Fix coding style * Fix Thinkpad L520 SPI lvscc register No function change, just moving stuff around. Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/lenovo/l520/devicetree.cb M src/mainboard/lenovo/l520/mainboard.c M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/lenovo/t400/mainboard.c M src/mainboard/lenovo/t420/devicetree.cb M src/mainboard/lenovo/t420/mainboard.c M src/mainboard/lenovo/t420s/devicetree.cb M src/mainboard/lenovo/t420s/mainboard.c M src/mainboard/lenovo/t430s/devicetree.cb M src/mainboard/lenovo/t430s/mainboard.c M src/mainboard/lenovo/t520/devicetree.cb M src/mainboard/lenovo/t520/mainboard.c M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/mainboard.c M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb M src/mainboard/lenovo/x1_carbon_gen1/mainboard.c M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x220/mainboard.c M src/mainboard/lenovo/x230/devicetree.cb M src/mainboard/lenovo/x230/mainboard.c 21 files changed, 87 insertions(+), 223 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/19494/5 -- To view, visit https://review.coreboot.org/19494 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in coreboot[master]: soc/intel/skylake: Set xtal bypass on low power idle
by Martin Roth (Code Review) 02 May '17

02 May '17

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19442 ) Change subject: soc/intel/skylake: Set xtal bypass on low power idle ...................................................................... soc/intel/skylake: Set xtal bypass on low power idle When using Wake On Voice &/or DCI, it requires xtal to be active during low power idle. With xtal being active in S0ix state power impact is 1-2 mW. Hence set xtal bypass bit in CIR31C for low power idle entry. TEST= Build with s0ix enable for Poppy. Boot to OS & verify that bit 22 of CIR31C register is set. s0ix works. Change-Id: Ide2d01536f652cd1b0ac32eede89ec410c5101cf Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> Reviewed-on: https://review.coreboot.org/19442 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/skylake/finalize.c M src/soc/intel/skylake/include/soc/pmc.h 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Aaron Durbin: Looks good to me, approved build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index f489e4b..9cb246c 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -143,6 +143,13 @@ write8(pmcbase + PCH_PWRM_ACPI_TMR_CTL, reg8); } + /* Disable XTAL shutdown qualification for low power idle. */ + if (config->s0ix_enable) { + reg32 = read32(pmcbase + CIR31C); + reg32 |= XTALSDQDIS; + write32(pmcbase + CIR31C, reg32); + } + /* we should disable Heci1 based on the devicetree policy */ if (config->HeciEnabled == 0) pch_disable_heci(); diff --git a/src/soc/intel/skylake/include/soc/pmc.h b/src/soc/intel/skylake/include/soc/pmc.h index 10ea6ae..4a80917 100644 --- a/src/soc/intel/skylake/include/soc/pmc.h +++ b/src/soc/intel/skylake/include/soc/pmc.h @@ -98,5 +98,6 @@ #define GPE0_DW2_SHIFT 8 #define GBLRST_CAUSE0 0x124 #define GBLRST_CAUSE1 0x128 - +#define CIR31C 0x31c +#define XTALSDQDIS (1 << 22) #endif -- To view, visit https://review.coreboot.org/19442 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide2d01536f652cd1b0ac32eede89ec410c5101cf Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Roy Park <roy.mingi.park(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam(a)intel.com>

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by build bot (Jenkins) (Code Review) 02 May '17

02 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19500 ) Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... Patch Set 17: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53086/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/8921/ : SUCCESS -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/gm45: Set display backlight according to EDID string
by Arthur Heymans (Code Review) 02 May '17

02 May '17

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19500 to look at the new patch set (#17). Change subject: nb/intel/gm45: Set display backlight according to EDID string ...................................................................... nb/intel/gm45: Set display backlight according to EDID string Add some known good values for some thinkpads displays. Known good means that at this pwm frequency the display is evenly lit on all duty cycles, the display makes minimal to no noise at lower duty cycles and the display does not flicker. This values differs from vendor (which uses an obviously wrong display clock (190MHz instead of 320MHz) resulting in frequency more than 60% off the intended value. TESTED on Thinkpad X200 with edid ascii string in list and removed from list to see if notice message is shown. Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t400/Makefile.inc A src/mainboard/lenovo/t400/blc.c M src/mainboard/lenovo/x200/Makefile.inc A src/mainboard/lenovo/x200/blc.c M src/mainboard/roda/rk9/Makefile.inc A src/mainboard/roda/rk9/blc.c M src/northbridge/intel/gm45/chip.h M src/northbridge/intel/gm45/gm45.h M src/northbridge/intel/gm45/gma.c 9 files changed, 145 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/19500/17 -- To view, visit https://review.coreboot.org/19500 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7bc0d453fac31e806852206ba2c895720b2c843 Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017