coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: intelmetool: Enable warning *set-but-unused-variable*
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19613 ) Change subject: intelmetool: Enable warning *set-but-unused-variable* ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53418/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9217/ : SUCCESS -- To view, visit https://review.coreboot.org/19613 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9eb26d4f8b298af231b952b547b71d68c649eaf Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: intelmetool: Comment out unused variable
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19612 ) Change subject: intelmetool: Comment out unused variable ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/53417/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9216/ : SUCCESS -- To view, visit https://review.coreboot.org/19612 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ecb2b5e9f32906ccfc8a0628d2e0f2d3ad39a02 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable PARALLEL_MP_AP_WORK
by Philippe Mathieu-Daudé (Code Review) 07 May '17

07 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19608 ) Change subject: soc/intel/skylake: Enable PARALLEL_MP_AP_WORK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19608 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22a8f6ac90ba35075ff97dd57bab66c129f3e771 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: Enable MTRR check
by Philippe Mathieu-Daudé (Code Review) 07 May '17

07 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19609 ) Change subject: soc/intel/skylake: Enable MTRR check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19609 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I440405c58c470ffa338be386d84870635530a031 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/skylake: remove unused SMI functions
by Philippe Mathieu-Daudé (Code Review) 07 May '17

07 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19598 ) Change subject: soc/intel/skylake: remove unused SMI functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19598 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86994191a63cbf515bc330433ef7c3f79a39936e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: inteltool: Fix clean-up and close related TODO
by Philippe Mathieu-Daudé (Code Review) 07 May '17

07 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19587 ) Change subject: inteltool: Fix clean-up and close related TODO ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19587 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ef80c837263a205467f835156dcb8fa667d3a8f Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: inteltool: #include <commonlib/helpers.h>
by Philippe Mathieu-Daudé (Code Review) 07 May '17

07 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19586 ) Change subject: inteltool: #include <commonlib/helpers.h> ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19586 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66a243486a347313103ffd2cb2ca0447228e4054 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: Check return status of a command
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19509 ) Change subject: autoport: Check return status of a command ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53415/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9214/ : SUCCESS -- To view, visit https://review.coreboot.org/19509 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae11ba8de1883ac82be5394af7905e91606bec0 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: autoport: Check return status of a command
by Iru Cai (Code Review) 07 May '17

07 May '17

Iru Cai has uploaded a new patch set (#2). ( https://review.coreboot.org/19509 ) Change subject: autoport: Check return status of a command ...................................................................... autoport: Check return status of a command Some commands may fail and make autoport generate wrong code, especially when CONFIG_IO_STRICT_DEVMEM is set and "iomem=relaxed" is not in the kernel command line. Change-Id: Ieae11ba8de1883ac82be5394af7905e91606bec0 Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M util/autoport/log_maker.go 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/19509/2 -- To view, visit https://review.coreboot.org/19509 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieae11ba8de1883ac82be5394af7905e91606bec0 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com>

1 0

Change in coreboot[master]: mainboard: Add ASRock G41C-GS
by Arthur Heymans (Code Review) 07 May '17

07 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18993 ) Change subject: mainboard: Add ASRock G41C-GS ...................................................................... Patch Set 7: Code-Review-1 (2 comments) https://review.coreboot.org/#/c/18993/6/src/mainboard/asrock/g41c-gs/Kconfig File src/mainboard/asrock/g41c-gs/Kconfig: Line 36: select HAVE_ACPI_RESUME > I'm confused here, does this mean you won't get the owner to test Sadly not and I'm really unhappy about it too... I'll try to find one of these boards but until then I feel like this is wasting my and especially your time. https://review.coreboot.org/#/c/18993/6/src/mainboard/asrock/g41c-gs/dsdt.a… File src/mainboard/asrock/g41c-gs/dsdt.asl: Line 37: #include <drivers/intel/gma/acpi/default_brightness_levels.asl> > ok its a bug. /drivers/intel/gma/acpi/configure_brightness_levels.asl needs it... -- To view, visit https://review.coreboot.org/18993 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I992ee07b742dfc59733ce0f3a9be202a530ec6cc Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017