coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: nb/x4x: Add ramstage IGD disable function
by build bot (Jenkins) (Code Review) 08 May '17

08 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18504 ) Change subject: nb/x4x: Add ramstage IGD disable function ...................................................................... Patch Set 18: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9224/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53425/ : SUCCESS -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 18 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/x4x: Add ramstage IGD disable function
by Arthur Heymans (Code Review) 08 May '17

08 May '17

Hello Patrick Rudolph, Philippe Mathieu-Daudé, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18504 to look at the new patch set (#18). Change subject: nb/x4x: Add ramstage IGD disable function ...................................................................... nb/x4x: Add ramstage IGD disable function This disables VGA cycles on IGD when an external VGA device is found. This allows PCI or PCIe devices to be the 'main' VGA device if found, while the IGD is still available. TESTED on ga-g41m-es2l: SeaBIOS shows payload on external GPU while linux (4.10) can use both as a framebuffer simultaneously without any extra configuration. Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/18504/18 -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 18 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/x4x: Add ramstage IGD disable function
by Philippe Mathieu-Daudé (Code Review) 08 May '17

08 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/18504 ) Change subject: nb/x4x: Add ramstage IGD disable function ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/amd/cimx/sb800/ramtop: Fix coding style issues
by Philippe Mathieu-Daudé (Code Review) 08 May '17

08 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19458 ) Change subject: sb/amd/cimx/sb800/ramtop: Fix coding style issues ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/19458 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d48906bbeb5ec2f3bea6a93fd2a06aa76b29d9 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: intelmetool: Enable warning *set-but-unused-variable*
by Philippe Mathieu-Daudé (Code Review) 08 May '17

08 May '17

Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19613 ) Change subject: intelmetool: Enable warning *set-but-unused-variable* ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/19613 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9eb26d4f8b298af231b952b547b71d68c649eaf Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA...
by build bot (Jenkins) (Code Review) 08 May '17

08 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19607 ) Change subject: nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA cycles ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9223/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53424/ : SUCCESS -- To view, visit https://review.coreboot.org/19607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a03e35c0d7f2532edd6cc5e62d1cf07dab57f60 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA...
by Arthur Heymans (Code Review) 08 May '17

08 May '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19607 to look at the new patch set (#2). Change subject: nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA cycles ...................................................................... nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA cycles The NGI writes to legacy VGA registers which should not happen when VGA cycles are assigned to a different device. TESTED on ga-g41m-es2l Change-Id: I0a03e35c0d7f2532edd6cc5e62d1cf07dab57f60 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/19607/2 -- To view, visit https://review.coreboot.org/19607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0a03e35c0d7f2532edd6cc5e62d1cf07dab57f60 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: Enhance missing package help
by build bot (Jenkins) (Code Review) 08 May '17

08 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19617 ) Change subject: Enhance missing package help ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53423/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9222/ : SUCCESS -- To view, visit https://review.coreboot.org/19617 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vincent Legoll <vincent.legoll(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: Enhance missing package help
by Vincent Legoll (Code Review) 08 May '17

08 May '17

Vincent Legoll has uploaded a new change for review. ( https://review.coreboot.org/19617 ) Change subject: Enhance missing package help ...................................................................... Enhance missing package help On ubuntu 16.04 the libpci-dev package is required Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c Signed-off-by: Vincent Legoll <vincent.legoll(a)gmail.com> --- M util/intelmetool/Makefile 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/19617/1 diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile index 4461f86..b056945 100644 --- a/util/intelmetool/Makefile +++ b/util/intelmetool/Makefile @@ -74,7 +74,8 @@ @echo "$$LIBPCI_TEST" > .test.c @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \ printf "found.\n" || ( printf "not found.\n\n"; \ - printf "Please install pciutils-devel and zlib-devel.\n"; \ + printf "Please install pciutils-devel and zlib-devel,\n"; \ + printf "or libpci-dev.\n"; \ rm -f .test.c .test; exit 1) @rm -rf .test.c .test .test.dSYM -- To view, visit https://review.coreboot.org/19617 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I942b3e96f5b8112166a105eb5a61f8f3cf16cb7c Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vincent Legoll <vincent.legoll(a)gmail.com>

1 0

Change in coreboot[master]: superio/ite/it8728f: Hook up common environment-controller d...
by Felix Held (Code Review) 07 May '17

07 May '17

Felix Held has posted comments on this change. ( https://review.coreboot.org/19293 ) Change subject: superio/ite/it8728f: Hook up common environment-controller driver ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/19293 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf0c8908ba5ad6ff552b8302bffc638aa9052941 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rudolf Marek <r.marek(a)assembler.cz> Gerrit-Reviewer: Sergej Ivanov <getinaks(a)gmail.com> Gerrit-Reviewer: Tobias Diedrich <ranma+coreboot(a)tdiedrich.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017