coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: nb/x4x: Do not enable IGD when not supported
by build bot (Jenkins) (Code Review) 07 May '17

07 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18515 ) Change subject: nb/x4x: Do not enable IGD when not supported ...................................................................... Patch Set 13: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53408/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9208/ : SUCCESS -- To view, visit https://review.coreboot.org/18515 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdaa2862f82000de6d51278098365c63b7719f7f Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA...
by Arthur Heymans (Code Review) 07 May '17

07 May '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19607 ) Change subject: nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA cycles ...................................................................... nb/intel/x4x: Don't run NGI if IGD has not been assigned VGA cycles The NGI writes to legacy vga registers which can hang some discrete VGA devices. (mostly AMD devices, Nvidia are fine) TESTED on ga-g41m-es2l Change-Id: I0a03e35c0d7f2532edd6cc5e62d1cf07dab57f60 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/19607/1 diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index c2df074..b013c47 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -356,7 +356,7 @@ static void gma_func0_init(struct device *dev) { - u16 reg16; + u16 reg16, ggc; u32 reg32; /* IGD needs to be Bus Master */ @@ -370,7 +370,14 @@ reg16 |= 0xbc; pci_write_config16(dev_find_slot(0, PCI_DEVFN(0x2, 0)), 0xcc, reg16); - if (IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT)) + ggc = pci_read_config16(dev_find_slot(0, PCI_DEVFN(0, 0)), D0F0_GGC); + + /* + * Don't run native graphic init when VGA cycles are not assigned since + * this can cause issues with some discrete GPUs. + */ + if (IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT) && + !(ggc & (1 << 1))) native_init(dev); else pci_dev_init(dev); -- To view, visit https://review.coreboot.org/19607 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a03e35c0d7f2532edd6cc5e62d1cf07dab57f60 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: nb/x4x: Add ramstage IGD disable function
by build bot (Jenkins) (Code Review) 06 May '17

06 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18504 ) Change subject: nb/x4x: Add ramstage IGD disable function ...................................................................... Patch Set 17: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53407/ : SUCCESS -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/x4x: Add ramstage IGD disable function
by Arthur Heymans (Code Review) 06 May '17

06 May '17

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18504 to look at the new patch set (#17). Change subject: nb/x4x: Add ramstage IGD disable function ...................................................................... nb/x4x: Add ramstage IGD disable function This disables VGA cycles on IGD when an external VGA device is found. This allows PCI or PCIe devices to be the 'main' VGA device if found, while the IGD is still available. TESTED on ga-g41m-es2l: SeaBIOS shows payload on external GPU while linux (4.10) can use both as a framebuffer simultaneously without any extra configuration. Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c M src/northbridge/intel/x4x/x4x.h 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/18504/17 -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 17 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/x4x: Add support for second PEG slot
by build bot (Jenkins) (Code Review) 06 May '17

06 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18516 ) Change subject: nb/intel/x4x: Add support for second PEG slot ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53406/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9207/ : SUCCESS -- To view, visit https://review.coreboot.org/18516 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b138db6654c83c40b5ca4b65d6ccd51ad4277fa Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/x4x: Do not enable IGD when not supported
by build bot (Jenkins) (Code Review) 06 May '17

06 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18515 ) Change subject: nb/x4x: Do not enable IGD when not supported ...................................................................... Patch Set 12: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53405/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9206/ : SUCCESS -- To view, visit https://review.coreboot.org/18515 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdaa2862f82000de6d51278098365c63b7719f7f Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/x4x: Add ramstage disable function
by build bot (Jenkins) (Code Review) 06 May '17

06 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18504 ) Change subject: nb/x4x: Add ramstage disable function ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53404/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/9205/ : SUCCESS -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 16 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/i82801gx: remove conflicting acpi code.
by Arthur Heymans (Code Review) 06 May '17

06 May '17

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/16552 ) Change subject: sb/intel/i82801gx: remove conflicting acpi code. ...................................................................... Abandoned Conflicts with its own FADT, which should no be a problem. -- To view, visit https://review.coreboot.org/16552 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3b6cb00e5be2ebfb89a48fbbf5ee0cc4cf0576c9 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Sven Schnelle <svens(a)stackframe.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/x4x: Add ramstage disable function
by Arthur Heymans (Code Review) 06 May '17

06 May '17

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18504 to look at the new patch set (#16). Change subject: nb/x4x: Add ramstage disable function ...................................................................... nb/x4x: Add ramstage disable function Disable VGA cycles on IGD when an external VGA device is found. This allows PCI or PCIe devices to be the 'main' VGA device if found. Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/gma.c M src/northbridge/intel/x4x/x4x.h 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/18504/16 -- To view, visit https://review.coreboot.org/18504 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I74890918feb0f1ff6b971c4aaa96f1f7b75266ac Gerrit-PatchSet: 16 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/x4x: Do not enable IGD when not supported
by Arthur Heymans (Code Review) 06 May '17

06 May '17

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18515 to look at the new patch set (#12). Change subject: nb/x4x: Do not enable IGD when not supported ...................................................................... nb/x4x: Do not enable IGD when not supported According to "Intel ® 4 Series Chipset Family datasheet" in the description about GGC and DEVEN, CAPID0 bit46 is said to reflect the presence of an internal graphic device. This would allow the P43 and P45 chipset variants to work. Change-Id: Icdaa2862f82000de6d51278098365c63b7719f7f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/early_init.c 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/18515/12 -- To view, visit https://review.coreboot.org/18515 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icdaa2862f82000de6d51278098365c63b7719f7f Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017