coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: purism/librem13v1: Rename librem13 to librem13v1
by Youness Alaoui (Code Review) 30 May '17

30 May '17

Hello Arthur Heymans, Matt DeVillier, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19931 to look at the new patch set (#3). Change subject: purism/librem13v1: Rename librem13 to librem13v1 ...................................................................... purism/librem13v1: Rename librem13 to librem13v1 A simple rename of the directory and the config values and string in Kconfig/Kconfig.name/board_info.txt It will be less confusing for users since the first models are referred to as 'v1' everywhere now. Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- D src/mainboard/purism/librem13/Kconfig.name D src/mainboard/purism/librem13/board_info.txt R src/mainboard/purism/librem13v1/Kconfig A src/mainboard/purism/librem13v1/Kconfig.name R src/mainboard/purism/librem13v1/Makefile.inc R src/mainboard/purism/librem13v1/acpi/ec.asl R src/mainboard/purism/librem13v1/acpi/mainboard.asl R src/mainboard/purism/librem13v1/acpi/superio.asl R src/mainboard/purism/librem13v1/acpi_tables.c A src/mainboard/purism/librem13v1/board_info.txt R src/mainboard/purism/librem13v1/devicetree.cb R src/mainboard/purism/librem13v1/dsdt.asl R src/mainboard/purism/librem13v1/fadt.c R src/mainboard/purism/librem13v1/gpio.h R src/mainboard/purism/librem13v1/hda_verb.c R src/mainboard/purism/librem13v1/mainboard.c R src/mainboard/purism/librem13v1/pei_data.c R src/mainboard/purism/librem13v1/romstage.c 18 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/19931/3 -- To view, visit https://review.coreboot.org/19931 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: purism/librem13v1: Set FADT revision to ACPI 3.0
by Youness Alaoui (Code Review) 30 May '17

30 May '17

Hello Matt DeVillier, I'd like you to do a code review. Please visit https://review.coreboot.org/19985 to review the following change. Change subject: purism/librem13v1: Set FADT revision to ACPI 3.0 ...................................................................... purism/librem13v1: Set FADT revision to ACPI 3.0 The FADT revision was set to 5, but we do not implement the ACPI v5.0 specification, which prevented Windows from booting. Setting it to v3 (matching most other boards) fixes the issue and Windows now boots normally. Bug found by Matt DeVillier, fix tested by Youness Alaoui on Librem 13 v1 hardware. Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22 Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/purism/librem13v1/fadt.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/19985/1 diff --git a/src/mainboard/purism/librem13v1/fadt.c b/src/mainboard/purism/librem13v1/fadt.c index 980ff03..9cbcd3f 100644 --- a/src/mainboard/purism/librem13v1/fadt.c +++ b/src/mainboard/purism/librem13v1/fadt.c @@ -23,7 +23,7 @@ memset(fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 5; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); -- To view, visit https://review.coreboot.org/19985 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: purism/librem13v1: Rename librem13 to librem13v1
by Youness Alaoui (Code Review) 30 May '17

30 May '17

Hello Arthur Heymans, Matt DeVillier, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19931 to look at the new patch set (#2). Change subject: purism/librem13v1: Rename librem13 to librem13v1 ...................................................................... purism/librem13v1: Rename librem13 to librem13v1 A simple rename of the directory and the config values and string in Kconfig/Kconfig.name/board_info.txt It will be less confusing for users since the first models are referred to as 'v1' everywhere now. Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb Signed-off-by: Youness Alaoui <youness.alaoui(a)puri.sm> --- D src/mainboard/purism/librem13/Kconfig.name R src/mainboard/purism/librem13v1/Kconfig A src/mainboard/purism/librem13v1/Kconfig.name R src/mainboard/purism/librem13v1/Makefile.inc R src/mainboard/purism/librem13v1/acpi/ec.asl R src/mainboard/purism/librem13v1/acpi/mainboard.asl R src/mainboard/purism/librem13v1/acpi/superio.asl R src/mainboard/purism/librem13v1/acpi_tables.c R src/mainboard/purism/librem13v1/board_info.txt R src/mainboard/purism/librem13v1/devicetree.cb R src/mainboard/purism/librem13v1/dsdt.asl R src/mainboard/purism/librem13v1/fadt.c R src/mainboard/purism/librem13v1/gpio.h R src/mainboard/purism/librem13v1/hda_verb.c R src/mainboard/purism/librem13v1/mainboard.c R src/mainboard/purism/librem13v1/pei_data.c R src/mainboard/purism/librem13v1/romstage.c 17 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/19931/2 -- To view, visit https://review.coreboot.org/19931 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Add Intel common CPU code
by Pratikkumar V Prajapati (Code Review) 30 May '17

30 May '17

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/19540 ) Change subject: soc/intel/common/block: Add Intel common CPU code ...................................................................... Patch Set 11: (5 comments) https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/Kco… File src/soc/intel/common/block/cpu/Kconfig: PS11, Line 3: help set 'default n' Also, Common CPU code is supported for SOCs starting from SKL, KBL, APL, GLK and future.. It would good to mention it here. https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu… File src/soc/intel/common/block/cpu/cpu.c: PS11, Line 58: { 0, 0 }, GLK CPUIDs? https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu… File src/soc/intel/common/block/cpu/cpu_early.c: PS11, Line 164: * 7:0 - MAX_TURBO_1_CORE : * 15:8 - MAX_TURBO_2_CORES : * 23:16 - MAX_TURBO_3_CORES : * 31:24 - MAX_TURBO_4_CORES please reformat text. https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include… File src/soc/intel/common/block/include/intelblocks/cpu.h: PS11, Line 36: GLK CPUIDs? https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include… File src/soc/intel/common/block/include/intelblocks/msr.h: PS11, Line 124: /* MTRR_CAP_MSR bits */ : #define SMRR_SUPPORTED (1<<11) : #define PRMRR_SUPPORTED (1<<12) add one more tab to align -- To view, visit https://review.coreboot.org/19540 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f80c42132d9ea738be4051d2395e9e51ac153f8 Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: purism/librem13v1: Rename librem13 to librem13v1
by Martin Roth (Code Review) 30 May '17

30 May '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19931 ) Change subject: purism/librem13v1: Rename librem13 to librem13v1 ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/19931/1/src/mainboard/purism/librem13v1/boa… File src/mainboard/purism/librem13v1/board_info.txt: Line 4: Board URL: https://puri.sm/librem-13/ > I don't think it's necessary to drop this, that URL is still better than no Link to it through archive.org? https://web.archive.org/web/20170105173944/https://puri.sm/products/librem-… -- To view, visit https://review.coreboot.org/19931 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23fa977717230c2001868741bb684e9633a2c0bb Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Youness Alaoui <snifikino(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: binaryPI: Define AGESA blob in CBFS as Kconfig string
by Marshall Dawson (Code Review) 30 May '17

30 May '17

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19983 ) Change subject: binaryPI: Define AGESA blob in CBFS as Kconfig string ...................................................................... Patch Set 1: I like this change. I'd recommend also modifying vendorcode/amd/pi/Makefile.inc to use the config name (see the very bottom) where cbfs-files += AGESA. -- To view, visit https://review.coreboot.org/19983 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f78cb275ecad732f81c609564a0640f03d2559e Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name
by build bot (Jenkins) (Code Review) 30 May '17

30 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19954 ) Change subject: sb/intel/bd82x6x/early_usb: Use register name ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/10271/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54555/ : SUCCESS -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name
by Martin Roth (Code Review) 30 May '17

30 May '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19954 ) Change subject: sb/intel/bd82x6x/early_usb: Use register name ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/19954/1/src/southbridge/intel/bd82x6x/early… File src/southbridge/intel/bd82x6x/early_usb.c: PS1, Line 74: inw(DEFAULT_PMBASE | UPRWC) & ~UPRWC_WR_EN > your commit description is "Use register name" but this commit actually doe Agreed. It just needs a bit more in the commit message. -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: sb/intel/bd82x6x/early_usb: Use register name
by Patrick Rudolph (Code Review) 30 May '17

30 May '17

Hello Philippe Mathieu-Daudé, Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19954 to look at the new patch set (#2). Change subject: sb/intel/bd82x6x/early_usb: Use register name ...................................................................... sb/intel/bd82x6x/early_usb: Use register name Use register name instead of magic value. Only reset previously set bit instead of all bits. Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/bd82x6x/early_usb.c M src/southbridge/intel/bd82x6x/pch.h 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/19954/2 -- To view, visit https://review.coreboot.org/19954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4f2f3f196c12489613333ab9f6098443edda927f Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/t430: Fix PCIe hot-plug ports
by build bot (Jenkins) (Code Review) 30 May '17

30 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19928 ) Change subject: mb/lenovo/t430: Fix PCIe hot-plug ports ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54554/ : SUCCESS -- To view, visit https://review.coreboot.org/19928 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d3d4c7541683a6c09aac47ca251a6dad23ad1ab Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017