coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19757 ) Change subject: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9633/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53888/ : SUCCESS -- To view, visit https://review.coreboot.org/19757 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550cc4556fc4b63ebc174a7e2fde42251fe56052 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi: Add flash probe callbacks to spi_ctrlr structure
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19708 ) Change subject: drivers/spi: Add flash probe callbacks to spi_ctrlr structure ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/53887/ : SUCCESS -- To view, visit https://review.coreboot.org/19708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/spi_flash: Pass in spi_slave structure as const ...
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19707 ) Change subject: drivers/spi/spi_flash: Pass in spi_slave structure as const to probe functions ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9631/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53886/ : SUCCESS -- To view, visit https://review.coreboot.org/19707 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I956ee777c62dbb811fd6ce2aeb6ae090e1892acd Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi_flash: Add page_size to struct spi_flash
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19704 ) Change subject: drivers/spi_flash: Add page_size to struct spi_flash ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9628/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53883/ : SUCCESS -- To view, visit https://review.coreboot.org/19704 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f83e52cb1041432b0b575a8ee3bd173cc038d1f Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi_flash: Pass in flash structure to fill in probe
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19705 ) Change subject: drivers/spi_flash: Pass in flash structure to fill in probe ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9629/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53884/ : SUCCESS -- To view, visit https://review.coreboot.org/19705 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6f1b403731466525c4690777d9b32ce778eb563 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: 3rdparty/arm-trusted-firmware: Update to upstream master
by Julius Werner (Code Review) 17 May '17

17 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/18954 ) Change subject: 3rdparty/arm-trusted-firmware: Update to upstream master ...................................................................... Patch Set 1: *ping* Can we get this and https://review.coreboot.org/#/c/19431/ landed? With the current state you get an opaque kernel crash trying to combine upstream coreboot with Chromium ARM TF, it would be nice to get that resolved. Let me know if you need me to help with anything. -- To view, visit https://review.coreboot.org/18954 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf5bede79126bcbb62243808a2624d9517015920 Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/spi_flash: Use boot_device_spi_flash to obtain s...
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19703 ) Change subject: drivers/spi/spi_flash: Use boot_device_spi_flash to obtain spi_flash structure ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9627/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53882/ : SUCCESS -- To view, visit https://review.coreboot.org/19703 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd50b7644d1a4be8b62d38cc9239feae2215103c Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: spi/drivers/spi_flash_internal: Remove unused spi_fram_probe...
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19706 ) Change subject: spi/drivers/spi_flash_internal: Remove unused spi_fram_probe_ramtron ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9630/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53885/ : SUCCESS -- To view, visit https://review.coreboot.org/19706 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05e6c5c2b97d6c8a726c0e443ad855f9bcb703f9 Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi: Add flash probe callbacks to spi_ctrlr structure
by Furquan Shaikh (Code Review) 17 May '17

17 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19708 to look at the new patch set (#8). Change subject: drivers/spi: Add flash probe callbacks to spi_ctrlr structure ...................................................................... drivers/spi: Add flash probe callbacks to spi_ctrlr structure In order to support some specialized SPI controllers that are actually SPI flash controllers, define a new spi_flash_ctrlr structure with the following members: 1. probe: Specialized probe function provided by the spi flash controller. 2. try_generic_probe_first: Check if the controller wants the flash driver to perform generic probing before trying out the specialized probing. With this change, the specialized spi flash probe functions are now associated with a particular spi ctrlr structure and no longer disconnected from the spi controller. BUG=b:38330715 TEST=Verified with the entire patch series that spi flash driver still works fine on poppy. Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/drivers/spi/spi_flash.c M src/include/spi-generic.h M src/include/spi_flash.h M src/soc/intel/apollolake/spi.c M src/soc/intel/common/block/fast_spi/fast_spi.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/block/include/intelblocks/fast_spi.h M src/soc/intel/skylake/spi.c M src/soc/mediatek/mt8173/flash_controller.c M src/soc/mediatek/mt8173/spi.c M src/southbridge/intel/common/spi.c 11 files changed, 121 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/19708/8 -- To view, visit https://review.coreboot.org/19708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b Gerrit-PatchSet: 8 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure
by Furquan Shaikh (Code Review) 17 May '17

17 May '17

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/19757 ) Change subject: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure ...................................................................... drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure Now that we have a spi_flash_ctrlr structure, move all spi flash operations to this structure and add a pointer to this structure in struct spi_flash. BUG=b:38330715 Change-Id: I550cc4556fc4b63ebc174a7e2fde42251fe56052 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/drivers/spi/adesto.c M src/drivers/spi/amic.c M src/drivers/spi/atmel.c M src/drivers/spi/eon.c M src/drivers/spi/gigadevice.c M src/drivers/spi/macronix.c M src/drivers/spi/spansion.c M src/drivers/spi/spi_flash.c M src/drivers/spi/sst.c M src/drivers/spi/stmicro.c M src/drivers/spi/winbond.c M src/include/spi_flash.h M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/mediatek/mt8173/flash_controller.c M src/southbridge/intel/common/spi.c 15 files changed, 180 insertions(+), 120 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/19757/2 -- To view, visit https://review.coreboot.org/19757 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I550cc4556fc4b63ebc174a7e2fde42251fe56052 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017