coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: drivers/spi: Define spi_flash_ctrlr structure
by Furquan Shaikh (Code Review) 17 May '17

17 May '17

Hello Aaron Durbin, Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19708 to look at the new patch set (#11). Change subject: drivers/spi: Define spi_flash_ctrlr structure ...................................................................... drivers/spi: Define spi_flash_ctrlr structure In order to support some specialized SPI controllers that are actually SPI flash controllers, define a new spi_flash_ctrlr structure with the following member: 1. probe: Specialized probe function provided by the spi flash controller. With this change, the specialized spi flash probe functions are now associated with a particular spi ctrlr structure and no longer disconnected from the spi controller. Later, more functions will be added to spi_flash_ctrlr. BUG=b:38330715 TEST=Verified with the entire patch series that spi flash driver still works fine on poppy. Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/drivers/spi/spi_flash.c M src/include/spi-generic.h M src/include/spi_flash.h M src/soc/intel/apollolake/spi.c M src/soc/intel/common/block/fast_spi/fast_spi.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/block/include/intelblocks/fast_spi.h M src/soc/intel/skylake/spi.c M src/soc/mediatek/mt8173/flash_controller.c M src/soc/mediatek/mt8173/spi.c M src/southbridge/intel/common/spi.c 11 files changed, 81 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/19708/11 -- To view, visit https://review.coreboot.org/19708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b Gerrit-PatchSet: 11 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/spi/flash: Clean up SPI flash probe
by Furquan Shaikh (Code Review) 17 May '17

17 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19758 to look at the new patch set (#3). Change subject: drivers/spi/flash: Clean up SPI flash probe ...................................................................... drivers/spi/flash: Clean up SPI flash probe 1. Rename __spi_flash_probe to spi_flash_generic_probe and export it so that drivers can use it outside spi_flash.c. 2. Make southbridge intel spi driver use spi_flash_generic_probe if spi_is_multichip returns 0. BUG=b:38330715 Change-Id: I5ffe62fdb83b3c744f3779adacb77503352f6623 Signed-off-by: Furquan Shaikh <furquan(a)chromium.org> --- M src/drivers/spi/spi_flash.c M src/include/spi_flash.h M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/mediatek/mt8173/flash_controller.c M src/southbridge/intel/common/spi.c 5 files changed, 31 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/19758/3 -- To view, visit https://review.coreboot.org/19758 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5ffe62fdb83b3c744f3779adacb77503352f6623 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/spi: Define spi_flash_ctrlr structure
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19708 ) Change subject: drivers/spi: Define spi_flash_ctrlr structure ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9642/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53897/ : SUCCESS -- To view, visit https://review.coreboot.org/19708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b Gerrit-PatchSet: 10 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19757 ) Change subject: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9641/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53896/ : SUCCESS -- To view, visit https://review.coreboot.org/19757 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I550cc4556fc4b63ebc174a7e2fde42251fe56052 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/spi_flash: Pass in spi_slave structure as const ...
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19707 ) Change subject: drivers/spi/spi_flash: Pass in spi_slave structure as const to probe functions ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9639/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53894/ : SUCCESS -- To view, visit https://review.coreboot.org/19707 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I956ee777c62dbb811fd6ce2aeb6ae090e1892acd Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/flash: Clean up SPI flash probe
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19758 ) Change subject: drivers/spi/flash: Clean up SPI flash probe ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53895/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9640/ : SUCCESS -- To view, visit https://review.coreboot.org/19758 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ffe62fdb83b3c744f3779adacb77503352f6623 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/flash: Clean up SPI flash probe
by Furquan Shaikh (Code Review) 17 May '17

17 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19758 ) Change subject: drivers/spi/flash: Clean up SPI flash probe ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/19758/2/src/southbridge/intel/common/spi.c File src/southbridge/intel/common/spi.c: PS2, Line 903: int force, Aah.. this needs to go away in this patch. Will push follow-up. -- To view, visit https://review.coreboot.org/19758 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ffe62fdb83b3c744f3779adacb77503352f6623 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: drivers/spi_flash: Add page_size to struct spi_flash
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19704 ) Change subject: drivers/spi_flash: Add page_size to struct spi_flash ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9636/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53891/ : SUCCESS -- To view, visit https://review.coreboot.org/19704 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f83e52cb1041432b0b575a8ee3bd173cc038d1f Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/cbfs_spi: Provide implementation of boot_device_...
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19726 ) Change subject: drivers/spi/cbfs_spi: Provide implementation of boot_device_spi_flash ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9634/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53890/ : SUCCESS -- To view, visit https://review.coreboot.org/19726 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c07327115e0449cbd84d163218da76a6fa2cea0 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: drivers/spi/spi_flash: Use boot_device_spi_flash to obtain s...
by build bot (Jenkins) (Code Review) 17 May '17

17 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19703 ) Change subject: drivers/spi/spi_flash: Use boot_device_spi_flash to obtain spi_flash structure ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9635/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/53889/ : SUCCESS -- To view, visit https://review.coreboot.org/19703 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd50b7644d1a4be8b62d38cc9239feae2215103c Gerrit-PatchSet: 6 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017