coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19603 to look at the new patch set (#42). Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... soc/intel/apollolake: Bring in delta for GLK SOC Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/soc/intel/apollolake/Kconfig M src/soc/intel/apollolake/Makefile.inc R src/soc/intel/apollolake/acpi/gpio_apl.asl C src/soc/intel/apollolake/acpi/gpio_glk.asl M src/soc/intel/apollolake/acpi/gpiolib.asl R src/soc/intel/apollolake/acpi/lpc_apl.asl A src/soc/intel/apollolake/acpi/lpc_glk.asl R src/soc/intel/apollolake/acpi/lpss_apl.asl A src/soc/intel/apollolake/acpi/lpss_glk.asl M src/soc/intel/apollolake/acpi/southbridge.asl M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.c M src/soc/intel/apollolake/chip.h M src/soc/intel/apollolake/cpu.c M src/soc/intel/apollolake/dsp.c A src/soc/intel/apollolake/gpio_apl.c A src/soc/intel/apollolake/gpio_glk.c M src/soc/intel/apollolake/graphics.c M src/soc/intel/apollolake/include/soc/cpu.h M src/soc/intel/apollolake/include/soc/gpio.h A src/soc/intel/apollolake/include/soc/gpio_apl.h A src/soc/intel/apollolake/include/soc/gpio_glk.h A src/soc/intel/apollolake/include/soc/pci_apl_ids.h A src/soc/intel/apollolake/include/soc/pci_glk_ids.h M src/soc/intel/apollolake/include/soc/pci_ids.h M src/soc/intel/apollolake/include/soc/pcr_ids.h M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/lpc_lib.c M src/soc/intel/apollolake/northbridge.c M src/soc/intel/apollolake/p2sb.c M src/soc/intel/apollolake/pmc.c M src/soc/intel/apollolake/pmutil.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/apollolake/sd.c M src/soc/intel/apollolake/uart_early.c 35 files changed, 1,742 insertions(+), 264 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/19603/42 -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-PatchSet: 42 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Add support for GLKRVP
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19604 to look at the new patch set (#31). Change subject: mainboard/intel/glkrvp: Add support for GLKRVP ...................................................................... mainboard/intel/glkrvp: Add support for GLKRVP using SOC_INTEL_GLK Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef --- A src/mainboard/intel/glkrvp/Kconfig A src/mainboard/intel/glkrvp/Kconfig.name A src/mainboard/intel/glkrvp/Makefile.inc A src/mainboard/intel/glkrvp/acpi_tables.c A src/mainboard/intel/glkrvp/board_info.txt A src/mainboard/intel/glkrvp/boardid.c A src/mainboard/intel/glkrvp/bootblock.c A src/mainboard/intel/glkrvp/chromeos.c A src/mainboard/intel/glkrvp/chromeos.fmd A src/mainboard/intel/glkrvp/dsdt.asl A src/mainboard/intel/glkrvp/ec.c A src/mainboard/intel/glkrvp/mainboard.c A src/mainboard/intel/glkrvp/romstage.c A src/mainboard/intel/glkrvp/smihandler.c A src/mainboard/intel/glkrvp/touchpad.asl A src/mainboard/intel/glkrvp/variants/baseboard/Makefile.inc A src/mainboard/intel/glkrvp/variants/baseboard/boardid.c A src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb A src/mainboard/intel/glkrvp/variants/baseboard/gpio.c A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/acpi/dptf.asl A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/gpio.h A src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h A src/mainboard/intel/glkrvp/variants/baseboard/memory.c A src/mainboard/intel/glkrvp/variants/baseboard/nhlt.c A src/mainboard/intel/glkrvp/variants/glkrvp/include/variant/acpi/dptf.asl A src/mainboard/intel/glkrvp/variants/glkrvp/include/variant/ec.h A src/mainboard/intel/glkrvp/variants/glkrvp/include/variant/gpio.h 28 files changed, 1,878 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/19604/31 -- To view, visit https://review.coreboot.org/19604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef Gerrit-PatchSet: 31 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GL...
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello Shaunak Saha, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19739 to look at the new patch set (#4). Change subject: [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GLKRVP. ...................................................................... [WIP]mainboard/intel/glkrvp: Add GPE routing settings for GLKRVP. This patch sets the devicetree for gpe0_dw configuration and also configures the GPIO lines for SCI. The macros for LID switch is also set. Change-Id: I56a99bbb70ac9edda8448fabf05e3ea90d18d93c Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/ec.h M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/gpio.h 4 files changed, 36 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/19739/4 -- To view, visit https://review.coreboot.org/19739 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56a99bbb70ac9edda8448fabf05e3ea90d18d93c Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: [WIP]soc/intel/GLK: Fix GPE routing path
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello Paul Menzel, Shaunak Saha, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19697 to look at the new patch set (#12). Change subject: [WIP]soc/intel/GLK: Fix GPE routing path ...................................................................... [WIP]soc/intel/GLK: Fix GPE routing path This patch fix the GPE routing path for SCI to GPE. Change-Id: I484764ef4f6f815735cfc6615d10d87495d30186 Signed-off-by: Shaunak Saha <shaunak.saha(a)intel.com> --- M src/soc/intel/apollolake/gpio_glk.c M src/soc/intel/apollolake/include/soc/gpio_glk.h M src/soc/intel/apollolake/include/soc/pm.h 3 files changed, 37 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/19697/12 -- To view, visit https://review.coreboot.org/19697 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I484764ef4f6f815735cfc6615d10d87495d30186 Gerrit-PatchSet: 12 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19759 to look at the new patch set (#5). Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio ...................................................................... soc/intel/common/block/gpio: Port gpio code from Apollolake into common gpio Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- A src/soc/intel/common/block/gpio/Kconfig A src/soc/intel/common/block/gpio/Makefile.inc A src/soc/intel/common/block/gpio/gpio.c A src/soc/intel/common/block/include/intelblocks/gpio.h A src/soc/intel/common/block/include/intelblocks/gpio_defs.h 5 files changed, 802 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/19759/5 -- To view, visit https://review.coreboot.org/19759 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic48401e92103ff0ec278fb69a3d304148a2d79aa Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar(a)intel.com> Gerrit-Reviewer: Divya Chellappa <divya.chella(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block/uart: Add GLK UART pci ids
by build bot (Jenkins) (Code Review) 19 May '17

19 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19687 ) Change subject: soc/intel/common/block/uart: Add GLK UART pci ids ...................................................................... Patch Set 13: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53998/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9735/ : SUCCESS -- To view, visit https://review.coreboot.org/19687 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08dd7a8c0d42d4ec7c6ff65a82553fe1efbcc424 Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Add GLK I2C PCI IDs
by build bot (Jenkins) (Code Review) 19 May '17

19 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19782 ) Change subject: soc/intel/common/block: Add GLK I2C PCI IDs ...................................................................... Patch Set 2: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/53997/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/9734/ : SUCCESS -- To view, visit https://review.coreboot.org/19782 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2144199345e6382984c367f6a77f0cbb0a93daea Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block/uart: Add GLK UART pci ids
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello Paul Menzel, build bot (Jenkins), Brenton Dong, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19687 to look at the new patch set (#13). Change subject: soc/intel/common/block/uart: Add GLK UART pci ids ...................................................................... soc/intel/common/block/uart: Add GLK UART pci ids Change-Id: I08dd7a8c0d42d4ec7c6ff65a82553fe1efbcc424 Signed-off-by: Hannah Williams <hannah.williams(a)intel.com> --- M src/soc/intel/common/block/uart/uart.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/19687/13 -- To view, visit https://review.coreboot.org/19687 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08dd7a8c0d42d4ec7c6ff65a82553fe1efbcc424 Gerrit-PatchSet: 13 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block: Add GLK I2C PCI IDs
by Hannah Williams (Code Review) 19 May '17

19 May '17

Hello Ravishankar Sarawadi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19782 to look at the new patch set (#2). Change subject: soc/intel/common/block: Add GLK I2C PCI IDs ...................................................................... soc/intel/common/block: Add GLK I2C PCI IDs Add GLK PCI IDs for I2C to use common I2C code. Change-Id: I2144199345e6382984c367f6a77f0cbb0a93daea Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.com> --- M src/soc/intel/common/block/i2c/i2c.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/19782/2 -- To view, visit https://review.coreboot.org/19782 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2144199345e6382984c367f6a77f0cbb0a93daea Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>

1 0

Change in coreboot[master]: nb/intel/x4x/raminit: Rework receive enable calibration
by Arthur Heymans (Code Review) 19 May '17

19 May '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18692 ) Change subject: nb/intel/x4x/raminit: Rework receive enable calibration ...................................................................... Patch Set 19: hmm increasing the probe count like this did not fix it... the "if (tap == 0) {don't decrease tap}" workaround does seem to work on the other hand... -- To view, visit https://review.coreboot.org/18692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c970455e609d3ce96a262cbf110336a2079da4d Gerrit-PatchSet: 19 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit <damien(a)zamaudio.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017