coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Furquan Shaikh (Code Review) 23 May '17

23 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 23 May '17

23 May '17

Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/19692/3/src/mainboard/google/poppy/spd/hyni… File src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex: PS3, Line 10: 54 > This should be 55. Rest all looks good. Oh. Yes. Agree. -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Naresh Solanki (Code Review) 23 May '17

23 May '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19692 to look at the new patch set (#4). Change subject: mb/google/poppy: Update SPD data ...................................................................... mb/google/poppy: Update SPD data Though SPD is rightly selected (i.e., H9CCNNNBKTALBR-NUD), it displays wrong part number during boot in coreboot logs. So correct part number info within the SPD. TEST= Build for Soraka & make sure part number is rightly printed. Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> --- M src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/19692/4 -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: lib/edid: Split out fill_lb_framebuffer()
by Julius Werner (Code Review) 23 May '17

23 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19764 ) Change subject: lib/edid: Split out fill_lb_framebuffer() ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/19764/5/src/lib/Kconfig File src/lib/Kconfig: Line 4: Include fill_lb_framebuffer() implementation that caches an EDID. Does this really need to be split out and guarded by a separate Kconfig? I always like to avoid boilerplate Kconfigs that need to be selected by a large class of boards/chipsets as much as possible. Looks like you're later removing the weak no-op fill_lb_framebuffer(). Can't you then just make the EDID one the new weak default? Looks like all chipsets that don't use the EDID code define this in their chipset-specific code, so it would make sense as a default. https://review.coreboot.org/#/c/19764/5/src/mainboard/google/oak/Kconfig File src/mainboard/google/oak/Kconfig: Line 38: select EDID_FB_HELPER Should be selected by the SoC. Even though the entry point for display functions is in mainboard code here, all the core display init code (that's based on EDID) is in the SoC directory. (Also applies to daisy/exynos5250 and peach_pit/exynos5420, I think.) -- To view, visit https://review.coreboot.org/19764 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90634b835bd8e2d150b1c714328a5b2774d891bd Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER
by Julius Werner (Code Review) 23 May '17

23 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19800 ) Change subject: Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER ...................................................................... Patch Set 7: Code-Review+1 I think this should be okay for the ARM boards, but a better solution would be to fix t124 and rk3288 to also check for MAINBOARD_DO_NATIVE_VGA_INIT in soc_init(). It just wasn't implemented right back in the day. Or maybe we should just roll that check into display_init_required(), then we automatically get it everywhere. -- To view, visit https://review.coreboot.org/19800 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff6dac5a5f61af49456bc6312e7a376def02ab00 Gerrit-PatchSet: 7 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
by Julius Werner (Code Review) 23 May '17

23 May '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19770 ) Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/19770 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0d6e4e8185ce1285b671af5ebcead1d42e049bc Gerrit-PatchSet: 4 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: WIP soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 23 May '17

23 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19755 ) Change subject: WIP soc/amd/common: Convert to C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9924/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54190/ : SUCCESS -- To view, visit https://review.coreboot.org/19755 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811c7ef875b980874f3c4b1f234f969ae5618c44 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Enable verstage support
by build bot (Jenkins) (Code Review) 23 May '17

23 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19756 ) Change subject: soc/amd/stoneyridge: Enable verstage support ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9925/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54191/ : SUCCESS -- To view, visit https://review.coreboot.org/19756 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5c439a330d687156006aec2ebaea18ff2c96b3e Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add northbridge support
by build bot (Jenkins) (Code Review) 23 May '17

23 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19724 ) Change subject: soc/amd/stoneyridge: Add northbridge support ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9917/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54183/ : SUCCESS -- To view, visit https://review.coreboot.org/19724 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie86b4d744900f23502068517ece5bcea6c128993 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Add initial support for AMD PSP
by build bot (Jenkins) (Code Review) 23 May '17

23 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19753 ) Change subject: soc/amd/common: Add initial support for AMD PSP ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9922/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54188/ : SUCCESS -- To view, visit https://review.coreboot.org/19753 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34b2744b071aa3dfb1071b2aabde32ddb662ab87 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017