coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by Arthur Heymans (Code Review) 24 May '17

24 May '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19862 to look at the new patch set (#3). Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... mb/lenovo/*60: Remove not existing DIMMs from SPD map Should result in a tiny speed bump in raminit since those addresses are not checked for present DIMMs. Checked in schematics of both Thinkpad X60 and T60 and tested to configure raminit correctly for all DIMMs populated on X60. Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/19862/3 -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19862 ) Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54237/ : SUCCESS -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19862 ) Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/54236/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/9968/ : SUCCESS -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by Arthur Heymans (Code Review) 24 May '17

24 May '17

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/19862 ) Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... mb/lenovo/*60: Remove not existing DIMMs from SPD map Should result in a tiny speed bump in raminit since those addresses are not checked for present DIMMs. Checked in schematics of both Thinkpad X60 and T60. Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/19862/2 -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by Arthur Heymans (Code Review) 24 May '17

24 May '17

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19862 ) Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... mb/lenovo/*60: Remove not existing DIMMs from SPD map Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x60/romstage.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/19862/1 diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index cb3f8bc..80b989f 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -172,7 +172,7 @@ { int s3resume = 0; int dock_err; - const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0x52, 0x51, 0x53 }; + const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0, 0x51, 0 }; timestamp_init(get_initial_timestamp()); diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 51624a0..eddb150 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -171,7 +171,7 @@ void mainboard_romstage_entry(unsigned long bist) { int s3resume = 0; - const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0x52, 0x51, 0x53 }; + const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0, 0x51, 0 }; timestamp_init(get_initial_timestamp()); -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: google/kahlee: Add Realtek audio codec ASL
by Furquan Shaikh (Code Review) 24 May '17

24 May '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19845 ) Change subject: google/kahlee: Add Realtek audio codec ASL ...................................................................... Patch Set 2: > Coudl this be generated by the C code ACPI generator? Yes, it should be possible to generate this at runtime. Just need to add the required driver for this device. -- To view, visit https://review.coreboot.org/19845 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b256f68372c9d17d67c9cb2accaca616a0b9a5 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy: Update SPD data
by Furquan Shaikh (Code Review) 24 May '17

24 May '17

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19692 ) Change subject: mb/google/poppy: Update SPD data ...................................................................... mb/google/poppy: Update SPD data Though SPD is rightly selected (i.e., H9CCNNNBKTALBR-NUD), it displays wrong part number during boot in coreboot logs. So correct part number info within the SPD. TEST= Build for Soraka & make sure part number is rightly printed. Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Signed-off-by: Naresh G Solanki <naresh.solanki(a)intel.com> Reviewed-on: https://review.coreboot.org/19692 Reviewed-by: Furquan Shaikh <furquan(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex b/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex index 95716be..97d680b 100644 --- a/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex +++ b/src/mainboard/google/poppy/spd/hynix_dimm_H9CCNNNBKTALBR-NUD.spd.hex @@ -6,8 +6,8 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 80 AD 01 00 00 00 00 00 00 00 00 -48 39 43 43 4E 4E 4E 43 50 54 41 4C 42 52 2D 4E -54 44 00 00 80 AD 00 00 00 00 00 00 00 00 00 00 +48 39 43 43 4E 4E 4E 42 4B 54 41 4C 42 52 2D 4E +55 44 00 00 80 AD 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/19692 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67f676fb6ee9d685fa7aa41fdc4b00355e6d33c7 Gerrit-PatchSet: 5 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC
by Martin Roth (Code Review) 24 May '17

24 May '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19603 ) Change subject: soc/intel/apollolake: Bring in delta for GLK SOC ...................................................................... Patch Set 50: (12 comments) https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/Kconfig File src/soc/intel/apollolake/Kconfig: PS50, Line 9: select SOC_INTEL_APOLLOLAKE Would it be better to not select SOC_INTEL_APOLLOLAKE and use "if SOC_INTEL_APOLLOLAKE || SOC_INTEL_GLK" where needed? PS50, Line 294: default CAR_CQOS if !SOC_INTEL_GLK : default CAR_NEM if SOC_INTEL_GLK Maybe get rid of the second if? default CAR_NEM if SOC_INTEL_GLK default CAR_CQOS https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/gpio… File src/soc/intel/apollolake/acpi/gpio_apl.asl: Line 203: extra line https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/gpio… File src/soc/intel/apollolake/acpi/gpio_glk.asl: Line 22: extra line Line 208: extra line https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/lpc_… File src/soc/intel/apollolake/acpi/lpc_glk.asl: PS50, Line 25: Device (HPET) : { indent this file with tabs instead of spaces? https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/lpss… File src/soc/intel/apollolake/acpi/lpss_glk.asl: Line 159: extra line https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/include/s… File src/soc/intel/apollolake/include/soc/gpio_glk.h: PS50, Line 367: GLk use caps? https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/include/s… File src/soc/intel/apollolake/include/soc/pci_ids.h: PS50, Line 22: _SOC_APOLLOLAKE_PCI_IDS_H_ change to match the define? Line 23: extra line https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/romstage.c File src/soc/intel/apollolake/romstage.c: Line 139: Get rid of the preprocessor #if and just return false here if it's GLC? if (IS_ENABLED(CONFIG_SOC_INTEL_GLK)) return false; PS50, Line 347: #if !IS_ENABLED(CONFIG_SOC_INTEL_GLK) /* TODO */ Please use a C if statement unless the preprocessor if is specifically needed. -- To view, visit https://review.coreboot.org/19603 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3 Gerrit-PatchSet: 50 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: util/abuild: Start junit testcase block on kconfig failure
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19861 ) Change subject: util/abuild: Start junit testcase block on kconfig failure ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9967/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54235/ : SUCCESS -- To view, visit https://review.coreboot.org/19861 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f9083c346ac7b6502f854b7e1f1054e81954d76 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/glkrvp: Add support for GLKRVP
by Martin Roth (Code Review) 24 May '17

24 May '17

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19604 ) Change subject: mainboard/intel/glkrvp: Add support for GLKRVP ...................................................................... Patch Set 34: (1 comment) https://review.coreboot.org/#/c/19604/34/src/mainboard/intel/glkrvp/Kconfig File src/mainboard/intel/glkrvp/Kconfig: PS34, Line 41: config DRIVERS_I2C_GENERIC : default y This needs to be enabled with a 'select' statement or it adds a dependency on this mainboard that the other mainboards fail to meet. -- To view, visit https://review.coreboot.org/19604 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef Gerrit-PatchSet: 34 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Brenton Dong <brenton.m.dong(a)intel.com> Gerrit-Reviewer: Cole Nelson <colex.nelson(a)intel.com> Gerrit-Reviewer: Han Lim Ng <nhlhanlim93(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017