coreboot-gerrit May 2017

coreboot-gerrit@coreboot.org

1 participants
3888 discussions

Change in coreboot[master]: util/lint/kconfig_lint: update help checking
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19851 ) Change subject: util/lint/kconfig_lint: update help checking ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9972/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54242/ : SUCCESS -- To view, visit https://review.coreboot.org/19851 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf868c83e2a128ceb6c4d3da7f2cf7dc237054e6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy:[WIP] Clean up MIPI camera support from devi...
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19619 ) Change subject: mb/google/poppy:[WIP] Clean up MIPI camera support from devicetree.cb ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9971/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54241/ : SUCCESS -- To view, visit https://review.coreboot.org/19619 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a6a98d4c8ed6cba760eae5fd87bc2a3f15d7d2 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/google/poppy:[WIP] Add MIPI camera support.
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19621 ) Change subject: mb/google/poppy:[WIP] Add MIPI camera support. ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9970/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54240/ : SUCCESS -- To view, visit https://review.coreboot.org/19621 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32a2a8313488d2f50aad3feaa79e17b1d06c80f Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: util/lint/kconfig_lint: update help checking
by Martin Roth (Code Review) 24 May '17

24 May '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/19851 to look at the new patch set (#2). Change subject: util/lint/kconfig_lint: update help checking ...................................................................... util/lint/kconfig_lint: update help checking - Turn the check for help text with no indentation from a warning to an error. - Show an error if the help text is at the same indentation level as the 'help' keyword. Change-Id: Ibf868c83e2a128ceb6c4d3da7f2cf7dc237054e6 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M util/lint/kconfig_lint M util/lint/kconfig_lint_README 2 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/19851/2 -- To view, visit https://review.coreboot.org/19851 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibf868c83e2a128ceb6c4d3da7f2cf7dc237054e6 Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy:[WIP] Add MIPI camera support.
by Rizwan Qureshi (Code Review) 24 May '17

24 May '17

Hello V Sowmya, I'd like you to reexamine a change. Please visit https://review.coreboot.org/19621 to look at the new patch set (#2). Change subject: mb/google/poppy:[WIP] Add MIPI camera support. ...................................................................... mb/google/poppy:[WIP] Add MIPI camera support. This patch adds camera.asl * Extend scope for CIO2 device and add _DSD object. Also add ports and endpoint configurations. * Add TPS68470 PMIC related ACPI objects. * Add OV cameras related ACPI objects. * Add Dongwoon AF DAC related ACPI objects. Change-Id: If32a2a8313488d2f50aad3feaa79e17b1d06c80f Signed-off-by: V Sowmya <v.sowmya(a)intel.com> Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.corp-partner.google.com> --- A src/mainboard/google/poppy/acpi/camera.asl A src/mainboard/google/poppy/acpi/ipu_mainboard.asl M src/mainboard/google/poppy/dsdt.asl 3 files changed, 855 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/19621/2 -- To view, visit https://review.coreboot.org/19621 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If32a2a8313488d2f50aad3feaa79e17b1d06c80f Gerrit-PatchSet: 2 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by Patrick Rudolph (Code Review) 24 May '17

24 May '17

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19862 ) Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: enable the pull high for touchpad
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19863 ) Change subject: google/gru: enable the pull high for touchpad ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/9969/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/54239/ : SUCCESS -- To view, visit https://review.coreboot.org/19863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: enable the pull high for touchpad
by Caesar Wang (Code Review) 24 May '17

24 May '17

Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19863 ) Change subject: google/gru: enable the pull high for touchpad ...................................................................... Patch Set 1: This issue on https://partnerissuetracker.corp.google.com/u/2/issues/36705749 -- To view, visit https://review.coreboot.org/19863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Caesar Wang <wxt(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)google.com> Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: enable the pull high for touchpad
by Caesar Wang (Code Review) 24 May '17

24 May '17

Caesar Wang has uploaded a new change for review. ( https://review.coreboot.org/19863 ) Change subject: google/gru: enable the pull high for touchpad ...................................................................... google/gru: enable the pull high for touchpad As the hardware designed on gru, the AP_I2C_TP_PU_EN (gpio3_b4) controlled the SCL/SDA status to avoid leakage. As the gpio3_b4 of rk3399 pull resistor is 26k~71k and 3.3v for supply power, and gpio3_b4 pin connected 2.2k resistor to i2c of TP device. The default of this gpio status is output high during the start to bootup, it's very weak drive for the TP device that maybe cause to trigger the recovery process of elan touchpad. Also, the Elan updated their firmware to delay checking the i2c of touchpad. Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da Signed-off-by: Caesar Wang <wxt(a)rock-chips.com> --- M src/mainboard/google/gru/romstage.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/19863/1 diff --git a/src/mainboard/google/gru/romstage.c b/src/mainboard/google/gru/romstage.c index d644f7d..875cda0 100644 --- a/src/mainboard/google/gru/romstage.c +++ b/src/mainboard/google/gru/romstage.c @@ -67,12 +67,19 @@ reset_usb_otg1(); } +static void prepare_i2c(void) +{ + gpio_output(GPIO(3, B, 4), 1); /* Pull high for TP */ +} + void main(void) { console_init(); tsadc_init(TSHUT_POL_HIGH); exception_init(); + prepare_i2c(); + /* Init DVS to conservative values. */ init_dvs_outputs(); -- To view, visit https://review.coreboot.org/19863 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da Gerrit-PatchSet: 1 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Caesar Wang <wxt(a)rock-chips.com>

1 0

Change in coreboot[master]: mb/lenovo/*60: Remove not existing DIMMs from SPD map
by build bot (Jenkins) (Code Review) 24 May '17

24 May '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19862 ) Change subject: mb/lenovo/*60: Remove not existing DIMMs from SPD map ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/54238/ : SUCCESS -- To view, visit https://review.coreboot.org/19862 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-HasComments: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2017